Attention is currently required from: Malik Hsu.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57008 )
Change subject: mb/google/brya: Enable DRIVERS_GENESYSLOGIC_GL9755 for primus
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
needs rebase on master
--
To view, visit https://review.coreboot.org/c/coreboot/+/57008
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c60979a2d42f836e0f0261c42fcfc36c41e113a
Gerrit-Change-Number: 57008
Gerrit-PatchSet: 1
Gerrit-Owner: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 19 Aug 2021 04:02:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Malik Hsu.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57008 )
Change subject: mb/google/brya: Enable DRIVERS_GENESYSLOGIC_GL9755 for primus
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/57008
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c60979a2d42f836e0f0261c42fcfc36c41e113a
Gerrit-Change-Number: 57008
Gerrit-PatchSet: 1
Gerrit-Owner: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 19 Aug 2021 04:02:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Vinod Polimera, Shelley Chen, Julius Werner.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56966 )
Change subject: qualcomm/sc7180: Switch to common MIPI panel library
......................................................................
Patch Set 5:
(1 comment)
File src/soc/qualcomm/sc7180/display/dsi.c:
https://review.coreboot.org/c/coreboot/+/56966/comment/ea8a1a50_82eabff4
PS1, Line 226: size = ALIGN_UP(cm->size, DSI_PAYLOAD_SIZE_ALIGN);
> Actually, I just noticed that the corresponding kernel driver seems to pad them with 0xff instead. […]
Could you mention this in the commit message?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56966
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78f6efbaa9da88a3574d5c6a51061e308412340e
Gerrit-Change-Number: 56966
Gerrit-PatchSet: 5
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Vinod Polimera <vpolimer(a)qualcomm.corp-partner.google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Vinod Polimera <vpolimer(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 19 Aug 2021 02:58:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/57004 )
Change subject: google/trogdor: Read SKU ID as binary-first base3 strapping
......................................................................
google/trogdor: Read SKU ID as binary-first base3 strapping
We're running out of SKU IDs in the base2 system, so convert it to
binary-first base3.
Signed-off-by: Julius Werner <jwerner(a)chromium.org>
Change-Id: Ia7f749fa042d3eac76bfe1e74531905c6e279ad2
Reviewed-on: https://review.coreboot.org/c/coreboot/+/57004
Reviewed-by: Shelley Chen <shchen(a)google.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/mainboard/google/trogdor/boardid.c
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
build bot (Jenkins): Verified
Shelley Chen: Looks good to me, approved
diff --git a/src/mainboard/google/trogdor/boardid.c b/src/mainboard/google/trogdor/boardid.c
index ddb240a..c972160 100644
--- a/src/mainboard/google/trogdor/boardid.c
+++ b/src/mainboard/google/trogdor/boardid.c
@@ -51,9 +51,9 @@
if (id == UNDEFINED_STRAPPING_ID) {
if (use_old_pins())
- id = gpio_base2_value(old_pins, ARRAY_SIZE(old_pins));
+ id = gpio_binary_first_base3_value(old_pins, ARRAY_SIZE(old_pins));
else
- id = gpio_base2_value(pins, ARRAY_SIZE(pins));
+ id = gpio_binary_first_base3_value(pins, ARRAY_SIZE(pins));
}
return id;
--
To view, visit https://review.coreboot.org/c/coreboot/+/57004
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia7f749fa042d3eac76bfe1e74531905c6e279ad2
Gerrit-Change-Number: 57004
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Philip Chen <philipchen(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Vinod Polimera, Shelley Chen.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56966 )
Change subject: qualcomm/sc7180: Switch to common MIPI panel library
......................................................................
Patch Set 5:
(1 comment)
File src/soc/qualcomm/sc7180/display/dsi.c:
https://review.coreboot.org/c/coreboot/+/56966/comment/6db1c793_7a64ec54
PS1, Line 226: size = ALIGN_UP(cm->size, DSI_PAYLOAD_SIZE_ALIGN);
> This looks like it has always been wrong to me. […]
Actually, I just noticed that the corresponding kernel driver seems to pad them with 0xff instead. Let's copy that just to be sure, don't know if it makes a difference.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56966
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78f6efbaa9da88a3574d5c6a51061e308412340e
Gerrit-Change-Number: 56966
Gerrit-PatchSet: 5
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Vinod Polimera <vpolimer(a)qualcomm.corp-partner.google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Vinod Polimera <vpolimer(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Comment-Date: Thu, 19 Aug 2021 00:29:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Vinod Polimera, Shelley Chen, Julius Werner.
Hello Hung-Te Lin, Vinod Polimera, Shelley Chen, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56966
to look at the new patch set (#5).
Change subject: qualcomm/sc7180: Switch to common MIPI panel library
......................................................................
qualcomm/sc7180: Switch to common MIPI panel library
This patch changes the sc7180 boards to use the new common MIPI panel
framework, which allows more flexible initialization command packing and
sharing panel definitions between boards. (I'm taking the lane count
control back out again for now, since it seems we only ever want 4 for
now anyway, and if we ever have a need for a different lane count it's
not clear whether that should be a property of the board or the panel or
both. Better to leave that decision until we have a real use case.)
Signed-off-by: Julius Werner <jwerner(a)chromium.org>
Change-Id: I78f6efbaa9da88a3574d5c6a51061e308412340e
---
M src/device/mipi/Kconfig
M src/device/mipi/Makefile.inc
A src/device/mipi/panel-VIS_RM69299.c
M src/mainboard/google/trogdor/Kconfig
M src/mainboard/google/trogdor/Makefile.inc
M src/mainboard/google/trogdor/mainboard.c
D src/mainboard/google/trogdor/panel_driver.c
M src/soc/qualcomm/sc7180/display/dsi.c
M src/soc/qualcomm/sc7180/include/soc/display/mipi_dsi.h
D src/soc/qualcomm/sc7180/include/soc/display/panel.h
10 files changed, 141 insertions(+), 152 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/56966/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/56966
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78f6efbaa9da88a3574d5c6a51061e308412340e
Gerrit-Change-Number: 56966
Gerrit-PatchSet: 5
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Vinod Polimera <vpolimer(a)qualcomm.corp-partner.google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Vinod Polimera <vpolimer(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Furquan Shaikh, Martin Roth, Kangheui Won, Paul Menzel, Karthikeyan Ramasubramanian.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56990 )
Change subject: mb/google/zork: only enable RTD2141 when present
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56990/comment/de70d7e4_c9a18148
PS2, Line 10: fw_config
: probe
> Yes, the second one. […]
Clarified to explain the values are variant-specific and come from a fw_config field in CBI.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56990
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ada9b492ab221fa98350bf2faf27a23342f3a55
Gerrit-Change-Number: 56990
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Sam McNally <sammc(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Daniel Kurtz <djkurtz(a)google.com>
Gerrit-CC: Edward Hill <ecgh(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-Comment-Date: Thu, 19 Aug 2021 00:26:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-MessageType: comment