Attention is currently required from: Tim Crawford, Nico Huber, Furquan Shaikh, Jeremy Soller, Tim Wawrzynczak, Paul Menzel.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57034 )
Change subject: drivers/gfx/nvidia: Add driver for NVIDIA Optimus
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57034/comment/f11bd7e2_abeddbc6
PS2, Line 12:
> Is there a doc# for the datasheet that details the requirements? I think it would be helpful to add […]
I found "Switchable Graphics Design Guidelines" in the KBL PDG (Intel doc #564042) for example
--
To view, visit https://review.coreboot.org/c/coreboot/+/57034
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2dec7aa2c8db7994f78a7cc1220502676e248465
Gerrit-Change-Number: 57034
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Sun, 22 Aug 2021 16:10:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Mike Banon, Idwer Vollering, Paul Menzel, Arthur Heymans, Kyösti Mälkki, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53982 )
Change subject: AGESA f15tn boards: Sync IDS option values
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/53982/comment/ff314002_a86ed28e
PS6, Line 14: Note that the `IDSOPT_TRACING_ENABLED` option currently fails to build.
> Exactly. In any case, CB:53986 fixes tracing support. […]
Well, a88xm-e was copy-pasta'd from f2a85-m, but the idea still applies.
--
To view, visit https://review.coreboot.org/c/coreboot/+/53982
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iedd4d1f255650012f3efd9a27718e18c1c904dc1
Gerrit-Change-Number: 53982
Gerrit-PatchSet: 6
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sun, 22 Aug 2021 10:43:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Mike Banon, Idwer Vollering, Paul Menzel, Arthur Heymans, Kyösti Mälkki, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53982 )
Change subject: AGESA f15tn boards: Sync IDS option values
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/53982/comment/9e243735_eb80727c
PS6, Line 14: Note that the `IDSOPT_TRACING_ENABLED` option currently fails to build.
> But as `src/mainboard/asus/a88xm-e/OptionsIds. […]
Exactly. In any case, CB:53986 fixes tracing support.
Anything to do?
--
To view, visit https://review.coreboot.org/c/coreboot/+/53982
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iedd4d1f255650012f3efd9a27718e18c1c904dc1
Gerrit-Change-Number: 53982
Gerrit-PatchSet: 6
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sun, 22 Aug 2021 10:42:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Mike Banon, Idwer Vollering, Angel Pons, Arthur Heymans, Kyösti Mälkki, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53982 )
Change subject: AGESA f15tn boards: Sync IDS option values
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/53982/comment/b67801ee_05cd28e4
PS6, Line 14: Note that the `IDSOPT_TRACING_ENABLED` option currently fails to build.
But as `src/mainboard/asus/a88xm-e/OptionsIds.h` did not define `IDSOPT_IDS_ENABLED` it wasn’t noticed?
--
To view, visit https://review.coreboot.org/c/coreboot/+/53982
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iedd4d1f255650012f3efd9a27718e18c1c904dc1
Gerrit-Change-Number: 53982
Gerrit-PatchSet: 6
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sun, 22 Aug 2021 10:31:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Mike Banon, Idwer Vollering, Arthur Heymans, Kyösti Mälkki, Felix Held.
Hello Mike Banon, build bot (Jenkins), Michał Żygowski, Idwer Vollering, Mike Banon, Arthur Heymans, Kyösti Mälkki, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/53982
to look at the new patch set (#6).
Change subject: AGESA f15tn boards: Sync IDS option values
......................................................................
AGESA f15tn boards: Sync IDS option values
In preparation to replace OptionsIds.h with Kconfig options, use the
same settings on all AGESA f15tn boards. The only difference this makes
is that the `IDS_LATE_RUN_AP_TASK` macro no longer expands to nothing.
It is expected that the impact this difference makes is minimal.
Note that the `IDSOPT_TRACING_ENABLED` option currently fails to build.
Tested on asus/f2a85-m, still boots.
Change-Id: Iedd4d1f255650012f3efd9a27718e18c1c904dc1
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
M src/mainboard/asus/a88xm-e/OptionsIds.h
M src/mainboard/asus/f2a85-m/OptionsIds.h
M src/mainboard/msi/ms7721/OptionsIds.h
3 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/53982/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/53982
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iedd4d1f255650012f3efd9a27718e18c1c904dc1
Gerrit-Change-Number: 53982
Gerrit-PatchSet: 6
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Iru Cai, Iru Cai (vimacs).
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54745 )
Change subject: Documentation: update Haswell document on SPD
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54745/comment/2446f3c4_a45826c9
PS2, Line 7: document
nit: I'd use `documentation`
https://review.coreboot.org/c/coreboot/+/54745/comment/78688fd8_b5878494
PS2, Line 7: SPD
SPD *addresses*
https://review.coreboot.org/c/coreboot/+/54745/comment/f0ce1f37_4bcbd228
PS2, Line 10: .
nit: add `anymore`
--
To view, visit https://review.coreboot.org/c/coreboot/+/54745
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d545a1aeae9e4bf2ec792ab3dc85abd83fe1762
Gerrit-Change-Number: 54745
Gerrit-PatchSet: 2
Gerrit-Owner: Iru Cai (vimacs) <mytbk920423(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-Attention: Iru Cai (vimacs) <mytbk920423(a)gmail.com>
Gerrit-Comment-Date: Sun, 22 Aug 2021 10:06:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Paul Menzel, Iru Cai, Iru Cai (vimacs).
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54744 )
Change subject: Documentation: add Intel Broadwell
......................................................................
Patch Set 5:
(2 comments)
File Documentation/soc/intel/broadwell/blobs.md:
https://review.coreboot.org/c/coreboot/+/54744/comment/91a8ed07_cfdb82b3
PS5, Line 31: of `refcode` is needed.
> The device does not work otherwise?
The refcode blob does PCIe/xHCI/SATA initialisation. One could boot without refcode, but many things won't work.
https://review.coreboot.org/c/coreboot/+/54744/comment/2e430bf0_9b884c20
PS5, Line 39: Haswell
It doesn't support non-ULT Broadwell either.
--
To view, visit https://review.coreboot.org/c/coreboot/+/54744
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b1c29162a64030b5c100368f2471702e22b8311
Gerrit-Change-Number: 54744
Gerrit-PatchSet: 5
Gerrit-Owner: Iru Cai (vimacs) <mytbk920423(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-Attention: Iru Cai (vimacs) <mytbk920423(a)gmail.com>
Gerrit-Comment-Date: Sun, 22 Aug 2021 10:05:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57049 )
Change subject: arch/x86: Implement cpu_info in C code
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57049/comment/37ae1141_f8d562dc
PS1, Line 8:
Any idea, why it wasn’t in the first place?
--
To view, visit https://review.coreboot.org/c/coreboot/+/57049
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic7396b8429e29739e18a189dacea3a76e571cd58
Gerrit-Change-Number: 57049
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sun, 22 Aug 2021 10:01:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Angel Pons, Iru Cai, Iru Cai (vimacs).
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54744 )
Change subject: Documentation: add Intel Broadwell
......................................................................
Patch Set 5: Code-Review+1
(4 comments)
Patchset:
PS5:
Thank you for writing this.
File Documentation/soc/intel/broadwell/blobs.md:
https://review.coreboot.org/c/coreboot/+/54744/comment/d9941c6f_32439805
PS5, Line 18: ```bash
: cbfstool coreboot_*.rom extract -f broadwell-mrc.bin -n mrc.bin
: cbfstool coreboot_*.rom extract -m x86 -f broadwell-refcode.elf -n fallback/refcode
: ```
I’d just indent it by four spaces.
https://review.coreboot.org/c/coreboot/+/54744/comment/b20435d5_9c31a311
PS5, Line 25: is
are (referring to addresses)?
https://review.coreboot.org/c/coreboot/+/54744/comment/d6f38ba0_0a4efffe
PS5, Line 31: of `refcode` is needed.
The device does not work otherwise?
--
To view, visit https://review.coreboot.org/c/coreboot/+/54744
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b1c29162a64030b5c100368f2471702e22b8311
Gerrit-Change-Number: 54744
Gerrit-PatchSet: 5
Gerrit-Owner: Iru Cai (vimacs) <mytbk920423(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-Attention: Iru Cai (vimacs) <mytbk920423(a)gmail.com>
Gerrit-Comment-Date: Sun, 22 Aug 2021 10:00:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Jeff Chase, Tim Wawrzynczak, Edward O'Callaghan.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57037 )
Change subject: mb/google/hatch: don't override variant_ramstage_init() in baseboard
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57037/comment/f981be06_ed3a4bec
PS1, Line 12:
Please (tersely) describe the implementation.
File src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/57037/comment/fd49250d_440f1c09
PS1, Line 43: /* Perform puff specific initialization in ramstage. */
Nit: I’d remove the dot/period, but acknowledge that it’s inconsistent with in the present file.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57037
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5e787c3d4c2f2c62a0dc868997b6e4c3da84c43
Gerrit-Change-Number: 57037
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Chase <jnchase(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Joe Tessler <jrt(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Jeff Chase <jnchase(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Comment-Date: Sun, 22 Aug 2021 09:54:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment