Attention is currently required from: Nico Huber, Matt DeVillier, Angel Pons, Arthur Heymans, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55803 )
Change subject: [TESTME] mb/google/auron: Refactor memory-down SPD handling
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
lemme see if I can get my hands on one of these
--
To view, visit https://review.coreboot.org/c/coreboot/+/55803
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9bc4527057d4a771883c8cc60da2501516d6fb94
Gerrit-Change-Number: 55803
Gerrit-PatchSet: 6
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Sat, 21 Aug 2021 18:20:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Angel Pons, Kyösti Mälkki, Felix Held.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57046 )
Change subject: [RFC] PCI: Introduce `enable_mmconf()` function
......................................................................
Patch Set 1:
(1 comment)
File src/lib/bootblock.c:
https://review.coreboot.org/c/coreboot/+/57046/comment/25ca627a_6f2122ab
PS1, Line 45: if (CONFIG(MMCONF_SUPPORT))
: enable_mmconf();
I think this is pretty reasonable; bootblock_soc_early_init() is a common place to initialize MMCONF anyway
--
To view, visit https://review.coreboot.org/c/coreboot/+/57046
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f573f1c0d9a4cc3c25fe907d12778cd5d93241d
Gerrit-Change-Number: 57046
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sat, 21 Aug 2021 17:41:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Angel Pons, Kyösti Mälkki, Felix Held.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57046 )
Change subject: [RFC] PCI: Introduce `enable_mmconf()` function
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Seems fine to me; I imagine most PCI capable systems use it extensively during boot. I know that even some of the ARM platforms are adding some vaguely MMCONF-ish support (CB:53903 and friends). On x86 it's also nice to isolate what I think is the only required I/O space access to PCI config space
--
To view, visit https://review.coreboot.org/c/coreboot/+/57046
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f573f1c0d9a4cc3c25fe907d12778cd5d93241d
Gerrit-Change-Number: 57046
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sat, 21 Aug 2021 17:40:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Sergii Dmytruk, Ron Minnich.
Hello build bot (Jenkins), Ron Minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57084
to look at the new patch set (#3).
Change subject: src/arch/ppc64/*: pass FDT address to payload
......................................................................
src/arch/ppc64/*: pass FDT address to payload
It's available in %r3 in bootblock and needs to be passed first to
romstage, then to ramstage, where it's put into CMBEM to be read on
starting payload.
Change-Id: I0911f4b534c6f8cacfa057a5bad7576fec711637
Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
---
M src/arch/ppc64/boot.c
M src/arch/ppc64/bootblock_crt0.S
A src/arch/ppc64/fdt.h
M src/arch/ppc64/stages.c
4 files changed, 85 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/57084/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/57084
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0911f4b534c6f8cacfa057a5bad7576fec711637
Gerrit-Change-Number: 57084
Gerrit-PatchSet: 3
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ron Minnich.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57084 )
Change subject: src/arch/ppc64/*: pass FDT address to payload
......................................................................
Patch Set 2:
(2 comments)
File src/arch/ppc64/boot.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126521):
https://review.coreboot.org/c/coreboot/+/57084/comment/b5d129fb_3e0395ef
PS2, Line 42: void (*doit)(void *) = prog_entry(prog);
function definition argument 'void *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126521):
https://review.coreboot.org/c/coreboot/+/57084/comment/207514e6_e884a666
PS2, Line 54: void (*doit)(void *) = prog_entry(prog);
function definition argument 'void *' should also have an identifier name
--
To view, visit https://review.coreboot.org/c/coreboot/+/57084
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0911f4b534c6f8cacfa057a5bad7576fec711637
Gerrit-Change-Number: 57084
Gerrit-PatchSet: 2
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Sat, 21 Aug 2021 15:45:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Sergii Dmytruk.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57079
to look at the new patch set (#2).
Change subject: src/mainboard/emulation/qemu-power9/*: add QEMU POWER9 mainboard
......................................................................
src/mainboard/emulation/qemu-power9/*: add QEMU POWER9 mainboard
Add initial implementation for booting on QEMU POWER9 emulation
Change-Id: I079c5b9ad564024dd13296ef75c263bdc40c9d39
Signed-off-by: Yaroslav Kurlaev <yaroslav.kurlaev(a)3mdeb.com>
---
A configs/config.emulation_qemu_power9
A src/mainboard/emulation/qemu-power9/Kconfig
A src/mainboard/emulation/qemu-power9/Kconfig.name
A src/mainboard/emulation/qemu-power9/Makefile.inc
A src/mainboard/emulation/qemu-power9/board.fmd
A src/mainboard/emulation/qemu-power9/board_info.txt
A src/mainboard/emulation/qemu-power9/cbmem.c
A src/mainboard/emulation/qemu-power9/devicetree.cb
A src/mainboard/emulation/qemu-power9/mainboard.c
A src/mainboard/emulation/qemu-power9/memlayout.ld
A src/mainboard/emulation/qemu-power9/romstage.c
11 files changed, 138 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/57079/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/57079
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I079c5b9ad564024dd13296ef75c263bdc40c9d39
Gerrit-Change-Number: 57079
Gerrit-PatchSet: 2
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Igor Bagnucki, Krystian Hebel, Ron Minnich.
Hello build bot (Jenkins), Igor Bagnucki, Krystian Hebel, Ron Minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57078
to look at the new patch set (#2).
Change subject: src/cpu/power9/*: add file structure for power9, implement SCOM access
......................................................................
src/cpu/power9/*: add file structure for power9, implement SCOM access
Change-Id: Ib555ce51294c94b22d9a7c0db84d38d7928f7015
Signed-off-by: Krystian Hebel <krystian.hebel(a)3mdeb.com>
---
M src/arch/ppc64/include/arch/byteorder.h
M src/arch/ppc64/include/arch/io.h
M src/cpu/Makefile.inc
A src/cpu/power9/Kconfig
A src/cpu/power9/Makefile.inc
A src/cpu/power9/power9.c
A src/cpu/power9/scom.c
A src/include/cpu/power/scom.h
A src/include/cpu/power/spr.h
9 files changed, 411 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/57078/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/57078
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib555ce51294c94b22d9a7c0db84d38d7928f7015
Gerrit-Change-Number: 57078
Gerrit-PatchSet: 2
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Igor Bagnucki <igor.bagnucki(a)3mdeb.com>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Igor Bagnucki <igor.bagnucki(a)3mdeb.com>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Krystian Hebel, Sergii Dmytruk, Ron Minnich.
Hello build bot (Jenkins), Krystian Hebel, Ron Minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57076
to look at the new patch set (#2).
Change subject: ppc64/bootblock_crt0.S: minimal implementation for bootblock C environment
......................................................................
ppc64/bootblock_crt0.S: minimal implementation for bootblock C environment
BSS is loaded as part of the bootblock, it is zeroed in the file so it
doesn't have to be cleared explicitly by the code.
Code for clearing is left as a comment along with a warning about alignment
requirements.
Vector operations are sometimes generated for code such as
'uint8_t x[32] = {0}', this results in an exception when vector registers
(VR) are not enabled. VSR (vector-scalar register) operations are also
enabled, there is no reason not to.
Change-Id: I878ef61619eb4a191805c8911d001312a0d717a0
Signed-off-by: Krystian Hebel <krystian.hebel(a)3mdeb.com>
---
M src/arch/ppc64/Makefile.inc
D src/arch/ppc64/bootblock.S
A src/arch/ppc64/bootblock_crt0.S
3 files changed, 94 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/57076/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/57076
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I878ef61619eb4a191805c8911d001312a0d717a0
Gerrit-Change-Number: 57076
Gerrit-PatchSet: 2
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ron Minnich.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57084 )
Change subject: src/arch/ppc64/*: pass FDT address to payload
......................................................................
Patch Set 1:
(2 comments)
File src/arch/ppc64/boot.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126508):
https://review.coreboot.org/c/coreboot/+/57084/comment/539d05cd_85a14c0c
PS1, Line 42: void (*doit)(void *) = prog_entry(prog);
function definition argument 'void *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126508):
https://review.coreboot.org/c/coreboot/+/57084/comment/86745fdb_863d21c4
PS1, Line 54: void (*doit)(void *) = prog_entry(prog);
function definition argument 'void *' should also have an identifier name
--
To view, visit https://review.coreboot.org/c/coreboot/+/57084
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0911f4b534c6f8cacfa057a5bad7576fec711637
Gerrit-Change-Number: 57084
Gerrit-PatchSet: 1
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Sat, 21 Aug 2021 13:40:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment