Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42434 )
Change subject: x86/lapic: Set EXTINT on BSP only
......................................................................
x86/lapic: Set EXTINT on BSP only
aac79e0b8f4777f8a912ccdfc483755b7a4da52c changed the LAPIC delivery mode
for both the BSP and the APs. The change on the APs caused a regression
that massively slows down the boot process. Configuring the AP's LAPIC
delivery mode to fixed mode fixes this regression.
Change-Id: I78490d2cbe3d9f52e10ef2471508263fd6c146ba
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
---
M src/cpu/x86/lapic/lapic.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/42434/1
diff --git a/src/cpu/x86/lapic/lapic.c b/src/cpu/x86/lapic/lapic.c
index 653c3b2..2e04464 100644
--- a/src/cpu/x86/lapic/lapic.c
+++ b/src/cpu/x86/lapic/lapic.c
@@ -31,6 +31,8 @@
(LAPIC_LVT_REMOTE_IRR | LAPIC_SEND_PENDING);
if (boot_cpu())
lvt0_val = SET_LAPIC_DELIVERY_MODE(lvt0_val, LAPIC_MODE_EXINT);
+ else
+ lvt0_val = SET_LAPIC_DELIVERY_MODE(lvt0_val, LAPIC_MODE_FIXED);
lapic_write_around(LAPIC_LVT0, lvt0_val);
lapic_write_around(LAPIC_LVT1,
--
To view, visit https://review.coreboot.org/c/coreboot/+/42434
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78490d2cbe3d9f52e10ef2471508263fd6c146ba
Gerrit-Change-Number: 42434
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newchange
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48503 )
Change subject: [HACK]Fix edk2-stable202005/IntelFsp2Pkg headers for long mode
......................................................................
[HACK]Fix edk2-stable202005/IntelFsp2Pkg headers for long mode
Change-Id: I1039ecc417d177d8c656bf891cc2568bfd6becb9
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/vendorcode/intel/edk2/edk2-stable202005/IntelFsp2Pkg/Include/FspEas/FspApi.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/48503/1
diff --git a/src/vendorcode/intel/edk2/edk2-stable202005/IntelFsp2Pkg/Include/FspEas/FspApi.h b/src/vendorcode/intel/edk2/edk2-stable202005/IntelFsp2Pkg/Include/FspEas/FspApi.h
index 3d2fb9b..a31cbfe 100644
--- a/src/vendorcode/intel/edk2/edk2-stable202005/IntelFsp2Pkg/Include/FspEas/FspApi.h
+++ b/src/vendorcode/intel/edk2/edk2-stable202005/IntelFsp2Pkg/Include/FspEas/FspApi.h
@@ -166,7 +166,7 @@
/// Optional event handler for the bootloader to be informed of events occurring during FSP execution.
/// This value is only valid if Revision is >= 2.
///
- FSP_EVENT_HANDLER *FspEventHandler;
+ UINT32 FspEventHandler;
UINT8 Reserved1[4];
} FSPM_ARCH_UPD;
#else
--
To view, visit https://review.coreboot.org/c/coreboot/+/48503
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1039ecc417d177d8c656bf891cc2568bfd6becb9
Gerrit-Change-Number: 48503
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newchange
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42640 )
Change subject: util/abuild: Run `make .xcompile` only once
......................................................................
util/abuild: Run `make .xcompile` only once
If abuild called itself recursively, the file already exists and we can
spare us one evaluation of all the makefiles per recursive abuild run.
Change-Id: Id3e2239354ec251c24c03c971987586deeb026c5
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M util/abuild/abuild
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/42640/1
diff --git a/util/abuild/abuild b/util/abuild/abuild
index 022567d..d41fcd1 100755
--- a/util/abuild/abuild
+++ b/util/abuild/abuild
@@ -769,8 +769,6 @@
exit 1
fi
-$MAKE -C"${ROOT}" .xcompile || exit 1
-
customizing=$(echo "$customizing" | cut -c3-)
if [ "$customizing" = "" ]; then
customizing="default configuration"
@@ -780,6 +778,7 @@
PASSED_BOARDS="$(realpath ${TARGET}/passing_boards)"
if [ "$recursive" = "false" ]; then
+ $MAKE -C"${ROOT}" .xcompile || exit 1
rm -f "$FAILED_BOARDS" "$PASSED_BOARDS"
fi
--
To view, visit https://review.coreboot.org/c/coreboot/+/42640
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id3e2239354ec251c24c03c971987586deeb026c5
Gerrit-Change-Number: 42640
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: newchange