Change in coreboot[master]: util/abuild: Run `make .xcompile` only once

[Nico Huber (Code Review)]

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42640 )

Change subject: util/abuild: Run `make .xcompile` only once
......................................................................

util/abuild: Run `make .xcompile` only once

If abuild called itself recursively, the file already exists and we can
spare us one evaluation of all the makefiles per recursive abuild run.

Change-Id: Id3e2239354ec251c24c03c971987586deeb026c5
Signed-off-by: Nico Huber 
---
M util/abuild/abuild
1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/42640/1

diff --git a/util/abuild/abuild b/util/abuild/abuild
index 022567d..d41fcd1 100755
--- a/util/abuild/abuild
+++ b/util/abuild/abuild
@@ -769,8 +769,6 @@
    exit 1
 fi

-$MAKE -C"${ROOT}" .xcompile || exit 1
-
 customizing=$(echo "$customizing" | cut -c3-)
 if [ "$customizing" = "" ]; then
    customizing="default configuration"
@@ -780,6 +778,7 @@
 PASSED_BOARDS="$(realpath ${TARGET}/passing_boards)"

if [ "$recursive" = "false" ]; then
+	$MAKE -C"${ROOT}" .xcompile || exit 1
    rm -f "$FAILED_BOARDS" "$PASSED_BOARDS"
 fi

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42640 )

Change subject: util/abuild: Run `make .xcompile` only once
......................................................................

Patch Set 1: Code-Review+1

[Nico Huber (Code Review)]

Attention is currently required from: Tim Wawrzynczak, Reka Norman.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Tim Wawrzynczak, Reka Norman, Angel Pons, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42640

to look at the new patch set (#2).

Change subject: util/abuild: Run `make .xcompile` only once
......................................................................

util/abuild: Run `make .xcompile` only once

If abuild called itself recursively, the file already exists and we can
spare us one evaluation of all the makefiles per recursive abuild run.

Change-Id: Id3e2239354ec251c24c03c971987586deeb026c5
Signed-off-by: Nico Huber 
---
M util/abuild/abuild
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/42640/2

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Nico Huber, Reka Norman.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42640 )

Change subject: util/abuild: Run `make .xcompile` only once
......................................................................

Patch Set 2: Code-Review+1

[Reka Norman (Code Review)]

Attention is currently required from: Nico Huber.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42640 )

Change subject: util/abuild: Run `make .xcompile` only once
......................................................................

Patch Set 2: Code-Review+1

[Patrick Georgi (Code Review)]

Attention is currently required from: Nico Huber.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42640 )

Change subject: util/abuild: Run `make .xcompile` only once
......................................................................

Patch Set 2: Code-Review+2

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42640 )

Change subject: util/abuild: Run `make .xcompile` only once
......................................................................

util/abuild: Run `make .xcompile` only once

If abuild called itself recursively, the file already exists and we can
spare us one evaluation of all the makefiles per recursive abuild run.

Change-Id: Id3e2239354ec251c24c03c971987586deeb026c5
Signed-off-by: Nico Huber 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42640
Tested-by: build bot (Jenkins) 
Reviewed-by: Tim Wawrzynczak 
Reviewed-by: Reka Norman 
Reviewed-by: Patrick Georgi 
---
M util/abuild/abuild
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved
  Tim Wawrzynczak: Looks good to me, but someone else must approve
  Reka Norman: Looks good to me, but someone else must approve

diff --git a/util/abuild/abuild b/util/abuild/abuild
index 5fe298e..dc38efe 100755
--- a/util/abuild/abuild
+++ b/util/abuild/abuild
@@ -786,10 +786,6 @@
    exit 1
 fi

-# Generate a single xcompile for all boards
-export xcompile="${TARGET}/xcompile"
-$MAKE -C"${ROOT}" obj="$TARGET/temp" objutil="$TARGET/sharedutils" UPDATED_SUBMODULES=1 "${xcompile}" || exit 1
-
 customizing=$(echo "$customizing" | cut -c3-)
 if [ "$customizing" = "" ]; then
    customizing="default configuration"
@@ -798,7 +794,11 @@
 FAILED_BOARDS="$(realpath ${TARGET}/failed_boards)"
 PASSED_BOARDS="$(realpath ${TARGET}/passing_boards)"

+# Generate a single xcompile for all boards
+export xcompile="${TARGET}/xcompile"
+
 if [ "$recursive" = "false" ]; then
+	$MAKE -C"${ROOT}" obj="$TARGET/temp" objutil="$TARGET/sharedutils" UPDATED_SUBMODULES=1 "${xcompile}" || exit 1
    rm -f "$FAILED_BOARDS" "$PASSED_BOARDS"
 fi