Felix Held submitted this change.
util/abuild: Run `make .xcompile` only once
If abuild called itself recursively, the file already exists and we can
spare us one evaluation of all the makefiles per recursive abuild run.
Change-Id: Id3e2239354ec251c24c03c971987586deeb026c5
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42640
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Reka Norman <rekanorman@chromium.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
---
M util/abuild/abuild
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/util/abuild/abuild b/util/abuild/abuild
index 5fe298e..dc38efe 100755
--- a/util/abuild/abuild
+++ b/util/abuild/abuild
@@ -786,10 +786,6 @@
exit 1
fi
-# Generate a single xcompile for all boards
-export xcompile="${TARGET}/xcompile"
-$MAKE -C"${ROOT}" obj="$TARGET/temp" objutil="$TARGET/sharedutils" UPDATED_SUBMODULES=1 "${xcompile}" || exit 1
-
customizing=$(echo "$customizing" | cut -c3-)
if [ "$customizing" = "" ]; then
customizing="default configuration"
@@ -798,7 +794,11 @@
FAILED_BOARDS="$(realpath ${TARGET}/failed_boards)"
PASSED_BOARDS="$(realpath ${TARGET}/passing_boards)"
+# Generate a single xcompile for all boards
+export xcompile="${TARGET}/xcompile"
+
if [ "$recursive" = "false" ]; then
+ $MAKE -C"${ROOT}" obj="$TARGET/temp" objutil="$TARGET/sharedutils" UPDATED_SUBMODULES=1 "${xcompile}" || exit 1
rm -f "$FAILED_BOARDS" "$PASSED_BOARDS"
fi
To view, visit change 42640. To unsubscribe, or for help writing mail filters, visit settings.