coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: soc/intel/alderlake: Add (and fix) devices in IRQ table
by Tim Wawrzynczak (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56175 ) Change subject: soc/intel/alderlake: Add (and fix) devices in IRQ table ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > Is a similar change required for other platforms as well? TGL, CML? I believe I checked TGL and it enters S0ix just fine still, need to verify CML though. -- To view, visit https://review.coreboot.org/c/coreboot/+/56175 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7612ee008842ba2b8dcd36deb201f4f26130660 Gerrit-Change-Number: 56175 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 12 Jul 2021 22:58:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Add (and fix) devices in IRQ table
by Tim Wawrzynczak (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56175 ) Change subject: soc/intel/alderlake: Add (and fix) devices in IRQ table ...................................................................... Patch Set 5: (1 comment) File src/soc/intel/alderlake/fsp_params.c: https://review.coreboot.org/c/coreboot/+/56175/comment/af1be71d_c8f3e490 PS2, Line 51: FIXED_INT_PIRQ > > EDS and both say INT_LINE is RW for IGD and IPU (and indeed, they appear programmable from lspci's […] See next patchset with better comments. -- To view, visit https://review.coreboot.org/c/coreboot/+/56175 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7612ee008842ba2b8dcd36deb201f4f26130660 Gerrit-Change-Number: 56175 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 12 Jul 2021 22:57:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Add (and fix) devices in IRQ table
by Furquan Shaikh (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56175 ) Change subject: soc/intel/alderlake: Add (and fix) devices in IRQ table ...................................................................... Patch Set 5: Code-Review+2 (2 comments) Patchset: PS5: Is a similar change required for other platforms as well? TGL, CML? File src/soc/intel/alderlake/fsp_params.c: https://review.coreboot.org/c/coreboot/+/56175/comment/12b7f1d9_2c8a017c PS5, Line 51: /* INTERRUPT_PIN is RO/0x01 */ Since this is a single-function device, the RO field for INTERRUPT_PIN makes sense. ANY_PIRQ would work equally well here since the IRQ driver will default to using PCI_INT_A. But, I think FIXED_INT_ANY_PIRQ is fine for consistency with other devices that are not single-function but still have this pin as RO. -- To view, visit https://review.coreboot.org/c/coreboot/+/56175 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7612ee008842ba2b8dcd36deb201f4f26130660 Gerrit-Change-Number: 56175 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 12 Jul 2021 22:50:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: supermicro/x11-lga1151-series: Remove SkipExtGfxScan = 1
by Jan Tatje (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Jan Tatje, Nico Huber, Angel Pons. Hello build bot (Jenkins), Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56071 to look at the new patch set (#4). Change subject: supermicro/x11-lga1151-series: Remove SkipExtGfxScan = 1 ...................................................................... supermicro/x11-lga1151-series: Remove SkipExtGfxScan = 1 Scan for external graphics, allows SeaBIOS to use the AST2400 with VGA_TEXT_FRAMEBUFFER=y. Also move PrimaryDisplay from variant to board devicetree. Tested on X11SSH-LN4F. Change-Id: I41249112c65927b61ca5f791f8eb8c3f3d204fce Signed-off-by: Jan Tatje <jan(a)jnt.io> --- M Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-f/x11ssh-f.md M src/mainboard/supermicro/x11-lga1151-series/devicetree.cb M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-f/overridetree.cb 3 files changed, 3 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/56071/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/56071 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41249112c65927b61ca5f791f8eb8c3f3d204fce Gerrit-Change-Number: 56071 Gerrit-PatchSet: 4 Gerrit-Owner: Jan Tatje <jan(a)jnt.io> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jan Tatje <jan(a)jnt.io> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/amd/cezanne: Move APOB update into ramstage
by Karthik Ramasubramanian (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56227 ) Change subject: soc/amd/cezanne: Move APOB update into ramstage ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56227/comment/fd6741bf_623a5d6d PS2, Line 10: it into ramstage allow us to use threads to pre-load the apob from SPI. Does it offer boot time savings? If so, can you please capture in the commit message regarding how much savings is observed? https://review.coreboot.org/c/coreboot/+/56227/comment/ebb0bba9_8c01b184 PS2, Line 13: and picasso Nit: Zork and Guybrush? File src/soc/amd/common/block/apob/apob_cache.c: https://review.coreboot.org/c/coreboot/+/56227/comment/cc5005f5_c6b39b13 PS2, Line 187: OOT_STATE_INIT_ENTRY(BS_POST_DEVICE, BS_ON_EXIT, soc_update_apob_cache, NULL); If there is a reason why not before this boot state and why not after this boot state, can you please mention that in the comment. That will ensure no one plays with this callback. -- To view, visit https://review.coreboot.org/c/coreboot/+/56227 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I960437ff4400645de5a3e7447fcdbc52de85943e Gerrit-Change-Number: 56227 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 12 Jul 2021 22:30:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: thread: Add missing static inline
by Karthik Ramasubramanian (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Raul Rangel, Julius Werner, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56226 ) Change subject: thread: Add missing static inline ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/56226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e3cfb55e48737c378bde53ae0e5d7cbf5e41bc3 Gerrit-Change-Number: 56226 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 12 Jul 2021 22:20:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads: FILO: Hook up autoboot options
by Paul Menzel (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Nico Huber, Martin Roth, Stefan Reinauer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56213 ) Change subject: payloads: FILO: Hook up autoboot options ...................................................................... Patch Set 2: (3 comments) File payloads/external/FILO/Makefile: https://review.coreboot.org/c/coreboot/+/56213/comment/9aece3c3_247ebc42 PS1, Line 36: ifeq ($(CONFIG_FILO_USE_AUTOBOOT),y) > You stripped the `FILO_` when passing it to the inner Makefile. Thanks, I updated `Makefile.inc`. https://review.coreboot.org/c/coreboot/+/56213/comment/3fe920df_4f91a71c PS1, Line 39: FILO_ > Same here. Done File payloads/external/FILO/Makefile: https://review.coreboot.org/c/coreboot/+/56213/comment/d0583a67_6b9a10d5 PS2, Line 39: echo "CONFIG_AUTOBOOT_FILE=$(CONFIG_FILO_AUTOBOOT_FILE)" >> filo/.config That seems to work now, but it overridden later on: ``` echo "# CONFIG_USE_GRUB is not set" >> filo/.config echo "CONFIG_USE_AUTOBOOT=y" >> filo/.config echo "CONFIG_AUTOBOOT_FILE=hda1:/vmlinuz root=/dev/sda1 console=tty0 console=ttyS0,115200" >> filo/.config make -C filo oldconfig LIBCONFIG_PATH=../../../libpayload mkdir -p /dev/shm/coreboot/payloads/external/FILO/filo/build/drivers/ mkdir -p /dev/shm/coreboot/payloads/external/FILO/filo/build/fs/ mkdir -p /dev/shm/coreboot/payloads/external/FILO/filo/build/main/ mkdir -p /dev/shm/coreboot/payloads/external/FILO/filo/build/main/grub/ mkdir -p /dev/shm/coreboot/payloads/external/FILO/filo/build/x86/ echo "Using binary libpayload, nothing to configure" Using binary libpayload, nothing to configure /dev/shm/coreboot/payloads/external/FILO/filo/build/util/kconfig/conf -o Kconfig .config:74:warning: override: reassigning to symbol USE_GRUB * * FILO Configuration * Build for architecture > 1. x86 (TARGET_I386) 2. ARM (TARGET_ARM) choice[1-2]: 1 Include a MultiBoot header (MULTIBOOT_IMAGE) [Y/n/?] y * * Interface Options * Use GRUB like interface (USE_GRUB) [N/y/?] n non-interactive interface (NON_INTERACTIVE) [N/y/?] n Autoboot a command line after timeout? (USE_AUTOBOOT) [Y/n] y Kernel filename and parameters (AUTOBOOT_FILE) [hda1:/vmlinuz root=/dev/hda1 console=tty0 console=ttyS0,115200] ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/56213 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id167e9a144bf466da87469108002672b299b702a Gerrit-Change-Number: 56213 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Mon, 12 Jul 2021 22:20:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads: FILO: Hook up autoboot options
by Paul Menzel (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Martin Roth, Paul Menzel, Stefan Reinauer. Hello build bot (Jenkins), Martin Roth, Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56213 to look at the new patch set (#2). Change subject: payloads: FILO: Hook up autoboot options ...................................................................... payloads: FILO: Hook up autoboot options FILO allows to configure a line to autoboot. Hook this up into coreboot’s build system. Change-Id: Id167e9a144bf466da87469108002672b299b702a Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- M payloads/external/FILO/Kconfig M payloads/external/FILO/Makefile M payloads/external/Makefile.inc 3 files changed, 26 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/56213/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56213 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id167e9a144bf466da87469108002672b299b702a Gerrit-Change-Number: 56213 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: thread: Add thread_handle
by build bot (Jenkins) (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Julius Werner, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56229 ) Change subject: thread: Add thread_handle ...................................................................... Patch Set 2: (1 comment) File src/include/thread.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123896): https://review.coreboot.org/c/coreboot/+/56229/comment/fcf7a4a3_4bb1cdb2 PS2, Line 29: enum cb_err (*entry)(void *); function definition argument 'void *' should also have an identifier name -- To view, visit https://review.coreboot.org/c/coreboot/+/56229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie6f64d0c5a5acad4431a605f0b0b5100dc5358ff Gerrit-Change-Number: 56229 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 12 Jul 2021 22:10:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common/block/apob: Fix incorrect printf format
by Karthik Ramasubramanian (Code Review) 13 Jul '21

13 Jul '21

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021