coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: mb/intel/adlrvp: Update PMC Descriptor for Alder lake A0(906a0h) silicon
by Balaji Manigandan (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Sridhar Siricilla, Rizwan Qureshi, Werner Zeh. Balaji Manigandan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56073 ) Change subject: mb/intel/adlrvp: Update PMC Descriptor for Alder lake A0(906a0h) silicon ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/56073 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a1f60fda7575212bb694fc423bd229452515903 Gerrit-Change-Number: 56073 Gerrit-PatchSet: 4 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.corp-partner.google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Tue, 13 Jul 2021 05:41:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/cret: DSM setting enablement for Intel WLAN card
by Ravindra (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Rizwan Qureshi. Ravindra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56250 ) Change subject: mb/google/cret: DSM setting enablement for Intel WLAN card ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Please review the changes -- To view, visit https://review.coreboot.org/c/coreboot/+/56250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I18d3f3b1dd91a0487e0ee3321b9bff24513913e3 Gerrit-Change-Number: 56250 Gerrit-PatchSet: 1 Gerrit-Owner: Ravindra <ravindra(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Comment-Date: Tue, 13 Jul 2021 05:37:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: DSM setting enablement for Intel WLAN card
by build bot (Jenkins) (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Tim Wawrzynczak, Ravindra N. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56249 ) Change subject: mb/google/brya: DSM setting enablement for Intel WLAN card ...................................................................... Patch Set 3: (2 comments) File src/drivers/wifi/generic/acpi.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123926): https://review.coreboot.org/c/coreboot/+/56249/comment/11dac4fe_e15def76 PS3, Line 47: void wifi_write_dsm(const char *uuid, void (**callbacks)(void *), function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123926): https://review.coreboot.org/c/coreboot/+/56249/comment/6c0f62c5_10f42266 PS3, Line 47: void wifi_write_dsm(const char *uuid, void (**callbacks)(void *), function definition argument 'void *' should also have an identifier name -- To view, visit https://review.coreboot.org/c/coreboot/+/56249 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22411ca8648e89397a2c8dab6ed9041f47c664b8 Gerrit-Change-Number: 56249 Gerrit-PatchSet: 3 Gerrit-Owner: Ravindra <ravindra(a)intel.com> Gerrit-Reviewer: Ravindra N <ravindra(a)intel.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Ravindra N <ravindra(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Tue, 13 Jul 2021 05:36:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/cret: DSM setting enablement for Intel WLAN card
by Ravindra (Code Review) 13 Jul '21

13 Jul '21

Ravindra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56250 ) Change subject: mb/google/cret: DSM setting enablement for Intel WLAN card ...................................................................... mb/google/cret: DSM setting enablement for Intel WLAN card To support worldwide regulatory WLAN feature(Indonesia AX / Ukraine AX / Russia AX), Intel WLAN card has to set DSM setting to meet the regulatory requirement which allows to modify the settings. BUG=none TEST=Generate SSDT tables and verify the required settings applied Signed-off-by: Ravindra <ravindra(a)intel.com> Change-Id: I18d3f3b1dd91a0487e0ee3321b9bff24513913e3 --- M src/mainboard/google/dedede/variants/cret/overridetree.cb 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/56250/1 diff --git a/src/mainboard/google/dedede/variants/cret/overridetree.cb b/src/mainboard/google/dedede/variants/cret/overridetree.cb index 8b26d5d..e61ed8e 100644 --- a/src/mainboard/google/dedede/variants/cret/overridetree.cb +++ b/src/mainboard/google/dedede/variants/cret/overridetree.cb @@ -5,6 +5,15 @@ option AUDIO_CODEC_RT5682 2 option AUDIO_CODEC_CS42l42 3 end + field WIFI_INDONESIA_5GHZ_CONFIG 44 + option BAND_5GHZ_DISABLE 0 + option BAND_5GHZ_ENABLE 1 + end + field WIFI_OTP_DEF 45 46 + option UKR_RUS_OTP_11AX_DEFAULT 0 + option UKR_OTP_ENB_11AX_ENB 1 + option UKR_OTP_ENB_11AX_DIS 2 + end end chip soc/intel/jasperlake -- To view, visit https://review.coreboot.org/c/coreboot/+/56250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I18d3f3b1dd91a0487e0ee3321b9bff24513913e3 Gerrit-Change-Number: 56250 Gerrit-PatchSet: 1 Gerrit-Owner: Ravindra <ravindra(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/brya: DSM setting enablement for Intel WLAN card
by Ravindra (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Tim Wawrzynczak, Ravindra, Ravindra N. Hello build bot (Jenkins), Tim Wawrzynczak, Ravindra N, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56249 to look at the new patch set (#3). Change subject: mb/google/brya: DSM setting enablement for Intel WLAN card ...................................................................... mb/google/brya: DSM setting enablement for Intel WLAN card To support worldwide regulatory WLAN feature(Indonesia AX / Ukraine AX / Russia AX), Intel WLAN card has to set DSM setting to meet the regulatory requirement which allows to modify the settings. BUG=none TEST=Generate SSDT tables and verify the required settings applied Change-Id: I22411ca8648e89397a2c8dab6ed9041f47c664b8 Signed-off-by: Ravindra <ravindra(a)intel.com> --- M src/drivers/wifi/generic/acpi.c M src/mainboard/google/brya/variants/brya0/overridetree.cb 2 files changed, 153 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/56249/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/56249 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22411ca8648e89397a2c8dab6ed9041f47c664b8 Gerrit-Change-Number: 56249 Gerrit-PatchSet: 3 Gerrit-Owner: Ravindra <ravindra(a)intel.com> Gerrit-Reviewer: Ravindra N <ravindra(a)intel.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Ravindra <ravindra(a)intel.com> Gerrit-Attention: Ravindra N <ravindra(a)intel.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya: DSM setting enablement for Intel WLAN card
by build bot (Jenkins) (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Tim Wawrzynczak, Ravindra, Ravindra N. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56249 ) Change subject: mb/google/brya: DSM setting enablement for Intel WLAN card ...................................................................... Patch Set 1: (2 comments) File src/drivers/wifi/generic/acpi.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123925): https://review.coreboot.org/c/coreboot/+/56249/comment/ef4774da_856032ec PS1, Line 47: void wifi_write_dsm(const char *uuid, void (**callbacks)(void *), function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123925): https://review.coreboot.org/c/coreboot/+/56249/comment/45406852_8467a0ac PS1, Line 47: void wifi_write_dsm(const char *uuid, void (**callbacks)(void *), function definition argument 'void *' should also have an identifier name -- To view, visit https://review.coreboot.org/c/coreboot/+/56249 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22411ca8648e89397a2c8dab6ed9041f47c664b8 Gerrit-Change-Number: 56249 Gerrit-PatchSet: 1 Gerrit-Owner: Ravindra <ravindra(a)intel.com> Gerrit-Reviewer: Ravindra N <ravindra(a)intel.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Ravindra <ravindra(a)intel.com> Gerrit-Attention: Ravindra N <ravindra(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Tue, 13 Jul 2021 05:25:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: spi: Limit the SPI NOR size
by Sajida Bhanu (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Ravi kumar, Paul Menzel, Julius Werner. Sajida Bhanu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55376 ) Change subject: spi: Limit the SPI NOR size ...................................................................... Patch Set 9: (1 comment) Patchset: PS1: > Sure thank you Hi Julius, Our internal coreboot team commented "we can’t and shouldn’t access SPI_NOR larger than what is going to be on final chromebook hw from google" which is 8MB on herobrine board. Do we see any concern with limiting spi-nor here? Thanks, Sajida -- To view, visit https://review.coreboot.org/c/coreboot/+/55376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I78f3f402b383bbad303f26c31d3d973c5f20d172 Gerrit-Change-Number: 55376 Gerrit-PatchSet: 9 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Sajida Bhanu <sbhanu(a)codeaurora.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Tue, 13 Jul 2021 05:24:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sajida Bhanu <sbhanu(a)codeaurora.org> Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: DSM setting enablement for Intel WLAN card
by Ravindra (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Tim Wawrzynczak, Ravindra N. Hello Tim Wawrzynczak, Ravindra N, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56249 to look at the new patch set (#2). Change subject: mb/google/brya: DSM setting enablement for Intel WLAN card ...................................................................... mb/google/brya: DSM setting enablement for Intel WLAN card To support worldwide regulatory WLAN feature(Indonesia AX / Ukraine AX / Russia AX), Intel WLAN card has to set DSM setting to meet the regulatory requirement which allows to modify the settings. BUG=none TEST=Generate SSDT tables and verify the required settings applied Change-Id: I22411ca8648e89397a2c8dab6ed9041f47c664b8 Signed-off-by: Ravindra <ravindra(a)intel.com> --- M src/drivers/wifi/generic/acpi.c M src/mainboard/google/brya/variants/brya0/overridetree.cb 2 files changed, 153 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/56249/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56249 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22411ca8648e89397a2c8dab6ed9041f47c664b8 Gerrit-Change-Number: 56249 Gerrit-PatchSet: 2 Gerrit-Owner: Ravindra <ravindra(a)intel.com> Gerrit-Reviewer: Ravindra N <ravindra(a)intel.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Ravindra N <ravindra(a)intel.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: brya: DSM setting enablement for Intel WLAN card
by Ravindra (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Ravindra N. Hello Ravindra N, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/56249 to review the following change. Change subject: brya: DSM setting enablement for Intel WLAN card ...................................................................... brya: DSM setting enablement for Intel WLAN card To support worldwide regulatory WLAN feature(Indonesia AX / Ukraine AX / Russia AX), Intel WLAN card has to set DSM setting to meet the regulatory requirement which allows to modify the settings. BUG=none TEST=Generate SSDT tables and verify the required settings applied Change-Id: I22411ca8648e89397a2c8dab6ed9041f47c664b8 Signed-off-by: Ravindra N <ravindra(a)intel.corp-partner.google.com> --- M src/drivers/wifi/generic/acpi.c M src/mainboard/google/brya/variants/brya0/overridetree.cb 2 files changed, 153 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/56249/1 diff --git a/src/drivers/wifi/generic/acpi.c b/src/drivers/wifi/generic/acpi.c index 3e3b5c1..46d9a42 100644 --- a/src/drivers/wifi/generic/acpi.c +++ b/src/drivers/wifi/generic/acpi.c @@ -7,6 +7,7 @@ #include <device/pci_ids.h> #include <sar.h> #include <wrdd.h> +#include <include/fw_config.h> #include "chip.h" #include "wifi_private.h" @@ -34,6 +35,143 @@ */ #define WIFI_ACPI_NAME_MAX_LEN 5 +/* Unique ID for the WIFI _DSM. */ +#define ACPI_DSM_OEM_WIFI_UUID "F21202BF-8F78-4DC6-A5B3-1F738E285ADE" + +/* + * Generate ACPI AML code for _DSM method. + * This function takes as input uuid for the device, set of callbacks and + * argument to pass into the callbacks. Callbacks should ensure that Local0 and + * Local1 are left untouched. Use of Local2-Local7 is permitted in callbacks. + */ +void wifi_write_dsm(const char *uuid, void (**callbacks)(void *), + size_t count, void *arg); +void wifi_write_dsm_uuid_arr(struct dsm_uuid *ids, size_t count); +static void wifi_write_dsm_uuid(struct dsm_uuid *id); + +/* + * Function 2 : Supported Indonesia 5.15-5.35 GHz Band + * 00 - Set 5.115-5.35GHz to Disable in Indonesia + * 01 - Set 5.115-5.35GHz to Enable (Passive) in Indonesia + * 02 - Reserved + */ +static void wifi_dsm_indonasia_5Ghz_band_enable(void *arg) +{ + bool band_5ghz_enabled = fw_config_probe(FW_CONFIG(WIFI_INDONESIA_5GHZ_CONFIG, + BAND_5GHZ_ENABLE)); + acpigen_write_to_integer(band_5ghz_enabled, LOCAL0_OP); + acpigen_write_if_lequal_op_int(LOCAL0_OP, 1); + acpigen_write_return_integer(1); + acpigen_write_else(); + acpigen_write_return_integer(0); + acpigen_pop_len(); +} + +/* + * Function 6: 11Ax Control + * Bit 0 - Apply changes to country Ukraine. 11Ax Setting within + * module certification + * 0 - None. Work with Wi-Fi FW/OTP definitions [Default] + * 1 - Apply changes. + * + * Bit 1 - 11Ax Mode. Effective only if Bit 0 set to 1 + * 0 - Disable 11Ax on country Ukraine [Default] + * 1 - Enable 11Ax on country Ukraine + * + * Bit 2 - Apply changes to country Russia. 11Ax Setting within + * module certification + * 0 - None. Work with Wi-Fi FW/OTP definitions [Default] + * 1 - Apply changes. + * + * Bit 3 - 11Ax Mode. Effective only if Bit 2 set to 1 + * 0 - Disable 11Ax on country Russia [Default] + * 1 - Enable 11Ax on country Russia + * + * Bit 31:04 - Reserved + * + */ +static void wifi_dsm_ukrane_russia_11ax_enable(void *arg) +{ + bool dsm_11ax_enabled = fw_config_probe(FW_CONFIG(WIFI_OTP_DEF, + UKR_RUS_OTP_11AX_DEFAULT)); + acpigen_write_to_integer(dsm_11ax_enabled, LOCAL0_OP); + acpigen_write_if_lequal_op_int(LOCAL0_OP, 1); + acpigen_write_return_singleton_buffer(0x0000); + acpigen_pop_len(); + dsm_11ax_enabled = fw_config_probe(FW_CONFIG(WIFI_OTP_DEF, + UKR_OTP_ENB_11AX_ENB)); + acpigen_write_to_integer(dsm_11ax_enabled, LOCAL0_OP); + acpigen_write_if_lequal_op_int(LOCAL0_OP, 1); + acpigen_write_return_singleton_buffer(0x0011); + acpigen_pop_len(); + dsm_11ax_enabled = fw_config_probe(FW_CONFIG(WIFI_OTP_DEF, + UKR_OTP_ENB_11AX_DIS)); + acpigen_write_to_integer(dsm_11ax_enabled, LOCAL0_OP); + acpigen_write_if_lequal_op_int(LOCAL0_OP, 1); + acpigen_write_return_singleton_buffer(0x0010); + acpigen_pop_len(); +} + +static void (*wifi_dsm_callbacks[])(void *) = { + NULL, /* Function 0 */ + NULL, /* Function 1 */ + wifi_dsm_indonasia_5Ghz_band_enable, /* Function 2 */ + NULL, /* Function 3 */ + NULL, /* Function 4 */ + NULL, /* Function 5 */ + wifi_dsm_ukrane_russia_11ax_enable, /* Function 6 */ +}; + +void wifi_write_dsm(const char *uuid, void (**callbacks)(void *), + size_t count, void *arg) +{ + struct dsm_uuid id = DSM_UUID(uuid, callbacks, count, arg); + wifi_write_dsm_uuid_arr(&id, 1); +} + +static void wifi_write_dsm_uuid(struct dsm_uuid *id) +{ + size_t i; + + /* If (LEqual (Local0, ToUUID(uuid))) */ + acpigen_write_if(); + acpigen_emit_byte(LEQUAL_OP); + acpigen_emit_byte(LOCAL0_OP); + acpigen_write_uuid(id->uuid); + + /* ToInteger (Arg2, Local1) */ + acpigen_write_to_integer(ARG2_OP, LOCAL1_OP); + + for (i = 0; i < id->count; i++) { + /* If (LEqual (Local1, i)) */ + acpigen_write_if_lequal_op_int(LOCAL1_OP, i); + + /* Callback to write if handler. */ + if (id->callbacks[i]) + id->callbacks[i](id->arg); + + acpigen_pop_len(); /* If */ + } + + acpigen_pop_len(); /* If (LEqual (Local0, ToUUID(uuid))) */ +} + +void wifi_write_dsm_uuid_arr(struct dsm_uuid *ids, size_t count) +{ + size_t i; + + /* Method (_DSM, 4, Serialized) */ + acpigen_write_method_serialized("_DSM", 0x4) + + /* ToBuffer (Arg0, Local0) */ + acpigen_write_to_buffer(ARG0_OP, LOCAL0_OP); + + for (i = 0; i < count; i++) + wifi_write_dsm_uuid(&ids[i]); + + acpigen_pop_len(); /* Method _DSM */ +} + __weak int get_wifi_sar_limits(struct wifi_sar_limits *sar_limits) { return -1; @@ -183,10 +321,15 @@ static void wifi_ssdt_write_properties(const struct device *dev, const char *scope) { const struct drivers_wifi_generic_config *config = dev->chip_info; - /* Scope */ acpigen_write_scope(scope); + /* Call Wifi DSM method */ + wifi_write_dsm(ACPI_DSM_OEM_WIFI_UUID, + wifi_dsm_callbacks, + ARRAY_SIZE(wifi_dsm_callbacks), + NULL); + /* Wake capabilities */ if (config) acpigen_write_PRW(config->wake, ACPI_S3); diff --git a/src/mainboard/google/brya/variants/brya0/overridetree.cb b/src/mainboard/google/brya/variants/brya0/overridetree.cb index d4653bc..25590d7 100644 --- a/src/mainboard/google/brya/variants/brya0/overridetree.cb +++ b/src/mainboard/google/brya/variants/brya0/overridetree.cb @@ -27,6 +27,15 @@ option UFC_USB 0 option UFC_MIPI_5675 1 end + field WIFI_INDONESIA_5GHZ_CONFIG 15 + option BAND_5GHZ_DISABLE 0 + option BAND_5GHZ_ENABLE 1 + end + field WIFI_OTP_DEF 16 17 + option UKR_RUS_OTP_11AX_DEFAULT 0 + option UKR_OTP_ENB_11AX_ENB 1 + option UKR_OTP_ENB_11AX_DIS 2 + end end chip soc/intel/alderlake -- To view, visit https://review.coreboot.org/c/coreboot/+/56249 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22411ca8648e89397a2c8dab6ed9041f47c664b8 Gerrit-Change-Number: 56249 Gerrit-PatchSet: 1 Gerrit-Owner: Ravindra <ravindra(a)intel.com> Gerrit-Reviewer: Ravindra N <ravindra(a)intel.corp-partner.google.com> Gerrit-Attention: Ravindra N <ravindra(a)intel.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/intel/gma: Support IGD Opregion 2.1
by Furquan Shaikh (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Nico Huber, Krishna Prabhakaran, Maulik V Vaghela, Selma Bensaid, Angel Pons, Subrata Banik, Meera Ravindranath, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52758 ) Change subject: drivers/intel/gma: Support IGD Opregion 2.1 ...................................................................... Patch Set 24: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52758 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I95a9f3df185002a4e38faa910f867ace0b97ac2b Gerrit-Change-Number: 52758 Gerrit-PatchSet: 24 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Krishna Prabhakaran <krishna.prabhakaran(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Krishna Prabhakaran <krishna.prabhakaran(a)intel.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 13 Jul 2021 05:11:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021