coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: drivers/usb/acpi/usb_acpi: Fix Coverity errors
by Raul Rangel (Code Review) 13 Jul '21

13 Jul '21

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56269 ) Change subject: drivers/usb/acpi/usb_acpi: Fix Coverity errors ...................................................................... drivers/usb/acpi/usb_acpi: Fix Coverity errors >>> CID 1458232: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "usb_device" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. >>> CID 1458231: Incorrect expression (SIZEOF_MISMATCH) >>> Passing argument "pld" of type "struct acpi_pld *" and argument "4UL /* sizeof (pld) */" to function "memcpy" is suspicious. TEST=none Found-by: Coverity CID 1458232, 1458231 Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I8f604a48732457864cc50368205004d2299c4149 --- M src/drivers/usb/acpi/usb_acpi.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/56269/1 diff --git a/src/drivers/usb/acpi/usb_acpi.c b/src/drivers/usb/acpi/usb_acpi.c index a0dadff..c3bcfa2 100644 --- a/src/drivers/usb/acpi/usb_acpi.c +++ b/src/drivers/usb/acpi/usb_acpi.c @@ -125,14 +125,16 @@ bool usb_acpi_get_pld(const struct device *usb_device, struct acpi_pld *pld) { - struct drivers_usb_acpi_config *config = usb_device->chip_info; + struct drivers_usb_acpi_config *config; if (!usb_device || !usb_device->chip_info || usb_device->chip_ops != &drivers_usb_acpi_ops) return false; + config = usb_device->chip_info; + if (config->use_custom_pld) - memcpy(pld, &config->custom_pld, sizeof(pld)); + memcpy(pld, &config->custom_pld, sizeof(*pld)); else acpi_pld_fill_usb(pld, config->type, &config->group); -- To view, visit https://review.coreboot.org/c/coreboot/+/56269 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f604a48732457864cc50368205004d2299c4149 Gerrit-Change-Number: 56269 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/usb/acpi: Fix usb_acpi_get_pld
by Angel Pons (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Tim Wawrzynczak. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56264 ) Change subject: drivers/usb/acpi: Fix usb_acpi_get_pld ...................................................................... Patch Set 2: (1 comment) File src/drivers/usb/acpi/usb_acpi.c: https://review.coreboot.org/c/coreboot/+/56264/comment/ead6b528_ca33c376 PS2, Line 136: memcpy(pld, &config->custom_pld, sizeof(*pld)); Just don't use memcpy, it's not needed: CB:56265 -- To view, visit https://review.coreboot.org/c/coreboot/+/56264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I424ae185f544c13c0638ff57c097d784265f2848 Gerrit-Change-Number: 56264 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Tue, 13 Jul 2021 17:11:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib/timer: Make udelay respect input parameter
by Raul Rangel (Code Review) 13 Jul '21

13 Jul '21

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56268 ) Change subject: lib/timer: Make udelay respect input parameter ...................................................................... lib/timer: Make udelay respect input parameter This makes it possible to use `udelay(0)` to yield without actually wasting 1 us. BUG=b:179699789 TEST=Boot guybrush to the OS Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I03c842ecef7641009f177a1458b88ca500dbfdb4 --- M src/lib/timer.c 1 file changed, 4 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/56268/1 diff --git a/src/lib/timer.c b/src/lib/timer.c index 8a06f57..411e60e 100644 --- a/src/lib/timer.c +++ b/src/lib/timer.c @@ -10,15 +10,11 @@ { struct stopwatch sw; - /* - * As the timer granularity is in microseconds pad the - * requested delay by one to get at least >= requested usec delay. - */ - usec += 1; - if (!thread_yield_microseconds(usec)) return; - stopwatch_init_usecs_expire(&sw, usec); - stopwatch_wait_until_expired(&sw); + if (usec > 0) { + stopwatch_init_usecs_expire(&sw, usec); + stopwatch_wait_until_expired(&sw); + } } -- To view, visit https://review.coreboot.org/c/coreboot/+/56268 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I03c842ecef7641009f177a1458b88ca500dbfdb4 Gerrit-Change-Number: 56268 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/amd/common/block: Make SPI DMA readat co-op friendly
by Raul Rangel (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56267 ) Change subject: soc/amd/common/block: Make SPI DMA readat co-op friendly ...................................................................... soc/amd/common/block: Make SPI DMA readat co-op friendly We need to make the SPI readat method yield frequently so that we don't block the main thread of execution for too long. BUG=b:179699789 TEST=Boot guybrush to the OS. Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: Id3ec58a2e35e744b5bc2062ae479917f7f57bae9 --- M src/soc/amd/common/block/lpc/spi_dma.c 1 file changed, 21 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/56267/1 diff --git a/src/soc/amd/common/block/lpc/spi_dma.c b/src/soc/amd/common/block/lpc/spi_dma.c index dede449..9b17a38 100644 --- a/src/soc/amd/common/block/lpc/spi_dma.c +++ b/src/soc/amd/common/block/lpc/spi_dma.c @@ -41,14 +41,33 @@ return 0; } -static ssize_t spi_dma_readat_mmap(const struct region_device *rd, void *b, size_t offset, +static ssize_t spi_dma_readat_mmap(const struct region_device *rd, uint8_t *b, size_t offset, size_t size) { const struct mem_region_device *mdev; + /* + * Transfer at most 128 bytes at a time to not block too long. Otherwise + * we can drastically affect the udelay timings and timestamp accounting + * for other components. + */ + const size_t block_size = 128; + size_t remaining = size; + size_t transfer_size; mdev = container_of(rd, __typeof__(*mdev), rdev); - memcpy(b, &mdev->base[offset], size); + while (remaining) { + transfer_size = MIN(remaining, block_size); + + memcpy(b, &mdev->base[offset], transfer_size); + + b += transfer_size; + offset += transfer_size; + remaining -= transfer_size; + + /* Yield execution to other threads */ + udelay(0); + } return size; } -- To view, visit https://review.coreboot.org/c/coreboot/+/56267 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id3ec58a2e35e744b5bc2062ae479917f7f57bae9 Gerrit-Change-Number: 56267 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: lib/prog_loaders: Add payload_preload
by Raul Rangel (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Raul Rangel. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56051 to look at the new patch set (#7). Change subject: lib/prog_loaders: Add payload_preload ...................................................................... lib/prog_loaders: Add payload_preload This method will allow the SoC code to start loading the payload before it is required. BUG=b:177909625 TEST=Boot guybrush and see read/decompress drop by 23 ms. Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: Ifa8f30a0f4f931ece803c2e8e022e4d33d3fe581 --- M src/include/program_loading.h M src/include/symbols.h M src/lib/Kconfig M src/lib/prog_loaders.c 4 files changed, 63 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/56051/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/56051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifa8f30a0f4f931ece803c2e8e022e4d33d3fe581 Gerrit-Change-Number: 56051 Gerrit-PatchSet: 7 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/amd/common/block/lpc: Don't disable the HOG bit
by Raul Rangel (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Eric Peers, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56233 ) Change subject: soc/amd/common/block/lpc: Don't disable the HOG bit ...................................................................... Patch Set 3: (1 comment) File src/soc/amd/common/block/lpc/lpc.c: https://review.coreboot.org/c/coreboot/+/56233/comment/205d60cb_13eb1e3d PS2, Line 69: // byte &= ~LPC_NOHOG; > is this commented out line going to confuse future generations? This is a WIP patch, so still working out the details :) -- To view, visit https://review.coreboot.org/c/coreboot/+/56233 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If015869657f36d3533f4ab9ebd1f54b0d4eb283a Gerrit-Change-Number: 56233 Gerrit-PatchSet: 3 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Peers <epeers(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 13 Jul 2021 17:11:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Peers <epeers(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common/block/lpc: Don't disable the HOG bit
by Raul Rangel (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Eric Peers, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Marshall Dawson, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56233 to look at the new patch set (#3). Change subject: soc/amd/common/block/lpc: Don't disable the HOG bit ...................................................................... soc/amd/common/block/lpc: Don't disable the HOG bit According to the AMD FCH architects, we should be using the default value for the NO_HOG bit. This fixes a problem where the SPI DMA no longer functions after the LPC init runs. BUG=b:179699789, b:192373221 TEST=Boot guybrush and see SPI DMA working Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: If015869657f36d3533f4ab9ebd1f54b0d4eb283a --- M src/soc/amd/common/block/lpc/lpc.c 1 file changed, 0 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/56233/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/56233 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If015869657f36d3533f4ab9ebd1f54b0d4eb283a Gerrit-Change-Number: 56233 Gerrit-PatchSet: 3 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Peers <epeers(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/amd/common/apob: Add support for asynchronously reading APOB
by Raul Rangel (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Marshall Dawson, Eric Peers, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56232 to look at the new patch set (#3). Change subject: soc/amd/common/apob: Add support for asynchronously reading APOB ...................................................................... soc/amd/common/apob: Add support for asynchronously reading APOB This CL adds a method that can starts the processes of reading the APOB from SPI. It does require more RAM in ramstage since we no longer mmap the buffer in the async happy path. This will allow us to reduce our boot time by 10ms. BUG=b:179699789 TEST=With this and the patches above I can see a 10 ms reduction in boot time on guybrush. Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I930d58b76eb4558bc4f48ed928c4d6538fefb1e5 --- M src/soc/amd/common/block/apob/apob_cache.c 1 file changed, 68 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/56232/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/56232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I930d58b76eb4558bc4f48ed928c4d6538fefb1e5 Gerrit-Change-Number: 56232 Gerrit-PatchSet: 3 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/amd/common/block/lpc/spi_dma: Use mutex to protect DMA registers
by Raul Rangel (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Eric Peers, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56231 ) Change subject: soc/amd/common/block/lpc/spi_dma: Use mutex to protect DMA registers ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56231/comment/c702e03b_0877c784 PS2, Line 10: have multiple threads trhing to access the DMA hardware. > nit: trying Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56231 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibb8e31c95d6722521425772f4210af45626c8e09 Gerrit-Change-Number: 56231 Gerrit-PatchSet: 3 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Peers <epeers(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 13 Jul 2021 17:11:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Peers <epeers(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common/block/lpc/spi_dma: Use mutex to protect DMA registers
by Raul Rangel (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Eric Peers, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Marshall Dawson, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56231 to look at the new patch set (#3). Change subject: soc/amd/common/block/lpc/spi_dma: Use mutex to protect DMA registers ...................................................................... soc/amd/common/block/lpc/spi_dma: Use mutex to protect DMA registers Once we enable COOP_MULTITASKING, we need to guarantee that we don't have multiple threads trying to access the DMA hardware. BUG=b:179699789 TEST=Boot guybrush with APOB patches. Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: Ibb8e31c95d6722521425772f4210af45626c8e09 --- M src/soc/amd/common/block/lpc/spi_dma.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/56231/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/56231 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibb8e31c95d6722521425772f4210af45626c8e09 Gerrit-Change-Number: 56231 Gerrit-PatchSet: 3 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Peers <epeers(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021