Attention is currently required from: Angel Pons, Subrata Banik, Michael Niewöhner.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56217 )
Change subject: mb/intel/coffeelake_rvp: Rework Kconfig
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56217/comment/cb79bbd6_dbfee348
PS3, Line 17: Built each variant with `BUILD_TIMELESS=1` and all generated
> I imagine you had to skip including the config file inside the coreboot. […]
Right, I did not include the .config file.
File src/mainboard/intel/coffeelake_rvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/56217/comment/4d78b9a1_b6922368
PS3, Line 15: BOARD_INTEL_COFFEELAKE_RVP8_OPTIONS
> I'd reuse the symbols declared in Kconfig. […]
The linter complains about this:
Error: BOARD_INTEL_COFFEELAKE_RVP8 entry at src/mainboard/intel/coffeelake_rvp/Kconfig:15 has already
been created outside a choice block at src/mainboard/intel/coffeelake_rvp/Kconfig.name:12.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56217
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b3d3cff5ea7a3f4d1c4ddd911240763e4891e06
Gerrit-Change-Number: 56217
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Comment-Date: Wed, 14 Jul 2021 13:15:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Balaji Manigandan has removed Stefan Reinauer from this change. ( https://review.coreboot.org/c/coreboot/+/56307 )
Change subject: payloads/external/depthcharge:Add option to skip repo fetch
......................................................................
Removed reviewer Stefan Reinauer.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f0be607504af87a8634c6cbd97888b72f8ba41b
Gerrit-Change-Number: 56307
Gerrit-PatchSet: 1
Gerrit-Owner: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-MessageType: deleteReviewer
Attention is currently required from: Stefan Reinauer.
Balaji Manigandan has removed Martin Roth from this change. ( https://review.coreboot.org/c/coreboot/+/56307 )
Change subject: payloads/external/depthcharge:Add option to skip repo fetch
......................................................................
Removed reviewer Martin Roth.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f0be607504af87a8634c6cbd97888b72f8ba41b
Gerrit-Change-Number: 56307
Gerrit-PatchSet: 1
Gerrit-Owner: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-MessageType: deleteReviewer
Balaji Manigandan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56307 )
Change subject: payloads/external/depthcharge:Add option to skip repo fetch
......................................................................
payloads/external/depthcharge:Add option to skip repo fetch
Payload depthcharge repository gets automatically cloned/updated
based on the Kconfig settings,discarding any local cherry-picks
This option DEPTHCHARGE_SKIP_REPO_FETCH allows users to retain
cherry-pick and particularly useful while debugging
Signed-off-by: Balaji Manigandan B <balaji.manigandan(a)intel.com>
Change-Id: I5f0be607504af87a8634c6cbd97888b72f8ba41b
---
M payloads/external/depthcharge/Kconfig
M payloads/external/depthcharge/Makefile
2 files changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/56307/1
diff --git a/payloads/external/depthcharge/Kconfig b/payloads/external/depthcharge/Kconfig
index 89c81ef..27c410d 100644
--- a/payloads/external/depthcharge/Kconfig
+++ b/payloads/external/depthcharge/Kconfig
@@ -48,4 +48,9 @@
instead. This is can be a convenience for development purposes, or
if the defaults in defconfig are sufficient for your system.
+config DEPTHCHARGE_SKIP_REPO_FETCH
+ bool "Skip automatic update of the repo"
+ default n
+ help
+ Set this flag if you need to pick any patches and build them
endif
diff --git a/payloads/external/depthcharge/Makefile b/payloads/external/depthcharge/Makefile
index 23595e5..464900a 100644
--- a/payloads/external/depthcharge/Makefile
+++ b/payloads/external/depthcharge/Makefile
@@ -72,7 +72,7 @@
$(MAKE) -C $(libpayload_dir)
$(MAKE) -C $(libpayload_dir) install DESTDIR=$(libpayload_install_dir)
-config: $(project_dir)/.version_$(TAG-y) $(libpayload_install_dir)
+config: $(if $(findstring y,$(DEPTHCHARGE_SKIP_REPO_FETCH)),,$(project_dir)/.version_$(TAG-y)) $(libpayload_install_dir)
echo " CONFIG project_name $(TAG-y)"
export VERSION=$$(cd depthcharge && \
git describe --tags --long --dirty 2>/dev/null || \
--
To view, visit https://review.coreboot.org/c/coreboot/+/56307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f0be607504af87a8634c6cbd97888b72f8ba41b
Gerrit-Change-Number: 56307
Gerrit-PatchSet: 1
Gerrit-Owner: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-MessageType: newchange
Attention is currently required from: Frank Chu, Isaac Lee, Tim Wawrzynczak.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56302 )
Change subject: mb/google/volteer/variants/collis: Redefine GPIO_EC_IN_RW to GPP_F17
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56302/comment/bb5a7c7e_46550e00
PS1, Line 11: none
Create a bug for this. I think the FAFT test should catch this problem.
https://review.coreboot.org/c/coreboot/+/56302/comment/66a764f1_f9f35a0a
PS1, Line 12: none
firmware-volteer-13672.B
https://review.coreboot.org/c/coreboot/+/56302/comment/ecd1efdf_a9dfb5d4
PS1, Line 13: none
It shouldn't be none. You need to make sure the pin is working correctly. For example, you can measure the gpio signal.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56302
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24f4803dc99ef3fc78852241f3a9e86ec70293d9
Gerrit-Change-Number: 56302
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anson Tseng <ansontseng(a)google.com>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Isaac Lee <isaaclee(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Wed, 14 Jul 2021 11:52:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56223 )
Change subject: payloads/external/tianocore: Add build argument for 4G Decode
......................................................................
Patch Set 8:
(1 comment)
This change is ready for review.
File payloads/external/tianocore/Kconfig:
https://review.coreboot.org/c/coreboot/+/56223/comment/3777cbea_67a55609
PS7, Line 99: for Qubes (Xen).
> > "Above 4G Decoding" follows the term used by other firmware platforms; might make it easier for ot […]
Mapping would probably be a better way of putting it, but descriptions aren't my strong suit!
It's basically reserving memory so that EFI_RESOURCE_ATTRIBUTE_TESTED isn't set on any memory above 4GB in the resource HOB.
If it helps (still WIP as the build argument is proving as co-operative as a brick):
https://github.com/StarLabsLtd/edk2/commit/93085320b732e19a4f569235955fcc00…
--
To view, visit https://review.coreboot.org/c/coreboot/+/56223
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3b1d15196c0ec611431af29031682fea626d19d
Gerrit-Change-Number: 56223
Gerrit-PatchSet: 8
Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Wed, 14 Jul 2021 11:38:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-MessageType: comment
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56303 )
Change subject: drivers/intel/gma: Refactor IGD opregion 2.1 support code
......................................................................
drivers/intel/gma: Refactor IGD opregion 2.1 support code
This patch ensures SoC users to select supported IGD opregion
specification Kconfig example: INTEL_GMA_OPREGION_2_1 and GMA
driver code would be able to detect the opregion version.
The opregion version can be used to uniquely identify the
spec and fill the required filled as RVDA for opregion 2.1
spec differently compared to previous version.
Also, drop the opregion_get_version() function as
CONFIG_OPREGION_VERSION is enough to assign the opregion version
into the header structure.
Expectauon from user to add new Kconfig as OPREGION_X_x_VERSION
(X: Major and x: Minor version) and specify the opregion structure
version as spec demands as Bits[31:24] for Major Version,
Bits[23:16] for Minor version, Bits[15:8] for Revision and Bits[7:0]
Reserved. For example: Opregion 2.1 specificatin would use Kconfig
as below:
config OPREGION_2_1_VERSION
hex
default 0x02010000
TEST=Able to verify OPREGION_VERSION Kconfig default is changing as
per SoC selects of opregion Kconfig.
Change-Id: I2ba7b64473781ac67c8958241bf5149fe0c009ba
Signed-off-by: Subrata Banik <subrata.banik(a)intel.com>
---
M src/drivers/intel/gma/Kconfig
M src/drivers/intel/gma/opregion.c
M src/drivers/intel/gma/opregion.h
3 files changed, 33 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/56303/1
diff --git a/src/drivers/intel/gma/Kconfig b/src/drivers/intel/gma/Kconfig
index 87f6d12..9857561 100644
--- a/src/drivers/intel/gma/Kconfig
+++ b/src/drivers/intel/gma/Kconfig
@@ -111,6 +111,25 @@
bool
default n
+config OPREGION_2_0_VERSION
+ hex
+ default 0x02000000
+
+config OPREGION_2_1_VERSION
+ hex
+ default 0x02010000
+
+config OPREGION_VERSION
+ hex
+ default OPREGION_2_1_VERSION if INTEL_GMA_OPREGION_2_1
+ default OPREGION_2_0_VERSION
+ help
+ Opregion Structure Version can be decoded as Bits[31:24] for
+ Major Version, Bits[23:16] for Minor version, Bits[15:8] for
+ Revision and Bits[7:0] are Reserved. For example: 0x02010000
+ can be read as Major Version as 2, Minor Version as 1 and
+ Revision as 0.
+
if GFX_GMA
config GFX_GMA_DYN_CPU
diff --git a/src/drivers/intel/gma/opregion.c b/src/drivers/intel/gma/opregion.c
index f675987..6d0ffe9 100644
--- a/src/drivers/intel/gma/opregion.c
+++ b/src/drivers/intel/gma/opregion.c
@@ -255,15 +255,6 @@
return CB_ERR;
}
-/* Function to get the IGD Opregion version */
-static struct opregion_version opregion_get_version(void)
-{
- if (CONFIG(INTEL_GMA_OPREGION_2_1))
- return (struct opregion_version) { .major = 2, .minor = 1 };
-
- return (struct opregion_version) { .major = 2, .minor = 0 };
-}
-
/*
* Function to determine if we need to use extended VBT region to pass
* VBT pointer. If VBT size > 6 KiB then we need to use extended VBT
@@ -277,8 +268,10 @@
/* Function to determine if the VBT uses a relative address */
static inline bool uses_relative_vbt_addr(opregion_header_t *header)
{
- return (header->opver.major >= 2 && header->opver.minor >= 1) ||
- (header->opver.major > 2);
+ if (header->opver.version >= CONFIG_OPREGION_2_1_VERSION)
+ return true;
+
+ return false;
}
/*
@@ -347,7 +340,7 @@
ARRAY_SIZE(vbt->coreblock_biosbuild));
/* Get the opregion version information */
- opregion->header.opver = opregion_get_version();
+ opregion->header.opver.version = CONFIG_OPREGION_VERSION;
/* Extended VBT support */
if (is_ext_vbt_required(opregion, vbt)) {
diff --git a/src/drivers/intel/gma/opregion.h b/src/drivers/intel/gma/opregion.h
index 1dd177c..4debe2c 100644
--- a/src/drivers/intel/gma/opregion.h
+++ b/src/drivers/intel/gma/opregion.h
@@ -17,12 +17,15 @@
typedef struct {
u8 signature[16]; /* Offset 0 OpRegion signature */
u32 size; /* Offset 16 OpRegion size */
- struct opregion_version {
- u8 rsvd;
- u8 revision;
- u8 minor;
- u8 major;
- } opver; /* Offset 20 OpRegion version structure */
+ union opreg_version {
+ u32 version;
+ struct opregion_version {
+ u8 rsvd;
+ u8 revision;
+ u8 minor;
+ u8 major;
+ } fields;
+ } opver; /* Offset 20 OpRegion version structure */
u8 sbios_version[32]; /* Offset 24 System BIOS build version */
u8 vbios_version[16]; /* Offset 56 Video BIOS build version */
u8 driver_version[16]; /* Offset 72 Graphic drvr build version */
--
To view, visit https://review.coreboot.org/c/coreboot/+/56303
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ba7b64473781ac67c8958241bf5149fe0c009ba
Gerrit-Change-Number: 56303
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-MessageType: newchange