coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: payloads: FILO: Hook up autoboot options
by Nico Huber (Code Review) 14 Jul '21

14 Jul '21

Attention is currently required from: Martin Roth, Paul Menzel, Stefan Reinauer. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56213 ) Change subject: payloads: FILO: Hook up autoboot options ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: Assuming this works now? -- To view, visit https://review.coreboot.org/c/coreboot/+/56213 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id167e9a144bf466da87469108002672b299b702a Gerrit-Change-Number: 56213 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Jul 2021 10:48:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: console: Handle verstage as "first non-bootblock stage"
by Nico Huber (Code Review) 14 Jul '21

14 Jul '21

Attention is currently required from: Julius Werner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56210 ) Change subject: console: Handle verstage as "first non-bootblock stage" ...................................................................... Patch Set 1: (1 comment) File src/console/init.c: https://review.coreboot.org/c/coreboot/+/56210/comment/5b9bcd8b_4cc97105 PS1, Line 15: #endif > Okay, I see. […] Sorry, I don't understand: What difference would it make to use ENV_INITIAL_STAGE instead of always querying get_uint_option()? Would we lose something if we always call it? -- To view, visit https://review.coreboot.org/c/coreboot/+/56210 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I494a33483e306a049aa0c8137a118644fc28177e Gerrit-Change-Number: 56210 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 14 Jul 2021 10:47:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: supermicro/x11-lga1151-series: Enable scanning for external graphics
by Nico Huber (Code Review) 14 Jul '21

14 Jul '21

Attention is currently required from: Jan Tatje. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56071 ) Change subject: supermicro/x11-lga1151-series: Enable scanning for external graphics ...................................................................... Patch Set 6: (1 comment) File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-f/x11ssh-f.md: https://review.coreboot.org/c/coreboot/+/56071/comment/c6c09b5a_3610ab0f PS6, Line 44: even if IGD is disabled Is this true? do we need `SkipExtGfxScan = 0` even with `device pci 02.0 off`? If not, I'd really like to keep the two settings synchronized. -- To view, visit https://review.coreboot.org/c/coreboot/+/56071 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41249112c65927b61ca5f791f8eb8c3f3d204fce Gerrit-Change-Number: 56071 Gerrit-PatchSet: 6 Gerrit-Owner: Jan Tatje <jan(a)jnt.io> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jan Tatje <jan(a)jnt.io> Gerrit-Comment-Date: Wed, 14 Jul 2021 10:45:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/qualcomm/common/qspi: Add support for common QSPI driver
by Rajesh Patil (Code Review) 14 Jul '21

14 Jul '21

Attention is currently required from: Ravi kumar, Roja Rani Yarubandi, Paul Menzel, mturney mturney, Julius Werner. Rajesh Patil has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55323 ) Change subject: soc/qualcomm/common/qspi: Add support for common QSPI driver ...................................................................... Patch Set 12: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/55323/comment/bca91b95_2aca909f PS6, Line 12: Flash > flash Done -- To view, visit https://review.coreboot.org/c/coreboot/+/55323 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b3816b823e14db1dd13f1eb4a6761c7a61604b9 Gerrit-Change-Number: 55323 Gerrit-PatchSet: 12 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Roja Rani Yarubandi <c_rojay(a)qualcomm.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rajesh Patil <rajpat(a)qualcomm.corp-partner.google.com> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Roja Rani Yarubandi <c_rojay(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 14 Jul 2021 10:04:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/qualcomm/common/qspi: Add support for common QSPI driver
by Rajesh Patil (Code Review) 14 Jul '21

14 Jul '21

Attention is currently required from: Ravi kumar, Roja Rani Yarubandi, Paul Menzel, mturney mturney, Julius Werner. Rajesh Patil has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55323 ) Change subject: soc/qualcomm/common/qspi: Add support for common QSPI driver ...................................................................... Patch Set 12: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/55323/comment/7058eed1_736989f7 PS6, Line 15: TEST=Validated on qualcomm sc7180 and sc7280 development board > How? we are checking in Boot logs.In boot logs we observed Manufacturer id of the flash device and driver probe is successful. -- To view, visit https://review.coreboot.org/c/coreboot/+/55323 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b3816b823e14db1dd13f1eb4a6761c7a61604b9 Gerrit-Change-Number: 55323 Gerrit-PatchSet: 12 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Roja Rani Yarubandi <c_rojay(a)qualcomm.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rajesh Patil <rajpat(a)qualcomm.corp-partner.google.com> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Roja Rani Yarubandi <c_rojay(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 14 Jul 2021 10:03:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/cherry: add configuration for tomato
by Hung-Te Lin (Code Review) 14 Jul '21

14 Jul '21

Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56253 ) Change subject: mb/google/cherry: add configuration for tomato ...................................................................... mb/google/cherry: add configuration for tomato Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Change-Id: I972c70773d4d928e75098efbf78f174d7c3ebf50 Reviewed-on: https://review.coreboot.org/c/coreboot/+/56253 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> --- M src/mainboard/google/cherry/Kconfig M src/mainboard/google/cherry/Kconfig.name 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved diff --git a/src/mainboard/google/cherry/Kconfig b/src/mainboard/google/cherry/Kconfig index dd0b4571..09b21d2 100644 --- a/src/mainboard/google/cherry/Kconfig +++ b/src/mainboard/google/cherry/Kconfig @@ -35,6 +35,7 @@ config MAINBOARD_PART_NUMBER string default "Cherry" if BOARD_GOOGLE_CHERRY + default "Tomato" if BOARD_GOOGLE_TOMATO config DRIVER_TPM_I2C_BUS hex diff --git a/src/mainboard/google/cherry/Kconfig.name b/src/mainboard/google/cherry/Kconfig.name index 8690b22..7a65ada 100644 --- a/src/mainboard/google/cherry/Kconfig.name +++ b/src/mainboard/google/cherry/Kconfig.name @@ -3,3 +3,7 @@ config BOARD_GOOGLE_CHERRY bool "-> Cherry" select BOARD_GOOGLE_CHERRY_COMMON + +config BOARD_GOOGLE_TOMATO + bool "-> Tomato" + select BOARD_GOOGLE_CHERRY_COMMON -- To view, visit https://review.coreboot.org/c/coreboot/+/56253 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I972c70773d4d928e75098efbf78f174d7c3ebf50 Gerrit-Change-Number: 56253 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/mediatek/mt8195: Get DRAM size from DRAM calibration result
by Hung-Te Lin (Code Review) 14 Jul '21

14 Jul '21

Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56204 ) Change subject: soc/mediatek/mt8195: Get DRAM size from DRAM calibration result ...................................................................... soc/mediatek/mt8195: Get DRAM size from DRAM calibration result Signed-off-by: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com> Change-Id: Ic34f29d1692b94284b2cf6c5d91d323df736c76f Reviewed-on: https://review.coreboot.org/c/coreboot/+/56204 Reviewed-by: Hung-Te Lin <hungte(a)chromium.org> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/soc/mediatek/mt8195/emi.c 1 file changed, 18 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved Yu-Ping Wu: Looks good to me, approved diff --git a/src/soc/mediatek/mt8195/emi.c b/src/soc/mediatek/mt8195/emi.c index 120665a..6cbcae1 100644 --- a/src/soc/mediatek/mt8195/emi.c +++ b/src/soc/mediatek/mt8195/emi.c @@ -1,8 +1,25 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <console/console.h> +#include <emi.h> #include <soc/emi.h> size_t sdram_size(void) { - return (size_t)4 * GiB; + int rank_num; + u64 rank_size[RANK_MAX]; + static size_t dram_size = 0; + + if (dram_size) + return dram_size; + + get_rank_size_by_emi(rank_size); + rank_num = get_rank_nr_by_emi(); + + for (int i = 0; i < rank_num; i++) + dram_size += rank_size[i]; + + printk(BIOS_INFO, "dram size = %#lx\n", dram_size); + + return dram_size; } -- To view, visit https://review.coreboot.org/c/coreboot/+/56204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic34f29d1692b94284b2cf6c5d91d323df736c76f Gerrit-Change-Number: 56204 Gerrit-PatchSet: 4 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: util/ifdtool: Add APL to IFDv2 platforms
by Subrata Banik (Code Review) 14 Jul '21

14 Jul '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Stefan Reinauer. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56300 ) Change subject: util/ifdtool: Add APL to IFDv2 platforms ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56300/comment/29de1e36_17823636 PS1, Line 7: aplk > nit: APL Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/56300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied59ddb2fe05b421266a6b119fd6eab17b8beedc Gerrit-Change-Number: 56300 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Rick Lee <rick.lee(a)intel.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Jul 2021 09:32:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/ifdtool: Add APL to IFDv2 platforms
by Subrata Banik (Code Review) 14 Jul '21

14 Jul '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Stefan Reinauer, Subrata Banik. Hello build bot (Jenkins), Rick Lee, Furquan Shaikh, Tim Wawrzynczak, Stefan Reinauer, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56300 to look at the new patch set (#2). Change subject: util/ifdtool: Add APL to IFDv2 platforms ...................................................................... util/ifdtool: Add APL to IFDv2 platforms Initially APL was considered as IFDv2 platform irrespective being added into ifd_2_platforms[], hence commit hash 621ed4c had migrated APL into IFDv1 which break its FLMSTR1/FLMSTR2/FLMSTR3 Read/Write access. This change adds APL into the list of IFDv2 platforms to fix booting issue on the LeafHill board. Change-Id: Ied59ddb2fe05b421266a6b119fd6eab17b8beedc Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M util/ifdtool/ifdtool.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/56300/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied59ddb2fe05b421266a6b119fd6eab17b8beedc Gerrit-Change-Number: 56300 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Rick Lee <rick.lee(a)intel.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: arch/x86: Helper functions to get deterministic cache parameters
by Subrata Banik (Code Review) 14 Jul '21

14 Jul '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Rizwan Qureshi, Angel Pons, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55965 ) Change subject: arch/x86: Helper functions to get deterministic cache parameters ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: > Why bother with caching the results of this CPUID call? […] In that case, can we drop those other helper functions? I remember Angel had asked for that? -- To view, visit https://review.coreboot.org/c/coreboot/+/55965 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0dd701fb47460092448b64c7fa2162f762bf3095 Gerrit-Change-Number: 55965 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 14 Jul 2021 09:30:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021