coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: mb/google/cherry: Allow payloads to enable USB VBUS
by Paul Menzel (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Yu-Ping Wu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56326 ) Change subject: mb/google/cherry: Allow payloads to enable USB VBUS ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56326/comment/202b96db_db50b878 PS2, Line 11: Is there some corresponding commit needed in depthcharge to make use of it? `GPIO_XHCI_DONE` is just a macro, so I do not see, how this fits together. -- To view, visit https://review.coreboot.org/c/coreboot/+/56326 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21b7b811b8138cb3f71efecb0a0a886905c65a9c Gerrit-Change-Number: 56326 Gerrit-PatchSet: 2 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 16 Jul 2021 08:12:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/cannonlake: Make use of `cpu/intel/cpu_ids.h'
by Subrata Banik (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Patrick Rudolph. Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56379 ) Change subject: soc/intel/cannonlake: Make use of `cpu/intel/cpu_ids.h' ...................................................................... soc/intel/cannonlake: Make use of `cpu/intel/cpu_ids.h' Remove inclusion of mp_init.h for getting CPUIDs and use dedicated cpu_ids.h file in SoC directory. Change-Id: I129f169e5dc394a11d8f7b07486cca4894dbec8e Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/cannonlake/bootblock/report_platform.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/56379/1 diff --git a/src/soc/intel/cannonlake/bootblock/report_platform.c b/src/soc/intel/cannonlake/bootblock/report_platform.c index 9c393e5..fed8ac2 100644 --- a/src/soc/intel/cannonlake/bootblock/report_platform.c +++ b/src/soc/intel/cannonlake/bootblock/report_platform.c @@ -3,12 +3,12 @@ #include <arch/cpu.h> #include <device/pci_ops.h> #include <console/console.h> +#include <cpu/intel/cpu_ids.h> #include <cpu/intel/microcode.h> #include <cpu/x86/msr.h> #include <cpu/x86/name.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <intelblocks/mp_init.h> #include <soc/bootblock.h> #include <soc/pch.h> #include <soc/pci_devs.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/56379 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I129f169e5dc394a11d8f7b07486cca4894dbec8e Gerrit-Change-Number: 56379 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/kconfig: Stop trying to make sense of Linux configs
by Werner Zeh (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Martin Roth. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56373 ) Change subject: util/kconfig: Stop trying to make sense of Linux configs ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: On my system 'make menuconfig' without an .config-file being available in the root dir of coreboot led to the usage of the kernel config file in /boot of my PC prior to this patch. With this patch everything is fine again. -- To view, visit https://review.coreboot.org/c/coreboot/+/56373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idbce93232ba2b54561abab5b2747c418d6efa92b Gerrit-Change-Number: 56373 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Fri, 16 Jul 2021 08:10:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/elkhartlake: Make use of `cpu/intel/cpu_ids.h'
by Subrata Banik (Code Review) 16 Jul '21

16 Jul '21

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56378 ) Change subject: soc/intel/elkhartlake: Make use of `cpu/intel/cpu_ids.h' ...................................................................... soc/intel/elkhartlake: Make use of `cpu/intel/cpu_ids.h' Remove inclusion of mp_init.h for getting CPUIDs and use dedicated cpu_ids.h file in SoC directory. Change-Id: Ieb8063116bee59f6f6bf1f6b0b2349ce22bd67bd Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/elkhartlake/bootblock/report_platform.c M src/soc/intel/elkhartlake/fsp_params.c 2 files changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/56378/1 diff --git a/src/soc/intel/elkhartlake/bootblock/report_platform.c b/src/soc/intel/elkhartlake/bootblock/report_platform.c index 7d9e9f4..8d93e4d 100644 --- a/src/soc/intel/elkhartlake/bootblock/report_platform.c +++ b/src/soc/intel/elkhartlake/bootblock/report_platform.c @@ -2,13 +2,13 @@ #include <arch/cpu.h> #include <console/console.h> +#include <cpu/intel/cpu_ids.h> #include <cpu/intel/microcode.h> #include <cpu/x86/msr.h> #include <cpu/x86/name.h> #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> -#include <intelblocks/mp_init.h> #include <soc/bootblock.h> #include <soc/pch.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/elkhartlake/fsp_params.c b/src/soc/intel/elkhartlake/fsp_params.c index 210040e..da9a783 100644 --- a/src/soc/intel/elkhartlake/fsp_params.c +++ b/src/soc/intel/elkhartlake/fsp_params.c @@ -6,7 +6,6 @@ #include <fsp/ppi/mp_service_ppi.h> #include <fsp/util.h> #include <intelblocks/lpss.h> -#include <intelblocks/mp_init.h> #include <intelblocks/pmclib.h> #include <intelblocks/xdci.h> #include <intelpch/lockdown.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/56378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb8063116bee59f6f6bf1f6b0b2349ce22bd67bd Gerrit-Change-Number: 56378 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: lib/thread: Move thread_run and thread_run_until outside of #if guard
by Furquan Shaikh (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Raul Rangel. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56352 ) Change subject: lib/thread: Move thread_run and thread_run_until outside of #if guard ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/include/thread.h: https://review.coreboot.org/c/coreboot/+/56352/comment/398b7fe3_042db65a PS2, Line 26: arrg arg -- To view, visit https://review.coreboot.org/c/coreboot/+/56352 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If9983fca939c8a15fa570481bfe016a388458830 Gerrit-Change-Number: 56352 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Comment-Date: Fri, 16 Jul 2021 08:05:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/jasperlake: Make use of `cpu/intel/cpu_ids.h'
by Subrata Banik (Code Review) 16 Jul '21

16 Jul '21

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56377 ) Change subject: soc/intel/jasperlake: Make use of `cpu/intel/cpu_ids.h' ...................................................................... soc/intel/jasperlake: Make use of `cpu/intel/cpu_ids.h' Remove inclusion of mp_init.h for getting CPUIDs and use dedicated cpu_ids.h file in SoC directory. Change-Id: Iefc19bc81125f422b8d4fc2f4af60622e7d28c0f Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/jasperlake/bootblock/report_platform.c M src/soc/intel/jasperlake/fsp_params.c 2 files changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/56377/1 diff --git a/src/soc/intel/jasperlake/bootblock/report_platform.c b/src/soc/intel/jasperlake/bootblock/report_platform.c index a588b75..241e172 100644 --- a/src/soc/intel/jasperlake/bootblock/report_platform.c +++ b/src/soc/intel/jasperlake/bootblock/report_platform.c @@ -3,12 +3,12 @@ #include <arch/cpu.h> #include <device/pci_ops.h> #include <console/console.h> +#include <cpu/intel/cpu_ids.h> #include <cpu/intel/microcode.h> #include <cpu/x86/msr.h> #include <cpu/x86/name.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <intelblocks/mp_init.h> #include <soc/bootblock.h> #include <soc/pch.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/jasperlake/fsp_params.c b/src/soc/intel/jasperlake/fsp_params.c index 45bed5e..0ad65e4 100644 --- a/src/soc/intel/jasperlake/fsp_params.c +++ b/src/soc/intel/jasperlake/fsp_params.c @@ -6,7 +6,6 @@ #include <fsp/ppi/mp_service_ppi.h> #include <fsp/util.h> #include <intelblocks/lpss.h> -#include <intelblocks/mp_init.h> #include <intelblocks/pmclib.h> #include <intelblocks/xdci.h> #include <intelpch/lockdown.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/56377 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iefc19bc81125f422b8d4fc2f4af60622e7d28c0f Gerrit-Change-Number: 56377 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: lib/thread: Add thread_handle
by Furquan Shaikh (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Raul Rangel, Eric Peers, Felix Held. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56229 ) Change subject: lib/thread: Add thread_handle ...................................................................... Patch Set 7: (1 comment) File src/lib/thread.c: https://review.coreboot.org/c/coreboot/+/56229/comment/b4a65800_d0a2362d PS7, Line 230: idle_thread You will have to update the signature of `idle_thread` as well. -- To view, visit https://review.coreboot.org/c/coreboot/+/56229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie6f64d0c5a5acad4431a605f0b0b5100dc5358ff Gerrit-Change-Number: 56229 Gerrit-PatchSet: 7 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Peers <epeers(a)google.com> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 16 Jul 2021 08:05:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/apollolake: Make use of `cpu/intel/cpu_ids.h'
by Subrata Banik (Code Review) 16 Jul '21

16 Jul '21

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56376 ) Change subject: soc/intel/apollolake: Make use of `cpu/intel/cpu_ids.h' ...................................................................... soc/intel/apollolake: Make use of `cpu/intel/cpu_ids.h' Remove inclusion of mp_init.h for getting CPUIDs and use dedicated cpu_ids.h file in SoC directory. Change-Id: I00ebb9a124eb3b8b893c2b176e14773c05851c18 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/apollolake/report_platform.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/56376/1 diff --git a/src/soc/intel/apollolake/report_platform.c b/src/soc/intel/apollolake/report_platform.c index e79e28a..25587eb 100644 --- a/src/soc/intel/apollolake/report_platform.c +++ b/src/soc/intel/apollolake/report_platform.c @@ -3,12 +3,12 @@ #include <arch/cpu.h> #include <device/pci_ops.h> #include <console/console.h> +#include <cpu/intel/cpu_ids.h> #include <cpu/intel/microcode.h> #include <cpu/x86/msr.h> #include <cpu/x86/name.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <intelblocks/mp_init.h> #include <soc/romstage.h> #include <soc/pci_devs.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/56376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00ebb9a124eb3b8b893c2b176e14773c05851c18 Gerrit-Change-Number: 56376 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: lib/thread: Make thread_run not block the current state
by Furquan Shaikh (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Raul Rangel. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56351 ) Change subject: lib/thread: Make thread_run not block the current state ...................................................................... Patch Set 2: (1 comment) File src/lib/thread.c: https://review.coreboot.org/c/coreboot/+/56351/comment/17bf60bd_ff9a1710 PS2, Line 170: boot_state_current_block Should we drop boot_state_current_{block|unblock}() as well now? -- To view, visit https://review.coreboot.org/c/coreboot/+/56351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e5b0aed70385ddcd23ffcf7b063f8ccb547fc05 Gerrit-Change-Number: 56351 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Comment-Date: Fri, 16 Jul 2021 07:57:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/icelake: Make use of `cpu/intel/cpu_ids.h'
by Subrata Banik (Code Review) 16 Jul '21

16 Jul '21

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56375 ) Change subject: soc/intel/icelake: Make use of `cpu/intel/cpu_ids.h' ...................................................................... soc/intel/icelake: Make use of `cpu/intel/cpu_ids.h' Remove inclusion of mp_init.h for getting CPUIDs and use dedicated cpu_ids.h file in SoC directory. Change-Id: I97f4d9715f3205678acca8fcdfb1a62714dfaa53 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/icelake/bootblock/report_platform.c M src/soc/intel/icelake/fsp_params.c 2 files changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/56375/1 diff --git a/src/soc/intel/icelake/bootblock/report_platform.c b/src/soc/intel/icelake/bootblock/report_platform.c index 898b0e3..8c6a6ef 100644 --- a/src/soc/intel/icelake/bootblock/report_platform.c +++ b/src/soc/intel/icelake/bootblock/report_platform.c @@ -3,11 +3,11 @@ #include <arch/cpu.h> #include <device/pci_ops.h> #include <console/console.h> +#include <cpu/intel/cpu_ids.h> #include <cpu/intel/microcode.h> #include <cpu/x86/msr.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <intelblocks/mp_init.h> #include <soc/bootblock.h> #include <soc/pch.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/icelake/fsp_params.c b/src/soc/intel/icelake/fsp_params.c index 2d63097..aee2ef8 100644 --- a/src/soc/intel/icelake/fsp_params.c +++ b/src/soc/intel/icelake/fsp_params.c @@ -12,7 +12,6 @@ #include <soc/ramstage.h> #include <soc/soc_chip.h> #include <string.h> -#include <intelblocks/mp_init.h> #include <fsp/ppi/mp_service_ppi.h> static void parse_devicetree(FSP_S_CONFIG *params) -- To view, visit https://review.coreboot.org/c/coreboot/+/56375 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97f4d9715f3205678acca8fcdfb1a62714dfaa53 Gerrit-Change-Number: 56375 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021