coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: soc/intel/common/block: Drop unused `intelblocks/mp_init.h` include
by EricR Lai (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56381 ) Change subject: soc/intel/common/block: Drop unused `intelblocks/mp_init.h` include ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8621a38214686b359ee0e7cdf7e92154af3cbc81 Gerrit-Change-Number: 56381 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 16 Jul 2021 10:28:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/pirika: Add USB2 PHY parameters
by Alex1 Kao (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Alex1 Kao, Kirk Wang. Hello build bot (Jenkins), Kirk Wang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56327 to look at the new patch set (#3). Change subject: mb/google/dedede/var/pirika: Add USB2 PHY parameters ...................................................................... mb/google/dedede/var/pirika: Add USB2 PHY parameters This change adds fine-tuned USB2 PHY parameters for pirika. BUG=192601233 TEST=Built and verified USB2 eye diagram test result Signed-off-by: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Change-Id: Icf9fb41cd0ae40728e4ec5bd72a15ec3c45c963b --- M src/mainboard/google/dedede/variants/pirika/overridetree.cb 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/56327/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/56327 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf9fb41cd0ae40728e4ec5bd72a15ec3c45c963b Gerrit-Change-Number: 56327 Gerrit-PatchSet: 3 Gerrit-Owner: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Kirk Wang <kirk_wang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Attention: Kirk Wang <kirk_wang(a)pegatron.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: UPSTREAM: mb/google/dedede/var/pirika: Add USB2 PHY parameters
by Alex1 Kao (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Alex1 Kao, Kirk Wang. Hello build bot (Jenkins), Kirk Wang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56327 to look at the new patch set (#2). Change subject: UPSTREAM: mb/google/dedede/var/pirika: Add USB2 PHY parameters ...................................................................... UPSTREAM: mb/google/dedede/var/pirika: Add USB2 PHY parameters This change adds fine-tuned USB2 PHY parameters for pirika. BUG=192601233 TEST=Built and verified USB2 eye diagram test result Signed-off-by: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Change-Id: Icf9fb41cd0ae40728e4ec5bd72a15ec3c45c963b --- M src/mainboard/google/dedede/variants/pirika/overridetree.cb 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/56327/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56327 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf9fb41cd0ae40728e4ec5bd72a15ec3c45c963b Gerrit-Change-Number: 56327 Gerrit-PatchSet: 2 Gerrit-Owner: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Kirk Wang <kirk_wang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Attention: Kirk Wang <kirk_wang(a)pegatron.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common/block: Drop unused `intelblocks/mp_init.h` include
by Angel Pons (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph, EricR Lai. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56381 ) Change subject: soc/intel/common/block: Drop unused `intelblocks/mp_init.h` include ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8621a38214686b359ee0e7cdf7e92154af3cbc81 Gerrit-Change-Number: 56381 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Fri, 16 Jul 2021 10:19:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/block: Drop unused `intelblocks/mp_init.h` include
by Subrata Banik (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56381 ) Change subject: soc/intel/common/block: Drop unused `intelblocks/mp_init.h` include ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56381/comment/18b49cbc_c04cabe4 PS1, Line 7: Make use of `cpu/intel/cpu_ids.h' > Drop unused `intelblocks/mp_init. […] Ack https://review.coreboot.org/c/coreboot/+/56381/comment/02bb27b7_9cde668d PS1, Line 9: Remove inclusion of mp_init.h for getting CPUIDs and use dedicated : cpu_ids.h file in SoC directory. > With the updated commit message, this should be removed. Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/56381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8621a38214686b359ee0e7cdf7e92154af3cbc81 Gerrit-Change-Number: 56381 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Fri, 16 Jul 2021 09:45:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/block: Drop unused `intelblocks/mp_init.h` include
by Subrata Banik (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph, EricR Lai. Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, EricR Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56381 to look at the new patch set (#2). Change subject: soc/intel/common/block: Drop unused `intelblocks/mp_init.h` include ...................................................................... soc/intel/common/block: Drop unused `intelblocks/mp_init.h` include Change-Id: I8621a38214686b359ee0e7cdf7e92154af3cbc81 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/common/block/sgx/sgx.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/56381/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8621a38214686b359ee0e7cdf7e92154af3cbc81 Gerrit-Change-Number: 56381 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/octopus/var/phaser: Change IRQ trigger method to level
by Joey Peng (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Paul Menzel. Hello build bot (Jenkins), Henry Sun, Marco Chen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56380 to look at the new patch set (#4). Change subject: mb/google/octopus/var/phaser: Change IRQ trigger method to level ...................................................................... mb/google/octopus/var/phaser: Change IRQ trigger method to level The change from Synaptics S7817 to Elan 3915N and pin distribution of touch IC is the same. According to vendor spec definition IRQ trigger method needs to change to level. BUG=b:190574692 TEST=Build coreboot and check that device works Signed-off-by: joey.peng <joey.peng(a)lcfc.corp-partner.google.com> Change-Id: I44ee779242779c78ceafdddd34dca2571e714dd3 --- M src/mainboard/google/octopus/variants/phaser/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/56380/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/56380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44ee779242779c78ceafdddd34dca2571e714dd3 Gerrit-Change-Number: 56380 Gerrit-PatchSet: 4 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alec Wang <alec.wang(a)lcfc.corp-partner.google.com> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/kconfig: Stop trying to make sense of Linux configs
by Lean Sheng Tan (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Martin Roth. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56373 ) Change subject: util/kconfig: Stop trying to make sense of Linux configs ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Yes the same issue with Werner: On my system 'make menuconfig' without an .config-file being available in the root dir of coreboot led to the usage of the kernel config file in /boot of my PC prior to this patch. With this patch everything is fine again. -- To view, visit https://review.coreboot.org/c/coreboot/+/56373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idbce93232ba2b54561abab5b2747c418d6efa92b Gerrit-Change-Number: 56373 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <lean.sheng.tan(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Fri, 16 Jul 2021 09:35:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/octopus/var/phaser: Change IRQ trigger method to level
by Joey Peng (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Paul Menzel. Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56380 ) Change subject: mb/google/octopus/var/phaser: Change IRQ trigger method to level ...................................................................... Patch Set 3: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56380/comment/708ac550_95023e20 PS1, Line 7: src/mainboard/google/octopus/variants/phaser > Please look at `git log --oneline` how prefixes are composed. Done https://review.coreboot.org/c/coreboot/+/56380/comment/23523528_32c8f82a PS1, Line 7: src/mainboard/google/octopus/variants/phaser:Change > Please add a space after the colon. Done https://review.coreboot.org/c/coreboot/+/56380/comment/606d9024_fbef285c PS1, Line 9: The change from Synaptics S7817 to Elan 3915N > What do you mean? The ELAN touchpad is already configured in the devicetree, isn’t it? Yes,originally,this is defined by former engineers who worked on this project before, but we actually never used it. https://review.coreboot.org/c/coreboot/+/56380/comment/82ce2883_f6250aab PS1, Line 9: The change from Synaptics S7817 to Elan 3915N and pin distribution of touch IC is the same. : : According to vendor spec definition IRQ trigger method needs to change to level. > Please wrap lines after 75 characters. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44ee779242779c78ceafdddd34dca2571e714dd3 Gerrit-Change-Number: 56380 Gerrit-PatchSet: 3 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alec Wang <alec.wang(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 16 Jul 2021 09:35:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/octopus/var/phaser: Change IRQ trigger method to level
by Joey Peng (Code Review) 16 Jul '21

16 Jul '21

Hello build bot (Jenkins), Henry Sun, Marco Chen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56380 to look at the new patch set (#3). Change subject: mb/google/octopus/var/phaser: Change IRQ trigger method to level ...................................................................... mb/google/octopus/var/phaser: Change IRQ trigger method to level The change from Synaptics S7817 to Elan 3915N and pin distribution of touch IC is the same. According to vendor spec definition IRQ trigger method needs to change to level. BUG=b:190574692 TEST=FW_NAME=Build coreboot and check that device works Signed-off-by: joey.peng <joey.peng(a)lcfc.corp-partner.google.com> Change-Id: I44ee779242779c78ceafdddd34dca2571e714dd3 --- M src/mainboard/google/octopus/variants/phaser/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/56380/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/56380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44ee779242779c78ceafdddd34dca2571e714dd3 Gerrit-Change-Number: 56380 Gerrit-PatchSet: 3 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alec Wang <alec.wang(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021