coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: soc/intel/alderlake: Fix booting issue with MultiPhaseSiInit API skip
by V Sowmya (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Ronak Kanabar, Patrick Rudolph, EricR Lai. V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56382 ) Change subject: soc/intel/alderlake: Fix booting issue with MultiPhaseSiInit API skip ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I019fa8364605f5061d56e2d80b20e1a91857c423 Gerrit-Change-Number: 56382 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Fri, 16 Jul 2021 11:34:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/pirika: Configure I2C times for touchpad
by Kirk Wang (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Alex1 Kao, Shou-Chieh Hsu. Kirk Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56383 ) Change subject: mb/google/dedede/var/pirika: Configure I2C times for touchpad ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/56383 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia57c90ead44ceb0990878dc0566e595bae5a9099 Gerrit-Change-Number: 56383 Gerrit-PatchSet: 2 Gerrit-Owner: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Kirk Wang <kirk_wang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Fri, 16 Jul 2021 11:23:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/pirika: Configure I2C times for touchpad
by Alex1 Kao (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Kirk Wang. Alex1 Kao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56383 ) Change subject: mb/google/dedede/var/pirika: Configure I2C times for touchpad ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/56383 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia57c90ead44ceb0990878dc0566e595bae5a9099 Gerrit-Change-Number: 56383 Gerrit-PatchSet: 2 Gerrit-Owner: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Kirk Wang <kirk_wang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kirk Wang <kirk_wang(a)pegatron.corp-partner.google.com> Gerrit-Comment-Date: Fri, 16 Jul 2021 11:22:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/pirika: Configure I2C times for touchpad
by Alex1 Kao (Code Review) 16 Jul '21

16 Jul '21

Alex1 Kao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56383 ) Change subject: mb/google/dedede/var/pirika: Configure I2C times for touchpad ...................................................................... mb/google/dedede/var/pirika: Configure I2C times for touchpad Configure I2C high / low time in the device tree to ensure I2C CLK runs accurately between 380 kHz and 400 kHz. BUG=b:193864546 BRANCH=dedede TEST=Build and check after tuning I2C clock is between 380 kHz and 400 kHz Signed-off-by: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Change-Id: Ia57c90ead44ceb0990878dc0566e595bae5a9099 --- M src/mainboard/google/dedede/variants/pirika/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/56383/1 diff --git a/src/mainboard/google/dedede/variants/pirika/overridetree.cb b/src/mainboard/google/dedede/variants/pirika/overridetree.cb index 80d2dbe..d7d23db 100644 --- a/src/mainboard/google/dedede/variants/pirika/overridetree.cb +++ b/src/mainboard/google/dedede/variants/pirika/overridetree.cb @@ -21,6 +21,12 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 190, + .scl_hcnt = 100, + .sda_hold = 40, + } }, .i2c[1] = { .speed = I2C_SPEED_FAST, -- To view, visit https://review.coreboot.org/c/coreboot/+/56383 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia57c90ead44ceb0990878dc0566e595bae5a9099 Gerrit-Change-Number: 56383 Gerrit-PatchSet: 1 Gerrit-Owner: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/alderlake: Fix booting issue with MultiPhaseSiInit API skip
by Angel Pons (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: V Sowmya, Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Ronak Kanabar, Patrick Rudolph, EricR Lai. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56382 ) Change subject: soc/intel/alderlake: Fix booting issue with MultiPhaseSiInit API skip ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/56382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I019fa8364605f5061d56e2d80b20e1a91857c423 Gerrit-Change-Number: 56382 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Fri, 16 Jul 2021 11:12:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/pirika: Add USB2 PHY parameters
by Kirk Wang (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Paul Menzel, Alex1 Kao. Kirk Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56327 ) Change subject: mb/google/dedede/var/pirika: Add USB2 PHY parameters ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/56327 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf9fb41cd0ae40728e4ec5bd72a15ec3c45c963b Gerrit-Change-Number: 56327 Gerrit-PatchSet: 5 Gerrit-Owner: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Kirk Wang <kirk_wang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Comment-Date: Fri, 16 Jul 2021 10:56:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Fix booting issue with MultiPhaseSiInit API skip
by build bot (Jenkins) (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56382 ) Change subject: soc/intel/alderlake: Fix booting issue with MultiPhaseSiInit API skip ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/alderlake/fsp_params.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124398): https://review.coreboot.org/c/coreboot/+/56382/comment/c80b214d_bd14330a PS1, Line 646: * soc_fsp_multi_phase_init_is_enable() inside SoC dirctory might wish to skip 'dirctory' may be misspelled - perhaps 'directory'? -- To view, visit https://review.coreboot.org/c/coreboot/+/56382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I019fa8364605f5061d56e2d80b20e1a91857c423 Gerrit-Change-Number: 56382 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 16 Jul 2021 10:53:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Fix booting issue with MultiPhaseSiInit API skip
by Subrata Banik (Code Review) 16 Jul '21

16 Jul '21

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56382 ) Change subject: soc/intel/alderlake: Fix booting issue with MultiPhaseSiInit API skip ...................................................................... soc/intel/alderlake: Fix booting issue with MultiPhaseSiInit API skip This patch honors soc_fsp_multi_phase_init_is_enable() function while assigning EnableMultiPhaseSiliconInit UPD. FSP would results into a hang while calling FSP-Notify Phase if EnableMultiPhaseSiliconInit UPD remains enable but bootloader don't make call into MultiPhaseSiInit as soc_fsp_multi_phase_init_is_enable() returns 0. Ensures EnableMultiPhaseSiliconInit UPD is getting updated based on return value from soc_fsp_multi_phase_init_is_enable(). Change-Id: I019fa8364605f5061d56e2d80b20e1a91857c423 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/alderlake/fsp_params.c 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/56382/1 diff --git a/src/soc/intel/alderlake/fsp_params.c b/src/soc/intel/alderlake/fsp_params.c index 9dec31c..3970eb4 100644 --- a/src/soc/intel/alderlake/fsp_params.c +++ b/src/soc/intel/alderlake/fsp_params.c @@ -636,8 +636,18 @@ static void arch_silicon_init_params(FSPS_ARCH_UPD *s_arch_cfg) { - /* EnableMultiPhaseSiliconInit for running MultiPhaseSiInit */ - s_arch_cfg->EnableMultiPhaseSiliconInit = 1; + /* + * EnableMultiPhaseSiliconInit ARCH UPD for running MultiPhaseSiInit + * if SoC user allows it. + * + * soc_fsp_multi_phase_init_is_enable() function will return if MultiPhaseInit + * call is required for the SoC and only enable EnableMultiPhaseSiliconInit UPD + * if soc_fsp_multi_phase_init_is_enable() returns 1. An override of + * soc_fsp_multi_phase_init_is_enable() inside SoC dirctory might wish to skip + * MultiPhaseInit call, in such case don't default enable this + * EnableMultiPhaseSiliconInit UPD. + */ + s_arch_cfg->EnableMultiPhaseSiliconInit = soc_fsp_multi_phase_init_is_enable(); } static void soc_silicon_init_params(FSP_S_CONFIG *s_cfg, -- To view, visit https://review.coreboot.org/c/coreboot/+/56382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I019fa8364605f5061d56e2d80b20e1a91857c423 Gerrit-Change-Number: 56382 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/dedede/var/pirika: Add USB2 PHY parameters
by Alex1 Kao (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Paul Menzel, Kirk Wang. Alex1 Kao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56327 ) Change subject: mb/google/dedede/var/pirika: Add USB2 PHY parameters ...................................................................... Patch Set 5: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56327/comment/d17392d3_bfb429ee PS1, Line 7: UPSTREAM: > This is a Chromium repository tag to my knowledge. Please remove. Done https://review.coreboot.org/c/coreboot/+/56327/comment/76403e7b_0e9a93ef PS1, Line 9: This change adds fine-tuned USB2 PHY parameters for pirika. > Please add, where you got these from. Removed "UPSTREAM". I copied another project's git log but forgot to remove it. -- To view, visit https://review.coreboot.org/c/coreboot/+/56327 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf9fb41cd0ae40728e4ec5bd72a15ec3c45c963b Gerrit-Change-Number: 56327 Gerrit-PatchSet: 5 Gerrit-Owner: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Kirk Wang <kirk_wang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kirk Wang <kirk_wang(a)pegatron.corp-partner.google.com> Gerrit-Comment-Date: Fri, 16 Jul 2021 10:39:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/pirika: Add USB2 PHY parameters
by Alex1 Kao (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Alex1 Kao, Kirk Wang. Hello build bot (Jenkins), Kirk Wang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56327 to look at the new patch set (#5). Change subject: mb/google/dedede/var/pirika: Add USB2 PHY parameters ...................................................................... mb/google/dedede/var/pirika: Add USB2 PHY parameters This change adds fine-tuned USB2 PHY parameters for pirika. BUG=b:192601233, b:193846600 TEST=Built and verified USB2 eye diagram test result Signed-off-by: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Change-Id: Icf9fb41cd0ae40728e4ec5bd72a15ec3c45c963b --- M src/mainboard/google/dedede/variants/pirika/overridetree.cb 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/56327/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/56327 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf9fb41cd0ae40728e4ec5bd72a15ec3c45c963b Gerrit-Change-Number: 56327 Gerrit-PatchSet: 5 Gerrit-Owner: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Kirk Wang <kirk_wang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Attention: Kirk Wang <kirk_wang(a)pegatron.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021