coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: mb/google/brya: add BASEBOARD_DIR to support different baseboard
by Furquan Shaikh (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Zhuohao Lee. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56308 ) Change subject: mb/google/brya: add BASEBOARD_DIR to support different baseboard ...................................................................... Patch Set 1: (3 comments) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/56308/comment/da4e51ac_a57c791f PS1, Line 1: BOARD_GOOGLE_BASEBOARD_BRYA > Yes, i'm going to push another patch for the Brask. I'll refer to the CL you provide. […] Ack https://review.coreboot.org/c/coreboot/+/56308/comment/6e8c2582_006f5987 PS1, Line 46: CHROMEOS_DRAM_PART_NUMBER_IN_CBI > Yes, i'll submit another CL to change the memory setting. Ack https://review.coreboot.org/c/coreboot/+/56308/comment/c5435880_5fdcba43 PS1, Line 77: BOARD_GOOGLE_BRYA0 > yes, i'll change this too. Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/56308 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic99e42dbbd27fa3e1f6cb3a1b5daee1c8c7b1083 Gerrit-Change-Number: 56308 Gerrit-PatchSet: 1 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Comment-Date: Fri, 16 Jul 2021 07:46:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Zhuohao Lee <zhuohao(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: add BASEBOARD_DIR to support different baseboard
by Zhuohao Lee (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Furquan Shaikh, Zhuohao Lee. Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56308 ) Change subject: mb/google/brya: add BASEBOARD_DIR to support different baseboard ...................................................................... Patch Set 1: (4 comments) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/56308/comment/e5eb6155_20fac3c8 PS1, Line 1: BOARD_GOOGLE_BASEBOARD_BRYA > This will have to be updated to allow for different Kconfigs for different baseboards. […] Yes, i'm going to push another patch for the Brask. I'll refer to the CL you provide. Thanks! https://review.coreboot.org/c/coreboot/+/56308/comment/370a03c3_4f7554ab PS1, Line 37: config BASEBOARD_BRYA_LAPTOP : def_bool n : select SYSTEM_TYPE_LAPTOP > There is some clean up required for this as well. […] ok, i'll submit a patch for this. https://review.coreboot.org/c/coreboot/+/56308/comment/a0bf4344_b09b508e PS1, Line 46: CHROMEOS_DRAM_PART_NUMBER_IN_CBI > I think this is specific to brya baseboard. […] Yes, i'll submit another CL to change the memory setting. https://review.coreboot.org/c/coreboot/+/56308/comment/59c2ac1f_7a21972c PS1, Line 77: BOARD_GOOGLE_BRYA0 > This will have to be changed to BOARD_GOOGLE_BASEBOARD_BRYA. Also the string should be Google_Brya. yes, i'll change this too. -- To view, visit https://review.coreboot.org/c/coreboot/+/56308 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic99e42dbbd27fa3e1f6cb3a1b5daee1c8c7b1083 Gerrit-Change-Number: 56308 Gerrit-PatchSet: 1 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Comment-Date: Fri, 16 Jul 2021 07:40:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/kconfig: Mess less with Linux's kconfig Makefile
by Patrick Georgi (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Martin Roth. Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56374 ) Change subject: util/kconfig: Mess less with Linux's kconfig Makefile ...................................................................... util/kconfig: Mess less with Linux's kconfig Makefile We can just save and recover the CONFIG_ setting, one less dependency on what precisely goes on in the upstream Makefile. Change-Id: I3c5ebf8c925bd1e2df570a84ddbb9275024c7dae Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/kconfig/Makefile.inc 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/56374/1 diff --git a/util/kconfig/Makefile.inc b/util/kconfig/Makefile.inc index bedb41d..e6f66d7 100644 --- a/util/kconfig/Makefile.inc +++ b/util/kconfig/Makefile.inc @@ -17,14 +17,15 @@ -e "s,^savedefconfig:,__disable__&," \ -e "s,\$$(srctree)/arch/\$$(SRCARCH)/configs/\$$(KBUILD_DEFCONFIG),\$$(KBUILD_DEFCONFIG)," \ -e "s,--defconfig=arch/\$$(SRCARCH)/configs/\$$(KBUILD_DEFCONFIG),--defconfig=\$$(KBUILD_DEFCONFIG)," \ - -e "/^unexport CONFIG_$$/d" \ $< > $@.tmp mv $@.tmp $@ kecho := echo +OUR_CONFIG_ := CONFIG_ -include $(objk)/Makefile.real unexport KCONFIG_DEFCONFIG_LIST +export CONFIG_ := $(OUR_CONFIG_) # Fill in Linux kconfig build rules to work -- To view, visit https://review.coreboot.org/c/coreboot/+/56374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c5ebf8c925bd1e2df570a84ddbb9275024c7dae Gerrit-Change-Number: 56374 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/kconfig: Stop trying to make sense of Linux configs
by Patrick Georgi (Code Review) 16 Jul '21

16 Jul '21

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56373 ) Change subject: util/kconfig: Stop trying to make sense of Linux configs ...................................................................... util/kconfig: Stop trying to make sense of Linux configs It only leads to missing symbol errors. Change-Id: Idbce93232ba2b54561abab5b2747c418d6efa92b Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/kconfig/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/56373/1 diff --git a/util/kconfig/Makefile.inc b/util/kconfig/Makefile.inc index db8b1be..bedb41d 100644 --- a/util/kconfig/Makefile.inc +++ b/util/kconfig/Makefile.inc @@ -24,6 +24,7 @@ kecho := echo -include $(objk)/Makefile.real +unexport KCONFIG_DEFCONFIG_LIST # Fill in Linux kconfig build rules to work -- To view, visit https://review.coreboot.org/c/coreboot/+/56373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idbce93232ba2b54561abab5b2747c418d6efa92b Gerrit-Change-Number: 56373 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/amd/common/block/lpc/spi_dma: Yield after completing transaction
by Furquan Shaikh (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Julius Werner, Felix Held. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56321 ) Change subject: soc/amd/common/block/lpc/spi_dma: Yield after completing transaction ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56321 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c1272bde46c3e0c15305b76c2ea7a6dde5ed0b0 Gerrit-Change-Number: 56321 Gerrit-PatchSet: 3 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 16 Jul 2021 07:27:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common/block/lpc/spi_dma: Use mutex to protect DMA registers
by Furquan Shaikh (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Eric Peers, Felix Held. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56231 ) Change subject: soc/amd/common/block/lpc/spi_dma: Use mutex to protect DMA registers ...................................................................... Patch Set 7: (1 comment) File src/soc/amd/common/block/lpc/spi_dma.c: https://review.coreboot.org/c/coreboot/+/56231/comment/5dd9c942_28cda3c0 PS7, Line 168: struct static -- To view, visit https://review.coreboot.org/c/coreboot/+/56231 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibb8e31c95d6722521425772f4210af45626c8e09 Gerrit-Change-Number: 56231 Gerrit-PatchSet: 7 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Peers <epeers(a)google.com> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 16 Jul 2021 07:26:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib/thread: Add mutex
by Furquan Shaikh (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Raul Rangel, Eric Peers, Felix Held. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56230 ) Change subject: lib/thread: Add mutex ...................................................................... Patch Set 7: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56230/comment/bdc743e9_532947dc PS7, Line 14: : If a task (A) wishes to yield control to the next task (B) that is : holding onto the mutex, without encountering a delay of its own : (i.e., udelay(0)), then we need to ensure the next task (B) is at the : head of the queue. We do this by using a `0 us` delay in mutex_lock. If : we were to use anything larger than a `0 us` delay, a `udelay(0)` by the : task (A) that just unlocked the mutex will most likely not schedule the : next task (B) that was holding onto the mutex. Maybe its just me. But I find this example really confusing. The logic in the code makes sense, but this explanation confused me :P. -- To view, visit https://review.coreboot.org/c/coreboot/+/56230 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ife1ac95ec064ebcdd00fcaacec37a06ac52885ff Gerrit-Change-Number: 56230 Gerrit-PatchSet: 7 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Peers <epeers(a)google.com> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 16 Jul 2021 07:25:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/skylake: Make use of `cpu/intel/cpu_ids.h'
by Furquan Shaikh (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Subrata Banik, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56371 ) Change subject: soc/intel/skylake: Make use of `cpu/intel/cpu_ids.h' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2123a081baaf6fd254fe81d64eaeee1e3248dd34 Gerrit-Change-Number: 56371 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 16 Jul 2021 06:59:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/ehlcrb: Update FIVR configs
by Werner Zeh (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Maulik V Vaghela, Mario Scheithauer, Subrata Banik, Lean Sheng Tan. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55981 ) Change subject: mb/intel/ehlcrb: Update FIVR configs ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/55981/comment/ea7a66d2_3d820a2d PS3, Line 10: extra whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/55981 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e30ff6d84bfe078fcce0f968fce6aaab7fd575b Gerrit-Change-Number: 55981 Gerrit-PatchSet: 3 Gerrit-Owner: Lean Sheng Tan <lean.sheng.tan(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Lean Sheng Tan <lean.sheng.tan(a)intel.com> Gerrit-Comment-Date: Fri, 16 Jul 2021 06:59:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/tigerlake: Make use of `cpu/intel/cpu_ids.h'
by Furquan Shaikh (Code Review) 16 Jul '21

16 Jul '21

Attention is currently required from: Wonkyu Kim, Tim Wawrzynczak, Subrata Banik, Angel Pons, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56369 ) Change subject: soc/intel/tigerlake: Make use of `cpu/intel/cpu_ids.h' ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56369 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I773114a703d62bf469aa74b128c697cc0924cc3d Gerrit-Change-Number: 56369 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wonkyu Kim Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Wonkyu Kim Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 16 Jul 2021 06:58:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021