Attention is currently required from: Varshit B Pandya, Maulik V Vaghela, Tim Wawrzynczak.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56655 )
Change subject: mb/google/brya: Configure H21 as GPO
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
How about set the power pins default low A17 F20 C3 H21.. etc? Also do this for WFC pins..
--
To view, visit https://review.coreboot.org/c/coreboot/+/56655
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I745169a5ab6a9c20b6e1bda792a43193d04ac48d
Gerrit-Change-Number: 56655
Gerrit-PatchSet: 1
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Wed, 28 Jul 2021 12:06:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Sunwei Li has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/56657 )
Change subject: mb/google/dedede/var/cappy2: Add LTE module support
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/56657
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9fb7e30a3dbfa8c3255168f2b0ad4d564b729f69
Gerrit-Change-Number: 56657
Gerrit-PatchSet: 1
Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: abandon
Sunwei Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56657 )
Change subject: mb/google/dedede/var/cappy2: Add LTE module support
......................................................................
mb/google/dedede/var/cappy2: Add LTE module support
Add LTE module support into devicetree
BUG=None
BRANCH=dedede
TEST=LTE function is OK
Signed-off-by: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Change-Id: I9fb7e30a3dbfa8c3255168f2b0ad4d564b729f69
---
M src/mainboard/google/dedede/variants/cappy2/overridetree.cb
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/56657/1
diff --git a/src/mainboard/google/dedede/variants/cappy2/overridetree.cb b/src/mainboard/google/dedede/variants/cappy2/overridetree.cb
index 5786b05..0bdbefd 100644
--- a/src/mainboard/google/dedede/variants/cappy2/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/cappy2/overridetree.cb
@@ -74,6 +74,16 @@
register "enable_delay_ms" = "20"
device usb 2.5 on end
end
+ chip drivers/usb/acpi
+ register "desc" = ""LTE""
+ register "type" = "UPC_TYPE_INTERNAL"
+ register "has_power_resource" = "1"
+ register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H17)"
+ register "reset_off_delay_ms" = "20"
+ register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A10)"
+ register "enable_delay_ms" = "20"
+ device usb 3.3 on end
+ end
end
end
end # USB xHCI
--
To view, visit https://review.coreboot.org/c/coreboot/+/56657
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9fb7e30a3dbfa8c3255168f2b0ad4d564b729f69
Gerrit-Change-Number: 56657
Gerrit-PatchSet: 1
Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Tim Wawrzynczak, Wisley Chen.
Hello Tim Wawrzynczak, Wisley Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56656
to look at the new patch set (#3).
Change subject: mb/google/brya/variants/redrix: Init devicetree for redrix
......................................................................
mb/google/brya/variants/redrix: Init devicetree for redrix
Init basic override devicetree
BUG=b:192052098
TEST=FW_NAME=redrix emerge-brya coreboot chromeos-bootimage
Change-Id: I9fb752fe8280893b84c172d8a519578fa4220184
Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brya/Kconfig.name
M src/mainboard/google/brya/variants/redrix/Makefile.inc
A src/mainboard/google/brya/variants/redrix/fw_config.c
M src/mainboard/google/brya/variants/redrix/overridetree.cb
4 files changed, 397 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/56656/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/56656
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9fb752fe8280893b84c172d8a519578fa4220184
Gerrit-Change-Number: 56656
Gerrit-PatchSet: 3
Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Wisley Chen.
Hello Tim Wawrzynczak, Wisley Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56656
to look at the new patch set (#2).
Change subject: mb/google/brya/variants/redrix: Init devicetree for redrix
......................................................................
mb/google/brya/variants/redrix: Init devicetree for redrix
Init basci override devicetree
BUG=b:192052098
TEST=FW_NAME=redrix emerge-brya coreboot chromeos-bootimag
Change-Id: I9fb752fe8280893b84c172d8a519578fa4220184
Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brya/Kconfig.name
M src/mainboard/google/brya/variants/redrix/Makefile.inc
A src/mainboard/google/brya/variants/redrix/fw_config.c
M src/mainboard/google/brya/variants/redrix/overridetree.cb
4 files changed, 397 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/56656/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56656
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9fb752fe8280893b84c172d8a519578fa4220184
Gerrit-Change-Number: 56656
Gerrit-PatchSet: 2
Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset