Attention is currently required from: Zhuohao Lee.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56308 )
Change subject: mb/google/brya: add BASEBOARD_DIR to support different baseboard
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56308
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic99e42dbbd27fa3e1f6cb3a1b5daee1c8c7b1083
Gerrit-Change-Number: 56308
Gerrit-PatchSet: 5
Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Comment-Date: Wed, 28 Jul 2021 14:12:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber.
Hello Nico Huber,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/56660
to review the following change.
Change subject: soc/intel/cannonlake: Disable `TccOffsetClamp` if no offset is given
......................................................................
soc/intel/cannonlake: Disable `TccOffsetClamp` if no offset is given
Change-Id: I4f9b62fd944d8a91d53bc584c88797f23de1e5ca
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M src/soc/intel/cannonlake/fsp_params.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/56660/1
diff --git a/src/soc/intel/cannonlake/fsp_params.c b/src/soc/intel/cannonlake/fsp_params.c
index 9d2d722..1e6ae39 100644
--- a/src/soc/intel/cannonlake/fsp_params.c
+++ b/src/soc/intel/cannonlake/fsp_params.c
@@ -608,6 +608,7 @@
/* Set TccActivationOffset */
tconfig->TccActivationOffset = config->tcc_offset;
+ tconfig->TccOffsetClamp = config->tcc_offset > 0;
/* Unlock all GPIO pads */
tconfig->PchUnlockGpioPads = config->PchUnlockGpioPads;
--
To view, visit https://review.coreboot.org/c/coreboot/+/56660
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f9b62fd944d8a91d53bc584c88797f23de1e5ca
Gerrit-Change-Number: 56660
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: newchange
Attention is currently required from: Paul Menzel.
Hello build bot (Jenkins), Idwer Vollering, Werner Zeh, Harshit Sharma,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/54050
to look at the new patch set (#16).
Change subject: util/crossgcc: Update gcc to 11.2
......................................................................
util/crossgcc: Update gcc to 11.2
Various fixes to gnat and the improved nds32 backend have been merged
into gcc by now, so we don't need to carry those patches anymore.
Change-Id: Icdee2a8beedd109ee1f0eef6f32f7accbf66674b
Signed-off-by: Patrick Georgi <pgeorgi(a)google.com>
---
M util/crossgcc/buildgcc
R util/crossgcc/patches/gcc-11.2.0_ada-musl_workaround.patch
R util/crossgcc/patches/gcc-11.2.0_asan_shadow_offset_callback.patch
R util/crossgcc/patches/gcc-11.2.0_gnat.patch
R util/crossgcc/patches/gcc-11.2.0_libcpp.patch
R util/crossgcc/patches/gcc-11.2.0_libgcc.patch
D util/crossgcc/patches/gcc-8.3.0_gnat-bad_constant.patch
D util/crossgcc/patches/gcc-8.3.0_gnat_eh.patch
D util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch
A util/crossgcc/sum/gcc-11.2.0.tar.xz.cksum
D util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum
11 files changed, 25 insertions(+), 21,485 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/54050/16
--
To view, visit https://review.coreboot.org/c/coreboot/+/54050
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icdee2a8beedd109ee1f0eef6f32f7accbf66674b
Gerrit-Change-Number: 54050
Gerrit-PatchSet: 16
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Harshit Sharma <harshitsharmajs(a)gmail.com>
Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Iru Cai (vimacs) <mytbk920423(a)gmail.com>
Gerrit-CC: Jacob Garber <jgarber1(a)ualberta.ca>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset