Attention is currently required from: Martin Roth, Karthik Ramasubramanian.
Hello Martin Roth, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56667
to look at the new patch set (#2).
Change subject: guybrush: Document USB mapping in devicetree
......................................................................
guybrush: Document USB mapping in devicetree
Add a short documenting comment to each usb entry in devicetree so it is
clear which function each usb port maps to.
BUG=None
TEST=Build
BRANCH=None
Change-Id: I14cbb6af021bb27c89aa82456722f21aa09617be
Signed-off-by: Rob Barnes <robbarnes(a)google.com>
---
M src/mainboard/google/guybrush/variants/baseboard/devicetree.cb
1 file changed, 10 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/56667/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56667
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14cbb6af021bb27c89aa82456722f21aa09617be
Gerrit-Change-Number: 56667
Gerrit-PatchSet: 2
Gerrit-Owner: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-CC: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ravi kumar, Taniya Das, Paul Menzel, mturney mturney.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50580 )
Change subject: sc7280: Move to use common clock driver for sc7280
......................................................................
Patch Set 57:
(1 comment)
File src/soc/qualcomm/sc7280/clock.c:
https://review.coreboot.org/c/coreboot/+/50580/comment/f8c82c5b_5fead5bc
PS54, Line 524: return CB_ERR;
> zonda_pll_enable() https://review.coreboot.org/c/coreboot/+/56588/2/src/soc/qualcomm/common/cl…. […]
That's good enough, we only need one error printed per issue, not one on each function level.
--
To view, visit https://review.coreboot.org/c/coreboot/+/50580
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I590a93cda0d6eccb51b54692b620d43ccacede77
Gerrit-Change-Number: 50580
Gerrit-PatchSet: 57
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Taniya Das <tdas(a)codeaurora.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Taniya Das <tdas(a)codeaurora.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Comment-Date: Wed, 28 Jul 2021 17:55:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Taniya Das <tdas(a)codeaurora.org>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Ravi kumar, Taniya Das, mturney mturney.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56589 )
Change subject: sc7180: Move to use common clock driver for sc7180
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
This patch isn't needed anymore (been replaced by CB:56588), right? If so please Abandon it to make the patch train less confusing.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56589
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87e5f681576f299794844a944410ead03987417d
Gerrit-Change-Number: 56589
Gerrit-PatchSet: 1
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Taniya Das <tdas(a)codeaurora.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Taniya Das <tdas(a)codeaurora.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Comment-Date: Wed, 28 Jul 2021 17:54:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Shelley Chen, Ravi kumar, Taniya Das, mturney mturney.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56587 )
Change subject: sc7180: Cleanups for drivers with common clock
......................................................................
Patch Set 3:
(1 comment)
File src/soc/qualcomm/sc7180/display/dsi_phy.c:
https://review.coreboot.org/c/coreboot/+/56587/comment/fa699ae8_ceee9859
PS1, Line 725: .clk_div = 1, .source_div = 2},
> I didn't want to clutter the common change with this target specific code. […]
Yes, this definitely needs to be merged with the clock.c change so it doesn't break in between the patches. Please also rename the argument in mdss_clock_configure() from half_divider to something else (e.g. just divider) to clarify that the doubling is done inside the function now.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56587
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic334fd0d43e5b4b1e43a27d5db7665f0bc151d66
Gerrit-Change-Number: 56587
Gerrit-PatchSet: 3
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Taniya Das <tdas(a)codeaurora.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Taniya Das <tdas(a)codeaurora.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Comment-Date: Wed, 28 Jul 2021 17:52:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen <shchen(a)google.com>
Comment-In-Reply-To: Taniya Das <tdas(a)codeaurora.org>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Shelley Chen, Ravi kumar, Taniya Das, mturney mturney.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56588 )
Change subject: soc: common: clock: Add support for common clock driver
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> >>> […]
Yes, it's true that it still needs to compile and boot correctly in between the two patches. But I still think you can do a lot of this work inside the sc7180/clock.c file first without breaking compilation. For example, it looks like you remove the clock_configure_qup() function because it is unused, you're factoring out parts of pll_init_and_set() into a new function (agera_pll_enable()), you turn clock_configure_dfsr() into a thin wrapper for another function (clock_configure_dfsr_table()), and so on. Please make all of these changes inside the sc7180/clock.c file first, without moving anything to a different file, and submit that as a separate patch. That makes it much easier for us to review what actually changed inside the code (because Gerrit will diff it for us and we don't have to follow every change manually). Then in the next patch you can move the relevant parts out of sc7180/clock.c into common/clock.c (and that should be pretty much a straight Cut+Paste at that point without having to make more changes to the contents).
(Also, it looks like this patch is introducing some sc7280-related stuff that sc7180 doesn't need yet, like the zonda_pll_enable() function. Please move that part into CB:50580 instead.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56588
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03d1b4a2fb90303c7259ec08f312d78b4e33ec39
Gerrit-Change-Number: 56588
Gerrit-PatchSet: 2
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Taniya Das <tdas(a)codeaurora.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Taniya Das <tdas(a)codeaurora.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Comment-Date: Wed, 28 Jul 2021 17:46:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Taniya Das <tdas(a)codeaurora.org>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54050 )
Change subject: util/crossgcc: Update gcc to 11.2
......................................................................
Patch Set 16:
(1 comment)
Patchset:
PS16:
> It seems, the 11.2 source archive is not on all the mirrors yet: […]
Yes, I restarted the build and the new run got it from another server.
--
To view, visit https://review.coreboot.org/c/coreboot/+/54050
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icdee2a8beedd109ee1f0eef6f32f7accbf66674b
Gerrit-Change-Number: 54050
Gerrit-PatchSet: 16
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Harshit Sharma <harshitsharmajs(a)gmail.com>
Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Iru Cai (vimacs) <mytbk920423(a)gmail.com>
Gerrit-CC: Jacob Garber <jgarber1(a)ualberta.ca>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 28 Jul 2021 17:40:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54050 )
Change subject: util/crossgcc: Update gcc to 11.2
......................................................................
Patch Set 16:
(1 comment)
Patchset:
PS16:
It seems, the 11.2 source archive is not on all the mirrors yet:
https://mirror.tochlab.net/pub/gnu/gcc/gcc-11.2.0/gcc-11.2.0.tar.xz: 2021-07-28 15:01:01 ERROR 404: Not Found.
--
To view, visit https://review.coreboot.org/c/coreboot/+/54050
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icdee2a8beedd109ee1f0eef6f32f7accbf66674b
Gerrit-Change-Number: 54050
Gerrit-PatchSet: 16
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Harshit Sharma <harshitsharmajs(a)gmail.com>
Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Iru Cai (vimacs) <mytbk920423(a)gmail.com>
Gerrit-CC: Jacob Garber <jgarber1(a)ualberta.ca>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 28 Jul 2021 17:29:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Tim Wawrzynczak, Felix Held.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56651 )
Change subject: cpu/x86: Rename X86_AMD_INIT_SIPI to X86_INIT_SIPI
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> The Intel Multiprocessor Specification 1. […]
This is a finding by us and we had initiated a discussion to capture the details at validation side, we are also running more validation. At limited validation at our side on multiple skus we don't see any problem while working on MP services.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56651
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a4e6a8b1edc6e8ba43597259bd8b2de697e4e62
Gerrit-Change-Number: 56651
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 28 Jul 2021 17:27:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Subrata Banik, Felix Held.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56651 )
Change subject: cpu/x86: Rename X86_AMD_INIT_SIPI to X86_INIT_SIPI
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
The Intel Multiprocessor Specification 1.4 still specifies the 2 STARTUP SIPIs ("Universal Start-up Algorithm"). Is there a change in this ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56651
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a4e6a8b1edc6e8ba43597259bd8b2de697e4e62
Gerrit-Change-Number: 56651
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 28 Jul 2021 17:18:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment