Attention is currently required from: Martin Roth, Rob Barnes.
Hello build bot (Jenkins), Martin Roth, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56667
to look at the new patch set (#3).
Change subject: guybrush: Document USB mapping in devicetree
......................................................................
guybrush: Document USB mapping in devicetree
Add a short documenting comment to each usb entry in devicetree so it is
clear which function each usb port maps to.
BUG=None
TEST=Build
BRANCH=None
Change-Id: I14cbb6af021bb27c89aa82456722f21aa09617be
Signed-off-by: Rob Barnes <robbarnes(a)google.com>
---
M src/mainboard/google/guybrush/variants/baseboard/devicetree.cb
1 file changed, 12 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/56667/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/56667
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14cbb6af021bb27c89aa82456722f21aa09617be
Gerrit-Change-Number: 56667
Gerrit-PatchSet: 3
Gerrit-Owner: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Angel Pons.
Furquan Shaikh has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/56628 )
Change subject: arch/x86: Add missing SPD memory type 72b-SO-UDIMM and Non-DIMM
......................................................................
Removed Code-Review+2 by Furquan Shaikh <furquan(a)google.com>
--
To view, visit https://review.coreboot.org/c/coreboot/+/56628
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia337ac8f50b61ae78d86a07c7a86aa9c248bad50
Gerrit-Change-Number: 56628
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: deleteVote
Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Angel Pons.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56627 )
Change subject: include/spd: Fix SPD Memory Type as per JEDEC Standard No. 21-C
......................................................................
Patch Set 3:
(1 comment)
File src/include/spd.h:
https://review.coreboot.org/c/coreboot/+/56627/comment/89ca1839_700c9cae
PS3, Line 204: 0x04
Looking at the rest of the CLs in the patch series, it looks like we have been converting module type for different memory technologies into the module type for DDR2. So the value 0x04 here was correct for DDR2. Please see comment https://review.coreboot.org/c/coreboot/+/56650/comment/cb91dcb6_4210c12b/ on how to fix this.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56627
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I356b322fabd7ceeaefda60bcc5438eb4a64675ed
Gerrit-Change-Number: 56627
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Wed, 28 Jul 2021 18:30:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Angel Pons.
Furquan Shaikh has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/56627 )
Change subject: include/spd: Fix SPD Memory Type as per JEDEC Standard No. 21-C
......................................................................
Removed Code-Review+2 by Furquan Shaikh <furquan(a)google.com>
--
To view, visit https://review.coreboot.org/c/coreboot/+/56627
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I356b322fabd7ceeaefda60bcc5438eb4a64675ed
Gerrit-Change-Number: 56627
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: deleteVote
Attention is currently required from: Paul Menzel, Subrata Banik, Angel Pons, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56650 )
Change subject: soc/intel/common: Don't suppress SPD Module Type value
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/smbios.c:
https://review.coreboot.org/c/coreboot/+/56650/comment/cb91dcb6_4210c12b
PS3, Line 18: /* Translate to DDR2 module type field that SMBIOS code expects. */
Subrata, I think we need to address the root problem here. Why does the SMBIOS code expect module type in DDR2 format? We are always going to run into issues trying to fit module types for new memory technologies into the values supported by DDR2.
Instead, I think we need to separate this out such that:
1. mod_type contains the value of module type for the given memory type.
2. In `create_smbios_type17_for_dimm()`, use both mod_type and ddr_type to determine the correct translation from mod_type to smbios form factor. I think we are going to need at least the following 3 conversions:
```
* ddr3
* ddr4
* lp -- I have not checked if LP3 and LP4/LP4x use the same module types. If not, then those will have to be separate as well.
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/56650
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3f38c24efa6a8685639bb607926e2fd9c702ff6
Gerrit-Change-Number: 56650
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Wed, 28 Jul 2021 18:25:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth.
Hello Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56677
to look at the new patch set (#2).
Change subject: util/kconfig: detect ncurses on FreeBSD
......................................................................
util/kconfig: detect ncurses on FreeBSD
Signed-off-by: Idwer Vollering <vidwer(a)gmail.com>
Change-Id: I4344ba2116c0b8618357db4248d993509cbb666e
---
M util/kconfig/mconf-cfg.sh
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/56677/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56677
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4344ba2116c0b8618357db4248d993509cbb666e
Gerrit-Change-Number: 56677
Gerrit-PatchSet: 2
Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-MessageType: newpatchset
Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56677 )
Change subject: util/kconfig: detect ncurses on FreeBSD
......................................................................
util/kconfig: detect ncurses on FreeBSD
Signed-off-by: Idwer Vollering <vidwer(a)gmail.com>
Change-Id: I4344ba2116c0b8618357db4248d993509cbb666e
---
M util/kconfig/mconf-cfg.sh
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/56677/1
diff --git a/util/kconfig/mconf-cfg.sh b/util/kconfig/mconf-cfg.sh
index b520e40..94c3a90 100755
--- a/util/kconfig/mconf-cfg.sh
+++ b/util/kconfig/mconf-cfg.sh
@@ -33,6 +33,12 @@
exit 0
fi
+# We'll want to be able to build on (FreeBSD):
+if [ -f /usr/include/ncurses.h ]; then
+ echo libs=\"-lncurses\"
+ exit 0
+fi
+
# As a final fallback before giving up, check if $HOSTCC knows of a default
# ncurses installation (e.g. from a vendor-specific sysroot).
if echo '#include <ncurses.h>' | ${HOSTCC} -E - >/dev/null 2>&1; then
--
To view, visit https://review.coreboot.org/c/coreboot/+/56677
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4344ba2116c0b8618357db4248d993509cbb666e
Gerrit-Change-Number: 56677
Gerrit-PatchSet: 1
Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56675 )
Change subject: soc/amd/common/block/include/acpimmio_map: drop unused GPIO bank defines
......................................................................
soc/amd/common/block/include/acpimmio_map: drop unused GPIO bank defines
The offsets of all GPIOs in the up to four regular banks are all
calculated relatively to ACPIMMIO_GPIO0_BANK, so we can just drop the
unused defines for ACPIMMIO_GPIO1_BANK and ACPIMMIO_GPIO2_BANK.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I832ffdca479c1f07219a23b4a7f9be69322dfe03
---
M src/soc/amd/common/block/include/amdblocks/acpimmio_map.h
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/56675/1
diff --git a/src/soc/amd/common/block/include/amdblocks/acpimmio_map.h b/src/soc/amd/common/block/include/amdblocks/acpimmio_map.h
index ebfc039..7081dbb 100644
--- a/src/soc/amd/common/block/include/amdblocks/acpimmio_map.h
+++ b/src/soc/amd/common/block/include/amdblocks/acpimmio_map.h
@@ -119,8 +119,6 @@
#define ACPIMMIO_MISC_BANK 0x0e00
#define ACPIMMIO_DPVGA_BANK 0x1400
#define ACPIMMIO_GPIO0_BANK 0x1500
-#define ACPIMMIO_GPIO1_BANK 0x1600
-#define ACPIMMIO_GPIO2_BANK 0x1700
#define ACPIMMIO_XHCIPM_BANK 0x1c00
#define ACPIMMIO_ACDCTMR_BANK 0x1d00
#define ACPIMMIO_AOAC_BANK 0x1e00
--
To view, visit https://review.coreboot.org/c/coreboot/+/56675
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I832ffdca479c1f07219a23b4a7f9be69322dfe03
Gerrit-Change-Number: 56675
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-MessageType: newchange