coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: nb/intel/common: Replace `_bar_clrsetbits_impl` macro
by Angel Pons (Code Review) 01 May '21

01 May '21

Attention is currently required from: Arthur Heymans, Patrick Rudolph. Hello build bot (Jenkins), Nico Huber, Arthur Heymans, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51886 to look at the new patch set (#10). Change subject: nb/intel/common: Replace `_bar_clrsetbits_impl` macro ...................................................................... nb/intel/common: Replace `_bar_clrsetbits_impl` macro This macro contains a cast on the and-mask, which can suppress actual type overflow issues. Replace it with wrapper functions around the existing macros in device/mmio.h which still contain a type cast, but it is a non-issue because the wrapper functions now allow compilers to check for overflows. Change-Id: I975bf8152fc961767f0292bff4a03aecd8c65f56 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/northbridge/intel/common/fixed_bars.h 1 file changed, 58 insertions(+), 29 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/51886/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/51886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I975bf8152fc961767f0292bff4a03aecd8c65f56 Gerrit-Change-Number: 51886 Gerrit-PatchSet: 10 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: nb/intel/common: Drop deprecated fixed BAR accessors
by Angel Pons (Code Review) 01 May '21

01 May '21

Attention is currently required from: Nico Huber, Arthur Heymans, Patrick Rudolph. Hello build bot (Jenkins), Nico Huber, Arthur Heymans, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51885 to look at the new patch set (#10). Change subject: nb/intel/common: Drop deprecated fixed BAR accessors ...................................................................... nb/intel/common: Drop deprecated fixed BAR accessors Now that all code has been switched to make use of the new accessors, the old ones can be dropped. Follow-ups will clean up bitwise accessors. Change-Id: Ib4cb24ca71f3c3717ea50d147ddca74aaf0288fa Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/northbridge/intel/common/fixed_bars.h 1 file changed, 0 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/51885/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/51885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4cb24ca71f3c3717ea50d147ddca74aaf0288fa Gerrit-Change-Number: 51885 Gerrit-PatchSet: 10 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: nb/intel/common: Turn `*bar_{read,write}*` macros into functions
by Angel Pons (Code Review) 01 May '21

01 May '21

Attention is currently required from: Patrick Rudolph. Hello Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52816 to look at the new patch set (#2). Change subject: nb/intel/common: Turn `*bar_{read,write}*` macros into functions ...................................................................... nb/intel/common: Turn `*bar_{read,write}*` macros into functions These accessors were defined as macros in order to allow verifying the patches that replaced the accessors using BUILD_TIMELESS=1. Now that all replacement is done, turn the new accessors into static functions to let the compiler perform overflow checks on the arguments. Change-Id: Iaa2ba208fba11c4a00f2b8a05eb1129a32c6c092 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/northbridge/intel/common/fixed_bars.h 1 file changed, 97 insertions(+), 29 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/52816/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52816 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa2ba208fba11c4a00f2b8a05eb1129a32c6c092 Gerrit-Change-Number: 52816 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: nb/intel/common: Drop deprecated fixed BAR accessors
by Angel Pons (Code Review) 01 May '21

01 May '21

Attention is currently required from: Nico Huber, Arthur Heymans, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51885 ) Change subject: nb/intel/common: Drop deprecated fixed BAR accessors ...................................................................... Patch Set 9: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/51885/comment/e4a9434b_20d773e7 PS8, Line 7: nb/intel/common: Drop deprecated fixed BAR accessors : : Now that all code has been switched to make use of the new accessors, : the old ones can be dropped. Follow-ups will clean up bitwise accessors. > 😄 […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/51885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4cb24ca71f3c3717ea50d147ddca74aaf0288fa Gerrit-Change-Number: 51885 Gerrit-PatchSet: 9 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 01 May 2021 21:27:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/common: Turn fixed BAR accessors into functions
by Angel Pons (Code Review) 01 May '21

01 May '21

Attention is currently required from: Patrick Rudolph. Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52816 ) Change subject: nb/intel/common: Turn fixed BAR accessors into functions ...................................................................... nb/intel/common: Turn fixed BAR accessors into functions Change-Id: Iaa2ba208fba11c4a00f2b8a05eb1129a32c6c092 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/northbridge/intel/common/fixed_bars.h 1 file changed, 97 insertions(+), 29 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/52816/1 diff --git a/src/northbridge/intel/common/fixed_bars.h b/src/northbridge/intel/common/fixed_bars.h index 8a0d9dc..ed7b403 100644 --- a/src/northbridge/intel/common/fixed_bars.h +++ b/src/northbridge/intel/common/fixed_bars.h @@ -3,10 +3,7 @@ #ifndef NORTHBRIDGE_INTEL_COMMON_FIXED_BARS_H #define NORTHBRIDGE_INTEL_COMMON_FIXED_BARS_H -_Static_assert(CONFIG_FIXED_MCHBAR_MMIO_BASE != 0, "MCHBAR base address is zero"); -_Static_assert(CONFIG_FIXED_DMIBAR_MMIO_BASE != 0, "DMIBAR base address is zero"); -_Static_assert(CONFIG_FIXED_EPBAR_MMIO_BASE != 0, "EPBAR base address is zero"); - +#include <device/mmio.h> #include <stdint.h> /* Deprecated in favor of the read/write accessors below */ @@ -32,19 +29,106 @@ #define EPBAR16(x) (*((volatile u16 *)((uintptr_t)CONFIG_FIXED_EPBAR_MMIO_BASE + (x)))) #define EPBAR32(x) (*((volatile u32 *)((uintptr_t)CONFIG_FIXED_EPBAR_MMIO_BASE + (x)))) -/* The *bar_{read,write}X macros will be replaced with functions in follow-ups */ +_Static_assert(CONFIG_FIXED_MCHBAR_MMIO_BASE != 0, "MCHBAR base address is zero"); + +static __always_inline uint8_t mchbar_read8(const uintptr_t offset) +{ + return read8p(CONFIG_FIXED_MCHBAR_MMIO_BASE + offset); +} + +static __always_inline uint16_t mchbar_read16(const uintptr_t offset) +{ + return read16p(CONFIG_FIXED_MCHBAR_MMIO_BASE + offset); +} + +static __always_inline uint32_t mchbar_read32(const uintptr_t offset) +{ + return read32p(CONFIG_FIXED_MCHBAR_MMIO_BASE + offset); +} + +static __always_inline void mchbar_write8(const uintptr_t offset, const uint8_t value) +{ + write8p(CONFIG_FIXED_MCHBAR_MMIO_BASE + offset, value); +} + +static __always_inline void mchbar_write16(const uintptr_t offset, const uint16_t value) +{ + write16p(CONFIG_FIXED_MCHBAR_MMIO_BASE + offset, value); +} + +static __always_inline void mchbar_write32(const uintptr_t offset, const uint32_t value) +{ + write32p(CONFIG_FIXED_MCHBAR_MMIO_BASE + offset, value); +} + +_Static_assert(CONFIG_FIXED_DMIBAR_MMIO_BASE != 0, "DMIBAR base address is zero"); + +static __always_inline uint8_t dmibar_read8(const uintptr_t offset) +{ + return read8p(CONFIG_FIXED_DMIBAR_MMIO_BASE + offset); +} + +static __always_inline uint16_t dmibar_read16(const uintptr_t offset) +{ + return read16p(CONFIG_FIXED_DMIBAR_MMIO_BASE + offset); +} + +static __always_inline uint32_t dmibar_read32(const uintptr_t offset) +{ + return read32p(CONFIG_FIXED_DMIBAR_MMIO_BASE + offset); +} + +static __always_inline void dmibar_write8(const uintptr_t offset, const uint8_t value) +{ + write8p(CONFIG_FIXED_DMIBAR_MMIO_BASE + offset, value); +} + +static __always_inline void dmibar_write16(const uintptr_t offset, const uint16_t value) +{ + write16p(CONFIG_FIXED_DMIBAR_MMIO_BASE + offset, value); +} + +static __always_inline void dmibar_write32(const uintptr_t offset, const uint32_t value) +{ + write32p(CONFIG_FIXED_DMIBAR_MMIO_BASE + offset, value); +} + +_Static_assert(CONFIG_FIXED_EPBAR_MMIO_BASE != 0, "EPBAR base address is zero"); + +static __always_inline uint8_t epbar_read8(const uintptr_t offset) +{ + return read8p(CONFIG_FIXED_EPBAR_MMIO_BASE + offset); +} + +static __always_inline uint16_t epbar_read16(const uintptr_t offset) +{ + return read16p(CONFIG_FIXED_EPBAR_MMIO_BASE + offset); +} + +static __always_inline uint32_t epbar_read32(const uintptr_t offset) +{ + return read32p(CONFIG_FIXED_EPBAR_MMIO_BASE + offset); +} + +static __always_inline void epbar_write8(const uintptr_t offset, const uint8_t value) +{ + write8p(CONFIG_FIXED_EPBAR_MMIO_BASE + offset, value); +} + +static __always_inline void epbar_write16(const uintptr_t offset, const uint16_t value) +{ + write16p(CONFIG_FIXED_EPBAR_MMIO_BASE + offset, value); +} + +static __always_inline void epbar_write32(const uintptr_t offset, const uint32_t value) +{ + write32p(CONFIG_FIXED_EPBAR_MMIO_BASE + offset, value); +} + #define _bar_clrsetbits_impl(base, addr, clear, set, bits) \ base##bar_write##bits(addr, \ (base##bar_read##bits(addr) & ~(uint##bits##_t)(clear)) | (set)) -#define mchbar_read8(addr) MCHBAR8(addr) -#define mchbar_read16(addr) MCHBAR16(addr) -#define mchbar_read32(addr) MCHBAR32(addr) - -#define mchbar_write8(addr, value) (MCHBAR8(addr) = (value)) -#define mchbar_write16(addr, value) (MCHBAR16(addr) = (value)) -#define mchbar_write32(addr, value) (MCHBAR32(addr) = (value)) - #define mchbar_clrsetbits8(addr, clear, set) _bar_clrsetbits_impl(mch, addr, clear, set, 8) #define mchbar_clrsetbits16(addr, clear, set) _bar_clrsetbits_impl(mch, addr, clear, set, 16) #define mchbar_clrsetbits32(addr, clear, set) _bar_clrsetbits_impl(mch, addr, clear, set, 32) @@ -57,14 +141,6 @@ #define mchbar_clrbits16(addr, clear) mchbar_clrsetbits16(addr, clear, 0) #define mchbar_clrbits32(addr, clear) mchbar_clrsetbits32(addr, clear, 0) -#define dmibar_read8(addr) DMIBAR8(addr) -#define dmibar_read16(addr) DMIBAR16(addr) -#define dmibar_read32(addr) DMIBAR32(addr) - -#define dmibar_write8(addr, value) (DMIBAR8(addr) = (value)) -#define dmibar_write16(addr, value) (DMIBAR16(addr) = (value)) -#define dmibar_write32(addr, value) (DMIBAR32(addr) = (value)) - #define dmibar_clrsetbits8(addr, clear, set) _bar_clrsetbits_impl(dmi, addr, clear, set, 8) #define dmibar_clrsetbits16(addr, clear, set) _bar_clrsetbits_impl(dmi, addr, clear, set, 16) #define dmibar_clrsetbits32(addr, clear, set) _bar_clrsetbits_impl(dmi, addr, clear, set, 32) @@ -77,14 +153,6 @@ #define dmibar_clrbits16(addr, clear) dmibar_clrsetbits16(addr, clear, 0) #define dmibar_clrbits32(addr, clear) dmibar_clrsetbits32(addr, clear, 0) -#define epbar_read8(addr) EPBAR8(addr) -#define epbar_read16(addr) EPBAR16(addr) -#define epbar_read32(addr) EPBAR32(addr) - -#define epbar_write8(addr, value) (EPBAR8(addr) = (value)) -#define epbar_write16(addr, value) (EPBAR16(addr) = (value)) -#define epbar_write32(addr, value) (EPBAR32(addr) = (value)) - #define epbar_clrsetbits8(addr, clear, set) _bar_clrsetbits_impl(ep, addr, clear, set, 8) #define epbar_clrsetbits16(addr, clear, set) _bar_clrsetbits_impl(ep, addr, clear, set, 16) #define epbar_clrsetbits32(addr, clear, set) _bar_clrsetbits_impl(ep, addr, clear, set, 32) -- To view, visit https://review.coreboot.org/c/coreboot/+/52816 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa2ba208fba11c4a00f2b8a05eb1129a32c6c092 Gerrit-Change-Number: 52816 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: nb/intel/common: Drop deprecated fixed BAR accessors
by Angel Pons (Code Review) 01 May '21

01 May '21

Attention is currently required from: Angel Pons, Arthur Heymans, Patrick Rudolph. Hello build bot (Jenkins), Nico Huber, Arthur Heymans, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51885 to look at the new patch set (#9). Change subject: nb/intel/common: Drop deprecated fixed BAR accessors ...................................................................... nb/intel/common: Drop deprecated fixed BAR accessors Now that all code has been switched to make use of the new accessors, the old ones can be dropped. Follow-ups will clean up bitwise accessors. Change-Id: Ib4cb24ca71f3c3717ea50d147ddca74aaf0288fa Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/northbridge/intel/common/fixed_bars.h 1 file changed, 0 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/51885/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/51885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4cb24ca71f3c3717ea50d147ddca74aaf0288fa Gerrit-Change-Number: 51885 Gerrit-PatchSet: 9 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in libgfxinit[master]: Add support to switch LSPCON modes
by Angel Pons (Code Review) 01 May '21

01 May '21

Attention is currently required from: Nico Huber, Martin Roth, Matt DeVillier. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/51133 ) Change subject: Add support to switch LSPCON modes ...................................................................... Patch Set 9: (1 comment) File common/hw-gfx-dp_dual_mode.adb: https://review.coreboot.org/c/libgfxinit/+/51133/comment/7bcca0df_e134a4aa PS7, Line 118: Time.M_Delay (1); > timeout helpers should exist somewhere I forgot what I meant with this comment. -- To view, visit https://review.coreboot.org/c/libgfxinit/+/51133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Idfa9bdff47a6591000cd5092d64a4cd4f8dbdc8d Gerrit-Change-Number: 51133 Gerrit-PatchSet: 9 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Sat, 01 May 2021 21:08:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [DO NOT SUBMIT] 3rdparty/libgfxinit: Update submodule pointer
by Angel Pons (Code Review) 01 May '21

01 May '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51147 to look at the new patch set (#3). Change subject: [DO NOT SUBMIT] 3rdparty/libgfxinit: Update submodule pointer ...................................................................... [DO NOT SUBMIT] 3rdparty/libgfxinit: Update submodule pointer This brings in LSPCON support. Change-Id: I35cefa2aa8107b7841d7cf7a7bb61d4b591d14ae Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M 3rdparty/libgfxinit 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/51147/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/51147 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35cefa2aa8107b7841d7cf7a7bb61d4b591d14ae Gerrit-Change-Number: 51147 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in libgfxinit[master]: Add support to switch LSPCON modes
by Angel Pons (Code Review) 01 May '21

01 May '21

Attention is currently required from: Nico Huber, Martin Roth. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/51133 ) Change subject: Add support to switch LSPCON modes ...................................................................... Patch Set 9: (2 comments) File common/hw-gfx-dp_dual_mode.ads: https://review.coreboot.org/c/libgfxinit/+/51133/comment/b4f4bdb4_8f954334 PS7, Line 32: LSPCON); > Dead code Gone https://review.coreboot.org/c/libgfxinit/+/51133/comment/7e51cfa8_91f21bb8 PS7, Line 36: Auto_Configure > Switch_LSPCON Done -- To view, visit https://review.coreboot.org/c/libgfxinit/+/51133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Idfa9bdff47a6591000cd5092d64a4cd4f8dbdc8d Gerrit-Change-Number: 51133 Gerrit-PatchSet: 9 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Sat, 01 May 2021 20:59:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in libgfxinit[master]: Add support to switch LSPCON modes
by Angel Pons (Code Review) 01 May '21

01 May '21

Attention is currently required from: Nico Huber, Martin Roth. Hello Nico Huber, Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/libgfxinit/+/51133 to look at the new patch set (#9). Change subject: Add support to switch LSPCON modes ...................................................................... Add support to switch LSPCON modes LSPCON is a highly-cursed level shifter and protocol converter chip. It is primarily used to convert DisplayPort into HDMI 2.0, since some Intel iGPUs do not have native HDMI 2.0 support. The chip defaults to LS mode. Add code to detect LSPCON chips and put them in protocol converter mode. This way, the LSPCON behaves like a regular DisplayPort sink. This needs to be done before any DPCD accesses, because the LSPCON does not respond to DPCD accesses in level shifter mode. Tested on Purism Librem Mini v1 (WHL-U), HDMI port can now light up. Change-Id: Idfa9bdff47a6591000cd5092d64a4cd4f8dbdc8d Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M common/Makefile.inc A common/hw-gfx-dp_dual_mode.adb A common/hw-gfx-dp_dual_mode.ads M common/hw-gfx-gma-connector_info.adb A common/hw-gfx-gma-dp_dual_mode.ads 5 files changed, 262 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/33/51133/9 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/51133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Idfa9bdff47a6591000cd5092d64a4cd4f8dbdc8d Gerrit-Change-Number: 51133 Gerrit-PatchSet: 9 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021