coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: lib/option: Move CMOS option backend to choice
by Patrick Rudolph (Code Review) 03 May '21

03 May '21

Attention is currently required from: Patrick Rudolph. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52856 to look at the new patch set (#2). Change subject: lib/option: Move CMOS option backend to choice ...................................................................... lib/option: Move CMOS option backend to choice In order to add more option backend make the current one part of a Kconfig choice. Also remove the remaining 'select' directives which do not work with choice options. Instead of inlining the option framework add a stub file in case no option backend is selected, which is the default. Change-Id: Ibcbc3db01d35b933678e5d6a203b2a9e406092fe Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M payloads/Kconfig M src/Kconfig M src/drivers/pc80/rtc/option.c M src/include/option.h M src/lib/Makefile.inc A src/lib/option.c 6 files changed, 45 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/52856/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcbc3db01d35b933678e5d6a203b2a9e406092fe Gerrit-Change-Number: 52856 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/prodrive/hermes: Implement the mainboard option table interface
by build bot (Jenkins) (Code Review) 03 May '21

03 May '21

Attention is currently required from: Martin Roth, Christian Walter, Angel Pons, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52577 ) Change subject: mb/prodrive/hermes: Implement the mainboard option table interface ...................................................................... Patch Set 5: (1 comment) File src/mainboard/prodrive/hermes/option.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118247): https://review.coreboot.org/c/coreboot/+/52577/comment/76fc2280_69293c9e PS5, Line 9: #define OPTION(x, y) { y, offsetof(struct eeprom_board_settings, x), sizeof(((struct eeprom_board_settings *)NULL)->x), }, line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/52577 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I11fc342c5d422cc3d29392df9c53c7996d6f868e Gerrit-Change-Number: 52577 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 03 May 2021 13:20:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib/option: Move CMOS option backend to choice
by Patrick Rudolph (Code Review) 03 May '21

03 May '21

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52856 ) Change subject: lib/option: Move CMOS option backend to choice ...................................................................... lib/option: Move CMOS option backend to choice In order to add more option backend make the current one part of a Kconfig choice. Also remove the remaining 'select' directives which do not work with choice options. Instead of inlining the option framework add a stub file in case no option backend is selected, which is the default. Change-Id: Ibcbc3db01d35b933678e5d6a203b2a9e406092fe Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M payloads/Kconfig M src/Kconfig M src/drivers/pc80/rtc/option.c M src/include/option.h M src/lib/Makefile.inc A src/lib/option.c 6 files changed, 43 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/52856/1 diff --git a/payloads/Kconfig b/payloads/Kconfig index 627bb95..386b207 100644 --- a/payloads/Kconfig +++ b/payloads/Kconfig @@ -133,7 +133,6 @@ bool "Load nvramcui as a secondary payload" default n depends on ARCH_X86 && HAVE_OPTION_TABLE - select USE_OPTION_TABLE help nvramcui can be loaded as a secondary payload under SeaBIOS, GRUB, or any other payload that can load additional payloads. diff --git a/src/Kconfig b/src/Kconfig index fe325e8..3877658 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -120,6 +120,14 @@ Otherwise, say N to use the provided pregenerated scanner/parser. +choice + prompt "Option backend to use" + default USE_OPTION_TABLE if NVRAMCUI_SECONDARY_PAYLOAD + default USE_NO_OPTION_TABLE + +config USE_NO_OPTION_TABLE + bool "None" + config USE_OPTION_TABLE bool "Use CMOS for configuration values" depends on HAVE_OPTION_TABLE @@ -127,6 +135,9 @@ Enable this option if coreboot shall read options from the "CMOS" NVRAM instead of using hard-coded values. + +endchoice + config STATIC_OPTION_TABLE bool "Load default configuration values into CMOS on each boot" depends on USE_OPTION_TABLE diff --git a/src/drivers/pc80/rtc/option.c b/src/drivers/pc80/rtc/option.c index 5cc5ea5..de90822 100644 --- a/src/drivers/pc80/rtc/option.c +++ b/src/drivers/pc80/rtc/option.c @@ -205,3 +205,16 @@ cmos_restore_rtc(control_state); } } + +enum cb_err set_int_option(const char *name, int value) +{ + return cmos_set_option(name, &value); +} + +int get_int_option(const char *name, const int fallback) +{ + if (cmos_get_option(&value, name) == CB_SUCCESS) + return value; + + return fallback; +} diff --git a/src/include/option.h b/src/include/option.h index 4de032b..7c33cad 100644 --- a/src/include/option.h +++ b/src/include/option.h @@ -7,25 +7,7 @@ void sanitize_cmos(void); -enum cb_err cmos_set_option(const char *name, void *val); -enum cb_err cmos_get_option(void *dest, const char *name); - -static inline enum cb_err set_int_option(const char *name, int value) -{ - if (CONFIG(USE_OPTION_TABLE)) - return cmos_set_option(name, &value); - - return CB_CMOS_OTABLE_DISABLED; -} - -static inline int get_int_option(const char *name, const int fallback) -{ - if (CONFIG(USE_OPTION_TABLE)) { - int value = 0; - if (cmos_get_option(&value, name) == CB_SUCCESS) - return value; - } - return fallback; -} +enum cb_err set_int_option(const char *name, int value); +int get_int_option(const char *name, const int fallback); #endif /* _OPTION_H_ */ diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc index 358035d..f36efbf 100644 --- a/src/lib/Makefile.inc +++ b/src/lib/Makefile.inc @@ -270,6 +270,9 @@ ramstage-y += crc_byte.c smm-y += crc_byte.c +all-$(CONFIG_USE_NO_OPTION_TABLE) += option.c +smm-$(CONFIG_USE_NO_OPTION_TABLE) += option.c + postcar-y += bootmode.c postcar-y += boot_device.c postcar-y += cbfs.c diff --git a/src/lib/option.c b/src/lib/option.c new file mode 100644 index 0000000..0d3a498 --- /dev/null +++ b/src/lib/option.c @@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <types.h> +#include <option.h> + +enum cb_err set_int_option(const char *name, int value) +{ + return CB_CMOS_OTABLE_DISABLED; +} + +int get_int_option(const char *name, const int fallback) +{ + return fallback; +} -- To view, visit https://review.coreboot.org/c/coreboot/+/52856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcbc3db01d35b933678e5d6a203b2a9e406092fe Gerrit-Change-Number: 52856 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/*/Kconfig: Drop select USE_OPTION_TABLE
by Patrick Rudolph (Code Review) 03 May '21

03 May '21

Attention is currently required from: Tristan Corrick, Alexander Couzens, Evgeny Zinoviev, Patrick Rudolph. Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52855 ) Change subject: mb/*/Kconfig: Drop select USE_OPTION_TABLE ...................................................................... mb/*/Kconfig: Drop select USE_OPTION_TABLE Only 4 mainboards selected to use the option table. Use the same default on all boards. Change-Id: Ia9ef88d5158a2b43f843c26b5b366a899dad8788 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/mainboard/apple/macbook21/Kconfig M src/mainboard/asrock/h81m-hds/Kconfig M src/mainboard/asus/am1i-a/Kconfig M src/mainboard/lenovo/x60/Kconfig 4 files changed, 0 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/52855/1 diff --git a/src/mainboard/apple/macbook21/Kconfig b/src/mainboard/apple/macbook21/Kconfig index 9eb06ff..5d8f626 100644 --- a/src/mainboard/apple/macbook21/Kconfig +++ b/src/mainboard/apple/macbook21/Kconfig @@ -15,7 +15,6 @@ select INTEL_INT15 select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME - select USE_OPTION_TABLE select I945_LVDS config MAINBOARD_DIR diff --git a/src/mainboard/asrock/h81m-hds/Kconfig b/src/mainboard/asrock/h81m-hds/Kconfig index af723a3..4e9583c 100644 --- a/src/mainboard/asrock/h81m-hds/Kconfig +++ b/src/mainboard/asrock/h81m-hds/Kconfig @@ -32,12 +32,4 @@ string default "H81M-HDS" -# -# Since this is a desktop board, the assumption is made that most users -# would want CMOS configuration enabled by default. -# -config USE_OPTION_TABLE - bool - default y - endif diff --git a/src/mainboard/asus/am1i-a/Kconfig b/src/mainboard/asus/am1i-a/Kconfig index 78948b2..365043c 100644 --- a/src/mainboard/asus/am1i-a/Kconfig +++ b/src/mainboard/asus/am1i-a/Kconfig @@ -7,7 +7,6 @@ select FORCE_AM1_SOCKET_SUPPORT select GFXUMA select HAVE_OPTION_TABLE - select USE_OPTION_TABLE select HAVE_CMOS_DEFAULT select HAVE_PIRQ_TABLE select HAVE_ACPI_RESUME diff --git a/src/mainboard/lenovo/x60/Kconfig b/src/mainboard/lenovo/x60/Kconfig index 8397835..3a82179 100644 --- a/src/mainboard/lenovo/x60/Kconfig +++ b/src/mainboard/lenovo/x60/Kconfig @@ -21,7 +21,6 @@ select BOARD_ROMSIZE_KB_2048 select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME - select USE_OPTION_TABLE select DRIVERS_LENOVO_WACOM select I945_LVDS select INTEL_GMA_HAVE_VBT -- To view, visit https://review.coreboot.org/c/coreboot/+/52855 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia9ef88d5158a2b43f843c26b5b366a899dad8788 Gerrit-Change-Number: 52855 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Attention: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/prodrive/hermes: Implement the mainboard option table interface
by Patrick Rudolph (Code Review) 03 May '21

03 May '21

Attention is currently required from: Martin Roth, Christian Walter, Angel Pons, Patrick Rudolph. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Christian Walter, Angel Pons, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52577 to look at the new patch set (#5). Change subject: mb/prodrive/hermes: Implement the mainboard option table interface ...................................................................... mb/prodrive/hermes: Implement the mainboard option table interface The board allows to configure firmware settings using the BMC's webUI and stores it in an I2C EEPROM. Implement mainboard_get_option and mainboard_set_option. TODO: The backend caches data and thus different stages might not see an updated variable at runtime. TODO: Clean EEPROM reading and writing code. Change-Id: I11fc342c5d422cc3d29392df9c53c7996d6f868e Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/mainboard/prodrive/hermes/Kconfig M src/mainboard/prodrive/hermes/Makefile.inc M src/mainboard/prodrive/hermes/eeprom.c M src/mainboard/prodrive/hermes/mainboard.c A src/mainboard/prodrive/hermes/option.c M src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h M src/southbridge/intel/common/Makefile.inc 7 files changed, 134 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/52577/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/52577 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I11fc342c5d422cc3d29392df9c53c7996d6f868e Gerrit-Change-Number: 52577 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: option: Add API for mainboard provided options
by Patrick Rudolph (Code Review) 03 May '21

03 May '21

Attention is currently required from: Bill XIE, Nico Huber, Patrick Rudolph, Christian Walter, Julius Werner, Kyösti Mälkki. Hello build bot (Jenkins), Bill XIE, Nico Huber, Christian Walter, Julius Werner, Kyösti Mälkki, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52601 to look at the new patch set (#2). Change subject: option: Add API for mainboard provided options ...................................................................... option: Add API for mainboard provided options This API can be implemented by mainboards providing a custom option storage. For example an external I2C EEPROM, IPMI on BMC, ... Update documentation accordingly. Change-Id: Ic5bbb5b3353d862c5533f90ced4824eec27ca3b9 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M Documentation/index.md A Documentation/lib/option.md M src/Kconfig 3 files changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/52601/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52601 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic5bbb5b3353d862c5533f90ced4824eec27ca3b9 Gerrit-Change-Number: 52601 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: [RFC] device: Introduce new method for setting device states
by Michael Niewöhner (Code Review) 03 May '21

03 May '21

Attention is currently required from: Felix Singer, Nico Huber, Raul Rangel, Furquan Shaikh, Matt DeVillier, Angel Pons, Patrick Rudolph, Felix Held. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52493 ) Change subject: [RFC] device: Introduce new method for setting device states ...................................................................... Patch Set 18: (1 comment) File src/soc/intel/skylake/chip.c: https://review.coreboot.org/c/coreboot/+/52493/comment/485d1e8e_2de29e61 PS13, Line 461: if (!xdci_can_enable()) : params->XdciEnable = 0; > Oh, no. Now you triggered the software engineer in me... […] Felix, what do you think? -- To view, visit https://review.coreboot.org/c/coreboot/+/52493 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70fde306c65a8881f565c5f923be20f380ea64d3 Gerrit-Change-Number: 52493 Gerrit-PatchSet: 18 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 03 May 2021 12:49:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [RFC] device: Introduce new method for setting device states
by Michael Niewöhner (Code Review) 03 May '21

03 May '21

Attention is currently required from: Felix Singer, Nico Huber, Raul Rangel, Furquan Shaikh, Matt DeVillier, Angel Pons, Patrick Rudolph, Felix Held. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52493 ) Change subject: [RFC] device: Introduce new method for setting device states ...................................................................... Patch Set 18: (1 comment) File src/include/device/devenmap.h: https://review.coreboot.org/c/coreboot/+/52493/comment/1d344510_6216da36 PS18, Line 17: const why was that readded? -- To view, visit https://review.coreboot.org/c/coreboot/+/52493 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70fde306c65a8881f565c5f923be20f380ea64d3 Gerrit-Change-Number: 52493 Gerrit-PatchSet: 18 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 03 May 2021 12:48:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp1_1: Remove verstage compilation units
by Frans Hendriks (Code Review) 03 May '21

03 May '21

Attention is currently required from: Lee Leahy, Huang Jin, Arthur Heymans, Patrick Rudolph. Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52785 ) Change subject: drivers/intel/fsp1_1: Remove verstage compilation units ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54361c835055907c2a4414ec26a1495425d4ef09 Gerrit-Change-Number: 52785 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Attention: Huang Jin <huang.jin(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 03 May 2021 12:47:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: security/vboot: Include fspt.bin in the RO region only
by Michał Żygowski (Code Review) 03 May '21

03 May '21

Attention is currently required from: Arthur Heymans, Aaron Durbin. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52853 ) Change subject: security/vboot: Include fspt.bin in the RO region only ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52853 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6fe29793fa638312c8b275b6fa8662df78b3b2bd Gerrit-Change-Number: 52853 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Mon, 03 May 2021 12:39:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021