Attention is currently required from: Felix Friedlander, Nico Huber, Martin Roth, Paul Menzel.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49233 )
Change subject: payloads/external/tianocore/Kconfig: elaborate help for TIANOCORE_BOOTSPLASH_FILE
......................................................................
Patch Set 1:
(1 comment)
File payloads/external/tianocore/Kconfig:
https://review.coreboot.org/c/coreboot/+/49233/comment/41778a8d_5b197c82
PS1, Line 100: and will be displayed slightly above the centre of
: the screen,
> That's also what I recall. However confusing reality might seem, the new […]
I'd prefer if this help text were more precise than just "substantially smaller": the boot splash image should be no wider than the pixel width of the panel/resolution set, and no taller than 76.4% of the pixel height of the panel/resolution set (100-(50-38.2)*2).
--
To view, visit https://review.coreboot.org/c/coreboot/+/49233
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4c6666bb0e49369fe8fe2ae3dc12c023f668da0
Gerrit-Change-Number: 49233
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Friedlander <felix(a)ffetc.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Friedlander <felix(a)ffetc.net>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Fri, 07 May 2021 03:05:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Friedlander <felix(a)ffetc.net>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: chris wang.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52900 )
Change subject: mb/google/mancomb: Update AMDFW config file
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/mancomb/variants/baseboard/amdfw.cfg:
https://review.coreboot.org/c/coreboot/+/52900/comment/900af606_90d3e25a
PS1, Line 37: PSP_PMUI_FILE1 TypeId0x65_Appb_CZN_1D_Ddr4_Udimm_Dmem.csbin
: PSP_PMUD_FILE2 TypeId0x64_Appb_CZN_2D_Ddr4_Udimm_Imem.csbin
> It should like below. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/52900
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc4dc8aec2053cb177765f57e57cac7a099508fe
Gerrit-Change-Number: 52900
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-CC: chris wang <Chris.Wang(a)amd.com>
Gerrit-Attention: chris wang <Chris.Wang(a)amd.com>
Gerrit-Comment-Date: Fri, 07 May 2021 02:54:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Comment-In-Reply-To: chris wang <Chris.Wang(a)amd.com>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52925 )
Change subject: soc/mediatek/mt8195: Turn off L2C SRAM and reconfigure as L2 cache
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52925
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8777b0c8471fe17ffffdcb6ad5b7c00fb1d35db1
Gerrit-Change-Number: 52925
Gerrit-PatchSet: 4
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidi.lin(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Comment-Date: Fri, 07 May 2021 02:27:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Vinod Polimera, Douglas Anderson, Julius Werner.
Xuxin Xiong has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52959 )
Change subject: drivers/sn65dsi86: Switch EDID reading to use "indirect mode"
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
I tested this CL in trogdor firmware branch, and it works well.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52959
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65f80193380d3c3841f9f5c26897ed672f45e15a
Gerrit-Change-Number: 52959
Gerrit-PatchSet: 4
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Douglas Anderson <dianders(a)chromium.org>
Gerrit-Reviewer: Vinod Polimera <vpolimer(a)qualcomm.corp-partner.google.com>
Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-CC: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Attention: Vinod Polimera <vpolimer(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Douglas Anderson <dianders(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Fri, 07 May 2021 01:56:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Kevin Chang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/53890 )
Change subject: mb/google/volteer/variant/lindar: Increase Cbfs Mcache size
......................................................................
mb/google/volteer/variant/lindar: Increase Cbfs Mcache size
Increase Cbfs Mcache size for FAFT fail test item.
BUG=b:162052593
TEST=Build FW and boot to OS and test FAFT fail test item.
Signed-off-by: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Change-Id: I84f4f3d7c35165eba9c446ed6658f5bba15c5cfe
---
M src/arch/x86/Kconfig
M src/lib/Kconfig
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/53890/1
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig
index bb03db2..8ad83bc 100644
--- a/src/arch/x86/Kconfig
+++ b/src/arch/x86/Kconfig
@@ -145,7 +145,7 @@
Increase this value if preram cbmem console is getting truncated
config CBFS_MCACHE_SIZE
- hex
+ hex "CBFS mcache size"
depends on !NO_CBFS_MCACHE
default 0x2000
help
diff --git a/src/lib/Kconfig b/src/lib/Kconfig
index e1d56fe..e78629a 100644
--- a/src/lib/Kconfig
+++ b/src/lib/Kconfig
@@ -100,7 +100,7 @@
the respective file.
config CBFS_MCACHE_RW_PERCENTAGE
- int
+ int "percentage of the rw mcache"
depends on VBOOT && !NO_CBFS_MCACHE
default 25 if CHROMEOS # Chrome OS stores many L10n files in RO only
default 50
--
To view, visit https://review.coreboot.org/c/coreboot/+/53890
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I84f4f3d7c35165eba9c446ed6658f5bba15c5cfe
Gerrit-Change-Number: 53890
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Karthik Ramasubramanian.
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52887 )
Change subject: mb/google/dedede: Add a variant callback to update devicetree config
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/dedede/variants/metaknight/variant.c:
https://review.coreboot.org/c/coreboot/+/52887/comment/29d0a11b_2462cad9
PS2, Line 36: /* Set 1A HDMI configuration */
> Leave USB Port A as a default configuration in the devicetree. […]
Thanks.
https://review.coreboot.org/c/coreboot/+/52887/comment/48cc041f_6427a8b1
PS2, Line 38: /* Set LTE HDMI configuration */
> Configure the settings as in the devicetree. […]
Thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52887
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I857211bfc4beb36ab225f3786c1707336a34aae9
Gerrit-Change-Number: 52887
Gerrit-PatchSet: 3
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Fri, 07 May 2021 01:09:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment