coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: mb/asus/p8z77-v_lx2: Extract overridetree
by Angel Pons (Code Review) 17 May '21

17 May '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54413 ) Change subject: mb/asus/p8z77-v_lx2: Extract overridetree ...................................................................... mb/asus/p8z77-v_lx2: Extract overridetree Tested with BUILD_TIMELESS=1, coreboot.rom for the Asus P8Z77-V LX2 remains identical when not adding the .config file in it. Change-Id: Ia84b07f5fec3c2969134b0d0bc39248d50ac04ff Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/asus/p8z77-series/Kconfig A src/mainboard/asus/p8z77-series/devicetree.cb R src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/overridetree.cb 3 files changed, 68 insertions(+), 36 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/54413/1 diff --git a/src/mainboard/asus/p8z77-series/Kconfig b/src/mainboard/asus/p8z77-series/Kconfig index d09b3cb..d963b09 100644 --- a/src/mainboard/asus/p8z77-series/Kconfig +++ b/src/mainboard/asus/p8z77-series/Kconfig @@ -29,10 +29,22 @@ default "P8Z77-M PRO" if BOARD_ASUS_P8Z77_M_PRO default "P8Z77-V LX2" if BOARD_ASUS_P8Z77_V_LX2 +# TODO: remove once all boards use overridetrees +if BOARD_ASUS_P8Z77_M_PRO + config DEVICETREE string default "variants/\$(CONFIG_VARIANT_DIR)/devicetree.cb" +endif +if !BOARD_ASUS_P8Z77_M_PRO + +config OVERRIDE_DEVICETREE + string + default "variants/\$(CONFIG_VARIANT_DIR)/overridetree.cb" + +endif + config CMOS_DEFAULT_FILE default "src/mainboard/\$(MAINBOARDDIR)/variants/\$(CONFIG_VARIANT_DIR)/cmos.default" diff --git a/src/mainboard/asus/p8z77-series/devicetree.cb b/src/mainboard/asus/p8z77-series/devicetree.cb new file mode 100644 index 0000000..1b9d14d --- /dev/null +++ b/src/mainboard/asus/p8z77-series/devicetree.cb @@ -0,0 +1,56 @@ +## SPDX-License-Identifier: GPL-2.0-only + +chip northbridge/intel/sandybridge + device cpu_cluster 0 on + chip cpu/intel/model_206ax + register "acpi_c1" = "1" + register "acpi_c2" = "3" + register "acpi_c3" = "5" + device lapic 0 on end + device lapic 0xacac off end + end + end + device domain 0 on + device pci 00.0 on end # Host bridge + device pci 01.0 on end # PCIEX16_1 + device pci 02.0 on end # iGPU + + chip southbridge/intel/bd82x6x + register "c2_latency" = "0x0065" + register "sata_interface_speed_support" = "0x3" + register "sata_port_map" = "0x3f" + register "spi_lvscc" = "0x2005" + register "spi_uvscc" = "0x2005" + register "superspeed_capable_ports" = "0x0000000f" + register "xhci_overcurrent_mapping" = "0x00000c03" + register "xhci_switchable_ports" = "0x0000000f" + + device pci 14.0 on end # xHCI + device pci 16.0 on end # MEI #1 + device pci 16.1 off end # MEI #2 + device pci 16.2 off end # ME IDE-R + device pci 16.3 off end # ME KT + device pci 19.0 off end # Intel GbE + device pci 1a.0 on end # EHCI #2 + device pci 1b.0 on end # HD Audio + + device pci 1c.0 off end # RP #1 + device pci 1c.1 off end # RP #2 + device pci 1c.2 off end # RP #3 + device pci 1c.3 off end # RP #4 + device pci 1c.4 off end # RP #5 + device pci 1c.5 off end # RP #6 + device pci 1c.6 off end # RP #7 + device pci 1c.7 off end # RP #8 + + device pci 1d.0 on end # EHCI #1 + device pci 1e.0 off end # PCI bridge + device pci 1f.0 on # LPC bridge + end + device pci 1f.2 on end # SATA (AHCI) + device pci 1f.3 on end # SMBus + device pci 1f.5 off end # SATA (Legacy) + device pci 1f.6 off end # Thermal + end + end +end diff --git a/src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/devicetree.cb b/src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/overridetree.cb similarity index 60% rename from src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/devicetree.cb rename to src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/overridetree.cb index 40f8e6d..6be23fa 100644 --- a/src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/devicetree.cb +++ b/src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/overridetree.cb @@ -1,40 +1,10 @@ ## SPDX-License-Identifier: GPL-2.0-only chip northbridge/intel/sandybridge - device cpu_cluster 0 on - chip cpu/intel/model_206ax - register "acpi_c1" = "1" - register "acpi_c2" = "3" - register "acpi_c3" = "5" - device lapic 0 on end - device lapic 0xacac off end - end - end device domain 0 on subsystemid 0x1043 0x84ca inherit - device pci 00.0 on end # Host bridge - device pci 01.0 on end # PCIEX16_1 - device pci 02.0 on end # iGPU - chip southbridge/intel/bd82x6x - register "c2_latency" = "0x0065" register "gen1_dec" = "0x000c0291" - register "sata_interface_speed_support" = "0x3" - register "sata_port_map" = "0x3f" - register "spi_lvscc" = "0x2005" - register "spi_uvscc" = "0x2005" - register "superspeed_capable_ports" = "0x0000000f" - register "xhci_overcurrent_mapping" = "0x00000c03" - register "xhci_switchable_ports" = "0x0000000f" - - device pci 14.0 on end # xHCI - device pci 16.0 on end # MEI #1 - device pci 16.1 off end # MEI #2 - device pci 16.2 off end # ME IDE-R - device pci 16.3 off end # ME KT - device pci 19.0 off end # Intel GbE - device pci 1a.0 on end # EHCI #2 - device pci 1b.0 on end # HD Audio device pci 1c.0 on end # RP #1: PCIEX16_2 (electrical x4) device pci 1c.1 off end # RP #2: @@ -45,8 +15,6 @@ device pci 1c.6 on end # RP #7: PCIEX1_1 device pci 1c.7 on end # RP #8: PCIEX1_2 - device pci 1d.0 on end # EHCI #1 - device pci 1e.0 off end # PCI bridge device pci 1f.0 on # LPC bridge chip superio/nuvoton/nct6779d device pnp 2e.1 off end # Parallel @@ -88,10 +56,6 @@ device pnp 2e.16 off end # Deep Sleep end end - device pci 1f.2 on end # SATA (AHCI) - device pci 1f.3 on end # SMBus - device pci 1f.5 off end # SATA (Legacy) - device pci 1f.6 off end # Thermal end end end -- To view, visit https://review.coreboot.org/c/coreboot/+/54413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia84b07f5fec3c2969134b0d0bc39248d50ac04ff Gerrit-Change-Number: 54413 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/google/chromeec: Implement support for DRIVERS_ACPI_THERMAL_ZONE
by Raul Rangel (Code Review) 17 May '21

17 May '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54133 ) Change subject: ec/google/chromeec: Implement support for DRIVERS_ACPI_THERMAL_ZONE ...................................................................... Patch Set 2: (1 comment) File src/ec/google/chromeec/ec_acpi.c: https://review.coreboot.org/c/coreboot/+/54133/comment/50dbc280_ef1c25c1 PS2, Line 267: : void google_chromeec_acpigen_write_TMP(const struct device *dev) : { : struct drivers_acpi_thermal_zone_config *config = config_of(dev); : static char buf[DEVICE_PATH_MAX] = {}; : const char *ec_path = acpi_device_path(config->temperature_controller); : : /* : * The cros EC device returns EC0.CREC as the acpi_name. The method : * we want is on the EC0 device. : */ : snprintf(buf, sizeof(buf), "%.*s.TSRD", strlen(ec_path) - 5, : acpi_device_path(config->temperature_controller)); : : acpigen_write_method_serialized("_TMP", 0); : : acpigen_emit_byte(RETURN_OP); : acpigen_emit_namestring(buf); : acpigen_write_integer(config->sensor_id); : : acpigen_write_method_end(); : } > consider a refactor? https://review.coreboot. […] Can we inject the EC0 device into the device tree at runtime? I'm not sure how complicated it is to update all the pointers though... -- To view, visit https://review.coreboot.org/c/coreboot/+/54133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I418b6691a7d00a4c2d89c9c1fe8f9416602be0f1 Gerrit-Change-Number: 54133 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Mon, 17 May 2021 16:10:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sc7280: add qclib support
by Shelley Chen (Code Review) 17 May '21

17 May '21

Attention is currently required from: Ravi kumar, Martin Roth, mturney mturney, Julius Werner, Sudheer Amrabadi. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50582 ) Change subject: sc7280: add qclib support ...................................................................... Patch Set 36: (1 comment) Patchset: PS35: > Ravi, can you please for reference put the qclib version (BOOT. […] Thank you! However, I think that you uploaded on an old checkout. You need to rebased on top of latest head, mainly make sure https://review.coreboot.org/c/coreboot/+/54037 is in your repo. -- To view, visit https://review.coreboot.org/c/coreboot/+/50582 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d400f0ad96dbef2e45cc1f11ed17ea95fc60d16 Gerrit-Change-Number: 50582 Gerrit-PatchSet: 36 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Sudheer Amrabadi <samrab(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Sudheer Amrabadi <samrab(a)codeaurora.org> Gerrit-Comment-Date: Mon, 17 May 2021 16:09:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shelley Chen <shchen(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: LGA1155 boards: Drop `VGA_BIOS_{FILE,ID}` for iGPU
by Arthur Heymans (Code Review) 17 May '21

17 May '21

Attention is currently required from: Tristan Corrick, Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54361 ) Change subject: LGA1155 boards: Drop `VGA_BIOS_{FILE,ID}` for iGPU ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: note that Seabios supports aliasing cbfs files. -- To view, visit https://review.coreboot.org/c/coreboot/+/54361 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee6749e4fb691f09664cc6ffb3cbf66e4230fa9c Gerrit-Change-Number: 54361 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 17 May 2021 16:06:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/asus/p8z77-series: Always select `INTEL_INT15`
by Angel Pons (Code Review) 17 May '21

17 May '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54412 ) Change subject: mb/asus/p8z77-series: Always select `INTEL_INT15` ...................................................................... mb/asus/p8z77-series: Always select `INTEL_INT15` The mainboard.c guard was only added to preserve reproducibility when unifying the boards. The `install_intel_vga_int15_handler` function does nothing when `VGA_ROM_RUN` is not selected. Remove the guard and always select `INTEL_INT15` for simplicity. Change-Id: If38ca49dba81921a3e7abe22542ae74d8914a38d Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/asus/p8z77-series/Kconfig M src/mainboard/asus/p8z77-series/Kconfig.name M src/mainboard/asus/p8z77-series/mainboard.c 3 files changed, 1 insertion(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/54412/1 diff --git a/src/mainboard/asus/p8z77-series/Kconfig b/src/mainboard/asus/p8z77-series/Kconfig index 8927ff5..d09b3cb 100644 --- a/src/mainboard/asus/p8z77-series/Kconfig +++ b/src/mainboard/asus/p8z77-series/Kconfig @@ -7,6 +7,7 @@ select HAVE_CMOS_DEFAULT select HAVE_OPTION_TABLE select INTEL_GMA_HAVE_VBT + select INTEL_INT15 select MAINBOARD_HAS_LIBGFXINIT select NORTHBRIDGE_INTEL_SANDYBRIDGE select SERIRQ_CONTINUOUS_MODE diff --git a/src/mainboard/asus/p8z77-series/Kconfig.name b/src/mainboard/asus/p8z77-series/Kconfig.name index 44dae81..d4725b4 100644 --- a/src/mainboard/asus/p8z77-series/Kconfig.name +++ b/src/mainboard/asus/p8z77-series/Kconfig.name @@ -3,7 +3,6 @@ select BOARD_ASUS_P8Z77_SERIES select BOARD_ROMSIZE_KB_8192 select DRIVERS_ASMEDIA_ASPM_BLACKLIST # for ASM1061 eSATA - select INTEL_INT15 select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_TPM1 select SUPERIO_NUVOTON_NCT6779D diff --git a/src/mainboard/asus/p8z77-series/mainboard.c b/src/mainboard/asus/p8z77-series/mainboard.c index bc45baf..ac992f6 100644 --- a/src/mainboard/asus/p8z77-series/mainboard.c +++ b/src/mainboard/asus/p8z77-series/mainboard.c @@ -1,8 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -/* TODO: remove */ -#if CONFIG(INTEL_INT15) - #include <device/device.h> #include <drivers/intel/gma/int15.h> @@ -17,5 +14,3 @@ struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable }; - -#endif -- To view, visit https://review.coreboot.org/c/coreboot/+/54412 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If38ca49dba81921a3e7abe22542ae74d8914a38d Gerrit-Change-Number: 54412 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/asus/p8z77-m_pro: Transform into variant
by Angel Pons (Code Review) 17 May '21

17 May '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54411 ) Change subject: mb/asus/p8z77-m_pro: Transform into variant ...................................................................... mb/asus/p8z77-m_pro: Transform into variant To preserve reproducibility, temporarily guard mainboard.c contents. Tested with BUILD_TIMELESS=1, coreboot.rom for the Asus P8Z77-M PRO remains identical when not adding the .config file in it. Change-Id: I05e272690ca78f6b9e22b1db1c36cb9e5a7afe3c Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M MAINTAINERS D src/mainboard/asus/p8z77-m_pro/Kconfig D src/mainboard/asus/p8z77-m_pro/Kconfig.name D src/mainboard/asus/p8z77-m_pro/Makefile.inc D src/mainboard/asus/p8z77-m_pro/acpi/ec.asl D src/mainboard/asus/p8z77-m_pro/acpi/platform.asl D src/mainboard/asus/p8z77-m_pro/acpi/superio.asl D src/mainboard/asus/p8z77-m_pro/dsdt.asl M src/mainboard/asus/p8z77-series/Kconfig M src/mainboard/asus/p8z77-series/Kconfig.name R src/mainboard/asus/p8z77-series/mainboard.c R src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/board_info.txt R src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/cmos.default R src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/cmos.layout R src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/data.vbt R src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/devicetree.cb R src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/early_init.c R src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/gma-mainboard.ads R src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/gpio.c R src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/hda_verb.c 20 files changed, 18 insertions(+), 88 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/54411/1 diff --git a/MAINTAINERS b/MAINTAINERS index f6ee6dd..74f1854 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -196,13 +196,9 @@ S: Maintained F: src/mainboard/asus/p5qpl-am/ -ASUS P8Z77-M PRO MAINBOARD -M: Vlado Cibic <vladocb(a)protonmail.com> -S: Maintained -F: src/mainboard/asus/p8z77-m_pro/ - ASUS P8Z77 SERIES MAINBOARDS M: Angel Pons <th3fanbus(a)gmail.com> +M: Vlado Cibic <vladocb(a)protonmail.com> S: Maintained F: src/mainboard/asus/p8z77-series/ diff --git a/src/mainboard/asus/p8z77-m_pro/Kconfig b/src/mainboard/asus/p8z77-m_pro/Kconfig deleted file mode 100644 index 19a1fe1..0000000 --- a/src/mainboard/asus/p8z77-m_pro/Kconfig +++ /dev/null @@ -1,31 +0,0 @@ -## SPDX-License-Identifier: GPL-2.0-only - -if BOARD_ASUS_P8Z77_M_PRO - -config BOARD_SPECIFIC_OPTIONS - def_bool y - select BOARD_ROMSIZE_KB_8192 - select HAVE_ACPI_RESUME - select HAVE_ACPI_TABLES - select INTEL_INT15 - select NORTHBRIDGE_INTEL_SANDYBRIDGE - select SERIRQ_CONTINUOUS_MODE - select SOUTHBRIDGE_INTEL_C216 - select MAINBOARD_HAS_LPC_TPM - select MAINBOARD_HAS_TPM1 - select HAVE_OPTION_TABLE - select HAVE_CMOS_DEFAULT - select MAINBOARD_HAS_LIBGFXINIT - select INTEL_GMA_HAVE_VBT - select SUPERIO_NUVOTON_NCT6779D - select DRIVERS_ASMEDIA_ASPM_BLACKLIST # for ASM1061 eSATA - -config MAINBOARD_DIR - string - default "asus/p8z77-m_pro" - -config MAINBOARD_PART_NUMBER - string - default "P8Z77-M PRO" - -endif # BOARD_ASUS_P8Z77_M_PRO diff --git a/src/mainboard/asus/p8z77-m_pro/Kconfig.name b/src/mainboard/asus/p8z77-m_pro/Kconfig.name deleted file mode 100644 index 372ec4a..0000000 --- a/src/mainboard/asus/p8z77-m_pro/Kconfig.name +++ /dev/null @@ -1,4 +0,0 @@ -## SPDX-License-Identifier: GPL-2.0-only - -config BOARD_ASUS_P8Z77_M_PRO - bool "P8Z77-M PRO" diff --git a/src/mainboard/asus/p8z77-m_pro/Makefile.inc b/src/mainboard/asus/p8z77-m_pro/Makefile.inc deleted file mode 100644 index 26b20d7..0000000 --- a/src/mainboard/asus/p8z77-m_pro/Makefile.inc +++ /dev/null @@ -1,8 +0,0 @@ -## SPDX-License-Identifier: GPL-2.0-or-later - -bootblock-y += gpio.c -romstage-y += gpio.c - -ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads -bootblock-y += early_init.c -romstage-y += early_init.c diff --git a/src/mainboard/asus/p8z77-m_pro/acpi/ec.asl b/src/mainboard/asus/p8z77-m_pro/acpi/ec.asl deleted file mode 100644 index 8b13789..0000000 --- a/src/mainboard/asus/p8z77-m_pro/acpi/ec.asl +++ /dev/null @@ -1 +0,0 @@ - diff --git a/src/mainboard/asus/p8z77-m_pro/acpi/platform.asl b/src/mainboard/asus/p8z77-m_pro/acpi/platform.asl deleted file mode 100644 index 90cf05b..0000000 --- a/src/mainboard/asus/p8z77-m_pro/acpi/platform.asl +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -Method(_PTS,1) -{ -} - -Method(_WAK,1) -{ - Return(Package(){0,0}) -} diff --git a/src/mainboard/asus/p8z77-m_pro/acpi/superio.asl b/src/mainboard/asus/p8z77-m_pro/acpi/superio.asl deleted file mode 100644 index ee2eabe..0000000 --- a/src/mainboard/asus/p8z77-m_pro/acpi/superio.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <drivers/pc80/pc/ps2_controller.asl> diff --git a/src/mainboard/asus/p8z77-m_pro/dsdt.asl b/src/mainboard/asus/p8z77-m_pro/dsdt.asl deleted file mode 100644 index 19a528f..0000000 --- a/src/mainboard/asus/p8z77-m_pro/dsdt.asl +++ /dev/null @@ -1,26 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <acpi/acpi.h> -DefinitionBlock( - "dsdt.aml", - "DSDT", - ACPI_DSDT_REV_2, - OEM_ID, - ACPI_TABLE_CREATOR, - 0x20141018 /* OEM revision */ -) -{ - #include <acpi/dsdt_top.asl> - #include "acpi/platform.asl" - #include <cpu/intel/common/acpi/cpu.asl> - #include <southbridge/intel/common/acpi/platform.asl> - - #include <southbridge/intel/bd82x6x/acpi/globalnvs.asl> - #include <southbridge/intel/common/acpi/sleepstates.asl> - - Device (\_SB.PCI0) - { - #include <northbridge/intel/sandybridge/acpi/sandybridge.asl> - #include <southbridge/intel/bd82x6x/acpi/pch.asl> - } -} diff --git a/src/mainboard/asus/p8z77-series/Kconfig b/src/mainboard/asus/p8z77-series/Kconfig index 99c76a0..8927ff5 100644 --- a/src/mainboard/asus/p8z77-series/Kconfig +++ b/src/mainboard/asus/p8z77-series/Kconfig @@ -20,10 +20,12 @@ config VARIANT_DIR string + default "p8z77-m_pro" if BOARD_ASUS_P8Z77_M_PRO default "p8z77-v_lx2" if BOARD_ASUS_P8Z77_V_LX2 config MAINBOARD_PART_NUMBER string + default "P8Z77-M PRO" if BOARD_ASUS_P8Z77_M_PRO default "P8Z77-V LX2" if BOARD_ASUS_P8Z77_V_LX2 config DEVICETREE diff --git a/src/mainboard/asus/p8z77-series/Kconfig.name b/src/mainboard/asus/p8z77-series/Kconfig.name index 4ab8943..44dae81 100644 --- a/src/mainboard/asus/p8z77-series/Kconfig.name +++ b/src/mainboard/asus/p8z77-series/Kconfig.name @@ -1,3 +1,13 @@ +config BOARD_ASUS_P8Z77_M_PRO + bool "P8Z77-M PRO" + select BOARD_ASUS_P8Z77_SERIES + select BOARD_ROMSIZE_KB_8192 + select DRIVERS_ASMEDIA_ASPM_BLACKLIST # for ASM1061 eSATA + select INTEL_INT15 + select MAINBOARD_HAS_LPC_TPM + select MAINBOARD_HAS_TPM1 + select SUPERIO_NUVOTON_NCT6779D + config BOARD_ASUS_P8Z77_V_LX2 bool "P8Z77-V LX2" select BOARD_ASUS_P8Z77_SERIES diff --git a/src/mainboard/asus/p8z77-m_pro/mainboard.c b/src/mainboard/asus/p8z77-series/mainboard.c similarity index 87% rename from src/mainboard/asus/p8z77-m_pro/mainboard.c rename to src/mainboard/asus/p8z77-series/mainboard.c index ac992f6..bc45baf 100644 --- a/src/mainboard/asus/p8z77-m_pro/mainboard.c +++ b/src/mainboard/asus/p8z77-series/mainboard.c @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +/* TODO: remove */ +#if CONFIG(INTEL_INT15) + #include <device/device.h> #include <drivers/intel/gma/int15.h> @@ -14,3 +17,5 @@ struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable }; + +#endif diff --git a/src/mainboard/asus/p8z77-m_pro/board_info.txt b/src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/board_info.txt similarity index 100% rename from src/mainboard/asus/p8z77-m_pro/board_info.txt rename to src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/board_info.txt diff --git a/src/mainboard/asus/p8z77-m_pro/cmos.default b/src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/cmos.default similarity index 100% rename from src/mainboard/asus/p8z77-m_pro/cmos.default rename to src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/cmos.default diff --git a/src/mainboard/asus/p8z77-m_pro/cmos.layout b/src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/cmos.layout similarity index 100% rename from src/mainboard/asus/p8z77-m_pro/cmos.layout rename to src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/cmos.layout diff --git a/src/mainboard/asus/p8z77-m_pro/data.vbt b/src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/data.vbt similarity index 100% rename from src/mainboard/asus/p8z77-m_pro/data.vbt rename to src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/data.vbt Binary files differ diff --git a/src/mainboard/asus/p8z77-m_pro/devicetree.cb b/src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/devicetree.cb similarity index 100% rename from src/mainboard/asus/p8z77-m_pro/devicetree.cb rename to src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/devicetree.cb diff --git a/src/mainboard/asus/p8z77-m_pro/early_init.c b/src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/early_init.c similarity index 100% rename from src/mainboard/asus/p8z77-m_pro/early_init.c rename to src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/early_init.c diff --git a/src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads b/src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/gma-mainboard.ads similarity index 100% rename from src/mainboard/asus/p8z77-m_pro/gma-mainboard.ads rename to src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/gma-mainboard.ads diff --git a/src/mainboard/asus/p8z77-m_pro/gpio.c b/src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/gpio.c similarity index 100% rename from src/mainboard/asus/p8z77-m_pro/gpio.c rename to src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/gpio.c diff --git a/src/mainboard/asus/p8z77-m_pro/hda_verb.c b/src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/hda_verb.c similarity index 100% rename from src/mainboard/asus/p8z77-m_pro/hda_verb.c rename to src/mainboard/asus/p8z77-series/variants/p8z77-m_pro/hda_verb.c -- To view, visit https://review.coreboot.org/c/coreboot/+/54411 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05e272690ca78f6b9e22b1db1c36cb9e5a7afe3c Gerrit-Change-Number: 54411 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/asus/p8z77-m_pro: Reorder `_PTS` and `_WAK`
by Angel Pons (Code Review) 17 May '21

17 May '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54410 ) Change subject: mb/asus/p8z77-m_pro: Reorder `_PTS` and `_WAK` ...................................................................... mb/asus/p8z77-m_pro: Reorder `_PTS` and `_WAK` Done to preserve reproducibility when switching to a variant setup. Change-Id: I4f3663d3b58c6245c9b73d370a48b8745ea5b95b Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/asus/p8z77-m_pro/acpi/platform.asl 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/54410/1 diff --git a/src/mainboard/asus/p8z77-m_pro/acpi/platform.asl b/src/mainboard/asus/p8z77-m_pro/acpi/platform.asl index 7b1b2b2..90cf05b 100644 --- a/src/mainboard/asus/p8z77-m_pro/acpi/platform.asl +++ b/src/mainboard/asus/p8z77-m_pro/acpi/platform.asl @@ -1,10 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ +Method(_PTS,1) +{ +} + Method(_WAK,1) { Return(Package(){0,0}) } - -Method(_PTS,1) -{ -} -- To view, visit https://review.coreboot.org/c/coreboot/+/54410 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f3663d3b58c6245c9b73d370a48b8745ea5b95b Gerrit-Change-Number: 54410 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/asus/p8z77-v_lx2: Transform into variant setup
by Angel Pons (Code Review) 17 May '21

17 May '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54409 ) Change subject: mb/asus/p8z77-v_lx2: Transform into variant setup ...................................................................... mb/asus/p8z77-v_lx2: Transform into variant setup Get ready to squash all Asus Z77 boards together, so as to factor out some redundant code. Tested with BUILD_TIMELESS=1, coreboot.rom for the Asus P8Z77-V LX2 remains identical when not adding the .config file in it. Change-Id: I701ec4adbc65732ffc0a60d311bf07bf7f414ebf Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M MAINTAINERS A src/mainboard/asus/p8z77-series/Kconfig A src/mainboard/asus/p8z77-series/Kconfig.name A src/mainboard/asus/p8z77-series/Makefile.inc R src/mainboard/asus/p8z77-series/acpi/ec.asl R src/mainboard/asus/p8z77-series/acpi/platform.asl R src/mainboard/asus/p8z77-series/acpi/superio.asl A src/mainboard/asus/p8z77-series/board_info.txt R src/mainboard/asus/p8z77-series/dsdt.asl C src/mainboard/asus/p8z77-series/hda_verb.c R src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/board_info.txt R src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/cmos.default R src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/cmos.layout R src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/data.vbt R src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/devicetree.cb R src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/early_init.c R src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/gma-mainboard.ads R src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/gpio.c R src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/hda_verb.c D src/mainboard/asus/p8z77-v_lx2/Kconfig D src/mainboard/asus/p8z77-v_lx2/Kconfig.name D src/mainboard/asus/p8z77-v_lx2/Makefile.inc 22 files changed, 61 insertions(+), 40 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/54409/1 diff --git a/MAINTAINERS b/MAINTAINERS index 6a668e5..f6ee6dd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -201,10 +201,10 @@ S: Maintained F: src/mainboard/asus/p8z77-m_pro/ -ASUS P8Z77-V LX2 MAINBOARD +ASUS P8Z77 SERIES MAINBOARDS M: Angel Pons <th3fanbus(a)gmail.com> S: Maintained -F: src/mainboard/asus/p8z77-v_lx2/ +F: src/mainboard/asus/p8z77-series/ diff --git a/src/mainboard/asus/p8z77-series/Kconfig b/src/mainboard/asus/p8z77-series/Kconfig new file mode 100644 index 0000000..99c76a0 --- /dev/null +++ b/src/mainboard/asus/p8z77-series/Kconfig @@ -0,0 +1,39 @@ +## SPDX-License-Identifier: GPL-2.0-only + +config BOARD_ASUS_P8Z77_SERIES + bool + select HAVE_ACPI_RESUME + select HAVE_ACPI_TABLES + select HAVE_CMOS_DEFAULT + select HAVE_OPTION_TABLE + select INTEL_GMA_HAVE_VBT + select MAINBOARD_HAS_LIBGFXINIT + select NORTHBRIDGE_INTEL_SANDYBRIDGE + select SERIRQ_CONTINUOUS_MODE + select SOUTHBRIDGE_INTEL_C216 + +if BOARD_ASUS_P8Z77_SERIES + +config MAINBOARD_DIR + string + default "asus/p8z77-series" + +config VARIANT_DIR + string + default "p8z77-v_lx2" if BOARD_ASUS_P8Z77_V_LX2 + +config MAINBOARD_PART_NUMBER + string + default "P8Z77-V LX2" if BOARD_ASUS_P8Z77_V_LX2 + +config DEVICETREE + string + default "variants/\$(CONFIG_VARIANT_DIR)/devicetree.cb" + +config CMOS_DEFAULT_FILE + default "src/mainboard/\$(MAINBOARDDIR)/variants/\$(CONFIG_VARIANT_DIR)/cmos.default" + +config CMOS_LAYOUT_FILE + default "src/mainboard/\$(MAINBOARDDIR)/variants/\$(CONFIG_VARIANT_DIR)/cmos.layout" + +endif diff --git a/src/mainboard/asus/p8z77-series/Kconfig.name b/src/mainboard/asus/p8z77-series/Kconfig.name new file mode 100644 index 0000000..4ab8943 --- /dev/null +++ b/src/mainboard/asus/p8z77-series/Kconfig.name @@ -0,0 +1,7 @@ +config BOARD_ASUS_P8Z77_V_LX2 + bool "P8Z77-V LX2" + select BOARD_ASUS_P8Z77_SERIES + select BOARD_ROMSIZE_KB_8192 + select REALTEK_8168_RESET + select SUPERIO_NUVOTON_NCT6779D + select USE_NATIVE_RAMINIT diff --git a/src/mainboard/asus/p8z77-series/Makefile.inc b/src/mainboard/asus/p8z77-series/Makefile.inc new file mode 100644 index 0000000..e339285 --- /dev/null +++ b/src/mainboard/asus/p8z77-series/Makefile.inc @@ -0,0 +1,8 @@ +## SPDX-License-Identifier: GPL-2.0-only + +bootblock-y += variants/$(VARIANT_DIR)/early_init.c +romstage-y += variants/$(VARIANT_DIR)/early_init.c +bootblock-y += variants/$(VARIANT_DIR)/gpio.c +romstage-y += variants/$(VARIANT_DIR)/gpio.c +ramstage-y += variants/$(VARIANT_DIR)/hda_verb.c +ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += variants/$(VARIANT_DIR)/gma-mainboard.ads diff --git a/src/mainboard/asus/p8z77-v_lx2/acpi/ec.asl b/src/mainboard/asus/p8z77-series/acpi/ec.asl similarity index 100% rename from src/mainboard/asus/p8z77-v_lx2/acpi/ec.asl rename to src/mainboard/asus/p8z77-series/acpi/ec.asl diff --git a/src/mainboard/asus/p8z77-v_lx2/acpi/platform.asl b/src/mainboard/asus/p8z77-series/acpi/platform.asl similarity index 100% rename from src/mainboard/asus/p8z77-v_lx2/acpi/platform.asl rename to src/mainboard/asus/p8z77-series/acpi/platform.asl diff --git a/src/mainboard/asus/p8z77-v_lx2/acpi/superio.asl b/src/mainboard/asus/p8z77-series/acpi/superio.asl similarity index 100% rename from src/mainboard/asus/p8z77-v_lx2/acpi/superio.asl rename to src/mainboard/asus/p8z77-series/acpi/superio.asl diff --git a/src/mainboard/asus/p8z77-series/board_info.txt b/src/mainboard/asus/p8z77-series/board_info.txt new file mode 100644 index 0000000..8f74c04 --- /dev/null +++ b/src/mainboard/asus/p8z77-series/board_info.txt @@ -0,0 +1,5 @@ +Category: desktop +ROM package: DIP-8 +ROM protocol: SPI +ROM socketed: y +Flashrom support: y diff --git a/src/mainboard/asus/p8z77-v_lx2/dsdt.asl b/src/mainboard/asus/p8z77-series/dsdt.asl similarity index 100% rename from src/mainboard/asus/p8z77-v_lx2/dsdt.asl rename to src/mainboard/asus/p8z77-series/dsdt.asl diff --git a/src/mainboard/asus/p8z77-v_lx2/acpi/ec.asl b/src/mainboard/asus/p8z77-series/hda_verb.c similarity index 100% copy from src/mainboard/asus/p8z77-v_lx2/acpi/ec.asl copy to src/mainboard/asus/p8z77-series/hda_verb.c diff --git a/src/mainboard/asus/p8z77-v_lx2/board_info.txt b/src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/board_info.txt similarity index 100% rename from src/mainboard/asus/p8z77-v_lx2/board_info.txt rename to src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/board_info.txt diff --git a/src/mainboard/asus/p8z77-v_lx2/cmos.default b/src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/cmos.default similarity index 100% rename from src/mainboard/asus/p8z77-v_lx2/cmos.default rename to src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/cmos.default diff --git a/src/mainboard/asus/p8z77-v_lx2/cmos.layout b/src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/cmos.layout similarity index 100% rename from src/mainboard/asus/p8z77-v_lx2/cmos.layout rename to src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/cmos.layout diff --git a/src/mainboard/asus/p8z77-v_lx2/data.vbt b/src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/data.vbt similarity index 100% rename from src/mainboard/asus/p8z77-v_lx2/data.vbt rename to src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/data.vbt Binary files differ diff --git a/src/mainboard/asus/p8z77-v_lx2/devicetree.cb b/src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/devicetree.cb similarity index 100% rename from src/mainboard/asus/p8z77-v_lx2/devicetree.cb rename to src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/devicetree.cb diff --git a/src/mainboard/asus/p8z77-v_lx2/early_init.c b/src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/early_init.c similarity index 100% rename from src/mainboard/asus/p8z77-v_lx2/early_init.c rename to src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/early_init.c diff --git a/src/mainboard/asus/p8z77-v_lx2/gma-mainboard.ads b/src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/gma-mainboard.ads similarity index 100% rename from src/mainboard/asus/p8z77-v_lx2/gma-mainboard.ads rename to src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/gma-mainboard.ads diff --git a/src/mainboard/asus/p8z77-v_lx2/gpio.c b/src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/gpio.c similarity index 100% rename from src/mainboard/asus/p8z77-v_lx2/gpio.c rename to src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/gpio.c diff --git a/src/mainboard/asus/p8z77-v_lx2/hda_verb.c b/src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/hda_verb.c similarity index 100% rename from src/mainboard/asus/p8z77-v_lx2/hda_verb.c rename to src/mainboard/asus/p8z77-series/variants/p8z77-v_lx2/hda_verb.c diff --git a/src/mainboard/asus/p8z77-v_lx2/Kconfig b/src/mainboard/asus/p8z77-v_lx2/Kconfig deleted file mode 100644 index 108d61a..0000000 --- a/src/mainboard/asus/p8z77-v_lx2/Kconfig +++ /dev/null @@ -1,29 +0,0 @@ -## SPDX-License-Identifier: GPL-2.0-only - -if BOARD_ASUS_P8Z77_V_LX2 - -config BOARD_SPECIFIC_OPTIONS - def_bool y - select BOARD_ROMSIZE_KB_8192 - select HAVE_ACPI_RESUME - select HAVE_ACPI_TABLES - select HAVE_CMOS_DEFAULT - select HAVE_OPTION_TABLE - select INTEL_GMA_HAVE_VBT - select MAINBOARD_HAS_LIBGFXINIT - select NORTHBRIDGE_INTEL_SANDYBRIDGE - select REALTEK_8168_RESET - select SERIRQ_CONTINUOUS_MODE - select SOUTHBRIDGE_INTEL_C216 - select SUPERIO_NUVOTON_NCT6779D - select USE_NATIVE_RAMINIT - -config MAINBOARD_DIR - string - default "asus/p8z77-v_lx2" - -config MAINBOARD_PART_NUMBER - string - default "P8Z77-V LX2" - -endif diff --git a/src/mainboard/asus/p8z77-v_lx2/Kconfig.name b/src/mainboard/asus/p8z77-v_lx2/Kconfig.name deleted file mode 100644 index 0dec75f..0000000 --- a/src/mainboard/asus/p8z77-v_lx2/Kconfig.name +++ /dev/null @@ -1,2 +0,0 @@ -config BOARD_ASUS_P8Z77_V_LX2 - bool "P8Z77-V LX2" diff --git a/src/mainboard/asus/p8z77-v_lx2/Makefile.inc b/src/mainboard/asus/p8z77-v_lx2/Makefile.inc deleted file mode 100644 index 7167e10..0000000 --- a/src/mainboard/asus/p8z77-v_lx2/Makefile.inc +++ /dev/null @@ -1,7 +0,0 @@ -bootblock-y += early_init.c -bootblock-y += gpio.c - -romstage-y += early_init.c -romstage-y += gpio.c - -ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads -- To view, visit https://review.coreboot.org/c/coreboot/+/54409 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I701ec4adbc65732ffc0a60d311bf07bf7f414ebf Gerrit-Change-Number: 54409 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/asus/h61-series: Always select `INTEL_INT15`
by Angel Pons (Code Review) 17 May '21

17 May '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54379 to look at the new patch set (#2). Change subject: mb/asus/h61-series: Always select `INTEL_INT15` ...................................................................... mb/asus/h61-series: Always select `INTEL_INT15` The mainboard.c guard was only added to preserve reproducibility when unifying the boards. The `install_intel_vga_int15_handler` function does nothing when `VGA_ROM_RUN` is not selected. Remove the guard and always select `INTEL_INT15` for simplicity. Change-Id: If51a0ab1c57b0856018a62cf669e5d1b53e5333c Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/asus/h61-series/Kconfig M src/mainboard/asus/h61-series/Kconfig.name M src/mainboard/asus/h61-series/mainboard.c 3 files changed, 1 insertion(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/54379/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54379 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If51a0ab1c57b0856018a62cf669e5d1b53e5333c Gerrit-Change-Number: 54379 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Makefile.inc: Drop unused `cbfs-files-processor-vsa`
by Arthur Heymans (Code Review) 17 May '21

17 May '21

Attention is currently required from: Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54360 ) Change subject: Makefile.inc: Drop unused `cbfs-files-processor-vsa` ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54360 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I28bf61cb953e3352b59aa91059341e4de8f84f23 Gerrit-Change-Number: 54360 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 17 May 2021 16:01:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021