coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: mb/asus/p8z77-series: Add P8Z77-V as a variant of P8Z77 series
by Bill XIE (Code Review) 26 May '21

26 May '21

Attention is currently required from: Bill XIE, Angel Pons. Hello build bot (Jenkins), Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54338 to look at the new patch set (#14). Change subject: mb/asus/p8z77-series: Add P8Z77-V as a variant of P8Z77 series ...................................................................... mb/asus/p8z77-series: Add P8Z77-V as a variant of P8Z77 series Mainboard information can be found in the included documentation. Signed-off-by: Bill XIE <persmule(a)hardenedlinux.org> Change-Id: Ic56ac0e5f93a6e818ef0666e41996718471b1cf6 --- A Documentation/mainboard/asus/p8z77-v.jpg A Documentation/mainboard/asus/p8z77-v.md A Documentation/mainboard/asus/wifigo_v1.md A Documentation/mainboard/asus/wifigo_v1_board.jpg A Documentation/mainboard/asus/wifigo_v1_connector.jpg M Documentation/mainboard/index.md M src/mainboard/asus/p8z77-series/Kconfig M src/mainboard/asus/p8z77-series/Kconfig.name A src/mainboard/asus/p8z77-series/variants/p8z77-v/board_info.txt A src/mainboard/asus/p8z77-series/variants/p8z77-v/cmos.default A src/mainboard/asus/p8z77-series/variants/p8z77-v/cmos.layout A src/mainboard/asus/p8z77-series/variants/p8z77-v/data.vbt A src/mainboard/asus/p8z77-series/variants/p8z77-v/early_init.c A src/mainboard/asus/p8z77-series/variants/p8z77-v/gma-mainboard.ads A src/mainboard/asus/p8z77-series/variants/p8z77-v/gpio.c A src/mainboard/asus/p8z77-series/variants/p8z77-v/hda_verb.c A src/mainboard/asus/p8z77-series/variants/p8z77-v/overridetree.cb 17 files changed, 630 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/54338/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/54338 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic56ac0e5f93a6e818ef0666e41996718471b1cf6 Gerrit-Change-Number: 54338 Gerrit-PatchSet: 14 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/alderlake: Add new memory parts for ADL boards
by EricR Lai (Code Review) 26 May '21

26 May '21

Attention is currently required from: Tim Wawrzynczak, Amanda Hwang, Patrick Rudolph. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54950 ) Change subject: soc/intel/alderlake: Add new memory parts for ADL boards ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: SG -- To view, visit https://review.coreboot.org/c/coreboot/+/54950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e76a887f81d432adbcfc2f8956b44f4343db5c2 Gerrit-Change-Number: 54950 Gerrit-PatchSet: 3 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 27 May 2021 02:52:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Add a function to extract firmwares
by Bao Zheng (Code Review) 26 May '21

26 May '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Paul Menzel, Zheng Bao, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54901 ) Change subject: amdfwtool: Add a function to extract firmwares ...................................................................... Patch Set 6: (1 comment) File util/amdfwtool/extract.c: https://review.coreboot.org/c/coreboot/+/54901/comment/a615192f_ab6f0164 PS6, Line 228: bhd_offset = *(uint32_t *)&buffer[romsig_offset + 0x28] - image_base; Forgot to delete. -- To view, visit https://review.coreboot.org/c/coreboot/+/54901 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74a6c7ff56cc11530695d1068763ecdd86282a17 Gerrit-Change-Number: 54901 Gerrit-PatchSet: 6 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Zheng Bao Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 27 May 2021 02:46:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Add new memory parts for ADL boards
by Furquan Shaikh (Code Review) 26 May '21

26 May '21

Attention is currently required from: Tim Wawrzynczak, Amanda Hwang, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54950 ) Change subject: soc/intel/alderlake: Add new memory parts for ADL boards ...................................................................... Patch Set 3: (1 comment) File util/spd_tools/lp4x/global_lp4x_mem_parts.json.txt: PS3: Can you please push this change as a separate CL? I want to make sure it doesn't hide behind the ADL changes since it impacts other platforms too. -- To view, visit https://review.coreboot.org/c/coreboot/+/54950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e76a887f81d432adbcfc2f8956b44f4343db5c2 Gerrit-Change-Number: 54950 Gerrit-PatchSet: 3 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 27 May 2021 02:44:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: elog: Add a log for Chrome OS diagnostics boot in coreboot/bootmode
by Hsuan-ting Chen (Code Review) 26 May '21

26 May '21

Attention is currently required from: Hsuan Ting Chen, Paul Menzel, Aaron Durbin. Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54948 ) Change subject: elog: Add a log for Chrome OS diagnostics boot in coreboot/bootmode ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/54948/comment/77d4948b_b934faba PS1, Line 9: Add an elog type 0xb6 for Chrome OS diagnostics related events. > I think Paul was suggesting to also note that a log message is added as well. Thanks for your clarification. Now that I will set it as WIP since there might be other changes at the vboot api side. -- To view, visit https://review.coreboot.org/c/coreboot/+/54948 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb675fc431d4c45e4f432b2d12cac6dcfb2d5e3a Gerrit-Change-Number: 54948 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Thu, 27 May 2021 02:36:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hsuan-ting Chen <roccochen(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Aaron Durbin <adurbin(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common/block/rtd3: Add AMD specific RTD3 driver
by Furquan Shaikh (Code Review) 26 May '21

26 May '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Tim Wawrzynczak, Karthik Ramasubramanian, Felix Held. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54966 ) Change subject: soc/amd/common/block/rtd3: Add AMD specific RTD3 driver ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/54966/comment/593faf6e_f17830c5 PS1, Line 9: I decided : to copy and modify it because the Intel driver has a lot of Intel : specific code. From a quick look, I see that the following things were omitted: 1. ExternalFacingPort: Even though we don't need it right now, I think this might be needed on AMD platforms too at some point. So, it shouldn't hurt to have this. 2. HotPlugSupportInD3: See Duncan's comment here: https://review.coreboot.org/c/coreboot/+/46260/comment/f1e1d4b1_64e48a36/. I think we might need this for AMD platforms too. 3. L23 entry/exit and PMC communication in _ON/_OFF: PMC communication is definitely Intel-specific. But, L23 entry/exit might apply to AMD platforms too. Overall, I think we can still have a common driver if we provide enough flexibility for platforms. Given that the flexibility is mostly required in _ON/_OFF routines, would it make sense to move the driver to common location and have SoC callbacks for pcie_rtd3_acpi_method_off/pcie_rtd3_acpi_method_on? File src/soc/amd/common/block/rtd3/rtd3.c: https://review.coreboot.org/c/coreboot/+/54966/comment/f6e2b7af_17ceb425 PS1, Line 160: "_PR2", "_PR3"} Duncan had added a comment about not adding _PR3 to this device: https://review.coreboot.org/c/coreboot/+/46260/comment/1aab6aea_41d9a99a/ https://review.coreboot.org/c/coreboot/+/54966/comment/5888c075_c832b2a2 PS1, Line 210: pci_dev_read_resources This assumes that the PCI device under the GPP bridge is of type PCI_HEADER_TYPE_NORMAL. I think one of the reasons why a generic device was used to emit the required SSDT _DSD in Intel driver was to let the pci_device.c logic take care of identifying the right set of device_operations for the downstream device. Instead a fake generic device was added under the root port which allows adding of the required properties to the upstream bridge device. I think we should use a similar logic here? -- To view, visit https://review.coreboot.org/c/coreboot/+/54966 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2adfc925183ff7a19ab97e89212bc87c40d552d0 Gerrit-Change-Number: 54966 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Duncan Laurie <dlaurie(a)gmail.com> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 27 May 2021 02:18:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lint: checkpatch: Add SUSPICIOUS_CODE_INDENT test
by Julius Werner (Code Review) 26 May '21

26 May '21

Attention is currently required from: Nico Huber, Martin Roth, Felix Held. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51838 ) Change subject: lint: checkpatch: Add SUSPICIOUS_CODE_INDENT test ...................................................................... Patch Set 3: (5 comments) Patchset: PS3: Okay, sorry for not getting back to this in a while, I had a few very busy weeks. But I still think it's important that we finalize something here so we don't get in the situation one year from now again where someone is again upset about a bug creeping in and we discover that we had all these discussions before but didn't end up doing anything in the end. Unfortunately, it seems that getting this into upstream checkpatch is pretty much impossible at the moment: one of the maintainers seems to have been fully AWOL for years, and the other one says that this code isn't his area and he'll not take it unless the AWOL maintainer reviews it first. I think the next best option is to just apply this locally then (I'm happy to sign up for maintaining this code through future uprevs if necessary). I've applied Nico's remaining comments now and retested it again, so if nobody else has any concerns this should be ready to go in. As far as the GCC warning is concerned, looks like nothing really happened in that area either and I'm not sure if anyone is actively pursuing that? I tried it out quickly but I think the fact that it doesn't pick up on macros at all is a pretty big drawback -- even if we fixed printk(), there are plenty of other macros in coreboot. I'd rather having something with a very low chance of false positives (that you can then just ignore when they happen) than something which might miss a whole bunch of important cases. (As I mentioned before, on the current coreboot codebase there's not a single false positive.) File util/lint/checkpatch.pl: https://review.coreboot.org/c/coreboot/+/51838/comment/d1b23e25_bf22e5a0 PS2, Line 1345: @stack = (['', 0]) if ($#stack == -1); > Right, I guess I could drop it. Dropped it, but I decided to initialize @stack like in ctx_statement_block instead so that the condition can remain $#stack > 0 and the code is more comparable between the two. https://review.coreboot.org/c/coreboot/+/51838/comment/59adb260_5b46baf6 PS2, Line 3629: s > Probably, yeah. […] Removed the `s`. https://review.coreboot.org/c/coreboot/+/51838/comment/4ff96e55_08af42ba PS2, Line 3638: \s* > No idea, this is also Ivo's stuff. Probably not. removed https://review.coreboot.org/c/coreboot/+/51838/comment/d732d9f1_449310dd PS2, Line 3642: \s*? > I think ctx_statement_block() just doesn't handle do-while perfectly, and this is meant to work arou […] Left as is for now. It seems to work in practice. -- To view, visit https://review.coreboot.org/c/coreboot/+/51838 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7bb90b56dfc7582271d2b82cb42a2c1df477054f Gerrit-Change-Number: 51838 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 27 May 2021 02:16:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Move the definition to header file
by Bao Zheng (Code Review) 26 May '21

26 May '21

Attention is currently required from: Raul Rangel, Zheng Bao. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54942 ) Change subject: amdfwtool: Move the definition to header file ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/54942/comment/6b048d7b_89c9bd95 PS1, Line 7: Move > Why do they need to move? It is for the next patch, which another source is added to use these definitions. https://review.coreboot.org/c/coreboot/+/54901/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/54942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8c7ed9fa626b249b4aa48544316a941dc2625c60 Gerrit-Change-Number: 54942 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Thu, 27 May 2021 02:11:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Add support for 2 new DRAM parts
by EricR Lai (Code Review) 26 May '21

26 May '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Amanda Hwang. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54951 ) Change subject: mb/google/brya: Add support for 2 new DRAM parts ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54951 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56bfe8aa4f8d8aab2011fa8d17b3b2c8659658e3 Gerrit-Change-Number: 54951 Gerrit-PatchSet: 2 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 27 May 2021 02:09:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Add support for 2 new DRAM parts
by Amanda Hwang (Code Review) 26 May '21

26 May '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Amanda Hwang. Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, EricR Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54951 to look at the new patch set (#2). Change subject: mb/google/brya: Add support for 2 new DRAM parts ...................................................................... mb/google/brya: Add support for 2 new DRAM parts 1) Hynix H9HCNNNCPMMLXR-NEE 2) Micron MT53E1G32D2NP-046 WT:B BUG=b:186616388, b:181736400 Change-Id: I56bfe8aa4f8d8aab2011fa8d17b3b2c8659658e3 Signed-off-by: Amanda Huang <amanda_hwang(a)compal.corp-partner.google.com> --- M src/mainboard/google/brya/variants/brya0/memory/Makefile.inc M src/mainboard/google/brya/variants/brya0/memory/dram_id.generated.txt M src/mainboard/google/brya/variants/brya0/memory/mem_list_variant.txt 3 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/54951/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54951 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56bfe8aa4f8d8aab2011fa8d17b3b2c8659658e3 Gerrit-Change-Number: 54951 Gerrit-PatchSet: 2 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021