coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: elog: Add a log for Chrome OS diagnostics boot in coreboot/bootmode
by Aaron Durbin (Code Review) 26 May '21

26 May '21

Attention is currently required from: Hsuan Ting Chen, Hsuan-ting Chen, Paul Menzel. Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54948 ) Change subject: elog: Add a log for Chrome OS diagnostics boot in coreboot/bootmode ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/54948/comment/196222cf_5dbb71d7 PS1, Line 9: Add an elog type 0xb6 for Chrome OS diagnostics related events. > The Chrome OS diagnostics is more like the fourth 'bootmode' of Chrome OS. […] I think Paul was suggesting to also note that a log message is added as well. Patchset: PS1: src/security/vboot/bootmode.c: In function 'vboot_diagnostic_boot_requested': src/security/vboot/bootmode.c:33:9: error: implicit declaration of function 'vb2api_diagnostic_boot_requested'; did you mean 'vboot_diagnostic_boot_requested'? [-Werror=implicit-function-declaration] return vb2api_diagnostic_boot_requested(vboot_get_context()); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vboot_diagnostic_boot_requested You are going to need to update the vboot submodule pointer in a separate commit before this one or together. -- To view, visit https://review.coreboot.org/c/coreboot/+/54948 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb675fc431d4c45e4f432b2d12cac6dcfb2d5e3a Gerrit-Change-Number: 54948 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 26 May 2021 22:34:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hsuan-ting Chen <roccochen(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Add a function to extract firmwares
by Marshall Dawson (Code Review) 26 May '21

26 May '21

Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel, Martin Roth, Paul Menzel, Zheng Bao, Felix Held. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54901 ) Change subject: amdfwtool: Add a function to extract firmwares ...................................................................... Patch Set 6: (10 comments) File util/amdfwtool/extract.c: https://review.coreboot.org/c/coreboot/+/54901/comment/3fe9f2ed_2063eaf1 PS6, Line 15: 0 Use amd_fw_type enums here? https://review.coreboot.org/c/coreboot/+/54901/comment/4ad26995_aecc240d PS6, Line 17: 8 > Can this be sorted? That's the order they go into the image 😄 The PSP needs the items in the order it plans to consume them. https://review.coreboot.org/c/coreboot/+/54901/comment/2b49c595_1b89dad5 PS6, Line 68: psp_cookie = ppsp->header.cookie; Since this is only used in if/else decisions for naming below, would it look cleaner to make the decision here instead? https://review.coreboot.org/c/coreboot/+/54901/comment/dc749790_5ba0b080 PS6, Line 75: if (token == 6 || token == 0xb) Use the amd_fw_type enums? BTW what is 6? https://review.coreboot.org/c/coreboot/+/54901/comment/00898b73_38a69526 PS6, Line 91: PspDirL10_Typex What's the 0 there, i.e. L10? Is the plan to replace that with the subprogram value? Oh, you have token as uint32, so you're already getting type/subprog/rsvd. In that case, I'd change it to %04x to be clearer (I assume you'll have a script later that can parse the filenames and use them as arguments back into amdfwtool). https://review.coreboot.org/c/coreboot/+/54901/comment/2dc34d84_85a04e72 PS6, Line 110: extract_bios_fws All comments in extract_psp_fws() apply here too https://review.coreboot.org/c/coreboot/+/54901/comment/47f058fb_d4c36521 PS6, Line 178: romsig_offset This has a strange look here after the init of romsig_offsets. I'd put it on the next line. https://review.coreboot.org/c/coreboot/+/54901/comment/f08dd056_59a89a5d PS6, Line 206: romsig_offsets[index] != 0xFFFFFFFF Does this for() loop also need a check for not reading past the size of the buffer? For example, if you have an image size of 0x800000, you wouldn't want to read from offset 0xFA0000. https://review.coreboot.org/c/coreboot/+/54901/comment/53911b00_dc391439 PS6, Line 238: ppsp = (psp_directory_table *)&buffer[psp2_offset]; : extract_psp_fws(buffer, ppsp, image_base, NULL); Probably surround these with if (psp2_offset) { } https://review.coreboot.org/c/coreboot/+/54901/comment/efdaf53a_d6454241 PS6, Line 242: pbdt = (bios_directory_table *)&buffer[bhd2_offset]; : extract_bios_fws(buffer, pbdt, image_base, NULL); same as above -- To view, visit https://review.coreboot.org/c/coreboot/+/54901 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74a6c7ff56cc11530695d1068763ecdd86282a17 Gerrit-Change-Number: 54901 Gerrit-PatchSet: 6 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Zheng Bao Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 26 May 2021 22:22:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp1_1: Drop empty weak functions
by Angel Pons (Code Review) 26 May '21

26 May '21

Attention is currently required from: Nico Huber, Raul Rangel, Lee Leahy, Huang Jin, Arthur Heymans, Patrick Rudolph, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54957 ) Change subject: drivers/intel/fsp1_1: Drop empty weak functions ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > $ git grep -l mainboard_add_dimm_info […] Yep. Denverton-NS is FSP 2.0 -- To view, visit https://review.coreboot.org/c/coreboot/+/54957 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie60213e5a6ae67bd8b982ee505f4b512253577c6 Gerrit-Change-Number: 54957 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Attention: Huang Jin <huang.jin(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 26 May 2021 21:35:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Aaron Durbin <adurbin(a)chromium.org> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tpm: Remove USER_TPMx options, make TPM1/TPM2 menuconfig visible
by Julius Werner (Code Review) 26 May '21

26 May '21

Attention is currently required from: Philipp Deppenwiese, Michał Żygowski, Christian Walter, Julius Werner, Aaron Durbin, Piotr Król. Hello Philipp Deppenwiese, build bot (Jenkins), Michał Żygowski, Christian Walter, Aaron Durbin, Piotr Król, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54641 to look at the new patch set (#3). Change subject: tpm: Remove USER_TPMx options, make TPM1/TPM2 menuconfig visible ...................................................................... tpm: Remove USER_TPMx options, make TPM1/TPM2 menuconfig visible We would like to have an easy way to completely disable TPM support on a board. For boards that don't pre-select a TPM protocol via the MAINBOARD_HAS_TPMx options, this is already possible with the USER_NO_TPM option. In order to make this available for all boards, this patch just removes the whole USER_TPMx option group and directly makes the TPM1 and TPM2 options visible to menuconfig. The MAINBOARD_HAS_TPMx options can still be used to select defaults and to prevent selection of a protocol that the TPM is known to not support, but the NO_TPM option always remains available. Also fix some mainboards that selected TPM2 directly, which they're not supposed to do (that's what MAINBOARD_HAS_TPM2 is for), and add a missing dependency to TPM_CR50 so it is set correctly for a NO_TPM scenario. Signed-off-by: Julius Werner <jwerner(a)chromium.org> Change-Id: Ib0a73da3c42fa4e8deffecb53f29ee38cbb51a93 --- M configs/config.asrock_b85m_pro4.tpm2_txt_placeholder_acms M configs/config.libretrend_lt1000 M src/mainboard/google/drallion/Kconfig M src/mainboard/protectli/vault_kbl/Kconfig M src/security/tpm/Kconfig M src/security/tpm/tss/vendor/cr50/Kconfig 6 files changed, 33 insertions(+), 43 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/54641/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/54641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib0a73da3c42fa4e8deffecb53f29ee38cbb51a93 Gerrit-Change-Number: 54641 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: vboot: Add VB2_CONTEXT_EC_TRUSTED
by Furquan Shaikh (Code Review) 26 May '21

26 May '21

Attention is currently required from: Joel Kitching, Daisuke Nojiri, Aaron Durbin. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54099 ) Change subject: vboot: Add VB2_CONTEXT_EC_TRUSTED ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9fa09dd7ae5baa1efb4e1ed4f0fe9a6803167c93 Gerrit-Change-Number: 54099 Gerrit-PatchSet: 6 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Joel Kitching <kitching(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Joel Kitching <kitching(a)google.com> Gerrit-Attention: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Wed, 26 May 2021 21:24:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vboot: Add VB2_CONTEXT_EC_TRUSTED
by Julius Werner (Code Review) 26 May '21

26 May '21

Attention is currently required from: Joel Kitching, Daisuke Nojiri, Aaron Durbin. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54099 ) Change subject: vboot: Add VB2_CONTEXT_EC_TRUSTED ...................................................................... Patch Set 6: Code-Review+2 (1 comment) Patchset: PS6: LGTM after vboot uprev -- To view, visit https://review.coreboot.org/c/coreboot/+/54099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9fa09dd7ae5baa1efb4e1ed4f0fe9a6803167c93 Gerrit-Change-Number: 54099 Gerrit-PatchSet: 6 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Joel Kitching <kitching(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Joel Kitching <kitching(a)google.com> Gerrit-Attention: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Wed, 26 May 2021 21:24:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Print the entry type when dumping the firmwares
by Marshall Dawson (Code Review) 26 May '21

26 May '21

Attention is currently required from: Bao Zheng, Zheng Bao. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54900 ) Change subject: amdfwtool: Print the entry type when dumping the firmwares ...................................................................... Patch Set 2: (2 comments) File util/amdfwtool/amdfwtool.c: https://review.coreboot.org/c/coreboot/+/54900/comment/c6e50c0e_8f1752f8 PS2, Line 653: %x: Maybe %02x or more in order to align of the strings. There are a small number that are only one digit, most are two, and some of the older ones are three. And would it look better to add a space after the colon? https://review.coreboot.org/c/coreboot/+/54900/comment/b7be4670_c71d1f7a PS2, Line 664: %x Whatever you decide above, repeat here -- To view, visit https://review.coreboot.org/c/coreboot/+/54900 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I07bf10e16a42a2b2ab784ee6ac4a4465b7412da6 Gerrit-Change-Number: 54900 Gerrit-PatchSet: 2 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Wed, 26 May 2021 21:19:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Set the region_type as 0 for entry "BIOS level 2"
by Marshall Dawson (Code Review) 26 May '21

26 May '21

Attention is currently required from: Bao Zheng, Raul Rangel, Zheng Bao. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54871 ) Change subject: amdfwtool: Set the region_type as 0 for entry "BIOS level 2" ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File util/amdfwtool/amdfwtool.c: https://review.coreboot.org/c/coreboot/+/54871/comment/3b3f351a_dafc0a9c PS2, Line 1047: region_type > So this changes the region type from 0xFF to 0? Yes, only for the type 0x70 entry, which is the pointer to the 2nd level of the table. I don't see any description for valid values for this field however I'd missed it when writing the code. -- To view, visit https://review.coreboot.org/c/coreboot/+/54871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b914f9f02beecce707aba86248826cd9208e6c0 Gerrit-Change-Number: 54871 Gerrit-PatchSet: 2 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Wed, 26 May 2021 21:13:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vboot: Add VB2_CONTEXT_EC_TRUSTED
by Daisuke Nojiri (Code Review) 26 May '21

26 May '21

Attention is currently required from: Joel Kitching, Julius Werner, Daisuke Nojiri, Aaron Durbin. Hello build bot (Jenkins), Joel Kitching, Julius Werner, Aaron Durbin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54099 to look at the new patch set (#6). Change subject: vboot: Add VB2_CONTEXT_EC_TRUSTED ...................................................................... vboot: Add VB2_CONTEXT_EC_TRUSTED This patch makes coreboot set VB2_CONTEXT_EC_TRUSTED based on the EC"s boot mode. Vboot will check VB2_CONTEXT_EC_TRUSTED to determine whether it can enter recovery mode or not. BUG=b:180927027, b:187871195 BRANCH=none TEST=build Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org> Change-Id: I9fa09dd7ae5baa1efb4e1ed4f0fe9a6803167c93 --- M src/security/vboot/vboot_logic.c 1 file changed, 12 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/54099/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/54099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9fa09dd7ae5baa1efb4e1ed4f0fe9a6803167c93 Gerrit-Change-Number: 54099 Gerrit-PatchSet: 6 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Joel Kitching <kitching(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Joel Kitching <kitching(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/amd/majolica: enable crypto coprocessor PCIe device
by Marshall Dawson (Code Review) 26 May '21

26 May '21

Attention is currently required from: Jason Glenesk, Felix Held. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54963 ) Change subject: mb/amd/majolica: enable crypto coprocessor PCIe device ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54963 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id1c6a6cbbdda2cb22e81e2b52b364617d6765e09 Gerrit-Change-Number: 54963 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 26 May 2021 20:52:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021