Attention is currently required from: Tim Wawrzynczak, Brandon Breitenstein.
Chiranjeevi Rapolu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51194 )
Change subject: soc/intel/tigerlake: Enable TCSS Muxes to disconnect mode during boot
......................................................................
Patch Set 9:
(2 comments)
Patchset:
PS9:
I cherry-picked these CLs and verified to be working fine.
File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/51194/comment/767d9f95_bdb8bd1b
PS9, Line 113: usb3_port
Brandon, I assume 1-based numbering is taken care here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51194
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4352072a4a7d6ccb1364b38377831f3c22ae8fb4
Gerrit-Change-Number: 51194
Gerrit-PatchSet: 9
Gerrit-Owner: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Comment-Date: Thu, 04 Mar 2021 16:16:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Martin Roth, Subrata Banik, Meera Ravindranath.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49433 )
Change subject: mb/intel/adlrvp: do UART pad config at board-level
......................................................................
Patch Set 11:
(1 comment)
Patchset:
PS11:
Subrata, Meera: can you verify this again, please, so we can finally get these changes merged
--
To view, visit https://review.coreboot.org/c/coreboot/+/49433
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55815a824ea3a77e6e603ba4beb17457f37c48f5
Gerrit-Change-Number: 49433
Gerrit-PatchSet: 11
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Comment-Date: Thu, 04 Mar 2021 16:00:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Henry Sun, Stanley Wu, Karthik Ramasubramanian.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51254 )
Change subject: mb/google/dedede/var/boten: update Goodix touch screen sequence
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51254/comment/a48fd22f_a296d5e7
PS1, Line 9: Update Goodix touch screen reset delay time to 180ms.
Where do you get 180ms? Is that from the datasheet or the manufacturer's engineering support?
--
To view, visit https://review.coreboot.org/c/coreboot/+/51254
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98efbe68dab538906802647582eba0e068d9c11f
Gerrit-Change-Number: 51254
Gerrit-PatchSet: 1
Gerrit-Owner: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com>
Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 04 Mar 2021 15:51:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Xi Chen.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51203 )
Change subject: src/mediatek/common: Move DRAM implementation from mt8192 to common
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Hi xixi, you changed the subject to 'move' but the change is still only adding files...
I think we need to do
git rm src/soc/mediatek/common/dpm.c
git rm ...dramc_param.c
..... dpm.h
..... emi.h
etc all files that you're going to delete in next change (and added in this change).
--
To view, visit https://review.coreboot.org/c/coreboot/+/51203
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I557c96b3d09828472b8b6f932b0192a90894043e
Gerrit-Change-Number: 51203
Gerrit-PatchSet: 3
Gerrit-Owner: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Comment-Date: Thu, 04 Mar 2021 15:02:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Angel Pons, Subrata Banik, Andrey Petrov, Patrick Rudolph.
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51085 )
Change subject: driver/intel/fsp2_0: Allow function to run serially on all APs
......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51085/comment/53e6a01a_d5a05bd4
PS2, Line 9: singlethread
> The name seems to be `run_serial`.
Ack
https://review.coreboot.org/c/coreboot/+/51085/comment/d0dadc4f_394209c5
PS2, Line 14:
> Please give some numbers, on how much time this actually saves. […]
Just adding a provision for serial run. Only for the were MP programming is recommended to run serially. Time would depend on the procedure to be run and also the timeout param in case it does not go through.
File src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c:
https://review.coreboot.org/c/coreboot/+/51085/comment/c64cf287_c313c538
PS2, Line 67: run_serial
> I’d prefer the opposite name `run_in_parallel`.
This is more to align with FSP EFI_PEI_MP_SERVICES_STARTUP_ALL_APS parameters.
https://review.coreboot.org/c/coreboot/+/51085/comment/4c91e32a_f247f5af
PS2, Line 77: uint32_t
> get_cpu_count() returns an int
Ack
https://review.coreboot.org/c/coreboot/+/51085/comment/a858da71_eea7817c
PS2, Line 91: MP_RUN_ON_ALL_CPUS
> I think this enum is named incorrectly. https://review.coreboot.org/cgit/coreboot. […]
ok to add a helper in mp init lib, you mean something like this?
diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c
index cca6093458a..8788f650b6b 100644
--- a/src/cpu/x86/mp_init.c
+++ b/src/cpu/x86/mp_init.c
@@ -992,6 +992,19 @@ int mp_run_on_aps(void (*func)(void *), void *arg, int logical_cpu_num,
return run_ap_work(&lcb, expire_us);
}
+int mp_run_on_all_aps(void (*func)(void *), void *arg, long expire_us, bool run_serial)
+{
+ if (run_serial) {
+ for (int ap_index = 1; ap_index <= global_aps_num; ap_index++) {
+ if (mp_run_on_aps(func, arg, ap_index, expire_us))
+ printk(BIOS_ERR, "%s: failed running procedure on AP %d\n",
+ __func__, ap_index);
+ }
+ } else {
+ return mp_run_on_aps(func, arg, 0, expire_us);
+ }
+}
and then call this from fsp driver?
--
To view, visit https://review.coreboot.org/c/coreboot/+/51085
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d85dd2ce9115f0186790c62c8dcc75f12412e92
Gerrit-Change-Number: 51085
Gerrit-PatchSet: 2
Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 04 Mar 2021 15:02:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Raul Rangel, Martin Roth, Mathew King, Karthik Ramasubramanian.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51043 )
Change subject: mb/google/guybrush: Enable Chrome EC
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h:
https://review.coreboot.org/c/coreboot/+/51043/comment/575830fe_6a935bc8
PS4, Line 26: SMI
> From what I can tell it is not important but all other boards define it this way. […]
SMI is needed for depthcharge receive LID close, right? I thought Intel platform had this issue due to not enable SMI.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51043
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3cdd6422b1bc53ea934346327359cbc6d86baeeb
Gerrit-Change-Number: 51043
Gerrit-PatchSet: 4
Gerrit-Owner: Mathew King <mathewk(a)chromium.org>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Mathew King <mathewk(a)chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 04 Mar 2021 14:32:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org>
Comment-In-Reply-To: Mathew King <mathewk(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Raul Rangel, Martin Roth, Karthik Ramasubramanian, EricR Lai.
Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51043 )
Change subject: mb/google/guybrush: Enable Chrome EC
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/guybrush/mainboard.c:
https://review.coreboot.org/c/coreboot/+/51043/comment/bc09e77e_2342a67a
PS4, Line 22: mainboard_ec_init
> Do we need to configure the GPIOs before the EC? I'm not sure what the default state of the eSPI pin […]
eSPI GPIOs are configured in verstage in zork, I could add eSPI GPIO configuration to bootbock for now or wait until we have psp verstage ready.
File src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h:
https://review.coreboot.org/c/coreboot/+/51043/comment/d672d25b_2d3f7fe3
PS4, Line 26: SMI
> Are we really using SMIs for this?
From what I can tell it is not important but all other boards define it this way. Happy to take it out if it is not needed.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51043
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3cdd6422b1bc53ea934346327359cbc6d86baeeb
Gerrit-Change-Number: 51043
Gerrit-PatchSet: 4
Gerrit-Owner: Mathew King <mathewk(a)chromium.org>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 04 Mar 2021 14:24:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: John Su, Martin Roth, Paul Menzel, Chris Wang, chris wang.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49683 )
Change subject: mb/google/zork/var/vilboz: Add Mainboard Type for VCORE IC
......................................................................
Patch Set 11: Code-Review+2
(1 comment)
File src/mainboard/google/zork/variants/vilboz/romstage.c:
https://review.coreboot.org/c/coreboot/+/49683/comment/0207ba24_54249649
PS11, Line 5: #include <console/uart.h>
nits: this not need.
--
To view, visit https://review.coreboot.org/c/coreboot/+/49683
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If153c0a3e641ae32ef89737925bd9f62dfb71f3d
Gerrit-Change-Number: 49683
Gerrit-PatchSet: 11
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: chris wang <Chris.Wang(a)amd.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Attention: chris wang <Chris.Wang(a)amd.com>
Gerrit-Comment-Date: Thu, 04 Mar 2021 13:06:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment