Attention is currently required from: Frank Wu, John Su, Furquan Shaikh, Martin Roth, Alan Lee, Angel Pons, Ivy Jian.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49783 )
Change subject: drivers/generic/bayhub_lv2: Add driver for BayHub lv2
......................................................................
Patch Set 8: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/49783
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc1340b1a6fe7063d16c8ea16488d6e2b8b308cc
Gerrit-Change-Number: 49783
Gerrit-PatchSet: 8
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Peichao Wang <pwang12(a)lenovo.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 02 Feb 2021 08:27:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Chris Wang, chris wang, EricR Lai.
Hello build bot (Jenkins), Martin Roth, Chris Wang, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/50214
to look at the new patch set (#4).
Change subject: mb/google/zork: Update eDP phy setting for new eDP phy setting UPDs
......................................................................
mb/google/zork: Update eDP phy setting for new eDP phy setting UPDs
Update eDP phy settings for new eDP phy setting UPDs.
BUG=b:171269338
BRANCH=none
TEST=Build; Verify the UPD was passed to system integrated table
Signed-off-by: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Change-Id: If457f6597d5163b2a22c79863c5e666cb8a2d9e6
---
M src/mainboard/google/zork/variants/vilboz/overridetree.cb
1 file changed, 11 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/50214/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/50214
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If457f6597d5163b2a22c79863c5e666cb8a2d9e6
Gerrit-Change-Number: 50214
Gerrit-PatchSet: 4
Gerrit-Owner: chris wang <Chris.Wang(a)amd.com>
Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Attention: chris wang <Chris.Wang(a)amd.com>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Chris Wang, EricR Lai, Felix Held.
Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Chris Wang, EricR Lai, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/50212
to look at the new patch set (#2).
Change subject: soc/amd/picasso: clean up and re-sort UPD table
......................................................................
soc/amd/picasso: clean up and re-sort UPD table
Clean up the unused UPD and re-sort the table, and also update
the new phy parameter in the soc code.
remove:
EDpPhySel
EDpVersion
rename:
DpPhyOverride -> edp_phy_override
EDpPhySel -> edp_physel
DpVsPemphLevel -> edp_dp_vs_pemph_level
MarginDeemPh -> edp_margin_deemph
Deemph6db4 -> edp_deemph_6db_4
BoostAdj -> edp_boost_adj
BUG=b:171269338
BRANCH=zork
TEST=Build, verify the parameter pass to picasso-fsp
Signed-off-by: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Change-Id: I655af08e2f86398d088e30d330f49e71cf7e1275
---
M src/soc/amd/picasso/chip.h
M src/soc/amd/picasso/fsp_params.c
M src/vendorcode/amd/fsp/picasso/FspsUpd.h
3 files changed, 26 insertions(+), 27 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/50212/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/50212
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I655af08e2f86398d088e30d330f49e71cf7e1275
Gerrit-Change-Number: 50212
Gerrit-PatchSet: 2
Gerrit-Owner: chris wang <Chris.Wang(a)amd.com>
Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Sunwei Li.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50215 )
Change subject: mb/google/kukui: kakadu: update the initial code for BOE LCD image stricking
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50215/comment/04a2112d_bc4107e2
PS1, Line 7: mb/google/kukui: kakadu: update the initial code for BOE LCD image stricking
Subject line too long (> 72 chars). Please rephrase.
https://review.coreboot.org/c/coreboot/+/50215/comment/4e187c42_024d2c3e
PS1, Line 13: Update the initial code to fix BOE LCD image stricking.
This field should describe how you tested the CL.
--
To view, visit https://review.coreboot.org/c/coreboot/+/50215
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc1bd5147dbda4e3b94023e7ba52ff6a18abba0c
Gerrit-Change-Number: 50215
Gerrit-PatchSet: 1
Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 02 Feb 2021 08:16:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Sunwei Li, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50215 )
Change subject: mb/google/kukui: kakadu: update the initial code for BOE LCD image stricking
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50215/comment/932d361b_36f1e564
PS1, Line 11: BUG=None
: BRANCH=kukui
: TEST=Update the initial code to fix BOE LCD image stricking.
Sounds like we'll have image issues without this patch. Can you provide the bug link? If not, create one and describe what you've seen (even better with screenshots) if this is not applied.
--
To view, visit https://review.coreboot.org/c/coreboot/+/50215
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc1bd5147dbda4e3b94023e7ba52ff6a18abba0c
Gerrit-Change-Number: 50215
Gerrit-PatchSet: 1
Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Tue, 02 Feb 2021 08:15:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Chris Wang, chris wang, Felix Held.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50213 )
Change subject: soc/amd/picasso: Update the UPDs for the eDP phy setting
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
You need combine this with previous one.
--
To view, visit https://review.coreboot.org/c/coreboot/+/50213
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35f1507e6a8d202208c99352f0ef425ec4a407b6
Gerrit-Change-Number: 50213
Gerrit-PatchSet: 2
Gerrit-Owner: chris wang <Chris.Wang(a)amd.com>
Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Attention: chris wang <Chris.Wang(a)amd.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 02 Feb 2021 08:08:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48480 )
Change subject: lib/cbfs.c: Update the cbfs_boot_device variable after cmbem_init
......................................................................
lib/cbfs.c: Update the cbfs_boot_device variable after cmbem_init
If CBFS is accessed before cbmem_init, the ro cbfs_boot_device will
never point to the mcache in cbmem, so use CBMEM_INIT_HOOK to update
the variable.
Change-Id: I6ce4683374c7a11c823e2f1b0b6f24e6db549ac7
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/lib/cbfs.c
1 file changed, 10 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/48480/1
diff --git a/src/lib/cbfs.c b/src/lib/cbfs.c
index 5e6fce4..3767a5d 100644
--- a/src/lib/cbfs.c
+++ b/src/lib/cbfs.c
@@ -449,10 +449,10 @@
return err;
}
+static struct cbfs_boot_device ro;
+
const struct cbfs_boot_device *cbfs_get_boot_device(bool force_ro)
{
- static struct cbfs_boot_device ro;
-
/* Ensure we always init RO mcache, even if first file is from RW.
Otherwise it may not be available when needed in later stages. */
if (ENV_INITIAL_STAGE && !force_ro && !region_device_sz(&ro.rdev))
@@ -487,6 +487,14 @@
return &ro;
}
+static void setup_cbfs_mcache(int unused)
+{
+ cbfs_boot_device_find_mcache(&ro, CBMEM_ID_CBFS_RO_MCACHE);
+}
+
+POSTCAR_CBMEM_INIT_HOOK(setup_cbfs_mcache);
+RAMSTAGE_CBMEM_INIT_HOOK(setup_cbfs_mcache);
+
#if !CONFIG(NO_CBFS_MCACHE)
static void mcache_to_cbmem(const struct cbfs_boot_device *cbd, u32 cbmem_id)
{
--
To view, visit https://review.coreboot.org/c/coreboot/+/48480
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ce4683374c7a11c823e2f1b0b6f24e6db549ac7
Gerrit-Change-Number: 48480
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newchange
Attention is currently required from: Martin Roth, Chris Wang, chris wang, EricR Lai.
Hello build bot (Jenkins), Martin Roth, Chris Wang, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/50214
to look at the new patch set (#3).
Change subject: mb/google/zork: Update eDP phy setting for new eDP phy setting UPDs
......................................................................
mb/google/zork: Update eDP phy setting for new eDP phy setting UPDs
Update eDP phy settings for new eDP phy setting UPDs.
BUG=b:171269338
BRANCH=none
TEST=Build; Verify the UPD was passed to system integrated table
Signed-off-by: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Change-Id: If457f6597d5163b2a22c79863c5e666cb8a2d9e6
---
M src/mainboard/google/zork/variants/vilboz/overridetree.cb
1 file changed, 11 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/50214/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/50214
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If457f6597d5163b2a22c79863c5e666cb8a2d9e6
Gerrit-Change-Number: 50214
Gerrit-PatchSet: 3
Gerrit-Owner: chris wang <Chris.Wang(a)amd.com>
Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Attention: chris wang <Chris.Wang(a)amd.com>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Chris Wang, Felix Held.
Hello Jason Glenesk, Raul Rangel, Marshall Dawson, Chris Wang, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/50213
to look at the new patch set (#2).
Change subject: soc/amd/picasso: Update the UPDs for the eDP phy setting
......................................................................
soc/amd/picasso: Update the UPDs for the eDP phy setting
The UPDs for the eDP phy setting has been update. it needs sync up with the new UPDs.
BUG=b:171269338
TEST=Build; Verify the UPD was pass to system integrated table; measure
the power on sequence on dalboz
Signed-off-by: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Change-Id: I35f1507e6a8d202208c99352f0ef425ec4a407b6
---
M src/soc/amd/picasso/chip.h
M src/soc/amd/picasso/fsp_params.c
2 files changed, 10 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/50213/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/50213
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35f1507e6a8d202208c99352f0ef425ec4a407b6
Gerrit-Change-Number: 50213
Gerrit-PatchSet: 2
Gerrit-Owner: chris wang <Chris.Wang(a)amd.com>
Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset