Attention is currently required from: Lijian Zhao.
Hello Lijian Zhao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/50352
to review the following change.
Change subject: acpi: Fix Coverity Scan report
......................................................................
acpi: Fix Coverity Scan report
Fix the issue that return value "r" in line 534 will get overwritten
problem.
BUG=CID 1445995
TEST=Build sucessful and boot up in QEMU
Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com>
Change-Id: Icf760b142cfecfed7c929c15ad190ac74df027b1
---
M src/arch/x86/acpi_bert_storage.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/50352/1
diff --git a/src/arch/x86/acpi_bert_storage.c b/src/arch/x86/acpi_bert_storage.c
index ec31917..ef10a6b 100644
--- a/src/arch/x86/acpi_bert_storage.c
+++ b/src/arch/x86/acpi_bert_storage.c
@@ -534,7 +534,7 @@
r = bert_append_genproc(status);
else if (!guidcmp(guid, &CPER_SEC_PROC_GENERIC_GUID))
r = bert_append_ia32x64(status);
- if (!guidcmp(guid, &CPER_SEC_FW_ERR_REC_REF_GUID))
+ else if (!guidcmp(guid, &CPER_SEC_FW_ERR_REC_REF_GUID))
r = bert_append_fw_err(status);
/* else if other types not implemented */
else
--
To view, visit https://review.coreboot.org/c/coreboot/+/50352
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf760b142cfecfed7c929c15ad190ac74df027b1
Gerrit-Change-Number: 50352
Gerrit-PatchSet: 1
Gerrit-Owner: Lance Zhao
Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com>
Gerrit-Attention: Lijian Zhao <lijian.zhao(a)intel.com>
Gerrit-MessageType: newchange
Attention is currently required from: Francois Toguo Fotso.
Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49799 )
Change subject: acpi: Add support for reporting CrashLog in BERT table
......................................................................
Patch Set 10:
(1 comment)
File src/arch/x86/acpi_bert_storage.c:
https://review.coreboot.org/c/coreboot/+/49799/comment/e610e8d4_918c70d0
PS10, Line 537: if (!guidcmp(guid, &CPER_SEC_FW_ERR_REC_REF_GUID))
That shall be else if here? According to CID 1445995
--
To view, visit https://review.coreboot.org/c/coreboot/+/49799
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00e390d735d61beac2e89a726e39119d9b06b3df
Gerrit-Change-Number: 49799
Gerrit-PatchSet: 10
Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nikunj Dadhania <nikunj.dadhania(a)intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Raj Astekar <raj.astekar(a)intel.com>
Gerrit-Attention: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com>
Gerrit-Comment-Date: Sat, 06 Feb 2021 04:14:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Derek Huang, YH Lin.
Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50293 )
Change subject: mb/google/volteer/var/voxel: Add settings for noise mitgation
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/50293
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I279a85c7741094bb7ddf0c1fde74b31189b12171
Gerrit-Change-Number: 50293
Gerrit-PatchSet: 2
Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derek.huang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Derek Huang <derek.huang(a)intel.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)chromium.org>
Gerrit-Comment-Date: Sat, 06 Feb 2021 04:08:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Furquan Shaikh, Bhanu Prakash Maiya, Felix Held.
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50282 )
Change subject: mb/google/zork: update USB 3 controller phy Parameter for dirinboz
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/zork/variants/dirinboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/50282/comment/24e8f8ff_bce777f4
PS2, Line 66: register "usb3_phy_tune_params[0]"
> Hi Martin, right now only port#0 needs to be enhanced so I suppose we could keep 0 for other ports a […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/50282
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42a94e03fb6f8230d4356d16b8e0d2164bc61e3f
Gerrit-Change-Number: 50282
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sat, 06 Feb 2021 02:58:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Comment-In-Reply-To: Martin Roth <martinroth(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Frans Hendriks, Patrick Rudolph, Aaron Durbin, Wim Vervoorn.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50350 )
Change subject: spd_bin: Replace get_spd_cbfs_rdev() with spd_cbfs_map()
......................................................................
Patch Set 1:
(2 comments)
File src/soc/intel/cannonlake/cnl_memcfg_init.c:
https://review.coreboot.org/c/coreboot/+/50350/comment/692438d5_66390cdd
PS1, Line 92: if (!spd_data_ptr);
trailing semicolon indicates no statements, indent implies otherwise
https://review.coreboot.org/c/coreboot/+/50350/comment/449a6e33_565dfd74
PS1, Line 92: if (!spd_data_ptr);
trailing statements should be on next line
--
To view, visit https://review.coreboot.org/c/coreboot/+/50350
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec7571bec809f2f0712e7a97b4c853b8b40702d1
Gerrit-Change-Number: 50350
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Attention: Wim Vervoorn <wvervoorn(a)eltan.com>
Gerrit-Comment-Date: Sat, 06 Feb 2021 02:57:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Furquan Shaikh, Marshall Dawson, Aaron Durbin, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50348 )
Change subject: cbfs: Replace more instances of cbfs_boot_locate() with newer APIs
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/net/r8168.c:
https://review.coreboot.org/c/coreboot/+/50348/comment/9053a709_ed0bd99b
PS1, Line 169: if (!cbfs_load("rt8168-macaddress", macstrbuf, MACLEN)) {{
trailing statements should be on next line
--
To view, visit https://review.coreboot.org/c/coreboot/+/50348
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd0f21e2fa49c7cc834523578b7b45b5482cb1a8
Gerrit-Change-Number: 50348
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sat, 06 Feb 2021 02:56:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Marshall Dawson, Patrick Rudolph, Aaron Durbin, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49335 )
Change subject: cbfs: Remove prog_locate() for stages and rmodules
......................................................................
Patch Set 7:
(1 comment)
File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/49335/comment/7b235ee7_bd7fcff6
PS7, Line 399: if ((err = cbfs_boot_lookup(prog_name(pstage), false, &mdata, &rdev)))
do not use assignment in if condition
--
To view, visit https://review.coreboot.org/c/coreboot/+/49335
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia600e55f77c2549a00e2606f09befc1f92594a3a
Gerrit-Change-Number: 49335
Gerrit-PatchSet: 7
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sat, 06 Feb 2021 02:42:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Aaron Durbin.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49334 )
Change subject: cbfs: Add cbfs_alloc() primitive and combine cbfs_load() and cbfs_map()
......................................................................
Patch Set 7:
(1 comment)
File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/49334/comment/04e55213_3f007853
PS7, Line 356: } else {
else is not generally useful after a break or return
--
To view, visit https://review.coreboot.org/c/coreboot/+/49334
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5fe0645387c0e9053ad5c15744437940fc904392
Gerrit-Change-Number: 49334
Gerrit-PatchSet: 7
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Comment-Date: Sat, 06 Feb 2021 02:20:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Philipp Hug, Furquan Shaikh, Marshall Dawson, Aaron Durbin, ron minnich, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49332 )
Change subject: memlayout: Store region sizes as separate symbols
......................................................................
Patch Set 6:
(3 comments)
File src/include/memlayout.h:
https://review.coreboot.org/c/coreboot/+/49332/comment/b154a677_ab7e5067
PS6, Line 36: #define RECORD_SIZE(name) \
Macros with multiple statements should be enclosed in a do - while loop
https://review.coreboot.org/c/coreboot/+/49332/comment/d41da4d6_1bba251f
PS6, Line 36: #define RECORD_SIZE(name) \
macros should not use a trailing semicolon
https://review.coreboot.org/c/coreboot/+/49332/comment/ccab64d3_03a0dcda
PS6, Line 53: #define REGION_END(name, addr) \
Macros with complex values should be enclosed in parentheses
--
To view, visit https://review.coreboot.org/c/coreboot/+/49332
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd89708ca9bd3937d0db7308959231106a6aa373
Gerrit-Change-Number: 49332
Gerrit-PatchSet: 6
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sat, 06 Feb 2021 02:20:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment