coreboot-gerrit February 2021

coreboot-gerrit@coreboot.org

1 participants
7192 discussions

Change in coreboot[master]: mb/google/zork/var/shuboz: Adjust GPIO settings
by Kane Chen (Code Review) 09 Feb '21

09 Feb '21

Attention is currently required from: Martin Roth, Bhanu Prakash Maiya. Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50277 ) Change subject: mb/google/zork/var/shuboz: Adjust GPIO settings ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/zork/variants/shuboz/gpio.c: https://review.coreboot.org/c/coreboot/+/50277/comment/3d94e817_b892a87f PS2, Line 14: /* RAM ID 2 */ : PAD_GPI(GPIO_86, PULL_NONE), > Ram ID 2 should be left high at boot as set in the general dalboz board. RAM ID should be pulled up/down by external resistor. -- To view, visit https://review.coreboot.org/c/coreboot/+/50277 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4342b2beb7fc755bee47ee4fad0023d7a6592c4b Gerrit-Change-Number: 50277 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Comment-Date: Tue, 09 Feb 2021 03:43:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/zork/var/shuboz: Modify touchpad setting for Jelboz
by Kane Chen (Code Review) 09 Feb '21

09 Feb '21

Attention is currently required from: Martin Roth. Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49742 ) Change subject: mb/google/zork/var/shuboz: Modify touchpad setting for Jelboz ...................................................................... Patch Set 14: (1 comment) File src/mainboard/google/zork/variants/shuboz/overridetree.cb: https://review.coreboot.org/c/coreboot/+/49742/comment/0eb21f14_2d44072b PS13, Line 64: ACPI_GPIO_IRQ_EDGE_LOW > I think Level is correct. Done, Thanks for your help. -- To view, visit https://review.coreboot.org/c/coreboot/+/49742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie0219419834b34b6eac589f28d3604f5f1b65679 Gerrit-Change-Number: 49742 Gerrit-PatchSet: 14 Gerrit-Owner: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Randy I-Fan Wang <ifanw(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Tue, 09 Feb 2021 03:22:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/zork/var/shuboz: Adjust touchscreen settings
by Kane Chen (Code Review) 09 Feb '21

09 Feb '21

Attention is currently required from: Martin Roth. Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50228 ) Change subject: mb/google/zork/var/shuboz: Adjust touchscreen settings ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/50228/comment/60263ddc_e24f4993 PS3, Line 12: b:174447201 > is this the correct bug number? Is this supposed to be b/174442484? OK, I change bug number to 174442484, thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/50228 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36a7055b7be0963479f8a0f4dc49c92bc8fbdc9d Gerrit-Change-Number: 50228 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: Randy I-Fan Wang <ifanw(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Tue, 09 Feb 2021 03:20:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/bootblock.c: Remove unused includes
by HAOUAS Elyes (Code Review) 09 Feb '21

09 Feb '21

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/50223 ) Change subject: mb/google/guybrush/bootblock.c: Remove unused includes ...................................................................... Abandoned include will be needed -- To view, visit https://review.coreboot.org/c/coreboot/+/50223 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae532b4137346382f6871ddca4ccd6ecc5dff7b9 Gerrit-Change-Number: 50223 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: mb/google/zork/var/shuboz: Adjust touchscreen settings
by Kane Chen (Code Review) 09 Feb '21

09 Feb '21

Attention is currently required from: Kane Chen. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Bhanu Prakash Maiya, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/50228 to look at the new patch set (#4). Change subject: mb/google/zork/var/shuboz: Adjust touchscreen settings ...................................................................... mb/google/zork/var/shuboz: Adjust touchscreen settings Modify GPIO_140 delay time and add "disable_gpio_export_in_crs" to meet touchscreen controller power on sequence. BUG=b:174442484 BRANCH=master TEST=emerge-zork coreboot chromeos-bootimage Signed-off-by: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Change-Id: I36a7055b7be0963479f8a0f4dc49c92bc8fbdc9d --- M src/mainboard/google/zork/variants/shuboz/overridetree.cb 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/50228/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/50228 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36a7055b7be0963479f8a0f4dc49c92bc8fbdc9d Gerrit-Change-Number: 50228 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: Randy I-Fan Wang <ifanw(a)google.com> Gerrit-Attention: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/zork/variants/vilboz: Disable ASPM L1.2 for SD card reader
by Frank Wu (Code Review) 09 Feb '21

09 Feb '21

Attention is currently required from: John Su, Shirley Her, Martin Roth, Furquan Shaikh, Dtrain Hsu, Kangheui Won, Rob Barnes, chris wang. Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50280 ) Change subject: mb/google/zork/variants/vilboz: Disable ASPM L1.2 for SD card reader ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Hi Google, Would you help to review the CL? Then we can have official CPFE FW later to test. Thank you. The positive result from vendor below: https://partnerissuetracker.corp.google.com/issues/177955523#comment11 The further details about the CL: https://partnerissuetracker.corp.google.com/issues/177955523#comment15 -- To view, visit https://review.coreboot.org/c/coreboot/+/50280 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f24c08411eabb1579c76aaafbe3eb054db54f69 Gerrit-Change-Number: 50280 Gerrit-PatchSet: 4 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Shirley Her <shirley.her(a)bayhubtech.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: chris wang <Chris.Wang(a)amd.com> Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Shirley Her <shirley.her(a)bayhubtech.corp-partner.google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: chris wang <Chris.Wang(a)amd.com> Gerrit-Comment-Date: Tue, 09 Feb 2021 02:59:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/cezanne: Add verstage support
by Marshall Dawson (Code Review) 09 Feb '21

09 Feb '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Felix Held. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50342 ) Change subject: soc/amd/cezanne: Add verstage support ...................................................................... Patch Set 2: (1 comment) File src/soc/amd/cezanne/Kconfig: https://review.coreboot.org/c/coreboot/+/50342/comment/ca7b0ad3_171a224a PS2, Line 128: config VBOOT : select VBOOT_STARTS_IN_BOOTBLOCK : select VBOOT_SEPARATE_VERSTAGE At a _very_ brief glance, I'm not seeing why this is necessary. I'm only comparing to kahlee which ran bootblock->verstage->romstage. Not a big deal, I probably just haven't found it yet... -- To view, visit https://review.coreboot.org/c/coreboot/+/50342 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82874d649db3c9c370e32841e6a9898efb70082e Gerrit-Change-Number: 50342 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 09 Feb 2021 02:42:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common/block: Fix guards for PSP transfer buffer
by Marshall Dawson (Code Review) 09 Feb '21

09 Feb '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Julius Werner. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50403 ) Change subject: soc/amd/common/block: Fix guards for PSP transfer buffer ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/soc/amd/common/block/cpu/noncar/memlayout_transfer_buffer.inc: https://review.coreboot.org/c/coreboot/+/50403/comment/8b12a30c_19064a72 PS1, Line 9: #if CONFIG(VBOOT_STARTS_BEFORE_BOOTBLOCK) || CONFIG(VBOOT_STARTS_IN_BOOTBLOCK) Nit: I wonder if CONFIG(VBOOT) would do just as well here. AFAICS the only other option is STARTS_IN_ROMSTAGE for some older devices, and that's not something we care about for a "nocar" platform. -- To view, visit https://review.coreboot.org/c/coreboot/+/50403 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I444bede3f2b716e1900e7621453351d7fddadaa3 Gerrit-Change-Number: 50403 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Tue, 09 Feb 2021 02:33:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/cezanne: Add root_complex
by Marshall Dawson (Code Review) 09 Feb '21

09 Feb '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50339 ) Change subject: soc/amd/cezanne: Add root_complex ...................................................................... Patch Set 2: (2 comments) File src/soc/amd/cezanne/root_complex.c: https://review.coreboot.org/c/coreboot/+/50339/comment/e8530748_0ac04d35 PS2, Line 130: } maybe a todo for the ioapic? https://review.coreboot.org/c/coreboot/+/50339/comment/7f8135ee_ea047167 PS2, Line 132: and todo for dptc (I assume)? -- To view, visit https://review.coreboot.org/c/coreboot/+/50339 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52682ec2a06c7e219c221648f241e18e26a9358e Gerrit-Change-Number: 50339 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Tue, 09 Feb 2021 02:26:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/cezanne: Enable SOC_AMD_COMMON_BLOCK_SPI
by Marshall Dawson (Code Review) 09 Feb '21

09 Feb '21

Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50344 ) Change subject: soc/amd/cezanne: Enable SOC_AMD_COMMON_BLOCK_SPI ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: From what I can see: SPI_BASE_ALIGNMENT needs to change from BIT(6) to BIT(8) in LPC D14F3xA0, so IMO we should pull this into soc. CZN adds a bit (5) for pspspimmiosel however with now real description. So not sure if we care, however that means SPI_PRESERVE_BITS should be pulled into soc too. According to the PPR, D14F3x0B8 looks obsolete, so we shouldn't call lpc_enable_spi_prefetch(). -- To view, visit https://review.coreboot.org/c/coreboot/+/50344 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4ce819b537333c28d394c925331e3dbf260b7732 Gerrit-Change-Number: 50344 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Comment-Date: Tue, 09 Feb 2021 02:19:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2021