coreboot-gerrit February 2021

coreboot-gerrit@coreboot.org

1 participants
7192 discussions

Change in coreboot[master]: superio/smsc/sch5545: Add include <types.h>
by HAOUAS Elyes (Code Review) 12 Feb '21

12 Feb '21

Attention is currently required from: Felix Held. Hello build bot (Jenkins), Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/50579 to look at the new patch set (#2). Change subject: superio/smsc/sch5545: Add include <types.h> ...................................................................... superio/smsc/sch5545: Add include <types.h> Add missing <types.h>. Change-Id: I16c6a86e8c8863a8e16a63a379484c2b47d5185e Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/superio/smsc/sch5545/sch5545_emi.c M src/superio/smsc/sch5545/sch5545_emi.h 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/50579/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50579 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I16c6a86e8c8863a8e16a63a379484c2b47d5185e Gerrit-Change-Number: 50579 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: sb/intel: Add include <types.h>
by HAOUAS Elyes (Code Review) 12 Feb '21

12 Feb '21

Attention is currently required from: Patrick Rudolph, HAOUAS Elyes. Hello build bot (Jenkins), Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/50577 to look at the new patch set (#2). Change subject: sb/intel: Add include <types.h> ...................................................................... sb/intel: Add include <types.h> Add missing <types.h>. Change-Id: I19d01e1837b1ee946c66d4cc22a5138b64d72078 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/southbridge/intel/bd82x6x/lpc.c M src/southbridge/intel/common/spi.c M src/southbridge/intel/lynxpoint/lpc.c 3 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/50577/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50577 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19d01e1837b1ee946c66d4cc22a5138b64d72078 Gerrit-Change-Number: 50577 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: nb/intel: Add include <types.h>
by HAOUAS Elyes (Code Review) 12 Feb '21

12 Feb '21

Attention is currently required from: Damien Zammit, Patrick Rudolph. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50578 ) Change subject: nb/intel: Add include <types.h> ...................................................................... Patch Set 2: (12 comments) File src/northbridge/intel/gm45/memmap.c: https://review.coreboot.org/c/coreboot/+/50578/comment/b6cdafa1_7433ab10 PS1, Line 24: u32 needs <stdint.h> https://review.coreboot.org/c/coreboot/+/50578/comment/dd986795_6c2e0bef PS1, Line 97: size_t needs <stddef.h> File src/northbridge/intel/haswell/northbridge.c: https://review.coreboot.org/c/coreboot/+/50578/comment/cc856f21_01cc5e87 PS1, Line 49: u32 needs <stdint.h> https://review.coreboot.org/c/coreboot/+/50578/comment/36a017e2_89151f01 PS1, Line 389: size_t needs <stddef.h> File src/northbridge/intel/haswell/raminit.c: https://review.coreboot.org/c/coreboot/+/50578/comment/7a306b00_364335f0 PS1, Line 36: size_t needs <stddef.h> https://review.coreboot.org/c/coreboot/+/50578/comment/d598addb_4a53290d PS1, Line 68: u32 needs <stdint.h> File src/northbridge/intel/i945/memmap.c: https://review.coreboot.org/c/coreboot/+/50578/comment/261af4fe_c58b6c53 PS1, Line 18: u8 needs <stdint.h> https://review.coreboot.org/c/coreboot/+/50578/comment/cb47d361_922baf49 PS1, Line 50: size_t needs <stddef.h> File src/northbridge/intel/pineview/memmap.c: https://review.coreboot.org/c/coreboot/+/50578/comment/0716d706_b0c93f8a PS1, Line 19: u32 needs <stdint.h> https://review.coreboot.org/c/coreboot/+/50578/comment/6983e625_b991dfaf PS1, Line 61: size_t needs <stddef.h> File src/northbridge/intel/x4x/memmap.c: https://review.coreboot.org/c/coreboot/+/50578/comment/3e3e0584_e658a838 PS1, Line 19: u32 needs <stdint.h> https://review.coreboot.org/c/coreboot/+/50578/comment/87299bb0_0fcd49a3 PS1, Line 60: size_t needs <stddef.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/50578 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I801be1ca8da4b1641941d5571d2aa298470f407b Gerrit-Change-Number: 50578 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 12 Feb 2021 09:45:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel: Add include <types.h>
by HAOUAS Elyes (Code Review) 12 Feb '21

12 Feb '21

Attention is currently required from: Damien Zammit, Patrick Rudolph, HAOUAS Elyes. Hello build bot (Jenkins), Damien Zammit, Angel Pons, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/50578 to look at the new patch set (#2). Change subject: nb/intel: Add include <types.h> ...................................................................... nb/intel: Add include <types.h> <types.h> is needed for size_t, u32, u8,... Change-Id: I801be1ca8da4b1641941d5571d2aa298470f407b Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/intel/gm45/memmap.c M src/northbridge/intel/haswell/northbridge.c M src/northbridge/intel/haswell/raminit.c M src/northbridge/intel/i945/memmap.c M src/northbridge/intel/pineview/memmap.c M src/northbridge/intel/x4x/memmap.c 6 files changed, 8 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/50578/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50578 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I801be1ca8da4b1641941d5571d2aa298470f407b Gerrit-Change-Number: 50578 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: sb/intel: Add include <types.h>
by Angel Pons (Code Review) 12 Feb '21

12 Feb '21

Attention is currently required from: Patrick Rudolph, HAOUAS Elyes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50577 ) Change subject: sb/intel: Add include <types.h> ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/50577/comment/91c09071_3e4145b0 PS1, Line 7: sb/intel: Add include <types.h> Reason? Is it needed but missing? -- To view, visit https://review.coreboot.org/c/coreboot/+/50577 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19d01e1837b1ee946c66d4cc22a5138b64d72078 Gerrit-Change-Number: 50577 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 12 Feb 2021 09:40:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: my boards: Do not include `superio.asl` twice
by Angel Pons (Code Review) 12 Feb '21

12 Feb '21

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50500 ) Change subject: my boards: Do not include `superio.asl` twice ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/50500/comment/3fdea90b_1d2382d3 PS1, Line 7: my boards > rather context dependent ;-) Yeah, I know. I said "*my* boards" because I've ported them, and looks like I made the same mistake several times. -- To view, visit https://review.coreboot.org/c/coreboot/+/50500 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I492d4c860a50ac98acbcb3a51fa4d47c94baade3 Gerrit-Change-Number: 50500 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 12 Feb 2021 09:39:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel: Add include <types.h>
by Angel Pons (Code Review) 12 Feb '21

12 Feb '21

Attention is currently required from: Damien Zammit, Patrick Rudolph, HAOUAS Elyes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50578 ) Change subject: nb/intel: Add include <types.h> ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/50578/comment/edac5f06_b35a35aa PS1, Line 7: nb/intel: Add include <types.h> Reason? -- To view, visit https://review.coreboot.org/c/coreboot/+/50578 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I801be1ca8da4b1641941d5571d2aa298470f407b Gerrit-Change-Number: 50578 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 12 Feb 2021 09:32:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/spi: Stop using a variable-length array
by Angel Pons (Code Review) 12 Feb '21

12 Feb '21

Attention is currently required from: Julius Werner, Jacob Garber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50480 ) Change subject: drivers/spi: Stop using a variable-length array ...................................................................... Patch Set 1: (1 comment) File src/drivers/spi/spi_flash.c: https://review.coreboot.org/c/coreboot/+/50480/comment/49c196fd_c7a7cb75 PS1, Line 95: u8 buff[4 + (1 << DEFAULT_PAGE_SIZE_SHIFT)]; > I mean, I don't really see how that would be an issue with what I suggested? I think it makes sense […] I had a different idea to avoid having to concatenate any buffers in this function. Initially I thought it made more sense, but after actually trying it out I didn't really like the result. I still pushed it to a different patch because I had already made it. -- To view, visit https://review.coreboot.org/c/coreboot/+/50480 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib630bff1b496bc276616989d4506a3c96f242e26 Gerrit-Change-Number: 50480 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Comment-Date: Fri, 12 Feb 2021 09:31:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86/ioapic: clear full upper byte when writing ID register
by Angel Pons (Code Review) 12 Feb '21

12 Feb '21

Attention is currently required from: Raul Rangel, Nico Huber, Martin Roth, Arthur Heymans, Kyösti Mälkki, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50574 ) Change subject: arch/x86/ioapic: clear full upper byte when writing ID register ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/50574 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id730ed0abbe69d4679ec07910230cae1881c6c9a Gerrit-Change-Number: 50574 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 12 Feb 2021 09:29:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/purism/librem_mini: move mainboard asl under variant
by Angel Pons (Code Review) 12 Feb '21

12 Feb '21

Attention is currently required from: Matt DeVillier, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50499 ) Change subject: mb/purism/librem_mini: move mainboard asl under variant ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50499 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c2c43e5ae5efe161cc2135c920a1b9dee5a1317 Gerrit-Change-Number: 50499 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Fri, 12 Feb 2021 09:25:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2021