coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: northbridge/amd/agesa/family14: Enable PARALLEL_MP
by Michał Kopeć (Code Review) 08 Dec '21

08 Dec '21

Michał Kopeć has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/59841 ) Change subject: northbridge/amd/agesa/family14: Enable PARALLEL_MP ...................................................................... Abandoned Duplicate of CB:59807 -- To view, visit https://review.coreboot.org/c/coreboot/+/59841 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I958bffefb2b60abb33b12f25335369496e70e9e8 Gerrit-Change-Number: 59841 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: libpayload: Add include/commonlib/bsd to installed headers
by Jakub Czapiga (Code Review) 08 Dec '21

08 Dec '21

Attention is currently required from: Patrick Georgi. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59916 ) Change subject: libpayload: Add include/commonlib/bsd to installed headers ...................................................................... Patch Set 3: (3 comments) File payloads/libpayload/Makefile.inc: https://review.coreboot.org/c/coreboot/+/59916/comment/4e639ad2_5ee627a0 PS1, Line 74: early-headers-install: > I suppose this question will become moot when we don't have that early header install step anymore? Done File payloads/libpayload/Makefile.inc: https://review.coreboot.org/c/coreboot/+/59916/comment/c0aebede_01875313 PS2, Line 75: printf " INSTALL $(obj)/libpayload/include\n" : install -m 755 -d "$(obj)/libpayload/include" : for file in `find include -name *.h -type f`; do \ : install -m 755 -d "$(obj)/libpayload/`dirname $$file`"; \ : install -m 644 "$$file" "$(obj)/libpayload/$$file"; \ : done : for file in `find $(coreboottop)/src/commonlib/bsd/include -name *.h -type f`; do \ : dest_file=$$(realpath --relative-to=$(coreboottop)/src/commonlib/bsd/ $$file); \ : install -m 755 -d "$(obj)/libpayload/`dirname $$dest_file`"; \ : install -m 644 "$$file" "$(obj)/libpayload/$$dest_file"; \ : done > Seeing what this requires it might indeed be easier to just ensure that "make install" copies common […] If one wants to work on libpayload and test it with their payload, adding `make install` step should be easy enough. I think, that we are not obligated to keep the build directory structure stable. Only the installation directory has to be consistent. https://review.coreboot.org/c/coreboot/+/59916/comment/732017a8_85a2fad8 PS2, Line 132: for file in `find $(coreboottop)/src/commonlib/bsd/include -name *.h -type f`; do \ > The scope of this change is to copy commonlib in place, I'd ignore any issues about pdcurses here. ACK > Changing the build directory structure _might_ help, but it's also more involved than just copying the right files in the install step, so while I thought that might be a good idea, it apparently is more complicated than it's worth. As I mentioned in another comment, we should not be obligated to keep the build directory structure consistent, only the installation directory. I think that it is not worth to mimic install dir in build dir. Calling `make install DESTDIR=xxx` is fast and easy, and adding it as a step before building payload should not be problematic. -- To view, visit https://review.coreboot.org/c/coreboot/+/59916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc7175240f3077ec98280331f9a952310aae4341 Gerrit-Change-Number: 59916 Gerrit-PatchSet: 3 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Dec 2021 10:09:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <patrick(a)coreboot.org> Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/zork/var/shuboz: Add fw_config probe for ALC5682-VD & VS
by Kane Chen (Code Review) 08 Dec '21

08 Dec '21

Attention is currently required from: Kangheui Won, Isaac Lee, Reka Norman, chris wang, Felix Held. Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59558 ) Change subject: mb/google/zork/var/shuboz: Add fw_config probe for ALC5682-VD & VS ...................................................................... Patch Set 14: (1 comment) Patchset: PS8: > Please fix compile errors. Done. Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/59558 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c78aa166010ffa4d0cacc8a11d418d5a6906749 Gerrit-Change-Number: 59558 Gerrit-PatchSet: 14 Gerrit-Owner: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com> Gerrit-Reviewer: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: chris wang <Chris.Wang(a)amd.com> Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Randy Wang <ifanw(a)google.com> Gerrit-CC: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Isaac Lee <isaaclee(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: chris wang <Chris.Wang(a)amd.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 08 Dec 2021 10:04:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kangheui Won <khwon(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Add include/commonlib/bsd to installed headers
by Jakub Czapiga (Code Review) 08 Dec '21

08 Dec '21

Attention is currently required from: Jakub Czapiga. Hello build bot (Jenkins), Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59916 to look at the new patch set (#3). Change subject: libpayload: Add include/commonlib/bsd to installed headers ...................................................................... libpayload: Add include/commonlib/bsd to installed headers Copy header files from the main commonlib/bsd to libpayload output installation directory. Change-Id: Idc7175240f3077ec98280331f9a952310aae4341 Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> --- M payloads/libpayload/Makefile.inc 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/59916/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/59916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc7175240f3077ec98280331f9a952310aae4341 Gerrit-Change-Number: 59916 Gerrit-PatchSet: 3 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cpu/amd/agesa/Kconfig: select NO_SMM for Family 14h
by Michał Kopeć (Code Review) 08 Dec '21

08 Dec '21

Attention is currently required from: Michał Żygowski. Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59809 ) Change subject: cpu/amd/agesa/Kconfig: select NO_SMM for Family 14h ...................................................................... Patch Set 6: (1 comment) File src/cpu/amd/agesa/Kconfig: https://review.coreboot.org/c/coreboot/+/59809/comment/d70be0bc_fe523966 PS5, Line 15: select NO_SMM if CPU_AMD_AGESA_FAMILY14 > Maybe let's move those setting to the appropriate CPU Kconfig file. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59809 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09bbe036a88dada847219606ec79c68e7ca8e5cc Gerrit-Change-Number: 59809 Gerrit-PatchSet: 6 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Wed, 08 Dec 2021 09:37:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/amd/agesa/Kconfig: select NO_SMM for Family 14h
by Michał Kopeć (Code Review) 08 Dec '21

08 Dec '21

Attention is currently required from: Michał Kopeć. Hello build bot (Jenkins), Michał Żygowski, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59809 to look at the new patch set (#6). Change subject: cpu/amd/agesa/Kconfig: select NO_SMM for Family 14h ...................................................................... cpu/amd/agesa/Kconfig: select NO_SMM for Family 14h Select NO_SMM for Family 14h since since there is not a single platform selecting HAVE_SMI_HANDLER. TEST=Boot Debian 11 on PC Engines apu1 Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Change-Id: I09bbe036a88dada847219606ec79c68e7ca8e5cc --- M src/cpu/amd/agesa/Kconfig M src/cpu/amd/agesa/family14/Kconfig M src/cpu/amd/agesa/family15tn/Kconfig M src/cpu/amd/agesa/family16kb/Kconfig 4 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/59809/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/59809 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09bbe036a88dada847219606ec79c68e7ca8e5cc Gerrit-Change-Number: 59809 Gerrit-PatchSet: 6 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: sb/amd/pi/hudson/early_init: fix setting SPI_USE_SPI100 in SPI100_ENABLE
by Michał Żygowski (Code Review) 08 Dec '21

08 Dec '21

Attention is currently required from: Michał Kopeć, Felix Held. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59934 ) Change subject: sb/amd/pi/hudson/early_init: fix setting SPI_USE_SPI100 in SPI100_ENABLE ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: Felix if you want, you may add Tested-by: <me> or something like that. I was booting Debian 11 with kernel 5.10 on apu2, which you may also add to TEST= -- To view, visit https://review.coreboot.org/c/coreboot/+/59934 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifbd960a9509542b28f03326a3066995540260bef Gerrit-Change-Number: 59934 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 08 Dec 2021 09:32:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/zork/var/shuboz: Add fw_config probe for ALC5682-VD & VS
by Kane Chen (Code Review) 08 Dec '21

08 Dec '21

Attention is currently required from: Isaac Lee, Reka Norman, chris wang, Felix Held. Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59558 ) Change subject: mb/google/zork/var/shuboz: Add fw_config probe for ALC5682-VD & VS ...................................................................... Patch Set 14: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/59558 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c78aa166010ffa4d0cacc8a11d418d5a6906749 Gerrit-Change-Number: 59558 Gerrit-PatchSet: 14 Gerrit-Owner: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com> Gerrit-Reviewer: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: chris wang <Chris.Wang(a)amd.com> Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Randy Wang <ifanw(a)google.com> Gerrit-CC: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Isaac Lee <isaaclee(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: chris wang <Chris.Wang(a)amd.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 08 Dec 2021 09:31:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/zork/var/shuboz: Add fw_config probe for ALC5682-VD & VS
by Kane Chen (Code Review) 08 Dec '21

08 Dec '21

Attention is currently required from: Isaac Lee, Reka Norman, chris wang, Felix Held. Hello build bot (Jenkins), Kangheui Won, Isaac Lee, chris wang, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59558 to look at the new patch set (#14). Change subject: mb/google/zork/var/shuboz: Add fw_config probe for ALC5682-VD & VS ...................................................................... mb/google/zork/var/shuboz: Add fw_config probe for ALC5682-VD & VS ALC5682-VD/ALC5682I-VS load different kernel driver by different hid name. Update hid name and machine_dev depending on the AUDIO_CODEC_SOURCE field of fw_config. Define FW_CONFIG bits 36 - 37 (SSFC bits 4 - 5) for codec selection. ALC5682-VD: _HID = "10EC5682" ALC5682I-VS: _HID = "RTL5682" BUG=b:198689479 BRANCH=zork TEST=ALC5682-VD/ALC5682I-VS audio codec can work Signed-off-by: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Change-Id: I0c78aa166010ffa4d0cacc8a11d418d5a6906749 --- M src/mainboard/google/zork/variants/baseboard/helpers.c M src/mainboard/google/zork/variants/shuboz/overridetree.cb 2 files changed, 89 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/59558/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/59558 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c78aa166010ffa4d0cacc8a11d418d5a6906749 Gerrit-Change-Number: 59558 Gerrit-PatchSet: 14 Gerrit-Owner: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com> Gerrit-Reviewer: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: chris wang <Chris.Wang(a)amd.com> Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Randy Wang <ifanw(a)google.com> Gerrit-CC: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Isaac Lee <isaaclee(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: chris wang <Chris.Wang(a)amd.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: Add dewatt device config
by Kenneth Chan (Code Review) 08 Dec '21

08 Dec '21

Kenneth Chan has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/59839 ) Change subject: mb/google/guybrush/var/dewatt: Add dewatt device config ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/59839 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01eb3b7c194dffd417b81386903d5bd437cd9b3e Gerrit-Change-Number: 59839 Gerrit-PatchSet: 3 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021