Attention is currently required from: Bao Zheng, Zheng Bao.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59919 )
Change subject: Google/Nipperkin: Add board specific values for eDP tuning
......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59919/comment/fdcaa7fc_fd0cb16c
PS5, Line 7: Google/Nipperkin
mb/google/guybrush/var/nipperkin
https://review.coreboot.org/c/coreboot/+/59919/comment/95887a36_eacf26b6
PS5, Line 9: These values are got from experiment.
How exactly?
https://review.coreboot.org/c/coreboot/+/59919/comment/f3a011cc_10ff3414
PS5, Line 9: document
That means the testing document? (Not the datasheet.)
File src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59919/comment/761040c6_7bd55807
PS5, Line 102: 0x1F
In coreboot it’s common to write it lowercase.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59919
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7aa8c594d9f5caa6b2523dac079aef89e623c56f
Gerrit-Change-Number: 59919
Gerrit-PatchSet: 5
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Thu, 09 Dec 2021 11:09:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Henry Sun, Paul Menzel, Marco Chen.
Hello build bot (Jenkins), Henry Sun, Marco Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/59859
to look at the new patch set (#10).
Change subject: mb/google/octopus/var/ampton: add touchscreen into SSFC support
......................................................................
mb/google/octopus/var/ampton: add touchscreen into SSFC support
Add ELAN9008 (eKTH6913UAY) support.
BUG=b:204441413
BRANCH=octopus
TEST=Set CBI SSFC BIT15-17 to select touchscreen controller,
and test touchscreen works
Change-Id: Ie0919d40a6c39ffaed52bb9e24a3509eb353127c
Signed-off-by: Paul Huang <paul2_huang(a)pegatron.corp-partner.google.com>
---
M src/mainboard/google/octopus/variants/ampton/Makefile.inc
M src/mainboard/google/octopus/variants/ampton/overridetree.cb
A src/mainboard/google/octopus/variants/ampton/variant.c
M src/mainboard/google/octopus/variants/baseboard/cbi_ssfc.c
M src/mainboard/google/octopus/variants/baseboard/include/baseboard/cbi_ssfc.h
5 files changed, 98 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/59859/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/59859
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0919d40a6c39ffaed52bb9e24a3509eb353127c
Gerrit-Change-Number: 59859
Gerrit-PatchSet: 10
Gerrit-Owner: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Marco Chen <marcochen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Marco Chen <marcochen(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Henry Sun, Paul Menzel, Paul2 Huang.
Hello build bot (Jenkins), Henry Sun, Marco Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/59856
to look at the new patch set (#7).
Change subject: mb/google/octopus: add ALC5682I-VS to be supported in the SSFC
......................................................................
mb/google/octopus: add ALC5682I-VS to be supported in the SSFC
Add ALC5682I-VS codec support.
ALC5682I-VD/ALC5682I-VS load different hid name
depending on SSFC.
BUG=b:198722640
BRANCH=octopus
TEST=Set CBI SSFC BIT9-11 to select codec,
and test audio works
Change-Id: I80be12d88e100ce8586371fc49b36447859e24f8
Signed-off-by: Paul Huang <paul2_huang(a)pegatron.corp-partner.google.com>
---
M src/mainboard/google/octopus/mainboard.c
M src/mainboard/google/octopus/variants/baseboard/include/baseboard/cbi_ssfc.h
M src/mainboard/google/octopus/variants/baseboard/nhlt.c
3 files changed, 24 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/59856/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/59856
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80be12d88e100ce8586371fc49b36447859e24f8
Gerrit-Change-Number: 59856
Gerrit-PatchSet: 7
Gerrit-Owner: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Marco Chen <marcochen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: YH Lin, Joey Peng, Nick Vaccaro.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59938 )
Change subject: mb/google/brya/variants/taniks: Configure GPIOs according to schematics
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59938/comment/a89679ad_e0e517de
PS4, Line 9: Update
Add?
https://review.coreboot.org/c/coreboot/+/59938/comment/f9ab73c1_14b2657a
PS4, Line 10:
Which schematics version is that? Please add it to the commit message.
File src/mainboard/google/brya/variants/taniks/gpio.c:
https://review.coreboot.org/c/coreboot/+/59938/comment/daeae087_2e96a137
PS4, Line 153: * FPMCU not working after a S3 resume. This is a known issue.
Is there a bug report for that?
--
To view, visit https://review.coreboot.org/c/coreboot/+/59938
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5c4ead4ad59137e1764e1226415ab6041c68aab
Gerrit-Change-Number: 59938
Gerrit-PatchSet: 4
Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Thu, 09 Dec 2021 10:52:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59692 )
Change subject: cpu/x86/mp_init.c: Make it work for !CONFIG_SMP
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/59692
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia0e8fdf8ed7bc2e0e4ff01be8d3e3c3cb837e6c7
Gerrit-Change-Number: 59692
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Thu, 09 Dec 2021 10:47:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: YH Lin, Tim Wawrzynczak.
Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59998 )
Change subject: mb/google/brya/variant/taniks: Update devicetree settings
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/59998
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib333150117832480f70fbe13bdbdf2982a7f70e6
Gerrit-Change-Number: 59998
Gerrit-PatchSet: 2
Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Thu, 09 Dec 2021 10:11:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment