Attention is currently required from: Henry Sun, Aseda Aboagye, Karthik Ramasubramanian, Felix Held.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59991 )
Change subject: mb/google/dedede/var/madoo: Generate new SPD ID for new memory parts
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Could googlers help to review the CL? Thank you.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59991
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b2f447a610a0a857e819ede257ac89cfd817018
Gerrit-Change-Number: 59991
Gerrit-PatchSet: 2
Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 14 Dec 2021 01:57:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chiu, Bhanu Prakash Maiya, Eric Peers.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60082 )
Change subject: mb/google/guybrush/var/nipperkin: config eSPI as dedicated alert
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/60082
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55cda7a1af22e555a4f55285cb7e337a69e6c234
Gerrit-Change-Number: 60082
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Attention: Eric Peers <epeers(a)google.com>
Gerrit-Comment-Date: Tue, 14 Dec 2021 01:32:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chiu, Bhanu Prakash Maiya, Eric Peers.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60082 )
Change subject: mb/google/guybrush/var/nipperkin: config eSPI as dedicated alert
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Did you run multiple boot and resume cycles?
--
To view, visit https://review.coreboot.org/c/coreboot/+/60082
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55cda7a1af22e555a4f55285cb7e337a69e6c234
Gerrit-Change-Number: 60082
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Attention: Eric Peers <epeers(a)google.com>
Gerrit-Comment-Date: Tue, 14 Dec 2021 01:29:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Paul Menzel, YH Lin.
Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60077 )
Change subject: mb/google/brya/var/taniks: Configure DRIVER_TPM_I2C_BUS
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60077/comment/c1ffe972_be7589cd
PS2, Line 7: for taniks
> Remove, as it’s already part of the prefix?
Done
https://review.coreboot.org/c/coreboot/+/60077/comment/c1d9554e_54bb4bee
PS2, Line 9: address
> nit: remove this word, the I2C address is specified in devicetree, this is just which I2C bus to use […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/60077
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b1719c3140c13f67e7cb0e6a69257774884bd4d
Gerrit-Change-Number: 60077
Gerrit-PatchSet: 3
Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: YH Lin <yueherngl(a)chromium.org>
Gerrit-Comment-Date: Tue, 14 Dec 2021 00:57:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Joey Peng, YH Lin.
Hello build bot (Jenkins), Tim Wawrzynczak, YH Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60077
to look at the new patch set (#3).
Change subject: mb/google/brya/var/taniks: Configure DRIVER_TPM_I2C_BUS
......................................................................
mb/google/brya/var/taniks: Configure DRIVER_TPM_I2C_BUS
Add I2C bus for taniks in Kconfig
BUG=b:210390520
TEST=emerge-brya coreboot and can boot to OS.
Signed-off-by: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Change-Id: I9b1719c3140c13f67e7cb0e6a69257774884bd4d
---
M src/mainboard/google/brya/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/60077/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/60077
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b1719c3140c13f67e7cb0e6a69257774884bd4d
Gerrit-Change-Number: 60077
Gerrit-PatchSet: 3
Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: YH Lin, Tim Wawrzynczak, Paul Menzel, Nick Vaccaro.
Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59998 )
Change subject: mb/google/brya/variant/taniks: Add devicetree settings
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/brya/variants/taniks/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59998/comment/941dd6c4_5ac52efd
PS4, Line 106: PchSerialIoPci
> `PchSerialIoDisabled` […]
Thanks for the remind!
Updated in latest patch.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59998
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib333150117832480f70fbe13bdbdf2982a7f70e6
Gerrit-Change-Number: 59998
Gerrit-PatchSet: 5
Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Tue, 14 Dec 2021 00:56:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: YH Lin, Paul Menzel, Nick Vaccaro.
Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59938 )
Change subject: mb/google/brya/variants/taniks: Configure GPIOs according to schematics
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59938/comment/e301b77b_5df1199a
PS5, Line 10: .T
> nit: space after `. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/59938
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5c4ead4ad59137e1764e1226415ab6041c68aab
Gerrit-Change-Number: 59938
Gerrit-PatchSet: 6
Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Tue, 14 Dec 2021 00:53:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: YH Lin, Joey Peng, Paul Menzel, Nick Vaccaro.
Hello build bot (Jenkins), YH Lin, Tim Wawrzynczak, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/59938
to look at the new patch set (#6).
Change subject: mb/google/brya/variants/taniks: Configure GPIOs according to schematics
......................................................................
mb/google/brya/variants/taniks: Configure GPIOs according to schematics
Add initial gpio configuration for taniks according to schematics
G570_MB_CHROME_1207_1630_ADC. The schematics reserved HPS and FP but
taniks doesn't use them, so set FP and HPS related pins to NC.
BUG=b:209492408, b:209553289
TEST=FW_NAME=taniks emerge-brya coreboot
Signed-off-by: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Change-Id: Ic5c4ead4ad59137e1764e1226415ab6041c68aab
---
A src/mainboard/google/brya/variants/taniks/Makefile.inc
A src/mainboard/google/brya/variants/taniks/gpio.c
2 files changed, 233 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/59938/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/59938
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5c4ead4ad59137e1764e1226415ab6041c68aab
Gerrit-Change-Number: 59938
Gerrit-PatchSet: 6
Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: newpatchset
Kevin Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59973 )
Change subject: mb/google/brya/var/taeko: Fix PLD group order (W/A)
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
> It's a workaround for a kernel patch that seems buggy (which has now been reverted). […]
Tim,
I will create an issue track on this and revert this CL before FSI, prevention someone using wrong OS version.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59973
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia4cf2d735de524ae721800600536923d1d47f04b
Gerrit-Change-Number: 59973
Gerrit-PatchSet: 8
Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com>
Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 14 Dec 2021 00:49:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment