coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/acer/g43t-am3: Add documentation
by Michael Büchler (Code Review) 18 Dec '21

18 Dec '21

Attention is currently required from: Felix Singer, Paul Menzel, Michael Büchler. Hello Felix Singer, build bot (Jenkins), Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56838 to look at the new patch set (#3). Change subject: mb/acer/g43t-am3: Add documentation ...................................................................... mb/acer/g43t-am3: Add documentation Signed-off-by: Michael Büchler <michael.buechler(a)posteo.net> Change-Id: I0e296b3efbff0260f32badc699f1062f9885fa53 --- A Documentation/mainboard/acer/g43t-am3.md M Documentation/mainboard/index.md 2 files changed, 176 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/56838/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/56838 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e296b3efbff0260f32badc699f1062f9885fa53 Gerrit-Change-Number: 56838 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Büchler <michael.buechler(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michael Büchler <michael.buechler(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/zork: use full path of SoC's chip.h
by Angel Pons (Code Review) 18 Dec '21

18 Dec '21

Attention is currently required from: Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60202 ) Change subject: mb/google/zork: use full path of SoC's chip.h ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60202 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I50d8c45e711dc62afe6f80e0f66422bcc9924dfd Gerrit-Change-Number: 60202 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 18 Dec 2021 01:02:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/amd/bilby,mandolin: use full path of SoC's chip.h
by Angel Pons (Code Review) 18 Dec '21

18 Dec '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Aaron Durbin, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60200 ) Change subject: mb/amd/bilby,mandolin: use full path of SoC's chip.h ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60200 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iba1948ae2332788b7e0ec9b4e3cea35c6608b152 Gerrit-Change-Number: 60200 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 18 Dec 2021 01:02:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/stoneyridge/include/southbridge: remove unneeded chip.h include
by Angel Pons (Code Review) 18 Dec '21

18 Dec '21

Attention is currently required from: Marshall Dawson, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60199 ) Change subject: soc/amd/stoneyridge/include/southbridge: remove unneeded chip.h include ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60199 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b37efc89e505c2de99536b59e7d7e2bb1d54bff Gerrit-Change-Number: 60199 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 18 Dec 2021 01:02:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/amd/gardenia,padmelon;mb/google/kahlee: use full path of SoC's chip.h
by Angel Pons (Code Review) 18 Dec '21

18 Dec '21

Attention is currently required from: Aaron Durbin, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60198 ) Change subject: mb/amd/gardenia,padmelon;mb/google/kahlee: use full path of SoC's chip.h ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60198 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10a18efb92ac0c3cad31044156e32aa6afe1d4d1 Gerrit-Change-Number: 60198 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 18 Dec 2021 01:02:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/amd/gardenia,padmelon;mb/google/kahlee: add missing soc/gpio includes
by Angel Pons (Code Review) 18 Dec '21

18 Dec '21

Attention is currently required from: Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60197 ) Change subject: mb/amd/gardenia,padmelon;mb/google/kahlee: add missing soc/gpio includes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie716633bd7602d5e4a7e186aa9e444b7f70dab56 Gerrit-Change-Number: 60197 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 18 Dec 2021 01:02:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd: remove root of SoC directory from include path
by Angel Pons (Code Review) 18 Dec '21

18 Dec '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Aaron Durbin, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60201 ) Change subject: soc/amd: remove root of SoC directory from include path ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60201 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45ed219e4e0cccf3d4f04cc70dc1ef77c518afff Gerrit-Change-Number: 60201 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 18 Dec 2021 01:01:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common/lpc/espi_util: use enum cb_err type for return values
by Felix Held (Code Review) 18 Dec '21

18 Dec '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Hello Jason Glenesk, Raul Rangel, Marshall Dawson, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60207 to look at the new patch set (#2). Change subject: soc/amd/common/lpc/espi_util: use enum cb_err type for return values ...................................................................... soc/amd/common/lpc/espi_util: use enum cb_err type for return values Use enum cb_err as return type of all functions that aren't exposed outside of this compilation unit. The checks if a function has returned a failure are replaced with checks if the return value isn't CB_SUCCESS which is equivalent if only those two values are used, but also detects a failure if any unexpected value would be returned. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: If8c703f62babac31948d0878e91bd31b31bebc01 --- M src/soc/amd/common/block/lpc/espi_util.c 1 file changed, 75 insertions(+), 71 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/60207/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60207 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If8c703f62babac31948d0878e91bd31b31bebc01 Gerrit-Change-Number: 60207 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/amd/common/lpc/espi_util: use enum cb_err type for return values
by build bot (Jenkins) (Code Review) 18 Dec '21

18 Dec '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60207 ) Change subject: soc/amd/common/lpc/espi_util: use enum cb_err type for return values ...................................................................... Patch Set 1: (4 comments) File src/soc/amd/common/block/lpc/espi_util.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135779): https://review.coreboot.org/c/coreboot/+/60207/comment/86bb4ffa_41d0f08a PS1, Line 740: static enum cb_err espi_set_general_configuration(const struct espi_config *mb_cfg, uint32_t slave_caps) line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135779): https://review.coreboot.org/c/coreboot/+/60207/comment/c254da3c_49770290 PS1, Line 794: static enum cb_err espi_set_channel_configuration(uint32_t slave_config, uint32_t slave_reg_addr, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135779): https://review.coreboot.org/c/coreboot/+/60207/comment/dfcd0322_a1e37264 PS1, Line 840: static enum cb_err espi_setup_periph_channel(const struct espi_config *mb_cfg, uint32_t slave_caps) line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135779): https://review.coreboot.org/c/coreboot/+/60207/comment/01ea62be_1dcdc510 PS1, Line 892: static enum cb_err espi_setup_flash_channel(const struct espi_config *mb_cfg, uint32_t slave_caps) line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/60207 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If8c703f62babac31948d0878e91bd31b31bebc01 Gerrit-Change-Number: 60207 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Comment-Date: Sat, 18 Dec 2021 00:42:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP,NOTFORMERGE] soc/amd/common/lpc/espi_util: add TODO to espi_wait...
by Felix Held (Code Review) 18 Dec '21

18 Dec '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60209 ) Change subject: [WIP,NOTFORMERGE] soc/amd/common/lpc/espi_util: add TODO to espi_wait_channel_ready ...................................................................... [WIP,NOTFORMERGE] soc/amd/common/lpc/espi_util: add TODO to espi_wait_channel_ready I'm not 100% sure yet if not checking the return value is intended or not. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Iff1a0670e17b9d6c6f4daf2ea56badf6c428b8c9 --- M src/soc/amd/common/block/lpc/espi_util.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/60209/1 diff --git a/src/soc/amd/common/block/lpc/espi_util.c b/src/soc/amd/common/block/lpc/espi_util.c index 4c42c04..a823c44 100644 --- a/src/soc/amd/common/block/lpc/espi_util.c +++ b/src/soc/amd/common/block/lpc/espi_util.c @@ -771,6 +771,7 @@ stopwatch_init_usecs_expire(&sw, ESPI_CH_READY_TIMEOUT_US); do { + /* TODO: Handle espi_get_configuration failure? */ espi_get_configuration(slave_reg_addr, &config); if (espi_slave_is_channel_ready(config)) return CB_SUCCESS; -- To view, visit https://review.coreboot.org/c/coreboot/+/60209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iff1a0670e17b9d6c6f4daf2ea56badf6c428b8c9 Gerrit-Change-Number: 60209 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021