coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: [RFC] smp/spinlock: Use compiler builtins
by Kyösti Mälkki (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Raul Rangel. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60253 ) Change subject: [RFC] smp/spinlock: Use compiler builtins ...................................................................... Patch Set 1: (1 comment) File src/include/smp/spinlock.h: https://review.coreboot.org/c/coreboot/+/60253/comment/8c32c67a_54d62cf6 PS1, Line 22: return !__atomic_load_1(&lock->locked, __ATOMIC_RELAXED); Inverted -- To view, visit https://review.coreboot.org/c/coreboot/+/60253 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6694784aa0810cd877886ef95434f62e3aefce6c Gerrit-Change-Number: 60253 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Comment-Date: Tue, 21 Dec 2021 12:14:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Rename ADL_P_482_CORE to ADL_P_482_28W_CORE
by Paul Menzel (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: V Sowmya, Tim Wawrzynczak, Kane Chen, Curtis Chen, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60267 ) Change subject: soc/intel/alderlake: Rename ADL_P_482_CORE to ADL_P_482_28W_CORE ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60267/comment/f03ee06f_5347bec4 PS1, Line 9: Every VR config items are not the same between ADL-P 4+8+2 28 & 45W. The VR config items differ between ADL-P 4+8+2 28W and 45W. The current settings are for ADL-P 4+8+2 28W, so rename the enum member. -- To view, visit https://review.coreboot.org/c/coreboot/+/60267 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I863023eba5fda3b6d45059383d6030427913ca9a Gerrit-Change-Number: 60267 Gerrit-PatchSet: 1 Gerrit-Owner: Curtis Chen <curtis.chen(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Attention: Curtis Chen <curtis.chen(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 21 Dec 2021 12:06:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: FSP 2511 headers include.
by Paul Menzel (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Saurabh Mishra, Tim Wawrzynczak, Balaji Manigandan, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60259 ) Change subject: FSP 2511 headers include. ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60259/comment/54d0b4c6_067214e2 PS1, Line 7: Meminit function call in coreboot has been updated as per new FSP : UPD and DQS in headers. : : src/soc/intel/alderlake/meminit.c : Changes adopted as per new FSP DQS & : UPD calls. : src/soc/intel/alderlake/fsp_params.c : Updated LpmStateEnableMask UPD > Ack The message summary still does not follow the common style. Please see how other FSP header commits are worded. -- To view, visit https://review.coreboot.org/c/coreboot/+/60259 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c6ae72610da39fc18ff252c440d006e83c576f3 Gerrit-Change-Number: 60259 Gerrit-PatchSet: 3 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.corp-partner.google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 21 Dec 2021 12:02:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Saurabh Mishra <mishra.saurabh(a)intel.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: docker/Makefile: Use all instead of all_without_gdb
by Paul Menzel (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Hsuan Ting Chen, Martin Roth, Hsuan-ting Chen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60268 ) Change subject: docker/Makefile: Use all instead of all_without_gdb ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60268/comment/f327a166_2bc56c8d PS1, Line 10: it What fails? -- To view, visit https://review.coreboot.org/c/coreboot/+/60268 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I06c6d8e36dfd4e6a00ddec8b640b608ab1ba614c Gerrit-Change-Number: 60268 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Comment-Date: Tue, 21 Dec 2021 11:59:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Add a new baseboard nissa
by Paul Menzel (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Kangheui Won, Reka Norman, Tim Wawrzynczak. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60271 ) Change subject: mb/google/brya: Add a new baseboard nissa ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60271/comment/82486638_31d7d9e5 PS2, Line 7: mb/google/brya: Add a new baseboard nissa _ with variants nivviks and nereid -- To view, visit https://review.coreboot.org/c/coreboot/+/60271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a3975fb7a45577fec8ea7c6c9f6ea042ab8cba5 Gerrit-Change-Number: 60271 Gerrit-PatchSet: 2 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Tue, 21 Dec 2021 11:52:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/starlabs/labtop: Enable I2C4
by Paul Menzel (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Sean Rhodes. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60264 ) Change subject: mb/starlabs/labtop: Enable I2C4 ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60264/comment/022ea7e6_70669651 PS2, Line 7: mb/starlabs/labtop: Enable I2C4 Mayeb: > Enable I2C4 to get UART2 working https://review.coreboot.org/c/coreboot/+/60264/comment/95946deb_70a69255 PS2, Line 12: How did you test UART2 is working? -- To view, visit https://review.coreboot.org/c/coreboot/+/60264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c2c4f67672ba5667ebdae9ecc01054449dd3dfd Gerrit-Change-Number: 60264 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Comment-Date: Tue, 21 Dec 2021 11:49:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: coreboot-sdk/Dockerfile: Build and install libflashrom
by Hsuan-ting Chen (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Hsuan Ting Chen, Martin Roth, Paul Menzel. Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60095 ) Change subject: coreboot-sdk/Dockerfile: Build and install libflashrom ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: Set to WIP This code is not correct yet; we did not generate the .pc file. And currently we could only generate this pc file with meson build. -- To view, visit https://review.coreboot.org/c/coreboot/+/60095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7269a5140fb02da6d143b339116db2fd089f8da8 Gerrit-Change-Number: 60095 Gerrit-PatchSet: 5 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 21 Dec 2021 11:12:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mainboard/starlabs: Add LabTop Mk IV
by Sean Rhodes (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Angel Pons. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58428 ) Change subject: mainboard/starlabs: Add LabTop Mk IV ...................................................................... Patch Set 72: (1 comment) File src/mainboard/starlabs/labtop/variants/cml/devicetree.cb: https://review.coreboot.org/c/coreboot/+/58428/comment/2a782b45_9a3d767a PS66, Line 125: device pci 19.0 off end # I2C4 > Haven't checked, but I think so. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/58428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idbaa907dc38dc521961806132f21b7a90324ec9c Gerrit-Change-Number: 58428 Gerrit-PatchSet: 72 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 21 Dec 2021 10:13:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <admin(a)starlabs.systems> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/starlabs/labtop: Enable I2C4
by Sean Rhodes (Code Review) 21 Dec '21

21 Dec '21

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60264 ) Change subject: mb/starlabs/labtop: Enable I2C4 ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60264/comment/8ae3156e_cb52f0ad PS1, Line 9: Enable I2C4 to allow for proper enumeration but avoid FSP configuring it. > nit: The period goes past the 72-char line length limit. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c2c4f67672ba5667ebdae9ecc01054449dd3dfd Gerrit-Change-Number: 60264 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Dec 2021 10:10:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/starlabs/labtop: Enable I2C4
by Sean Rhodes (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Sean Rhodes. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60264 to look at the new patch set (#2). Change subject: mb/starlabs/labtop: Enable I2C4 ...................................................................... mb/starlabs/labtop: Enable I2C4 Enable unused I2C4 PCI device (00:19.0) so that UART2 (00:19.2) can be enumerated properly, using `PchSerialIoSkipInit` to prevent FSP-S from configuring anything regarding I2C4 (e.g. GPIOs). Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I9c2c4f67672ba5667ebdae9ecc01054449dd3dfd --- M src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/60264/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c2c4f67672ba5667ebdae9ecc01054449dd3dfd Gerrit-Change-Number: 60264 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021