coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/brya/var/primus: Modify the GPIO pin to none.
by Ariel Fang (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Ariel Fang, Tim Wawrzynczak, Casper Chang. Ariel Fang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60104 ) Change subject: mb/google/brya/var/primus: Modify the GPIO pin to none. ...................................................................... Patch Set 9: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60104/comment/7d2645ee_5d5e20df PS5, Line 12: project_primus emerge-brya coreboot > Yes,it's a command, Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e269bc6fb6eda7b2de57e1a9c900864d3e86e98 Gerrit-Change-Number: 60104 Gerrit-PatchSet: 9 Gerrit-Owner: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Wed, 22 Dec 2021 08:41:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/brask: Customize the LED of RT8125
by Alan Huang (Code Review) 22 Dec '21

22 Dec '21

Alan Huang has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/59088 ) Change subject: mb/google/brya/var/brask: Customize the LED of RT8125 ...................................................................... Abandoned replaced by https://review.coreboot.org/c/coreboot/+/60298 -- To view, visit https://review.coreboot.org/c/coreboot/+/59088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6565f19b0ca7611c4731c4ae6365f17fbe63a7e9 Gerrit-Change-Number: 59088 Gerrit-PatchSet: 1 Gerrit-Owner: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: mb/google/brya/var/primus: Modify the GPIO pin to none.
by Felix Singer (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Ariel Fang, Tim Wawrzynczak, Casper Chang. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60104 ) Change subject: mb/google/brya/var/primus: Modify the GPIO pin to none. ...................................................................... Patch Set 9: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60104/comment/5adde097_871ba157 PS5, Line 12: project_primus emerge-brya coreboot > Yes,it's a command, Done Commit Message: https://review.coreboot.org/c/coreboot/+/60104/comment/b095c9a2_94cbaa6b PS9, Line 7: Modify the GPIO pin to none. You are modifying multiple pads, and also adding new. Please write an appropriate title about what this fixes. https://review.coreboot.org/c/coreboot/+/60104/comment/e5f7a51a_e2c4de1c PS9, Line 9: - Modify the gpio pin to none. Explain the issue and why this patch fixes the issue. https://review.coreboot.org/c/coreboot/+/60104/comment/880de64c_3776622d PS9, Line 11: B Missing number? -- To view, visit https://review.coreboot.org/c/coreboot/+/60104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e269bc6fb6eda7b2de57e1a9c900864d3e86e98 Gerrit-Change-Number: 60104 Gerrit-PatchSet: 9 Gerrit-Owner: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Wed, 22 Dec 2021 08:26:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/net/r8168: Modify to support RTL8125 LEDs
by Rory Liu (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Alan Huang. Rory Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59531 ) Change subject: drivers/net/r8168: Modify to support RTL8125 LEDs ...................................................................... Patch Set 5: (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59531/comment/62dd639b_ab57988f PS2, Line 9: The Realtek RTL8125 has four registers for each led, : therefore add customized_mleds[] to support register array. > Please reflow for 75 characters per line. Ack https://review.coreboot.org/c/coreboot/+/59531/comment/febce706_17d735c3 PS2, Line 7: drivers/net/r8168: Add customized_mleds to support RTL8125 : : The Realtek RTL8125 has four registers for each led, : therefore add customized_mleds[] to support register array. : : BUG=b:193750191 : TEST=emerge-brask coreboot chromeos-bootimage > Please remove the indentation. […] Ack https://review.coreboot.org/c/coreboot/+/59531/comment/82b73186_2400dfcc PS2, Line 13: TEST=emerge-brask coreboot chromeos-bootimage > How did you test this exactly? Modify overridetree.cb to verify LEDs' settings. https://review.coreboot.org/c/coreboot/+/60298 File src/drivers/net/r8168.c: https://review.coreboot.org/c/coreboot/+/59531/comment/8545c5b8_3eb1f11f PS1, Line 256: printk(BIOS_DEBUG, "r8168: Customized LED 0x%x\n", config->customized_mleds[i]); > line over 96 characters Fixed. File src/drivers/net/r8168.c: https://review.coreboot.org/c/coreboot/+/59531/comment/d0ad869f_1f7d11ff PS2, Line 32: #define CMD_LEDSEL[4] {0x18, 0x86, 0x84, 0x96} > Where did these IO port numbers come from? Do they come from the PCI enumeration? These come from the RTL8125 series datasheet 5.1 LED register definition. File src/include/device/pci_ids.h: PS2: > nit: please break out PCI ID updates to a separate change Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59531 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4b05a859dc0a0d2b8d6b35d6491fc88f7077cb92 Gerrit-Change-Number: 59531 Gerrit-PatchSet: 5 Gerrit-Owner: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 22 Dec 2021 08:16:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/vell: Add MIPI camera support
by Jimmy Su (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Tim Wawrzynczak, Kevin Chiu, Robert Chen, Wisley Chen, Shon Wang. Jimmy Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60275 ) Change subject: mb/google/brya/var/vell: Add MIPI camera support ...................................................................... Patch Set 4: (4 comments) File src/mainboard/google/brya/variants/vell/overridetree.cb: https://review.coreboot.org/c/coreboot/+/60275/comment/e84b96f8_1cf1a606 PS4, Line 133: 2 This value should be "4". We use 4 lane for ov8856 camera https://review.coreboot.org/c/coreboot/+/60275/comment/8f0cb04d_e7b0904a PS4, Line 235: OVTI2740 Please change the HID name as "OVTI8856" https://review.coreboot.org/c/coreboot/+/60275/comment/dd4e2fae_70154c30 PS4, Line 238: Ov 2740 Camera The chip name should be aligned with driver. Please change to "Ov 8856 Camera" https://review.coreboot.org/c/coreboot/+/60275/comment/afaac5ac_15d5aed9 PS4, Line 242: register "ssdb.lanes_used" = "2" : register "ssdb.link_used" = "1" : register "num_freq_entries" = "1" : register "link_freq[0]" = "DEFAULT_LINK_FREQ" please correct to the below content to align with driver settings register "ssdb.lanes_used" = "4" register "num_freq_entries" = "2" register "link_freq[0]" = "360000000" register "link_freq[1]" = "180000000" -- To view, visit https://review.coreboot.org/c/coreboot/+/60275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0fa77b07c52541446e83c479ff9a409a99175622 Gerrit-Change-Number: 60275 Gerrit-PatchSet: 4 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jimmy Su <jimmy.su(a)intel.corp-partner.google.com> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 22 Dec 2021 08:10:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/net/r8168: Modify to support RTL8125 LEDs
by Rory Liu (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Rory Liu, Tim Wawrzynczak, Alan Huang. Rory Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59531 ) Change subject: drivers/net/r8168: Modify to support RTL8125 LEDs ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/59531 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4b05a859dc0a0d2b8d6b35d6491fc88f7077cb92 Gerrit-Change-Number: 59531 Gerrit-PatchSet: 5 Gerrit-Owner: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 22 Dec 2021 08:08:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/brask: Customize LEDs of RT8125
by Rory Liu (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Tim Wawrzynczak. Rory Liu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60298 ) Change subject: mb/google/brya/var/brask: Customize LEDs of RT8125 ...................................................................... mb/google/brya/var/brask: Customize LEDs of RT8125 Add Kconfig item RT8168_SET_LED_MODE to enable LED customization. Update the LED settings in devicetree. BUG=b:193750191 TEST=Try different register values to verify LED feature. Signed-off-by: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Change-Id: If80ace497c7481ce40b55af7e17e12a286aa9164 --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/variants/brask/overridetree.cb 2 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/60298/1 diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 41f3f71..f285b4b 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -9,6 +9,7 @@ select SPD_CACHE_IN_FMAP select ENABLE_TCSS_DISPLAY_DETECTION if RUN_FSP_GOP select RT8168_GET_MAC_FROM_VPD + select RT8168_SET_LED_MODE select RT8168_GEN_ACPI_POWER_RESOURCE if BOARD_GOOGLE_BASEBOARD_BRYA || BOARD_GOOGLE_BASEBOARD_BRASK diff --git a/src/mainboard/google/brya/variants/brask/overridetree.cb b/src/mainboard/google/brya/variants/brask/overridetree.cb index 63a683d..e27cbb6 100644 --- a/src/mainboard/google/brya/variants/brask/overridetree.cb +++ b/src/mainboard/google/brya/variants/brask/overridetree.cb @@ -85,6 +85,10 @@ register "stop_delay_ms" = "12" # NIC needs time to quiesce register "stop_off_delay_ms" = "1" register "has_power_resource" = "1" + register "customized_leds" = "0x05af" + register "led_feature" = "0xe0" + register "customized_led0" = "0x23f" + register "customized_led2" = "0x028" device pci 00.0 on end end end # RTL8125 Ethernet NIC -- To view, visit https://review.coreboot.org/c/coreboot/+/60298 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If80ace497c7481ce40b55af7e17e12a286aa9164 Gerrit-Change-Number: 60298 Gerrit-PatchSet: 1 Gerrit-Owner: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/brya/var/primus: Modify the GPIO pin to none.
by Ariel Fang (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Felix Singer, Tim Wawrzynczak, Casper Chang. Ariel Fang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60104 ) Change subject: mb/google/brya/var/primus: Modify the GPIO pin to none. ...................................................................... Patch Set 9: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60104/comment/77b38156_150c93d6 PS5, Line 12: project_primus emerge-brya coreboot > What does that mean? Is that a command? Yes,it's a command, -- To view, visit https://review.coreboot.org/c/coreboot/+/60104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e269bc6fb6eda7b2de57e1a9c900864d3e86e98 Gerrit-Change-Number: 60104 Gerrit-PatchSet: 9 Gerrit-Owner: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Wed, 22 Dec 2021 08:04:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/primus: Modify the GPIO pin to none.
by Ariel Fang (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Tim Wawrzynczak, Casper Chang. Ariel Fang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60104 ) Change subject: mb/google/brya/var/primus: Modify the GPIO pin to none. ...................................................................... Patch Set 9: (1 comment) File src/mainboard/google/brya/variants/primus4es/gpio.c: https://review.coreboot.org/c/coreboot/+/60104/comment/520fae86_8041ff53 PS6, Line 57: > please, no spaces at the start of a line Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/60104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e269bc6fb6eda7b2de57e1a9c900864d3e86e98 Gerrit-Change-Number: 60104 Gerrit-PatchSet: 9 Gerrit-Owner: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Wed, 22 Dec 2021 08:03:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/primus: Modify the GPIO pin to none.
by Ariel Fang (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Tim Wawrzynczak, Casper Chang. Hello build bot (Jenkins), Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60104 to look at the new patch set (#9). Change subject: mb/google/brya/var/primus: Modify the GPIO pin to none. ...................................................................... mb/google/brya/var/primus: Modify the GPIO pin to none. - Modify the gpio pin to none. BUG=b: TEST= USE="project_primus" emerge-brya coreboot and verify it builds without error. Signed-off-by: Ariel_Fang <ariel_fang(a)wistron.corp-partner.google.com> Change-Id: I4e269bc6fb6eda7b2de57e1a9c900864d3e86e98 --- M src/mainboard/google/brya/variants/primus/gpio.c M src/mainboard/google/brya/variants/primus4es/gpio.c 2 files changed, 21 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/60104/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/60104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e269bc6fb6eda7b2de57e1a9c900864d3e86e98 Gerrit-Change-Number: 60104 Gerrit-PatchSet: 9 Gerrit-Owner: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021