coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: util/cse_serger: Add a new tool for stitching CSE components
by Michael Niewöhner (Code Review) 22 Dec '21

22 Dec '21

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55503 ) Change subject: util/cse_serger: Add a new tool for stitching CSE components ...................................................................... Patch Set 31: (1 comment) Patchset: PS31: isn't this redundant to ifwitool, at least parly? (I just had a very rough look tbh) -- To view, visit https://review.coreboot.org/c/coreboot/+/55503 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I90dd809b47fd16afdc80e66431312721082496aa Gerrit-Change-Number: 55503 Gerrit-PatchSet: 31 Gerrit-Owner: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Andrew McRae <amcrae(a)google.com> Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.corp-partner.google.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 22 Dec 2021 12:39:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mainboard: Fix DPTF device state in the devicetree on CFL boards
by Nico Huber (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Felix Singer, Tim Crawford, Patrick Rudolph, Jeremy Soller, Tim Wawrzynczak, Christian Walter. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60203 ) Change subject: mainboard: Fix DPTF device state in the devicetree on CFL boards ...................................................................... Patch Set 2: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60203/comment/f53803e1_41b5b0c6 PS2, Line 12: * google/hatch > As Tim wrote, he tested google/dratini. […] Done Wording could be better though, currently it suggests all of hatch is affected. https://review.coreboot.org/c/coreboot/+/60203/comment/92c6e6ff_3e2859bb PS2, Line 14: Thus, set it to on to make the resource allocator aware of it. > Anything to do here? Worth to mention in the commit message, IMHO. Or just rephrase. Currently it suggests to me that the resource allocation is the only difference. While it's just one of many side effects. -- To view, visit https://review.coreboot.org/c/coreboot/+/60203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I561598c252c5da64ece569c6ba336852e713ccab Gerrit-Change-Number: 60203 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Comment-Date: Wed, 22 Dec 2021 12:25:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: HACK trogdor: optimize coreboot.rom for T32 flash script HACK
by build bot (Jenkins) (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Ravi kumar, Shelley Chen, Sudheer Amrabadi, Julius Werner, Yu-Ping Wu, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36278 ) Change subject: HACK trogdor: optimize coreboot.rom for T32 flash script HACK ...................................................................... Patch Set 210: (78 comments) File 0001-google-herobrine-configure-gpio-to-detect-board-ID.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/5ea2e3f9_b56c20b3 PS210, Line 21: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/8f3c4541_49af5bd6 PS210, Line 25: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/32dd2ba3_9fede3f1 PS210, Line 69: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/e77e3fda_cd83a7c0 PS210, Line 70: -- trailing whitespace File 0002-mb-google-herobrine-Initialize-SPI-FW-for-EC-and-TPM.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/dd25431d_796e6752 PS210, Line 10: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/80f4ecb1_c4118879 PS210, Line 33: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/372b3a08_a90753c3 PS210, Line 38: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/199004d4_eabc04b8 PS210, Line 66: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/be544731_3cc1af0b PS210, Line 83: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/d70bca16_c06029ca PS210, Line 90: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/70c89ab5_e6bc6e06 PS210, Line 96: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/0a87bc23_4a36c128 PS210, Line 118: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/9317d6f8_1fa80e87 PS210, Line 124: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/1005f471_11085bd9 PS210, Line 146: -- trailing whitespace File 0003-Herobrine-sc7280-Add-support-for-audio.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/848f5c73_fcb77e93 PS210, Line 9: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/a902cf2a_eeeb8057 PS210, Line 26: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/462de28a_5f8607fd PS210, Line 40: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/a1b5b069_5350f7f6 PS210, Line 51: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/c90b4881_62194f91 PS210, Line 60: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/fca0a645_ad6c5203 PS210, Line 69: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/a4e16f99_72b57cc8 PS210, Line 88: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/c72ff4ef_2985903e PS210, Line 92: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/2f28ea7c_9adc2a8d PS210, Line 94: -- trailing whitespace File 0004-Herobrine-TPM-Config-Changes-to-support-audio.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/f16dc400_093f40ef PS210, Line 9: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/b4b61ea8_80a3df85 PS210, Line 28: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/adc86ba9_c4163270 PS210, Line 38: -- trailing whitespace File 0005-sc7280-enable-bl31-and-SDI-feature-support.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/9495ace1_c0d65c4b PS210, Line 37: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/fc06c09c_1ed4722a PS210, Line 62: -- trailing whitespace File 0006-sc7280-Add-Modem-region-in-memlayout-to-avoid-modem-.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/154f379e_4eb7bf25 PS210, Line 29: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/1a57b867_09b0e563 PS210, Line 41: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/0c811e95_05f9338c PS210, Line 116: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/889f23cb_51ccb2ce PS210, Line 118: -- trailing whitespace File 0007-sc7180-Update-video-mode-active-horizontal-vertical-.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/156f6c37_85d82100 PS210, Line 25: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/48651843_bf1874ef PS210, Line 31: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/e97d4bb0_2b92c431 PS210, Line 42: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/972c221c_2d2a70c5 PS210, Line 47: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/c9dca101_c70adf80 PS210, Line 55: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/e4ac7966_695f7c1d PS210, Line 58: -- trailing whitespace File 0008-src-mainboard-herobrine-Add-support-QUP-FW-for-I2C-a.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/5d6817fb_2e16ca66 PS210, Line 41: -- trailing whitespace File 0009-libpayload-Parse-DDR-Information-through-coreboot-ta.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/009635ba_c842b26b PS210, Line 8: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/0339585c_ac7391b8 PS210, Line 31: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/795a114a_4b629cd4 PS210, Line 42: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/2fdabba6_fa22247d PS210, Line 106: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/8f80d43d_93fc9511 PS210, Line 108: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/965d4676_6e77667f PS210, Line 116: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/2fdb14f5_bfd48f6c PS210, Line 155: -- trailing whitespace File 0010-src-lib-Added-CBMEM-tag-id-to-parse-ddr-information.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/ce3cda67_a93ef26a PS210, Line 7: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/c5db60d1_6e9407a6 PS210, Line 26: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/b8131d6a_5d7b2340 PS210, Line 48: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/319c15d0_5feedc7c PS210, Line 61: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/7f4a50ae_e438f719 PS210, Line 62: -- trailing whitespace File 0011-soc-Added-dram-information-to-cbmem.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/524eced5_8e204d9c PS210, Line 7: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/0a8061c7_1420d01f PS210, Line 25: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/74f17450_654c01d6 PS210, Line 33: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/5706d4c6_4ea25943 PS210, Line 35: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/d9fd9f5b_2c889044 PS210, Line 66: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/181da72d_0fc889d4 PS210, Line 68: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/c6ada2c9_d1ab535d PS210, Line 74: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/5f25dd28_01173e4d PS210, Line 79: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/6389b2a7_035fd390 PS210, Line 87: -- trailing whitespace File 0012-HACK-Senor-build-support-HACK.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/124f7d2b_5b263c0e PS210, Line 31: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/193789c7_840e9fbd PS210, Line 34: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/1490b516_6ca3fbca PS210, Line 42: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/6ecf6d73_4e874abe PS210, Line 43: -- trailing whitespace File 0013-HACK-sc7280-QSIP-SPI-NOR-addressing-mode-for-SKU1-an.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/a7121495_4d7c779c PS210, Line 11: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/22b5c228_8a0a7a52 PS210, Line 73: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/06e1ba2c_a0649546 PS210, Line 87: -- trailing whitespace File 0014-HACK-Herobrine-Reinit-TPM-INT-GPIO.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/b5461f20_b0749658 PS210, Line 29: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/bc316df0_442a0ba1 PS210, Line 41: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/27fa7446_29c64c73 PS210, Line 47: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/59be8865_479756bc PS210, Line 60: -- trailing whitespace File 0015-HACK-Herobrine-Reinit-TPM-INT-gpio-after-qclib-execu.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/5bb08d19_10b93a84 PS210, Line 18: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/ac6efa88_55d96e5c PS210, Line 20: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/0e5b756e_c3fd3f49 PS210, Line 32: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/9560758b_77d64fc1 PS210, Line 35: -- trailing whitespace File 0016-HACK-herobrine-T32-scripts-working-in-standalone-env.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/d35fad7a_040e311f PS210, Line 21: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/aa8607dd_2838e96a PS210, Line 154: -- trailing whitespace File 0017-HACK-trogdor-optimize-coreboot.rom-for-T32-flash-scr.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/78503b87_53b7ca56 PS210, Line 95: -- trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/36278 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5293ac9365bf4ac74bc475e70a02062f5371f9b8 Gerrit-Change-Number: 36278 Gerrit-PatchSet: 210 Gerrit-Owner: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Comment-Date: Wed, 22 Dec 2021 11:40:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: CB patch-train re-ordered/updated and pushed upstream
by build bot (Jenkins) (Code Review) 22 Dec '21

22 Dec '21

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60300 ) Change subject: CB patch-train re-ordered/updated and pushed upstream ...................................................................... Patch Set 1: (78 comments) File 0001-google-herobrine-configure-gpio-to-detect-board-ID.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/980c9519_fb8fb81c PS1, Line 21: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/52336c5f_4ae2abe1 PS1, Line 25: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/9d6c51f3_bc613a32 PS1, Line 69: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/b6a2b64c_42150423 PS1, Line 70: -- trailing whitespace File 0002-mb-google-herobrine-Initialize-SPI-FW-for-EC-and-TPM.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/a1cc0d12_758495f4 PS1, Line 10: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/174bfd12_0cf65ce4 PS1, Line 33: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/bc6940a2_588c573a PS1, Line 38: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/47e92b6f_c9beb12a PS1, Line 66: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/002eef1b_a95daf7f PS1, Line 83: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/ca33d8eb_ca023e15 PS1, Line 90: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/8810c297_1105201d PS1, Line 96: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/273c8675_4fa900c2 PS1, Line 118: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/2b6ee9af_ce6467da PS1, Line 124: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/be39c1e1_14ca6e04 PS1, Line 146: -- trailing whitespace File 0003-Herobrine-sc7280-Add-support-for-audio.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/e3b54c4d_b115427f PS1, Line 9: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/e63f8745_3fa3e8de PS1, Line 26: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/12497d2d_51667337 PS1, Line 40: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/25b270fa_dfbd321f PS1, Line 51: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/6492d8d2_18b22f42 PS1, Line 60: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/3374a5b1_e8d7b782 PS1, Line 69: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/87891dce_b552ae04 PS1, Line 88: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/7e21c341_279b5b14 PS1, Line 92: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/16816a79_2abac92d PS1, Line 94: -- trailing whitespace File 0004-Herobrine-TPM-Config-Changes-to-support-audio.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/e2b879bd_08a94256 PS1, Line 9: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/7130ce0e_43915c5c PS1, Line 28: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/b6ae864f_e1973daa PS1, Line 38: -- trailing whitespace File 0005-sc7280-enable-bl31-and-SDI-feature-support.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/d95991b9_4f163dc9 PS1, Line 37: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/cf86f442_b0c96085 PS1, Line 62: -- trailing whitespace File 0006-sc7280-Add-Modem-region-in-memlayout-to-avoid-modem-.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/e96614ec_60f28dd1 PS1, Line 29: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/a211a50a_5c367f89 PS1, Line 41: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/9af7163b_ff347843 PS1, Line 116: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/539b360f_0de46a11 PS1, Line 118: -- trailing whitespace File 0007-sc7180-Update-video-mode-active-horizontal-vertical-.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/5d1a40e8_f5f28d8b PS1, Line 25: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/9a616c90_50aaac06 PS1, Line 31: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/6f4d42a1_13bc3ccb PS1, Line 42: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/5dcf3263_34b92783 PS1, Line 47: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/297628a2_c55add90 PS1, Line 55: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/71755ac4_7a99b10d PS1, Line 58: -- trailing whitespace File 0008-src-mainboard-herobrine-Add-support-QUP-FW-for-I2C-a.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/b5191600_f10efd5a PS1, Line 41: -- trailing whitespace File 0009-libpayload-Parse-DDR-Information-through-coreboot-ta.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/bf629bf6_305f484f PS1, Line 8: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/d21a1435_db95ff26 PS1, Line 31: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/b143cde0_f18381d9 PS1, Line 42: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/6c4a814e_08425eec PS1, Line 106: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/54dbfd22_b5435750 PS1, Line 108: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/8505d4d6_d6626696 PS1, Line 116: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/f00efbff_9aeba3ba PS1, Line 155: -- trailing whitespace File 0010-src-lib-Added-CBMEM-tag-id-to-parse-ddr-information.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/9823ab92_4dc23e1b PS1, Line 7: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/c2fad40c_590bc32a PS1, Line 26: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/20577f81_256de0f9 PS1, Line 48: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/1abc2f4b_8316f240 PS1, Line 61: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/f8a8c2e1_ecb2e21f PS1, Line 62: -- trailing whitespace File 0011-soc-Added-dram-information-to-cbmem.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/8e825620_34d9d9e8 PS1, Line 7: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/fc5db2fc_e4a1c8d5 PS1, Line 25: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/c64bcb08_21a42165 PS1, Line 33: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/cdf2494e_8de79f7e PS1, Line 35: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/7105761b_23825dc7 PS1, Line 66: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/a6f2140f_669354a0 PS1, Line 68: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/e46e180f_0fd62a2c PS1, Line 74: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/1ff63b5b_c3387cca PS1, Line 79: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/39b6ed66_8791bff2 PS1, Line 87: -- trailing whitespace File 0012-HACK-Senor-build-support-HACK.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/4b923844_b527e7a6 PS1, Line 31: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/21f0d113_ef08518a PS1, Line 34: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/cbdb26f1_f4247e2d PS1, Line 42: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/a3c8a4c2_0ce660ff PS1, Line 43: -- trailing whitespace File 0013-HACK-sc7280-QSIP-SPI-NOR-addressing-mode-for-SKU1-an.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/c5002e06_d95a1577 PS1, Line 11: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/dc025266_9250a42e PS1, Line 73: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/33bb3189_45b4ed90 PS1, Line 87: -- trailing whitespace File 0014-HACK-Herobrine-Reinit-TPM-INT-GPIO.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/36b6ed74_6d97256f PS1, Line 29: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/2a01f9a0_8c34e637 PS1, Line 41: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/201dce76_928c67ab PS1, Line 47: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/84a0f667_a8199589 PS1, Line 60: -- trailing whitespace File 0015-HACK-Herobrine-Reinit-TPM-INT-gpio-after-qclib-execu.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/22fe60db_36386483 PS1, Line 18: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/20031f72_a7038fe7 PS1, Line 20: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/3a21fea1_8f0507cf PS1, Line 32: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/88995571_daba585c PS1, Line 35: -- trailing whitespace File 0016-HACK-herobrine-T32-scripts-working-in-standalone-env.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/5d7c608b_64d2aa07 PS1, Line 21: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/b2972b07_5974275a PS1, Line 154: -- trailing whitespace File 0017-HACK-trogdor-optimize-coreboot.rom-for-T32-flash-scr.patch: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/a1b8aaaf_bf8ed73b PS1, Line 95: -- trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/60300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f0e406d5adbc1b7502a12f15658fd0e236b3bfe Gerrit-Change-Number: 60300 Gerrit-PatchSet: 1 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 22 Dec 2021 11:20:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: HACK: Herobrine: Reinit TPM INT gpio after qclib executes
by build bot (Jenkins) (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Ravi kumar, Shelley Chen, Sudheer Amrabadi, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57025 ) Change subject: HACK: Herobrine: Reinit TPM INT gpio after qclib executes ...................................................................... Patch Set 38: Verified-1 (2 comments) File src/soc/qualcomm/common/qclib.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136040): https://review.coreboot.org/c/coreboot/+/57025/comment/64c0b5b4_b9be7e2d PS38, Line 254: mainboard_blob_fix(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136040): https://review.coreboot.org/c/coreboot/+/57025/comment/c4509916_eb25758c PS38, Line 254: mainboard_blob_fix(); please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/57025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c43d120ebb49800c82aec263ff8c215b60c5201 Gerrit-Change-Number: 57025 Gerrit-PatchSet: 38 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Attention: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Comment-Date: Wed, 22 Dec 2021 11:18:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: HACK sc7280: QSIP SPI NOR addressing mode for SKU1 and SKU2 HACK
by build bot (Jenkins) (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Shelley Chen, Ravi kumar, Sudheer Amrabadi, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50586 ) Change subject: HACK sc7280: QSIP SPI NOR addressing mode for SKU1 and SKU2 HACK ...................................................................... Patch Set 100: Verified-1 (2 comments) File src/drivers/spi/spi_flash.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136038): https://review.coreboot.org/c/coreboot/+/50586/comment/22fdcef6_06bd6c4d PS100, Line 533: while (1) suspect code indent for conditional statements (24, 24) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136038): https://review.coreboot.org/c/coreboot/+/50586/comment/ced1b3db_0b7e8de7 PS100, Line 554: while (1) suspect code indent for conditional statements (24, 24) -- To view, visit https://review.coreboot.org/c/coreboot/+/50586 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied5b647d0fcc8e3effff3bb7c8680ed5a0c1f3d4 Gerrit-Change-Number: 50586 Gerrit-PatchSet: 100 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Sajida Bhanu <quic_c_sbhanu(a)quicinc.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Attention: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Comment-Date: Wed, 22 Dec 2021 11:16:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Parse DDR Information through coreboot tables
by build bot (Jenkins) (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Ravi kumar, Shelley Chen, mturney mturney, Sudheer Amrabadi, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59193 ) Change subject: libpayload: Parse DDR Information through coreboot tables ...................................................................... Patch Set 8: Verified-1 (1 comment) File payloads/libpayload/include/mem_chip_info.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136034): https://review.coreboot.org/c/coreboot/+/59193/comment/3982b77d_691b7a9d PS8, Line 44: }dram_info; space required after that close brace '}' -- To view, visit https://review.coreboot.org/c/coreboot/+/59193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieca7e9fc0e1a018fcb2e9315aebee088edac858e Gerrit-Change-Number: 59193 Gerrit-PatchSet: 8 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-Reviewer: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-CC: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Comment-Date: Wed, 22 Dec 2021 11:06:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sc7280: Add Modem region in memlayout to avoid modem cleanup in Secbo...
by build bot (Jenkins) (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Ravi kumar, Sudheer Amrabadi. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58545 ) Change subject: sc7280: Add Modem region in memlayout to avoid modem cleanup in Secboot reboot. ...................................................................... Patch Set 13: Verified-1 (1 comment) File src/soc/qualcomm/sc7280/soc.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136031): https://review.coreboot.org/c/coreboot/+/58545/comment/daf09d79_3b2ae810 PS13, Line 27: if (soc_modem_carve_out(&start, &end)) that open brace { should be on the previous line -- To view, visit https://review.coreboot.org/c/coreboot/+/58545 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56bfb210606b08893ff71dd1b6679f1ec102ec95 Gerrit-Change-Number: 58545 Gerrit-PatchSet: 13 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Comment-Date: Wed, 22 Dec 2021 11:03:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/taeko4es: Set vGPIO reset type
by Joey Peng (Code Review) 22 Dec '21

22 Dec '21

Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60186 ) Change subject: mb/google/brya/var/taeko4es: Set vGPIO reset type ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60186/comment/ee55b78b_f783dce3 PS1, Line 11: > Mention something like […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60186 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0df489fe5513c4975747d52c97cb3ee8e691782 Gerrit-Change-Number: 60186 Gerrit-PatchSet: 2 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com> Gerrit-Comment-Date: Wed, 22 Dec 2021 10:58:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/taeko4es: Set vGPIO reset type
by Joey Peng (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Joey Peng. Hello build bot (Jenkins), YH Lin, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60186 to look at the new patch set (#2). Change subject: mb/google/brya/var/taeko4es: Set vGPIO reset type ...................................................................... mb/google/brya/var/taeko4es: Set vGPIO reset type Copied from commit df72b18d. Due to the vGPIO is not reset when we power on through S5, we would met MCA when PCIE send L1 request without following Ack. BUG=b:207070967 TEST=S0->S3->S5->power key->S3->S0, see if boot up normal Signed-off-by: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Change-Id: Id0df489fe5513c4975747d52c97cb3ee8e691782 --- M src/mainboard/google/brya/variants/taeko4es/gpio.c 1 file changed, 20 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/60186/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60186 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0df489fe5513c4975747d52c97cb3ee8e691782 Gerrit-Change-Number: 60186 Gerrit-PatchSet: 2 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com> Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021