Attention is currently required from: Justin van Son, Patrick Rudolph, Christian Walter, Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59999 )
Change subject: mb/prodrive/hermes: Support continuous Turbo Boost
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> Could you put this on hold? The customer that needed this probably doesn't need it after all since t […]
Sure
--
To view, visit https://review.coreboot.org/c/coreboot/+/59999
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8f629c92a51db84859e43748d44e479664f3716
Gerrit-Change-Number: 59999
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Thu, 23 Dec 2021 10:03:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chiu, Jimmy Su, Robert Chen, Wisley Chen.
Hello build bot (Jenkins), Tim Wawrzynczak, Kevin Chiu, Wisley Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60276
to look at the new patch set (#8).
Change subject: mb/google/brya/var/vell: Correct MIPI camera info
......................................................................
mb/google/brya/var/vell: Correct MIPI camera info
Correct OVTI8856 information for vell:
BUG=b:210801553
TEST=Build and boot on vell
Change-Id: I43de859cd0cdd9fe21c16cabfad511ed0b368ee3
Signed-off-by: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/vell/gpio.c
M src/mainboard/google/brya/variants/vell/overridetree.cb
2 files changed, 24 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/60276/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/60276
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43de859cd0cdd9fe21c16cabfad511ed0b368ee3
Gerrit-Change-Number: 60276
Gerrit-PatchSet: 8
Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jimmy Su <jimmy.su(a)intel.corp-partner.google.com>
Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Attention: Jimmy Su <jimmy.su(a)intel.corp-partner.google.com>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Kevin Chiu.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60313 )
Change subject: mb/google/cherry: add configuration for dojo
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/cherry/Kconfig:
https://review.coreboot.org/c/coreboot/+/60313/comment/6d5b250a_78f2b347
PS1, Line 66: default y if BOARD_GOOGLE_CHERRY || BOARD_GOOGLE_TOMATO
Do we need to add dojo here?
--
To view, visit https://review.coreboot.org/c/coreboot/+/60313
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3bd9803b4e47882df9fe351229478e4cb1630363
Gerrit-Change-Number: 60313
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Chen-Tsung Hsieh <chentsung(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Comment-Date: Thu, 23 Dec 2021 09:53:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Meera Ravindranath, Nick Vaccaro.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60320 )
Change subject: mb/google/brya: Change SD Card and Touch pad GPIO PAD_RST to RSMRST
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60320/comment/6ec99c41_a5b35912
PS3, Line 10: default state while the GPIO locking register gets a reset only in
during warm reset.
GPIO lock configuration register
https://review.coreboot.org/c/coreboot/+/60320/comment/451877d8_8a89a0c1
PS3, Line 11: RSMRST which prevents enumeration of SD card and Touch pad in
Can you put more detail as to why it prevents enumeration?
--
To view, visit https://review.coreboot.org/c/coreboot/+/60320
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I558bab39f935ab31a89541c6498a73af70cbf9ee
Gerrit-Change-Number: 60320
Gerrit-PatchSet: 3
Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Thu, 23 Dec 2021 09:42:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph, Christian Walter, Angel Pons, Arthur Heymans.
Justin van Son has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59999 )
Change subject: mb/prodrive/hermes: Support continuous Turbo Boost
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Could you put this on hold? The customer that needed this probably doesn't need it after all since the default turbo settings seem to be enough. We're still investigating whether they will need it, but it's looking like the current implementation is enough.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59999
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8f629c92a51db84859e43748d44e479664f3716
Gerrit-Change-Number: 59999
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Thu, 23 Dec 2021 09:41:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chiu, Jimmy Su, Robert Chen, Wisley Chen.
Shon Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60276 )
Change subject: mb/google/brya/var/vell: Correct MIPI camera info
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/brya/variants/vell/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/60276/comment/23c9fade_7986138e
PS6, Line 242: register "ssdb.lanes_used" = "4"
: register "num_freq_entries" = "2"
: register "link_freq[0]" = "360000000"
: register "link_freq[1]" = "180000000"
> I don't know why do you remove the two lines? […]
Corrected, thank you
--
To view, visit https://review.coreboot.org/c/coreboot/+/60276
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43de859cd0cdd9fe21c16cabfad511ed0b368ee3
Gerrit-Change-Number: 60276
Gerrit-PatchSet: 7
Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jimmy Su <jimmy.su(a)intel.corp-partner.google.com>
Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Attention: Jimmy Su <jimmy.su(a)intel.corp-partner.google.com>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 23 Dec 2021 09:25:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jimmy Su <jimmy.su(a)intel.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chiu, Robert Chen, Wisley Chen, Shon Wang.
Hello build bot (Jenkins), Tim Wawrzynczak, Kevin Chiu, Wisley Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60276
to look at the new patch set (#7).
Change subject: mb/google/brya/var/vell: Correct MIPI camera info
......................................................................
mb/google/brya/var/vell: Correct MIPI camera info
Correct OVTI8856 information for vell:
BUG=b:210801553
TEST=Build and boot on vell
Change-Id: I43de859cd0cdd9fe21c16cabfad511ed0b368ee3
Signed-off-by: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/vell/gpio.c
M src/mainboard/google/brya/variants/vell/overridetree.cb
2 files changed, 19 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/60276/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/60276
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43de859cd0cdd9fe21c16cabfad511ed0b368ee3
Gerrit-Change-Number: 60276
Gerrit-PatchSet: 7
Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jimmy Su <jimmy.su(a)intel.corp-partner.google.com>
Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Nick Vaccaro.
Hello build bot (Jenkins), Maulik V Vaghela, Tim Wawrzynczak, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60320
to look at the new patch set (#3).
Change subject: mb/google/brya: Change SD Card and Touch pad GPIO PAD_RST to RSMRST
......................................................................
mb/google/brya: Change SD Card and Touch pad GPIO PAD_RST to RSMRST
When the GPIO is set as DEEP or PLTRST, the PAD_CFG_DW0 resets to
default state while the GPIO locking register gets a reset only in
RSMRST which prevents enumeration of SD card and Touch pad in
warm reset.
Hence, change GPIO_PAD_RST to RSMRST to sync both the resets.
BUG=b:211573253
TEST=Boot to OS, issue warm reboot and see SD card and Touch pad
enumerating
Signed-off-by: Meera Ravindranath <meera.ravindranath(a)intel.com>
Change-Id: I558bab39f935ab31a89541c6498a73af70cbf9ee
---
M src/mainboard/google/brya/variants/baseboard/brya/gpio.c
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/60320/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/60320
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I558bab39f935ab31a89541c6498a73af70cbf9ee
Gerrit-Change-Number: 60320
Gerrit-PatchSet: 3
Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak.
Hello Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60320
to look at the new patch set (#2).
Change subject: mb/google/brya: Change SD Card and Touch pad GPIO PAD_RST to RSMRST
......................................................................
mb/google/brya: Change SD Card and Touch pad GPIO PAD_RST to RSMRST
When the GPIO is set as DEEP or PLTRST, the PAD_CFG_DW0 resets to
default state while the GPIO locking register gets a reset only in
RSMRST which prevents enumeration of SD card and Touch pad in
warm reset.
Hence, change GPIO_PAD_RST to RSMRST to sync both the resets.
BUG:b:211573253
TEST=Boot to OS, issue warm reboot and see SD card and Touch pad
enumerating
Signed-off-by: Meera Ravindranath <meera.ravindranath(a)intel.com>
Change-Id: I558bab39f935ab31a89541c6498a73af70cbf9ee
---
M src/mainboard/google/brya/variants/baseboard/brya/gpio.c
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/60320/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60320
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I558bab39f935ab31a89541c6498a73af70cbf9ee
Gerrit-Change-Number: 60320
Gerrit-PatchSet: 2
Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newpatchset