coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: soc/intel/{skl,cnl}: Guard USB macro parameters
by Angel Pons (Code Review) 23 Dec '21

23 Dec '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60324 ) Change subject: soc/intel/{skl,cnl}: Guard USB macro parameters ...................................................................... soc/intel/{skl,cnl}: Guard USB macro parameters Add parentheses around the parameter of the `USB_PORT_WAKE_ENABLE` macro to prevent unintentional operator precedence problems. Change-Id: I61fbacc129cbfb42ade7e64ee40cd07c98d87683 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/soc/intel/cannonlake/include/soc/usb.h M src/soc/intel/skylake/include/soc/usb.h 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/60324/1 diff --git a/src/soc/intel/cannonlake/include/soc/usb.h b/src/soc/intel/cannonlake/include/soc/usb.h index 66b3f8b..20b3149 100644 --- a/src/soc/intel/cannonlake/include/soc/usb.h +++ b/src/soc/intel/cannonlake/include/soc/usb.h @@ -191,6 +191,6 @@ * to Port 1, Bit n corresponds to Port (n+1). This bitmap is later used to * decide what ports need to set PORTSCN/PORTSCXUSB3 register bits. */ -#define USB_PORT_WAKE_ENABLE(x) (1 << (x - 1)) +#define USB_PORT_WAKE_ENABLE(x) (1 << ((x) - 1)) #endif diff --git a/src/soc/intel/skylake/include/soc/usb.h b/src/soc/intel/skylake/include/soc/usb.h index d87c859..7912603 100644 --- a/src/soc/intel/skylake/include/soc/usb.h +++ b/src/soc/intel/skylake/include/soc/usb.h @@ -185,6 +185,6 @@ * to Port 1, Bit n corresponds to Port (n+1). This bitmap is later used to * decide what ports need to set PORTSCN/PORTSCXUSB3 register bits. */ -#define USB_PORT_WAKE_ENABLE(x) (1 << (x - 1)) +#define USB_PORT_WAKE_ENABLE(x) (1 << ((x) - 1)) #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/60324 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61fbacc129cbfb42ade7e64ee40cd07c98d87683 Gerrit-Change-Number: 60324 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mainboard: Fix DPTF device state in the devicetree on CFL boards
by Nico Huber (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: Felix Singer, Tim Crawford, Patrick Rudolph, Jeremy Soller, Tim Wawrzynczak, Christian Walter. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60203 ) Change subject: mainboard: Fix DPTF device state in the devicetree on CFL boards ...................................................................... Patch Set 3: -Code-Review (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60203/comment/23b9d5d1_2bd9b515 PS2, Line 14: Thus, set it to on to make the resource allocator aware of it. > Just copied the statement from below. Ack. Technically there is nothing wrong with the statement, so I'll tag this as resolved. It's a poor commit message, though. Having the same text for rather complex and very simple cases suggests to reviewers that there is nothing to worry about, IMHO. > Changes to the devicetree always have further implications. Yes, but sometimes they are simple, e.g. setting a device to `off` that doesn't show up anyway, and sometimes they are not. > I haven't listed each side effect in any of my other patches hooking up the FSP options to the devicetree. Well, I can't talk about anonymous patches. Can you point me to any as subtle as this one? > Not sure why this is necessary here. I guess you either imply that your past patches had equally complex implications or you still haven't understood the full scope of this one. Have your pick. To the former I would have to say: Having done something wrong in the past (lacking commit message) is the worst excuse to keep doing it wrong. For the latter, well, I suggest to read PCI device probing in `device/pci_device.c`. For instance, check what would happen if a device doesn't show up and is set to `on` or `off` (AFAICT, the devicetree state after probing should be the same, so no further consequences for the execution of core- boot). Then, compare that to the situation when a device does show up. These are completely different cases, yet you keep treating them the same. -- To view, visit https://review.coreboot.org/c/coreboot/+/60203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I561598c252c5da64ece569c6ba336852e713ccab Gerrit-Change-Number: 60203 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Comment-Date: Thu, 23 Dec 2021 11:32:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/drallion: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 23 Dec '21

23 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60157 ) Change subject: mb/google/drallion: Move selects from Kconfig.name to Kconfig ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60157 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4de9bc426b92d57d6aabe17cceddf6b6aa444327 Gerrit-Change-Number: 60157 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 23 Dec 2021 11:31:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/drallion/Kconfig: Restore alphabetical order on selects
by Felix Singer (Code Review) 23 Dec '21

23 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60156 ) Change subject: mb/google/drallion/Kconfig: Restore alphabetical order on selects ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60156 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I31df9c339821074493329f6ed8fb1559b9e1a793 Gerrit-Change-Number: 60156 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 23 Dec 2021 11:31:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/hatch: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 23 Dec '21

23 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60155 ) Change subject: mb/google/hatch: Move selects from Kconfig.name to Kconfig ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60155 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idb7fcaaa175eb5b6e953ad0d5e2c5757d18838e4 Gerrit-Change-Number: 60155 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 23 Dec 2021 11:31:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/hatch: Restore alphabetical order on Kconfig selects
by Felix Singer (Code Review) 23 Dec '21

23 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60154 ) Change subject: mb/google/hatch: Restore alphabetical order on Kconfig selects ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60154 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6698c3882a3019e7e8f86fcb4e1c456e362d74b1 Gerrit-Change-Number: 60154 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 23 Dec 2021 11:31:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/hatch/Kconfig: Put baseboard option before variants
by Felix Singer (Code Review) 23 Dec '21

23 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60153 ) Change subject: mb/google/hatch/Kconfig: Put baseboard option before variants ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I314239b6d5abd531ccdcbe4426b2c7956dc9ae45 Gerrit-Change-Number: 60153 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 23 Dec 2021 11:31:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/sarien/Kconfig: Select board-specific options per board
by Felix Singer (Code Review) 23 Dec '21

23 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60152 ) Change subject: mb/google/sarien/Kconfig: Select board-specific options per board ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60152 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52c79f8958c5c40a258bcc292702154765afc476 Gerrit-Change-Number: 60152 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 23 Dec 2021 11:31:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/sarien: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 23 Dec '21

23 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60151 ) Change subject: mb/google/sarien: Move selects from Kconfig.name to Kconfig ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia9c59917196df8226391765f7dd7b7c5cdad1aee Gerrit-Change-Number: 60151 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 23 Dec 2021 11:31:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/sarien: Restore alphabetical order on Kconfig selects
by Felix Singer (Code Review) 23 Dec '21

23 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60150 ) Change subject: mb/google/sarien: Restore alphabetical order on Kconfig selects ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I013a6250727040c289244c31fbfbffef5ed0730b Gerrit-Change-Number: 60150 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 23 Dec 2021 11:30:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021