coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/brya/var/brask: Change TPM I2C to I2C1
by Zhuohao Lee (Code Review) 29 Dec '21

29 Dec '21

Zhuohao Lee has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60439 ) Change subject: mb/google/brya/var/brask: Change TPM I2C to I2C1 ...................................................................... mb/google/brya/var/brask: Change TPM I2C to I2C1 The latest schematics changes the TPM I2C from I2C3 to I2C1. This patch fixes the TPM I2C bus assignment. BUG=b:211886429 TEST=build pass Change-Id: I70d5a8fde1866c5dd4587ab5af2d41724c60ee0c Signed-off-by: Zhuohao Lee <zhuohao(a)chromium.org> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb M src/mainboard/google/brya/variants/baseboard/brask/gpio.c 3 files changed, 10 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/60439/1 diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 9363d6e..d16339d 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -76,7 +76,7 @@ hex default 0x3 if BOARD_GOOGLE_BRYA0 default 0x3 if BOARD_GOOGLE_BRYA4ES - default 0x3 if BOARD_GOOGLE_BRASK + default 0x1 if BOARD_GOOGLE_BRASK default 0x1 if BOARD_GOOGLE_PRIMUS default 0x3 if BOARD_GOOGLE_PRIMUS4ES default 0x1 if BOARD_GOOGLE_GIMBLE diff --git a/src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb b/src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb index 4662b95..ab50af4 100644 --- a/src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb +++ b/src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb @@ -77,7 +77,7 @@ #+-------------------+---------------------------+ #| GSPI1 | Fingerprint MCU | #| I2C0 | Audio | - #| I2C3 | cr50 TPM. Early init is | + #| I2C1 | cr50 TPM. Early init is | #| | required to set up a BAR | #| | for TPM communication | #+-------------------+---------------------------+ @@ -85,9 +85,12 @@ .i2c[0] = { .speed = I2C_SPEED_FAST, }, - .i2c[3] = { + .i2c[1] = { .early_init = 1, .speed = I2C_SPEED_FAST, + .rise_time_ns = 600, + .fall_time_ns = 400, + .data_hold_time_ns = 50, }, }" diff --git a/src/mainboard/google/brya/variants/baseboard/brask/gpio.c b/src/mainboard/google/brya/variants/baseboard/brask/gpio.c index 5ad8e46..756c89c 100644 --- a/src/mainboard/google/brya/variants/baseboard/brask/gpio.c +++ b/src/mainboard/google/brya/variants/baseboard/brask/gpio.c @@ -371,10 +371,6 @@ PAD_CFG_GPI_APIC(GPP_A13, NONE, PLTRST, LEVEL, INVERT), /* B4 : PROC_GP3 ==> SSD_PERST_L */ PAD_CFG_GPO(GPP_B4, 0, DEEP), - /* B7 : ISH_12C1_SDA ==> PCH_I2C_TPM_SDA */ - PAD_CFG_NF(GPP_B7, NONE, DEEP, NF2), - /* B8 : ISH_12C1_SCL ==> PCH_I2C_TPM_SCL */ - PAD_CFG_NF(GPP_B8, NONE, DEEP, NF2), /* * D1 : ISH_GP1 ==> FP_RST_ODL * FP_RST_ODL comes out of reset as hi-z and does not have an external pull-down. @@ -390,6 +386,10 @@ PAD_CFG_GPO(GPP_D11, 1, DEEP), /* E15 : RSVD_TP ==> PCH_WP_OD */ PAD_CFG_GPI_GPIO_DRIVER(GPP_E15, NONE, DEEP), + /* H6 : I2C1_SDA ==> PCH_I2C_TPM_SDA */ + PAD_CFG_NF(GPP_H6, NONE, DEEP, NF1), + /* H7 : I2C1_SCL ==> PCH_I2C_TPM_SCL */ + PAD_CFG_NF(GPP_H7, NONE, DEEP, NF1), /* H10 : UART0_RXD ==> UART_PCH_RX_DBG_TX */ PAD_CFG_NF(GPP_H10, NONE, DEEP, NF2), /* H11 : UART0_TXD ==> UART_PCH_TX_DBG_RX */ -- To view, visit https://review.coreboot.org/c/coreboot/+/60439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70d5a8fde1866c5dd4587ab5af2d41724c60ee0c Gerrit-Change-Number: 60439 Gerrit-PatchSet: 1 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: src: Remove duplicated includes
by HAOUAS Elyes (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Tim Wawrzynczak, Patrick Rudolph, Felix Held. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60438 ) Change subject: src: Remove duplicated includes ...................................................................... Patch Set 1: (7 comments) File src/mainboard/google/brya/bootblock.c: https://review.coreboot.org/c/coreboot/+/60438/comment/c76f02c6_0c3b74cc PS1, Line 5: <console/console.h> duplicated File src/mainboard/google/guybrush/variants/guybrush/gpio.c: https://review.coreboot.org/c/coreboot/+/60438/comment/30281548_03225576 PS1, Line 4: <baseboard/variants.h> duplicated File src/mainboard/google/guybrush/variants/nipperkin/gpio.c: https://review.coreboot.org/c/coreboot/+/60438/comment/272f3619_ff59748c PS1, Line 4: <baseboard/variants.h> duplicated File src/mainboard/google/herobrine/mainboard.c: https://review.coreboot.org/c/coreboot/+/60438/comment/9faf059e_4da184f2 PS1, Line 5: <bootblock_common.h> duplicated https://review.coreboot.org/c/coreboot/+/60438/comment/dbb7f8d6_fedf431a PS1, Line 11: <soc/clock.h> duplicated File src/soc/amd/picasso/fsp_s_params.c: https://review.coreboot.org/c/coreboot/+/60438/comment/f4f34150_fe966ab6 PS1, Line 5: <device/pci.h> duplicated File src/soc/intel/broadwell/pch/adsp.c: https://review.coreboot.org/c/coreboot/+/60438/comment/7fa7d237_72189b84 PS1, Line 11: <soc/device_nvs.h> duplicated -- To view, visit https://review.coreboot.org/c/coreboot/+/60438 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I50cdffca34a6150ac11c3e83e1a603b766d1b84e Gerrit-Change-Number: 60438 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 29 Dec 2021 07:27:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src: Remove duplicated includes
by HAOUAS Elyes (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Tim Wawrzynczak, Patrick Rudolph, Felix Held. HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60438 ) Change subject: src: Remove duplicated includes ...................................................................... src: Remove duplicated includes Change-Id: I50cdffca34a6150ac11c3e83e1a603b766d1b84e Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/google/brya/bootblock.c M src/mainboard/google/guybrush/variants/guybrush/gpio.c M src/mainboard/google/guybrush/variants/nipperkin/gpio.c M src/mainboard/google/herobrine/mainboard.c M src/soc/amd/picasso/fsp_s_params.c M src/soc/intel/broadwell/pch/adsp.c 6 files changed, 0 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/60438/1 diff --git a/src/mainboard/google/brya/bootblock.c b/src/mainboard/google/brya/bootblock.c index ac0dc32..d391cd1 100644 --- a/src/mainboard/google/brya/bootblock.c +++ b/src/mainboard/google/brya/bootblock.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <fmap.h> #include <commonlib/region.h> -#include <console/console.h> #include <cpu/intel/cpu_ids.h> #include <intelblocks/pmclib.h> #include <cf9_reset.h> diff --git a/src/mainboard/google/guybrush/variants/guybrush/gpio.c b/src/mainboard/google/guybrush/variants/guybrush/gpio.c index 0ebee22..cea1f42 100644 --- a/src/mainboard/google/guybrush/variants/guybrush/gpio.c +++ b/src/mainboard/google/guybrush/variants/guybrush/gpio.c @@ -5,7 +5,6 @@ #include <boardid.h> #include <gpio.h> #include <soc/gpio.h> -#include <baseboard/variants.h> /* This table is used by guybrush variant with board version < 2. */ static const struct soc_amd_gpio bid1_ramstage_gpio_table[] = { diff --git a/src/mainboard/google/guybrush/variants/nipperkin/gpio.c b/src/mainboard/google/guybrush/variants/nipperkin/gpio.c index df55e52..0b3b9b2 100644 --- a/src/mainboard/google/guybrush/variants/nipperkin/gpio.c +++ b/src/mainboard/google/guybrush/variants/nipperkin/gpio.c @@ -5,7 +5,6 @@ #include <boardid.h> #include <gpio.h> #include <soc/gpio.h> -#include <baseboard/variants.h> /* This table is used by nipperkin variant with board version < 2. */ static const struct soc_amd_gpio bid1_override_gpio_table[] = { diff --git a/src/mainboard/google/herobrine/mainboard.c b/src/mainboard/google/herobrine/mainboard.c index a2e0786..fcc468e 100644 --- a/src/mainboard/google/herobrine/mainboard.c +++ b/src/mainboard/google/herobrine/mainboard.c @@ -3,11 +3,9 @@ #include "board.h" #include <boardid.h> #include <bootblock_common.h> -#include <soc/clock.h> #include <console/console.h> #include <device/device.h> #include <device/mmio.h> -#include <bootblock_common.h> #include <soc/clock.h> #include <soc/qupv3_config_common.h> #include <soc/qup_se_handlers_common.h> diff --git a/src/soc/amd/picasso/fsp_s_params.c b/src/soc/amd/picasso/fsp_s_params.c index 57e51d5..af7de37 100644 --- a/src/soc/amd/picasso/fsp_s_params.c +++ b/src/soc/amd/picasso/fsp_s_params.c @@ -9,7 +9,6 @@ #include <soc/soc_util.h> #include <fsp/api.h> #include "chip.h" -#include <device/pci.h> static void fsps_update_emmc_config(FSP_S_CONFIG *scfg, const struct soc_amd_picasso_config *cfg) diff --git a/src/soc/intel/broadwell/pch/adsp.c b/src/soc/intel/broadwell/pch/adsp.c index eaae08b..e154446 100644 --- a/src/soc/intel/broadwell/pch/adsp.c +++ b/src/soc/intel/broadwell/pch/adsp.c @@ -9,7 +9,6 @@ #include <device/mmio.h> #include <soc/adsp.h> #include <soc/device_nvs.h> -#include <soc/device_nvs.h> #include <soc/pch.h> #include <soc/rcba.h> #include <soc/intel/broadwell/pch/chip.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/60438 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I50cdffca34a6150ac11c3e83e1a603b766d1b84e Gerrit-Change-Number: 60438 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: src: Drop duplicated includes
by HAOUAS Elyes (Code Review) 29 Dec '21

29 Dec '21

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60437 ) Change subject: src: Drop duplicated includes ...................................................................... src: Drop duplicated includes <types.h> already provides <commonlib/bsd/cb_err.h>, <limits.h>, <stdbool.h>, <stdint.h> and <stddef.h> headers. Change-Id: I700b3f0e864ecce3f8b3b66f3bf6c8f1040acee1 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/acpi/gnvs.c M src/arch/x86/include/arch/cpu.h M src/drivers/tpm/ppi.c M src/drivers/tpm/ppi_stub.c M src/include/thread.h M src/mainboard/emulation/qemu-i440fx/northbridge.c M src/mainboard/intel/adlrvp/board_id.c M src/mainboard/starlabs/labtop/smbios.c M src/northbridge/intel/x4x/dq_dqs.c M src/security/intel/txt/logging.c M src/soc/amd/common/block/include/amdblocks/acp.h M src/soc/amd/common/block/lpc/spi_dma.c M src/soc/intel/alderlake/elog.c M src/soc/intel/alderlake/include/soc/meminit.h M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/include/intelblocks/meminit.h M src/soc/intel/jasperlake/elog.c M src/soc/intel/tigerlake/elog.c M src/soc/intel/tigerlake/include/soc/meminit.h M src/soc/mediatek/common/flash_controller.c M src/soc/mediatek/common/include/soc/dpm.h M src/soc/mediatek/mt8192/include/soc/spm.h M src/soc/mediatek/mt8195/include/soc/spm.h M src/soc/qualcomm/sc7180/include/soc/display/mdssreg.h 24 files changed, 0 insertions(+), 27 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/60437/1 diff --git a/src/acpi/gnvs.c b/src/acpi/gnvs.c index 8024783..6de345f 100644 --- a/src/acpi/gnvs.c +++ b/src/acpi/gnvs.c @@ -5,7 +5,6 @@ #include <cbmem.h> #include <console/console.h> #include <soc/nvs.h> -#include <stdint.h> #include <string.h> #include <types.h> diff --git a/src/arch/x86/include/arch/cpu.h b/src/arch/x86/include/arch/cpu.h index 9a3b63d..d3f50bf 100644 --- a/src/arch/x86/include/arch/cpu.h +++ b/src/arch/x86/include/arch/cpu.h @@ -3,7 +3,6 @@ #ifndef ARCH_CPU_H #define ARCH_CPU_H -#include <stdint.h> #include <types.h> /* diff --git a/src/drivers/tpm/ppi.c b/src/drivers/tpm/ppi.c index 88dd649..6b02d45 100644 --- a/src/drivers/tpm/ppi.c +++ b/src/drivers/tpm/ppi.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <types.h> -#include <stddef.h> #include <acpi/acpi.h> #include <acpi/acpigen.h> #include <acpi/acpi_device.h> diff --git a/src/drivers/tpm/ppi_stub.c b/src/drivers/tpm/ppi_stub.c index 1e3a7fc..23236ff 100644 --- a/src/drivers/tpm/ppi_stub.c +++ b/src/drivers/tpm/ppi_stub.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <types.h> -#include <stddef.h> #include <acpi/acpi.h> #include <acpi/acpigen.h> #include <acpi/acpi_device.h> diff --git a/src/include/thread.h b/src/include/thread.h index 4f10782..f414db0 100644 --- a/src/include/thread.h +++ b/src/include/thread.h @@ -4,7 +4,6 @@ #include <arch/cpu.h> #include <bootstate.h> -#include <commonlib/bsd/cb_err.h> #include <types.h> struct thread_mutex { diff --git a/src/mainboard/emulation/qemu-i440fx/northbridge.c b/src/mainboard/emulation/qemu-i440fx/northbridge.c index 9785a3a..e1765fa 100644 --- a/src/mainboard/emulation/qemu-i440fx/northbridge.c +++ b/src/mainboard/emulation/qemu-i440fx/northbridge.c @@ -8,7 +8,6 @@ #include <device/pci_def.h> #include <device/pci_ops.h> #include <arch/ioapic.h> -#include <stdint.h> #include <device/device.h> #include <stdlib.h> #include <string.h> diff --git a/src/mainboard/intel/adlrvp/board_id.c b/src/mainboard/intel/adlrvp/board_id.c index 332ba1b..de7a380 100644 --- a/src/mainboard/intel/adlrvp/board_id.c +++ b/src/mainboard/intel/adlrvp/board_id.c @@ -3,7 +3,6 @@ #include <boardid.h> #include <ec/acpi/ec.h> #include <ec/google/chromeec/ec.h> -#include <stdint.h> #include <types.h> #include "board_id.h" diff --git a/src/mainboard/starlabs/labtop/smbios.c b/src/mainboard/starlabs/labtop/smbios.c index 8babae3..9acf64f 100644 --- a/src/mainboard/starlabs/labtop/smbios.c +++ b/src/mainboard/starlabs/labtop/smbios.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci_def.h> #include <ec/starlabs/merlin/ec.h> -#include <limits.h> #include <option.h> #include <smbios.h> #include <types.h> diff --git a/src/northbridge/intel/x4x/dq_dqs.c b/src/northbridge/intel/x4x/dq_dqs.c index e4cc888..870e660 100644 --- a/src/northbridge/intel/x4x/dq_dqs.c +++ b/src/northbridge/intel/x4x/dq_dqs.c @@ -3,7 +3,6 @@ #include <device/mmio.h> #include <console/console.h> #include <delay.h> -#include <stdint.h> #include <string.h> #include <types.h> #include "raminit.h" diff --git a/src/security/intel/txt/logging.c b/src/security/intel/txt/logging.c index f3e37aa..46c594c 100644 --- a/src/security/intel/txt/logging.c +++ b/src/security/intel/txt/logging.c @@ -3,7 +3,6 @@ #include <arch/mmio.h> #include <console/console.h> #include <cpu/x86/smm.h> -#include <stdint.h> #include <types.h> #include "txt.h" diff --git a/src/soc/amd/common/block/include/amdblocks/acp.h b/src/soc/amd/common/block/include/amdblocks/acp.h index a4c926d..13254e4 100644 --- a/src/soc/amd/common/block/include/amdblocks/acp.h +++ b/src/soc/amd/common/block/include/amdblocks/acp.h @@ -3,7 +3,6 @@ #ifndef AMD_COMMON_ACP_H #define AMD_COMMON_ACP_H -#include <stdint.h> #include <types.h> struct acp_config { diff --git a/src/soc/amd/common/block/lpc/spi_dma.c b/src/soc/amd/common/block/lpc/spi_dma.c index baf1eb8..2c183ee 100644 --- a/src/soc/amd/common/block/lpc/spi_dma.c +++ b/src/soc/amd/common/block/lpc/spi_dma.c @@ -4,7 +4,6 @@ #include <amdblocks/spi.h> #include <assert.h> #include <boot_device.h> -#include <commonlib/bsd/cb_err.h> #include <commonlib/bsd/helpers.h> #include <commonlib/region.h> #include <console/console.h> diff --git a/src/soc/intel/alderlake/elog.c b/src/soc/intel/alderlake/elog.c index 7b0fd87..7f79d94 100644 --- a/src/soc/intel/alderlake/elog.c +++ b/src/soc/intel/alderlake/elog.c @@ -8,7 +8,6 @@ #include <intelblocks/xhci.h> #include <soc/pci_devs.h> #include <soc/pm.h> -#include <stdint.h> #include <types.h> struct pme_map { diff --git a/src/soc/intel/alderlake/include/soc/meminit.h b/src/soc/intel/alderlake/include/soc/meminit.h index 49e3c76..debdef2 100644 --- a/src/soc/intel/alderlake/include/soc/meminit.h +++ b/src/soc/intel/alderlake/include/soc/meminit.h @@ -3,8 +3,6 @@ #ifndef _SOC_ALDERLAKE_MEMINIT_H_ #define _SOC_ALDERLAKE_MEMINIT_H_ -#include <stddef.h> -#include <stdint.h> #include <types.h> #include <fsp/soc_binding.h> #include <intelblocks/meminit.h> diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c index a80ab48..05b67ee 100644 --- a/src/soc/intel/common/block/cse/cse.c +++ b/src/soc/intel/common/block/cse/cse.c @@ -11,7 +11,6 @@ #include <device/pci_ids.h> #include <device/pci_ops.h> #include <intelblocks/cse.h> -#include <limits.h> #include <option.h> #include <security/vboot/misc.h> #include <security/vboot/vboot_common.h> diff --git a/src/soc/intel/common/block/include/intelblocks/meminit.h b/src/soc/intel/common/block/include/intelblocks/meminit.h index cbec04d..1fed02f 100644 --- a/src/soc/intel/common/block/include/intelblocks/meminit.h +++ b/src/soc/intel/common/block/include/intelblocks/meminit.h @@ -3,8 +3,6 @@ #ifndef __SOC_INTEL_COMMON_BLOCK_MEMINIT_H__ #define __SOC_INTEL_COMMON_BLOCK_MEMINIT_H__ -#include <stddef.h> -#include <stdint.h> #include <types.h> /* diff --git a/src/soc/intel/jasperlake/elog.c b/src/soc/intel/jasperlake/elog.c index 61b8fb8..0e4b2c5 100644 --- a/src/soc/intel/jasperlake/elog.c +++ b/src/soc/intel/jasperlake/elog.c @@ -8,7 +8,6 @@ #include <intelblocks/xhci.h> #include <soc/pci_devs.h> #include <soc/pm.h> -#include <stdint.h> #include <types.h> struct pme_map { diff --git a/src/soc/intel/tigerlake/elog.c b/src/soc/intel/tigerlake/elog.c index 93174be..301c88a 100644 --- a/src/soc/intel/tigerlake/elog.c +++ b/src/soc/intel/tigerlake/elog.c @@ -8,7 +8,6 @@ #include <intelblocks/xhci.h> #include <soc/pci_devs.h> #include <soc/pm.h> -#include <stdint.h> #include <types.h> struct pme_map { diff --git a/src/soc/intel/tigerlake/include/soc/meminit.h b/src/soc/intel/tigerlake/include/soc/meminit.h index 8583e66..6b3086c 100644 --- a/src/soc/intel/tigerlake/include/soc/meminit.h +++ b/src/soc/intel/tigerlake/include/soc/meminit.h @@ -3,8 +3,6 @@ #ifndef _SOC_TIGERLAKE_MEMINIT_H_ #define _SOC_TIGERLAKE_MEMINIT_H_ -#include <stddef.h> -#include <stdint.h> #include <types.h> #include <fsp/soc_binding.h> #include <intelblocks/meminit.h> diff --git a/src/soc/mediatek/common/flash_controller.c b/src/soc/mediatek/common/flash_controller.c index cdda056..3fe17f8 100644 --- a/src/soc/mediatek/common/flash_controller.c +++ b/src/soc/mediatek/common/flash_controller.c @@ -7,7 +7,6 @@ #include <soc/symbols.h> #include <spi_flash.h> #include <spi-generic.h> -#include <stdint.h> #include <string.h> #include <symbols.h> #include <timer.h> diff --git a/src/soc/mediatek/common/include/soc/dpm.h b/src/soc/mediatek/common/include/soc/dpm.h index 8c110aa..e72b6a1 100644 --- a/src/soc/mediatek/common/include/soc/dpm.h +++ b/src/soc/mediatek/common/include/soc/dpm.h @@ -5,7 +5,6 @@ #include <soc/addressmap.h> #include <soc/mcu_common.h> -#include <stdint.h> #include <types.h> struct dpm_regs { diff --git a/src/soc/mediatek/mt8192/include/soc/spm.h b/src/soc/mediatek/mt8192/include/soc/spm.h index d99ca65..4951f13 100644 --- a/src/soc/mediatek/mt8192/include/soc/spm.h +++ b/src/soc/mediatek/mt8192/include/soc/spm.h @@ -5,7 +5,6 @@ #include <soc/addressmap.h> #include <soc/mtcmos.h> -#include <stdint.h> #include <types.h> /* SPM READ/WRITE CFG */ diff --git a/src/soc/mediatek/mt8195/include/soc/spm.h b/src/soc/mediatek/mt8195/include/soc/spm.h index fb7d17f..945852a 100644 --- a/src/soc/mediatek/mt8195/include/soc/spm.h +++ b/src/soc/mediatek/mt8195/include/soc/spm.h @@ -6,7 +6,6 @@ #include <device/mmio.h> #include <soc/addressmap.h> #include <soc/mtcmos.h> -#include <stdint.h> #include <types.h> /* SPM READ/WRITE CFG */ diff --git a/src/soc/qualcomm/sc7180/include/soc/display/mdssreg.h b/src/soc/qualcomm/sc7180/include/soc/display/mdssreg.h index 57a3022..112cac6 100644 --- a/src/soc/qualcomm/sc7180/include/soc/display/mdssreg.h +++ b/src/soc/qualcomm/sc7180/include/soc/display/mdssreg.h @@ -4,7 +4,6 @@ #define _SOC_DISPLAY_MDSS_REG_H_ #include <types.h> -#include <stdint.h> struct dsi_regs { uint32_t hw_version; -- To view, visit https://review.coreboot.org/c/coreboot/+/60437 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I700b3f0e864ecce3f8b3b66f3bf6c8f1040acee1 Gerrit-Change-Number: 60437 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/purism/librem_cnl/acpi: Use Printf() for debug prints
by HAOUAS Elyes (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Felix Singer. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60428 ) Change subject: mb/purism/librem_cnl/acpi: Use Printf() for debug prints ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I587dcd8fc208562ecf0e0ba6ea9f741538511192 Gerrit-Change-Number: 60428 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Wed, 29 Dec 2021 06:31:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/jecht/acpi: Use Printf() for debug prints
by HAOUAS Elyes (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Felix Singer. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60427 ) Change subject: mb/google/jecht/acpi: Use Printf() for debug prints ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60427 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie54637c451252fd38aab9207ab0b846cc50f4b12 Gerrit-Change-Number: 60427 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Wed, 29 Dec 2021 06:30:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/kahlee/acpi: Use Printf() for debug prints
by HAOUAS Elyes (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Felix Singer. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60426 ) Change subject: mb/google/kahlee/acpi: Use Printf() for debug prints ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib5ccba321f3cb737eb6287472314b06ebe6e2437 Gerrit-Change-Number: 60426 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Wed, 29 Dec 2021 06:30:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/slippy/acpi: Use Printf() for debug prints
by HAOUAS Elyes (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Felix Singer. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60425 ) Change subject: mb/google/slippy/acpi: Use Printf() for debug prints ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60425 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8c0d1aaccb729eab91c88c77c5efc53d3e951692 Gerrit-Change-Number: 60425 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Wed, 29 Dec 2021 06:30:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/zork/acpi: Use Printf() for debug prints
by HAOUAS Elyes (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Felix Singer. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60424 ) Change subject: mb/google/zork/acpi: Use Printf() for debug prints ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60424 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I433b7138da84b57e45e816ab116f8ca874fdc0e0 Gerrit-Change-Number: 60424 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Wed, 29 Dec 2021 06:29:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/beltino/acpi: Use Printf() for debug prints
by HAOUAS Elyes (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Felix Singer. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60423 ) Change subject: mb/google/beltino/acpi: Use Printf() for debug prints ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60423 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f4ac9ba134e20cc1808de125f87b84f86567303 Gerrit-Change-Number: 60423 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Wed, 29 Dec 2021 06:29:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021