coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: amdfwtool: Set soc name for Stoneyridge
by Bao Zheng (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Martin Roth, Marshall Dawson, Richard Spiegel, Zheng Bao, Matt Papageorge, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58555 ) Change subject: amdfwtool: Set soc name for Stoneyridge ...................................................................... Patch Set 7: (1 comment) File src/soc/amd/stoneyridge/Makefile.inc: https://review.coreboot.org/c/coreboot/+/58555/comment/0306a295_9301ea93 PS5, Line 150: --soc-name "Stoneyridge" \ > not 100% sure, but this might need to depend on FIRMWARE_TYPE; see my comment on CB:55454 Done -- To view, visit https://review.coreboot.org/c/coreboot/+/58555 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e82188ce64733420a578446e22a077ef789be92 Gerrit-Change-Number: 58555 Gerrit-PatchSet: 7 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 04 Nov 2021 15:25:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by build bot (Jenkins) (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Sean Rhodes. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 ) Change subject: [WIP] util: Add coreboot Configurator ...................................................................... Patch Set 16: (363 comments) File util/coreboot-configurator/src/Documentation.txt: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/df863f14_ee95072f PS16, Line 5: This allows `coreboot-configurator` to display them in a relavant tab, with a nice 'relavant' may be misspelled - perhaps 'relevant'? File util/coreboot-configurator/src/application/aboutwindow.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/0b18beb4_faad66fb PS16, Line 16: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/4a45d118_e4f514e5 PS16, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7e028095_51b586c2 PS16, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/bf0f8c57_742ffbce PS16, Line 21: Ui::aboutWindow *ui; labels should not be indented File util/coreboot-configurator/src/application/configuration.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/a303112f_8a766efe PS16, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3ec28df9_0a288207 PS16, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/03bdd538_84964afa PS16, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/cf1f1543_2c730b7c PS16, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d78a7eab_db740e1f PS16, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3a0acba6_fa6481e0 PS16, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d6c1bf9a_ea664bcf PS16, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/410a05fc_b8ec5a04 PS16, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1a13fe3a_efb5fc2d PS16, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/992d7359_8f9404f9 PS16, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW) File util/coreboot-configurator/src/application/coreboot_configurator.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dae99d9d_1ab9d36c PS16, Line 29: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/622fb4dc_866f92de PS16, Line 30: coreboot_configurator(QWidget *parent = nullptr); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/16f21e5f_a1f209fd PS16, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5cb8e6df_599a2106 PS16, Line 37: void showEvent(QShowEvent *ev); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9c59b30f_0e20376d PS16, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f070c62c_b904ba5b PS16, Line 38: void closeEvent(QCloseEvent *ev); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/11509c8e_30547a0e PS16, Line 42: void closeWindow(int result); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dbdf30a4_5933b68f PS16, Line 43: void saveAndClose(void); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/4f9f295d_acc88041 PS16, Line 46: void getSettings(void); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/ec547c0c_f76a1722 PS16, Line 47: void getFromFile(void); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/565dc52b_b690909e PS16, Line 48: void displaySettings(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b7a66ce4_e0db8c88 PS16, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/27f7099a_16e58fdf PS16, Line 51: void writeSettings(void); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9da1b464_b3af4b5c PS16, Line 52: void writeToFile(const QString& out_file); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c8f3a7a7_0130532c PS16, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/988b28f3_2fe5b867 PS16, Line 55: void updateValue(const QString& name); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7c63e25f_3a82d068 PS16, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/a107e32d_440f2019 PS16, Line 59: QString m_fileName; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/bc640178_aca8eed5 PS16, Line 61: QMap<QString, QString> m_values; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5b8c2be9_a80f4219 PS16, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5a99ea18_6df14044 PS16, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/732bdf44_4af502b6 PS16, Line 64: QMap<QString, QVBoxLayout*> m_tabs; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f1c207c8_e45fcb35 PS16, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/eeab1a67_91aa834a PS16, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/fff24ca1_c9963aa7 PS16, Line 67: YAML::Node m_categories; labels should not be indented Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/2d91aab7_871d5ed5 PS16, Line 70: QComboBox *textToDisplay(const QString &in_string); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/6c21e6c1_0cdf8ffe PS16, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dce61de4_f2b7c51a PS16, Line 71: QCheckBox *checkToDisplay(const QString &in_string); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1f3e30ca_c1f96f2d PS16, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/520cbf51_0a720b03 PS16, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/4fe1af18_941b8b0d PS16, Line 73: Ui::coreboot_configurator *ui; labels should not be indented File util/coreboot-configurator/src/application/qtyaml.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/76283869_42641f35 PS16, Line 30: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f97e013a_febba75c PS16, Line 30: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/fbeb8508_72a41916 PS16, Line 31: struct convert<QString> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d75452c1_93d905de PS16, Line 31: struct convert<QString> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dd8bee5f_a36e53de PS16, Line 33: static Node encode(const QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/28130000_f5d39c36 PS16, Line 33: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/8ae6fbfb_48cb9075 PS16, Line 33: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/39655844_c752e82f PS16, Line 34: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/30b98118_79878984 PS16, Line 35: return Node(rhs.toStdString()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/63fe2c47_c19daf20 PS16, Line 35: return Node(rhs.toStdString()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/41b77e8a_17592e94 PS16, Line 36: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/113cefd8_142747dd PS16, Line 38: static bool decode(const Node& node, QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f79ec5fb_d68983ed PS16, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/4d978d0a_0cb4fbd7 PS16, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/16769760_40944dd6 PS16, Line 38: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/249b9c07_399667aa PS16, Line 39: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d3287ae1_edcbf9a7 PS16, Line 40: if (!node.IsScalar()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3624225b_bd0fa6df PS16, Line 40: if (!node.IsScalar()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/52e97d3a_593b5266 PS16, Line 40: if (!node.IsScalar()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9f25e8ba_410d2e5e PS16, Line 41: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/8588e4e5_f3c3679f PS16, Line 41: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/066182a2_5d0abd3c PS16, Line 42: rhs = QString::fromStdString(node.Scalar()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c28f8281_5b7c143f PS16, Line 42: rhs = QString::fromStdString(node.Scalar()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5867f4fa_23dd6413 PS16, Line 43: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/43e9d577_2d94d835 PS16, Line 43: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c0c64bb3_4c09e521 PS16, Line 44: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d591a1e9_85e68aee PS16, Line 48: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/595f25f7_358ea3ac PS16, Line 48: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3e8fcd0f_d8ebf383 PS16, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7c3d1783_e195e92e PS16, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c6762d2e_555dbac4 PS16, Line 49: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dce86d07_498e4c98 PS16, Line 51: static Node encode(const QMap<Key,Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/493700ad_ccd77b94 PS16, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dde0d4e8_c4c00c46 PS16, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/6255b632_7baa551b PS16, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f038710d_96719ce0 PS16, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3f8922d3_86fcd6e4 PS16, Line 51: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f0d9137e_dc98894c PS16, Line 51: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/27295f06_71413cb5 PS16, Line 52: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d97fd658_9239a62b PS16, Line 53: Node node(NodeType::Map); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5cdcc0d2_f90864e6 PS16, Line 53: Node node(NodeType::Map); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/25149b27_69bb61aa PS16, Line 54: auto it = rhs.constBegin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d1e5c3f7_37ae9052 PS16, Line 54: auto it = rhs.constBegin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/a75485b4_54a0a322 PS16, Line 55: while (it != rhs.constEnd()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/ed3dc88c_7f029ca5 PS16, Line 55: while (it != rhs.constEnd()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5e1c470a_7d14820b PS16, Line 55: while (it != rhs.constEnd()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/4a20594a_6c26f1d6 PS16, Line 55: while (it != rhs.constEnd()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/ed985308_ef5d8b77 PS16, Line 56: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/4d2fa72b_3abe6715 PS16, Line 56: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9d14b8cc_1a46e5a0 PS16, Line 57: node.force_insert(it.key(), it.value()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/2b0268e3_2f5b8d82 PS16, Line 57: node.force_insert(it.key(), it.value()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e39b2635_13464523 PS16, Line 58: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/ba9fe07c_773aac28 PS16, Line 58: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d1397749_72f0914e PS16, Line 59: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f028958a_e4b01ff1 PS16, Line 59: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/96bbf7e9_917c48cc PS16, Line 60: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/cd0c50ec_dae89c38 PS16, Line 60: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/a58a29d6_2633014e PS16, Line 61: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7118b4fe_7b9e1a8e PS16, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/28b9c428_7fcb821f PS16, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/61229030_2c50fd59 PS16, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c4b7b0f4_15c0ee2b PS16, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/fcef53e3_1a3c010a PS16, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9a6c99cd_180aae32 PS16, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d078da5b_39ead11c PS16, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/fd9d94ae_77ce3bd3 PS16, Line 64: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7ef1be23_3e3dd01d PS16, Line 65: if (!node.IsMap()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7185d28e_15ce0db6 PS16, Line 65: if (!node.IsMap()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/4b199335_904e492d PS16, Line 65: if (!node.IsMap()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/fb13976e_fd2a7f92 PS16, Line 66: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/4c5873bb_774134d1 PS16, Line 66: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/0f1aed63_74318f73 PS16, Line 68: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e55a7972_926e0e2d PS16, Line 68: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d8cbe6cf_12630be2 PS16, Line 69: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/105ed566_4ff745e7 PS16, Line 69: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/11bcc8e2_357ce93f PS16, Line 70: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e3e2fe9b_803a67ee PS16, Line 70: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5a1b0305_13835ccc PS16, Line 70: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/931ee3bf_30c64426 PS16, Line 70: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/355bd739_53979900 PS16, Line 71: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c19207b3_805a74da PS16, Line 71: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/edcf3159_1040e1fa PS16, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dfd9eefa_efac577e PS16, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/39d03d26_ccb48860 PS16, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/0d1a53af_7005b8ff PS16, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f5e939df_0f478787 PS16, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/4727f7fb_d5309220 PS16, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/418770b0_f9fda917 PS16, Line 73: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b232e529_436ed528 PS16, Line 73: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/60a8c127_342ae484 PS16, Line 74: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1312e7f8_51ffd0ae PS16, Line 74: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/fc53fb17_d8649df4 PS16, Line 75: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/6b6dc79c_f1c5a529 PS16, Line 75: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/a6473691_369c59ee PS16, Line 76: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/85ce1a1f_a1f1d9d7 PS16, Line 80: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e4899fe7_deca2542 PS16, Line 80: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c3c6bf31_3f23a392 PS16, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/11229b45_49c07dfd PS16, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/8c1476a6_60cb4ea5 PS16, Line 81: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/92fc7310_19952907 PS16, Line 83: static Node encode(const QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5f516bf4_2ebe6896 PS16, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/091690d2_b00ec25d PS16, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c466d125_c4e46750 PS16, Line 83: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dc17f48f_116614e2 PS16, Line 83: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/43863e7b_b35feeec PS16, Line 83: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5cbf13e1_e21c973a PS16, Line 84: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3cee2508_a5a6a7b5 PS16, Line 85: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f52acdd9_e70f32d0 PS16, Line 85: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9b4e16aa_7bf4125a PS16, Line 86: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/0755f35d_4aed82c4 PS16, Line 86: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/6832d8e7_522734d5 PS16, Line 86: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1e27fb48_040305d9 PS16, Line 87: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7752b705_ba2906a2 PS16, Line 87: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/6f439c65_30efdd95 PS16, Line 88: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/2396ed87_39510d2c PS16, Line 88: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e2029361_85598c90 PS16, Line 89: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/19fff2fd_99e3f862 PS16, Line 89: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1c139bed_9bf78836 PS16, Line 90: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d4463aa1_499e8789 PS16, Line 92: static bool decode(const Node& node, QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/afc06cf0_9901418c PS16, Line 92: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d06df76c_5acfc1ea PS16, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/85dfefdd_3d7e13b8 PS16, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5b72e106_d776cd73 PS16, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/ab8e9e83_e15a2825 PS16, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b94693dd_4864072e PS16, Line 92: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/0af6f1b0_d8bd695a PS16, Line 93: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7dce9ccb_a333c279 PS16, Line 94: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/a9877a22_db081467 PS16, Line 94: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f86c0e84_d25116d4 PS16, Line 94: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/8cb61e57_852a1c98 PS16, Line 95: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/52405c6c_c203bd42 PS16, Line 95: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3cf16dea_3644c9f8 PS16, Line 97: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/2df19fb3_eebad69d PS16, Line 97: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b4da854e_3bf257f0 PS16, Line 98: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/a90c03f8_8a8965a1 PS16, Line 98: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/a7f11227_04cc66b2 PS16, Line 99: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/25c34895_baf3a2be PS16, Line 99: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c0705030_c62a6f5a PS16, Line 99: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/6f01fcb5_99bad715 PS16, Line 99: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/bf4f3927_fce2f6f5 PS16, Line 100: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e0c11161_53d3ccce PS16, Line 100: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/85c6c9fb_3e41713a PS16, Line 101: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/2e9049b4_9d054a2e PS16, Line 101: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dd56870b_62c3b61c PS16, Line 101: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/cf0dee5e_32f54baf PS16, Line 101: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1ad304e2_bb547b33 PS16, Line 102: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/627924c1_ab681329 PS16, Line 102: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d69e22ff_bdf5f304 PS16, Line 103: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/90390e6a_3135418c PS16, Line 103: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/6b2bf4a3_816f5a4a PS16, Line 104: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9f541630_afffa5d5 PS16, Line 104: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/08baf9bd_5caf3bd0 PS16, Line 105: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/75230521_699db50d PS16, Line 109: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/ec4de567_5cc9d936 PS16, Line 109: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/91b1b373_296b0036 PS16, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9c04e7af_eb153c1f PS16, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1a0b6825_0d3d7015 PS16, Line 110: struct convert<QList<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dc81ed4f_6ae99ec6 PS16, Line 112: static Node encode(const QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c8009983_feec2ba9 PS16, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/96108c4c_21650a4b PS16, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d24e236a_f462d54d PS16, Line 112: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7c35720f_3683ccd5 PS16, Line 112: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/aa0a80bd_11df2177 PS16, Line 112: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/df30c090_baeb8a3e PS16, Line 113: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/2a5ce831_9ab02799 PS16, Line 114: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/cb7fb3ae_f64985bc PS16, Line 114: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9ebeaf8f_bfff5725 PS16, Line 115: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3192f4fa_76fea01a PS16, Line 115: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/fa485198_392412bd PS16, Line 115: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/4a3a97dc_2ec09829 PS16, Line 116: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e842680f_906d470d PS16, Line 116: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/0f59785c_5a3ea993 PS16, Line 117: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e2fa0403_b94d0c3a PS16, Line 117: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d99ebe3e_c4b3cda3 PS16, Line 118: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9bfbfb48_bdbc1a2b PS16, Line 118: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/10be4db5_e732330e PS16, Line 119: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/84a5614d_d59f157f PS16, Line 121: static bool decode(const Node& node, QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/555c5296_1157e5ab PS16, Line 121: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/8417e37a_21341b18 PS16, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b1f58178_974a0985 PS16, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/0c4649e5_ef03bf13 PS16, Line 121: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/131c2b1a_0b62ae58 PS16, Line 121: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e552283a_2f4b0738 PS16, Line 121: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/63d049d4_695299fa PS16, Line 122: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/46d2196f_e7da2a81 PS16, Line 123: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/db5e60aa_42835702 PS16, Line 123: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b2cbf354_09134e58 PS16, Line 123: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f4d32558_a0eaaf90 PS16, Line 124: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c7fb9433_7abb9089 PS16, Line 124: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/0c93e943_6deba94d PS16, Line 126: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d6932518_800eee4d PS16, Line 126: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/909219c2_d7c60d8e PS16, Line 127: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1ceb71ed_a1a46f13 PS16, Line 127: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f867ef62_2a371ffc PS16, Line 128: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f6cba361_476eed48 PS16, Line 128: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5a170241_c0d05a7d PS16, Line 128: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5de4b3da_c3601526 PS16, Line 128: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/6ba4fab3_b346bcec PS16, Line 129: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/a4d079dc_9165d142 PS16, Line 129: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e19a8121_2a85f6b3 PS16, Line 130: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/317a208d_a61b5711 PS16, Line 130: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3c7a2016_34fc3ac2 PS16, Line 130: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7a47cec9_3e1a4c6f PS16, Line 130: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/51879ecf_ceabe0b9 PS16, Line 131: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9e365e9a_2566bb2c PS16, Line 131: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3466cc17_ba004227 PS16, Line 132: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/468dec0a_138941e5 PS16, Line 132: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c7ca1b2c_ad54d428 PS16, Line 133: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/2beef1d1_59162fd4 PS16, Line 133: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5d799e0e_316092b9 PS16, Line 134: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d1251557_d3ea4637 PS16, Line 138: template<typename T, typename U> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9334a450_9459414b PS16, Line 138: template<typename T, typename U> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/47e7c867_f797d50c PS16, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/44ddbfb9_e010d75f PS16, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b6078ec7_242c808f PS16, Line 139: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/bffc5e57_9185bf7d PS16, Line 139: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/2b816d00_bb8c1a49 PS16, Line 141: static Node encode(const QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c54eeaa1_3962e412 PS16, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/8c3bea63_9906ef9d PS16, Line 141: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/05fb9f50_0ae602b3 PS16, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5be85854_24e321af PS16, Line 141: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/df68fa85_cb4b3e2e PS16, Line 141: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c2081f86_99c5111f PS16, Line 141: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/fe7cb6a7_dba32cd5 PS16, Line 142: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f23da2c8_6bab6497 PS16, Line 143: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b7908f58_115fd21e PS16, Line 143: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f6322dee_82c148da PS16, Line 144: node.push_back(rhs.first); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/bc3ebcd0_771bb23f PS16, Line 144: node.push_back(rhs.first); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f9e3be89_647d89bc PS16, Line 145: node.push_back(rhs.second); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/65f07637_7e6f6810 PS16, Line 145: node.push_back(rhs.second); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/884968e0_72b83d81 PS16, Line 146: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/42ae4924_b72f6b9f PS16, Line 146: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/24bc1065_94832bba PS16, Line 147: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3a0467ba_6ff66bdc PS16, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d560b768_9de88721 PS16, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b13e262a_c98f919c PS16, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b514cd93_bc8bf5b7 PS16, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b693eb6c_484b3626 PS16, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/82b4eaa6_cc2fecef PS16, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/94b8fa3f_b0e4ba0c PS16, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/53efc16d_6a76f426 PS16, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/0553bbc2_6fe9a746 PS16, Line 150: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f20fc1c2_e4808e2d PS16, Line 151: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dc5a1161_193293a0 PS16, Line 151: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/124147ba_f3b823a0 PS16, Line 151: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/483e76e7_0b82826b PS16, Line 152: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/789f14a6_520fa082 PS16, Line 152: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5b066d26_a251a922 PS16, Line 153: if (node.size() != 2) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1b57ab7d_53066d40 PS16, Line 153: if (node.size() != 2) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/0c7c672e_eff8af5b PS16, Line 153: if (node.size() != 2) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5b1116b1_8f1091bb PS16, Line 154: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/cefb3de9_301f3a04 PS16, Line 154: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f3b71172_f8ae3e84 PS16, Line 156: rhs.first = node[0].as<T>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/52769ea4_1e64d302 PS16, Line 156: rhs.first = node[0].as<T>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/6fb99135_cd03ec86 PS16, Line 156: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f5776709_f44f492e PS16, Line 156: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/8dd3525f_fa1c8b8e PS16, Line 157: rhs.second = node[1].as(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c2b9dc71_c1fca39a PS16, Line 157: rhs.second = node[1].as(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c1e11709_4e6267ce PS16, Line 157: rhs.second = node[1].as(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7ed7abcc_090c6271 PS16, Line 157: rhs.second = node[1].as(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/6ea67487_de776818 PS16, Line 158: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/56c96dd2_bd897670 PS16, Line 158: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/42ff36c2_db0f8e74 PS16, Line 159: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f15c50a1_acb9294e PS16, Line 163: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e6ac21bd_9b9a75ea PS16, Line 163: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/e4d72369_0aefbbc4 PS16, Line 164: struct convert<QStringList> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/27d41c01_2cd5557d PS16, Line 164: struct convert<QStringList> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/01db8bbc_b3944264 PS16, Line 166: static Node encode(const QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/4e1ee08b_57358ef6 PS16, Line 166: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/441fc661_453be02a PS16, Line 166: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d4f9dbf7_ef311b6b PS16, Line 167: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/7b7b72b8_ab94b67b PS16, Line 168: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/46102b37_25783392 PS16, Line 168: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3a7f4506_1d97a523 PS16, Line 169: for (const auto &value: rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/61ed20db_7532238a PS16, Line 169: for (const auto &value: rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/9081506b_c1c95d36 PS16, Line 169: for (const auto &value: rhs) { suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/dfb1a48b_a79cb911 PS16, Line 169: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/ef14011e_88506f22 PS16, Line 169: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b4694de6_6ce6660e PS16, Line 169: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1182afa2_15ef58f5 PS16, Line 170: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5584435c_f9929f03 PS16, Line 170: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/635d718b_8f6e0381 PS16, Line 171: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/66325bef_c2fce6e5 PS16, Line 171: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/a45ffbb8_d8db54f6 PS16, Line 172: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3c28c962_df8b2d54 PS16, Line 172: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1c6a706a_580dc5d7 PS16, Line 173: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/1825a1b7_7a671e62 PS16, Line 175: static bool decode(const Node& node, QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/8cba00f1_dc8f7e4f PS16, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/89b4ef29_ccd413a9 PS16, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/cb1c603e_bd728095 PS16, Line 175: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/cfe2ddcd_f94ae88b PS16, Line 176: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b66e6951_c17378b1 PS16, Line 177: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/0e6975fb_b7c7502d PS16, Line 177: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d4715219_1d2fadd6 PS16, Line 177: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f61b3d64_cea119e4 PS16, Line 178: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/352edf8c_c0b1b0c1 PS16, Line 178: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/03ea093a_0e117b8f PS16, Line 180: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5536cce0_78129ac6 PS16, Line 180: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/50e397ee_4171731f PS16, Line 181: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/39aeffc3_1c2a4e07 PS16, Line 181: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/3f538055_69121197 PS16, Line 182: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/68d63a26_a245e111 PS16, Line 182: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/95674cd9_73d2e05b PS16, Line 182: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/2b244478_7523dfeb PS16, Line 182: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d0e00769_92934df8 PS16, Line 183: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/76650ce4_acb869e0 PS16, Line 183: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/ff4c85c4_174bcfbb PS16, Line 184: rhs.push_back(it->as<QString>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/f2310b35_a82af468 PS16, Line 184: rhs.push_back(it->as<QString>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/ddbe23fc_5bb7b88d PS16, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/89c8808e_62a0a394 PS16, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/b386e3b3_91f6e5b9 PS16, Line 185: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/d25d58fb_47abf674 PS16, Line 185: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/c12c9e6f_3a0ecd11 PS16, Line 186: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/5698fa14_87a13b26 PS16, Line 186: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/a223470d_ba17d158 PS16, Line 187: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/fe4af770_b497d4e4 PS16, Line 187: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132311): https://review.coreboot.org/c/coreboot/+/58854/comment/ccaa0b0c_79671e3b PS16, Line 188: } please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 16 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Comment-Date: Thu, 04 Nov 2021 15:24:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by Sean Rhodes (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Sean Rhodes. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58854 to look at the new patch set (#16). Change subject: [WIP] util: Add coreboot Configurator ...................................................................... [WIP] util: Add coreboot Configurator A simply GUI to change settings in coreboot's CBFS, via the nvramtool utility. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 --- A util/coreboot-configurator/README.md A util/coreboot-configurator/contrib/PKGBUILD A util/coreboot-configurator/contrib/README.md A util/coreboot-configurator/contrib/debian/changelog A util/coreboot-configurator/contrib/debian/compat A util/coreboot-configurator/contrib/debian/control A util/coreboot-configurator/contrib/debian/copyright A util/coreboot-configurator/contrib/debian/files A util/coreboot-configurator/contrib/debian/rules A util/coreboot-configurator/contrib/debian/source/format A util/coreboot-configurator/contrib/flatpak/coreboot-configurator.json A util/coreboot-configurator/contrib/flatpak/org.coreboot.coreboot-configurator.json A util/coreboot-configurator/meson.build A util/coreboot-configurator/meson_options.txt A util/coreboot-configurator/screenshots/coreboot-configurator.gif A util/coreboot-configurator/screenshots/coreboot-configurator.png A util/coreboot-configurator/src/Documentation.txt A util/coreboot-configurator/src/application/aboutwindow.cpp A util/coreboot-configurator/src/application/aboutwindow.h A util/coreboot-configurator/src/application/aboutwindow.ui A util/coreboot-configurator/src/application/categories.yaml A util/coreboot-configurator/src/application/configuration.cpp A util/coreboot-configurator/src/application/configuration.h A util/coreboot-configurator/src/application/coreboot_configurator.cpp A util/coreboot-configurator/src/application/coreboot_configurator.h A util/coreboot-configurator/src/application/coreboot_configurator.ui A util/coreboot-configurator/src/application/images.qrc A util/coreboot-configurator/src/application/main.cpp A util/coreboot-configurator/src/application/meson.build A util/coreboot-configurator/src/application/qtyaml.h A util/coreboot-configurator/src/application/toggle-off.svg A util/coreboot-configurator/src/application/toggle-on.svg A util/coreboot-configurator/src/meson.build A util/coreboot-configurator/src/static/aboutIcon.png A util/coreboot-configurator/src/static/coreboot-configurator.desktop A util/coreboot-configurator/src/static/coreboot_configurator.svg A util/coreboot-configurator/src/static/meson.build A util/coreboot-configurator/src/static/org.coreboot.nvramtool.policy A util/coreboot-configurator/src/static/org.coreboot.reboot.policy 39 files changed, 2,941 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/58854/16 -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 16 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by build bot (Jenkins) (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Sean Rhodes. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 ) Change subject: [WIP] util: Add coreboot Configurator ...................................................................... Patch Set 15: (363 comments) File util/coreboot-configurator/src/Documentation.txt: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/2196be6c_e9a35fb8 PS15, Line 5: This allows `coreboot-configurator` to display them in a relavant tab, with a nice 'relavant' may be misspelled - perhaps 'relevant'? File util/coreboot-configurator/src/application/aboutwindow.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/54a95849_ae5f970b PS15, Line 16: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b0aa08eb_c6d1ddf8 PS15, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/09b9dae0_b659da90 PS15, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6dd139f5_3f433f13 PS15, Line 21: Ui::aboutWindow *ui; labels should not be indented File util/coreboot-configurator/src/application/configuration.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c26562b9_c3433966 PS15, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/1a77f037_733f3c79 PS15, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6269091f_738feb0e PS15, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/60ebdfe9_57c933de PS15, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c39444cd_7c68511f PS15, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3ab06318_95f8b4c0 PS15, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/40dc98e9_f76f0c98 PS15, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6d00809f_26f1d3e9 PS15, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/1e4645d4_4f902998 PS15, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8141d901_4168ba01 PS15, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW) File util/coreboot-configurator/src/application/coreboot_configurator.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/af209181_a474e5e5 PS15, Line 29: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7c4e939f_abfbb1f3 PS15, Line 30: coreboot_configurator(QWidget *parent = nullptr); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0e2ae25d_2e0584ab PS15, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/14337061_660ab78b PS15, Line 37: void showEvent(QShowEvent *ev); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/08bfe020_f481a4c0 PS15, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8648e4f7_32aceafb PS15, Line 38: void closeEvent(QCloseEvent *ev); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/27423284_c298b741 PS15, Line 42: void closeWindow(int result); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/43bc1583_884dd13f PS15, Line 43: void saveAndClose(void); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/25ff589d_ea771ae0 PS15, Line 46: void getSettings(void); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/dc8a99b3_64b0933f PS15, Line 47: void getFromFile(void); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c292aa23_d4b1d832 PS15, Line 48: void displaySettings(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/24cbcf3f_6234bc61 PS15, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b45c3298_2e2f20a1 PS15, Line 51: void writeSettings(void); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/edd63bf4_0401a6f9 PS15, Line 52: void writeToFile(const QString& out_file); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f5aa5f3a_5d50361b PS15, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/57cb6f09_0ed03de8 PS15, Line 55: void updateValue(const QString& name); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6e6b356a_01d1c9e9 PS15, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/4efa9bc1_45630d56 PS15, Line 59: QString m_fileName; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ac988067_afbc2839 PS15, Line 61: QMap<QString, QString> m_values; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6082d656_c5cc3493 PS15, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/da509137_b4bd0881 PS15, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/be3ed5b2_f9c469d1 PS15, Line 64: QMap<QString, QVBoxLayout*> m_tabs; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/dcd20a0d_197cf259 PS15, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3514a48c_e3804585 PS15, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/573d7bb7_52155488 PS15, Line 67: YAML::Node m_categories; labels should not be indented Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/23c8470a_4ecb2d59 PS15, Line 70: QComboBox *textToDisplay(const QString &in_string); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/076be2e6_d84b6e73 PS15, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c862f95f_216858b1 PS15, Line 71: QCheckBox *checkToDisplay(const QString &in_string); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c6120010_57883ec1 PS15, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6ef99821_0097bef3 PS15, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c0576ac1_79ad0262 PS15, Line 73: Ui::coreboot_configurator *ui; labels should not be indented File util/coreboot-configurator/src/application/qtyaml.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/9a753df1_f1e2d0e9 PS15, Line 30: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/d763c858_11f162d9 PS15, Line 30: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/1c6cbd83_2e0084ee PS15, Line 31: struct convert<QString> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/2a89b211_062c135c PS15, Line 31: struct convert<QString> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/167e3009_f78c6123 PS15, Line 33: static Node encode(const QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/006fb363_d6d78051 PS15, Line 33: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/de257d0b_95f134a8 PS15, Line 33: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8a2c6bf8_0ddbe329 PS15, Line 34: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ca90fb47_3cff7d7d PS15, Line 35: return Node(rhs.toStdString()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b7fb9cd0_cf7eeb5c PS15, Line 35: return Node(rhs.toStdString()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0c0476fc_b2c29d5e PS15, Line 36: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/4f3d8e94_a34ccaec PS15, Line 38: static bool decode(const Node& node, QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/982529e3_c9bf18b1 PS15, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7b93d18d_3219c270 PS15, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b2a96365_f83d7e0a PS15, Line 38: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/74190db2_16d95900 PS15, Line 39: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/517d2b8d_8b470ddc PS15, Line 40: if (!node.IsScalar()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/86b1d796_2ce59a3b PS15, Line 40: if (!node.IsScalar()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8c7b690c_d5eb6c96 PS15, Line 40: if (!node.IsScalar()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/685e1bbc_b1dd5bf4 PS15, Line 41: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/69c4829b_e54754cf PS15, Line 41: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f29148d5_90111283 PS15, Line 42: rhs = QString::fromStdString(node.Scalar()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/d73ec38c_8d0defb5 PS15, Line 42: rhs = QString::fromStdString(node.Scalar()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/1f803ffa_d646c11f PS15, Line 43: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3f11bc92_d69385aa PS15, Line 43: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/2da21889_8e1791ab PS15, Line 44: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/9549c9b7_532c9209 PS15, Line 48: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a61603d0_78a5346b PS15, Line 48: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3892276a_8322f9c2 PS15, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/d6409477_1ec5e550 PS15, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/9e8e07df_1df53951 PS15, Line 49: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b1a7b7ca_e354e82e PS15, Line 51: static Node encode(const QMap<Key,Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/282fc9ec_9451e711 PS15, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6b896cec_f243cf9b PS15, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/322c0fe0_a7185609 PS15, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8cac5796_3d617e7d PS15, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/4dfc820e_42f1a544 PS15, Line 51: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6a0eebd0_38da6300 PS15, Line 51: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/000d3a51_7f8e455c PS15, Line 52: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6c4a156f_8a13f736 PS15, Line 53: Node node(NodeType::Map); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/275d43a1_a20deacd PS15, Line 53: Node node(NodeType::Map); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3ba0a8c4_a3b7042f PS15, Line 54: auto it = rhs.constBegin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/54a302aa_99a408c3 PS15, Line 54: auto it = rhs.constBegin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/e0c306ce_ab82148e PS15, Line 55: while (it != rhs.constEnd()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/fec75194_1a734700 PS15, Line 55: while (it != rhs.constEnd()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/36eed318_7a4a2536 PS15, Line 55: while (it != rhs.constEnd()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/37e338af_add22a7c PS15, Line 55: while (it != rhs.constEnd()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c8a1a4bb_37ae1e4f PS15, Line 56: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/14e7da6c_3095cb75 PS15, Line 56: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b2719ca6_10cd8ed5 PS15, Line 57: node.force_insert(it.key(), it.value()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/259bbe6d_15159800 PS15, Line 57: node.force_insert(it.key(), it.value()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c0df2dfa_41fe938f PS15, Line 58: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7444fe32_5f11d336 PS15, Line 58: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/290c289b_4cc18660 PS15, Line 59: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a57fe4d2_5e31339c PS15, Line 59: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/42ff4c28_7ef2f9ee PS15, Line 60: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7e25b423_d59e8ab3 PS15, Line 60: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/deeeea56_2d52bbe7 PS15, Line 61: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f9014736_a72679d1 PS15, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/2b609342_629d3000 PS15, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/883d63d5_287f69ba PS15, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/428aed91_cfa7d555 PS15, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8293932f_4853b01f PS15, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/bd1e2ba0_7b039b1d PS15, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/34749384_f3aa6348 PS15, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/9921a8a7_5e93b0f7 PS15, Line 64: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/46c669be_c66d34ac PS15, Line 65: if (!node.IsMap()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/29e03c2c_420f75d4 PS15, Line 65: if (!node.IsMap()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/830fedfa_da9f8f3a PS15, Line 65: if (!node.IsMap()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/efaaff30_a26cbfb9 PS15, Line 66: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7da19d97_2d1d1760 PS15, Line 66: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8f60d95e_2b512724 PS15, Line 68: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/27f5e248_633657dd PS15, Line 68: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/fe99b0b1_652ccac6 PS15, Line 69: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3a4f8f36_5b9f00d0 PS15, Line 69: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a7b63769_9243c96e PS15, Line 70: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/08b14660_ef6ba293 PS15, Line 70: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/76a198f2_6442ced7 PS15, Line 70: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/38b7f629_db82e603 PS15, Line 70: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/67f1c968_2db52afc PS15, Line 71: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/773f086b_aac5f823 PS15, Line 71: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0b6ab901_d461f0bc PS15, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f03854a5_cc639542 PS15, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/245766c4_155ca1af PS15, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/cac23fa9_fb064958 PS15, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/49761fed_1a68a541 PS15, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/247197fd_ffdc0d39 PS15, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0865192c_88c0f8e0 PS15, Line 73: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f934ab92_246c35c3 PS15, Line 73: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8e7328b2_2cfb0857 PS15, Line 74: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/99746b4d_33767b8b PS15, Line 74: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0a95b36b_780ff192 PS15, Line 75: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/336f8386_c5637cfd PS15, Line 75: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/5e0f7fdd_f65a3bdd PS15, Line 76: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/86ecc8d8_d6e7b119 PS15, Line 80: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/683df71b_e8b48050 PS15, Line 80: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/08801d71_8098191b PS15, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/1f22d21c_200505b6 PS15, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/685a24c5_5b8e8b44 PS15, Line 81: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ce67ae8b_d863c394 PS15, Line 83: static Node encode(const QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7b614f96_5e7c324d PS15, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8dd126ee_69d5a29d PS15, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/71cf83e5_2685e44d PS15, Line 83: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a7318344_a4987084 PS15, Line 83: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7599a15d_c17781b5 PS15, Line 83: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f847de63_ab6a1bb7 PS15, Line 84: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/183ed5c2_c833d216 PS15, Line 85: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b447c708_837122c7 PS15, Line 85: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/be93dc32_50c5ab35 PS15, Line 86: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/d28e11f1_64bbdb57 PS15, Line 86: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a3eb7d8d_e66681d8 PS15, Line 86: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/caa9c28f_8946c69e PS15, Line 87: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/aefc3582_e652994f PS15, Line 87: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8b7792c1_ba12ddde PS15, Line 88: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/20360081_f58da623 PS15, Line 88: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/9df3c0ae_65d2efde PS15, Line 89: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b55706ef_d6f9a620 PS15, Line 89: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0d29ca49_3210ebcf PS15, Line 90: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6a532396_de5c188a PS15, Line 92: static bool decode(const Node& node, QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/9092c5e6_c7df19d8 PS15, Line 92: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ba779e0c_b82fd6ae PS15, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/52eeb0e4_43596081 PS15, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/e0832919_aa4c3583 PS15, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/80ebb5bb_183c9a3b PS15, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/48ac08dc_0e4c7e4d PS15, Line 92: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8e582f0b_b3e01137 PS15, Line 93: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a121bbf2_b649311c PS15, Line 94: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3afa98e1_f1ab943c PS15, Line 94: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8f1171b0_79bd2c25 PS15, Line 94: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/4b882496_8e74c80d PS15, Line 95: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/5029bf87_8388f094 PS15, Line 95: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/dd673448_cfb69642 PS15, Line 97: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/cb9bd6f1_67dbca83 PS15, Line 97: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6ab6dae8_558d5547 PS15, Line 98: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/9e6ce7e5_40baa0c5 PS15, Line 98: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/5a9fab4d_35f0d012 PS15, Line 99: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ea6d32bb_8f96a520 PS15, Line 99: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/00c0141d_ec5c22c9 PS15, Line 99: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8824c695_c01be871 PS15, Line 99: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6e86702a_a3b407e4 PS15, Line 100: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/5da1714d_cea709e8 PS15, Line 100: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3892a684_fe8e6d26 PS15, Line 101: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b23d8acc_2da45d29 PS15, Line 101: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a4383bc3_95069553 PS15, Line 101: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/4c7e00b2_a9b2c6d0 PS15, Line 101: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7bc4cad5_1efc7fd8 PS15, Line 102: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/bb6a7b43_de03dce4 PS15, Line 102: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8af201f6_93d66afb PS15, Line 103: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/665a27e6_970048a7 PS15, Line 103: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/2fa2cfba_34b68878 PS15, Line 104: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/55738c1b_f62a19a3 PS15, Line 104: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0299963c_2c4cef62 PS15, Line 105: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3d641b0d_54fef693 PS15, Line 109: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/01bf568b_62ecda6c PS15, Line 109: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7816d914_ccc8181d PS15, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/bc8630f3_f0ae0510 PS15, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ca081a72_11dfea73 PS15, Line 110: struct convert<QList<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/2d1c8b47_99ca0bf0 PS15, Line 112: static Node encode(const QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c28cd8aa_fac4a3f9 PS15, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b37f3c8a_45c4c7d9 PS15, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/37134ac4_a95858c1 PS15, Line 112: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ad7bbcc9_2ac739b9 PS15, Line 112: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/1d962eac_a3cf7197 PS15, Line 112: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/666fe8cc_3d4dc6a5 PS15, Line 113: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c7b74ce0_e128db66 PS15, Line 114: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/cecb5f57_384d0afb PS15, Line 114: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/054bbe6b_af2c4223 PS15, Line 115: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/78777388_f8c9ddef PS15, Line 115: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/84e4bb01_b68488c9 PS15, Line 115: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/5538378c_320f385f PS15, Line 116: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a3dfe446_259f2a8f PS15, Line 116: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0edb5dce_60710ff5 PS15, Line 117: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b8d51328_3f825430 PS15, Line 117: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ee40ebe2_0aba8e9f PS15, Line 118: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6b108508_081ae9fe PS15, Line 118: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/bba1d168_a11f85b9 PS15, Line 119: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/46e37805_f2eb30eb PS15, Line 121: static bool decode(const Node& node, QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f5f43581_a152db2d PS15, Line 121: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/e23cc069_9f16525a PS15, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/11c01509_a5c39f15 PS15, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/1e4078fe_87e7f505 PS15, Line 121: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/eb49b493_4c93147b PS15, Line 121: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/4d5797ed_3cf0d032 PS15, Line 121: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/da670125_fa5057ac PS15, Line 122: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b79407b3_66e953cb PS15, Line 123: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/eb2ca8fd_5b4796d9 PS15, Line 123: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/de6f9d86_38b54b23 PS15, Line 123: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/072094bd_3ae0a69f PS15, Line 124: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/fe580e30_2724edf6 PS15, Line 124: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a7b33a4e_e568ee9f PS15, Line 126: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ce518edb_2e3e8e9b PS15, Line 126: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/14e27337_139d88b9 PS15, Line 127: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/70d56443_2e00d66b PS15, Line 127: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3e2058f4_25f7ce44 PS15, Line 128: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7725735d_a7fd7a57 PS15, Line 128: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0e8984f2_bf1abee2 PS15, Line 128: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a9afcd35_f8f4cb93 PS15, Line 128: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/42b5f569_84b30279 PS15, Line 129: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/68b4670d_0a062e1f PS15, Line 129: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7cefc16d_aaac7510 PS15, Line 130: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/df802d9d_57b57e6c PS15, Line 130: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f7639210_501a5853 PS15, Line 130: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/bcfb4e72_268c0bc1 PS15, Line 130: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/df8e6757_616a7883 PS15, Line 131: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/977e8311_a5759e39 PS15, Line 131: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/4fc43040_3ad32e35 PS15, Line 132: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ad5d613a_34f2f4b8 PS15, Line 132: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f835a466_78f1af41 PS15, Line 133: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a0e950b5_f10b2751 PS15, Line 133: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/e88670ec_e3a16e89 PS15, Line 134: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/02082603_618cae1e PS15, Line 138: template<typename T, typename U> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/9a0b5df0_b1f5e506 PS15, Line 138: template<typename T, typename U> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8d4538c2_87f05b2e PS15, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/2d404b7b_6d661b00 PS15, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/654831c3_ccdb1e79 PS15, Line 139: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a2f37be0_216da8cc PS15, Line 139: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/4a63a8ec_2ad2362b PS15, Line 141: static Node encode(const QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7d7319be_61d9e8aa PS15, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b5cbe513_d5c2771d PS15, Line 141: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ad93ccab_3b3bac90 PS15, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/968301ff_8595de0f PS15, Line 141: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/1b7b95c0_855a7396 PS15, Line 141: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/9521d5fc_56fdaded PS15, Line 141: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/24506bd5_5976d124 PS15, Line 142: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/d8d56e4e_89a793b4 PS15, Line 143: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f7be0bf4_dfb31af6 PS15, Line 143: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/d4793f75_e5d2cd64 PS15, Line 144: node.push_back(rhs.first); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ed48b98c_6beeab6d PS15, Line 144: node.push_back(rhs.first); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a2bdc7da_c70b9050 PS15, Line 145: node.push_back(rhs.second); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/cb5d0a4c_e6e0d3e8 PS15, Line 145: node.push_back(rhs.second); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6abd9b51_48f8772e PS15, Line 146: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a610d9c0_6257a4ef PS15, Line 146: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f66240fb_c322f0e9 PS15, Line 147: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6659fb04_fd839437 PS15, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/5aa3d7bb_52503d2f PS15, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/d347e2af_88de2d99 PS15, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ff854b03_49cdd4a9 PS15, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/298dd8ab_0936735c PS15, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/d550f09c_0d88fe01 PS15, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/cb032012_7ea5f73a PS15, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/2bfc8abe_5a03657e PS15, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ae654ff2_62c762e4 PS15, Line 150: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b16af49d_bbd97f44 PS15, Line 151: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/5de0d6ee_2fac3a6c PS15, Line 151: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/9e80d1a7_c89eb2ad PS15, Line 151: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/5bd313c4_c536b1b3 PS15, Line 152: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f73d8a83_ae449d3a PS15, Line 152: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/1dfe9b4a_e7ddc095 PS15, Line 153: if (node.size() != 2) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b6571ed6_d069e18b PS15, Line 153: if (node.size() != 2) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/788d10ae_ff10ba8c PS15, Line 153: if (node.size() != 2) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c0877b3b_5c049efb PS15, Line 154: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/392f25a6_ea49fbd3 PS15, Line 154: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f12d701f_c00010c0 PS15, Line 156: rhs.first = node[0].as<T>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/1504576a_1f48c15a PS15, Line 156: rhs.first = node[0].as<T>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8abd16bb_eef119b6 PS15, Line 156: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8bc3db73_71f23313 PS15, Line 156: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/df6ead3a_9ccb672d PS15, Line 157: rhs.second = node[1].as(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/68e611bf_bf02d4b6 PS15, Line 157: rhs.second = node[1].as(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/4299bebd_ba929cd5 PS15, Line 157: rhs.second = node[1].as(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7008e4a6_6379f9a3 PS15, Line 157: rhs.second = node[1].as(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/69eee861_609410fa PS15, Line 158: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/11e99caa_6b914e7c PS15, Line 158: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/e9ce2a8f_50be7270 PS15, Line 159: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/737e2413_dd18e25c PS15, Line 163: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0204585d_07833baa PS15, Line 163: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8acb03a4_244c8ee5 PS15, Line 164: struct convert<QStringList> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/77190b76_2c125c78 PS15, Line 164: struct convert<QStringList> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0f7c2907_45382dfd PS15, Line 166: static Node encode(const QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a5e71ad8_0be350f5 PS15, Line 166: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/bd4b69c0_27760a65 PS15, Line 166: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ca3b841f_f8a2b10c PS15, Line 167: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/eb3a93a3_0c00c7d3 PS15, Line 168: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a7dda37c_1c42faa2 PS15, Line 168: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/56a89e88_99d0d76f PS15, Line 169: for (const auto &value: rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/514d318b_7b8bebff PS15, Line 169: for (const auto &value: rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/370fd439_d9747137 PS15, Line 169: for (const auto &value: rhs) { suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/483d8cff_cd35b233 PS15, Line 169: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a7025c23_5cc45bed PS15, Line 169: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f7a6719f_fbb88b92 PS15, Line 169: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3aa19548_ec2c1628 PS15, Line 170: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/e6a7e2bf_ca071ada PS15, Line 170: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/4e12909f_618795ca PS15, Line 171: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/e460918e_90f5be3a PS15, Line 171: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/efa477da_a7b17361 PS15, Line 172: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f968f543_8f28ea69 PS15, Line 172: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/e19376bd_7901436d PS15, Line 173: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/86275e11_0585fb92 PS15, Line 175: static bool decode(const Node& node, QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c584097b_dad765ab PS15, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3358033b_7c6fcc49 PS15, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/2fc30a3e_e6666058 PS15, Line 175: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/dc937f50_a9a35c21 PS15, Line 176: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/780e0c76_e68c30a8 PS15, Line 177: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7c58d1d3_e3ef3826 PS15, Line 177: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/61a39306_d51a33af PS15, Line 177: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f87f51f7_f8f130b3 PS15, Line 178: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0fe0fbb6_9022ce7f PS15, Line 178: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/98827d9e_953050a2 PS15, Line 180: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/9145b295_52bf385f PS15, Line 180: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/64db88b4_7c983930 PS15, Line 181: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/e2e1c541_47c7e271 PS15, Line 181: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/24d4d5d2_62328a2f PS15, Line 182: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/96a475c6_828afaa5 PS15, Line 182: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/d235898a_765499bc PS15, Line 182: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/278553a6_831ab619 PS15, Line 182: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8ef98548_e4f37957 PS15, Line 183: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a751285a_611f8bea PS15, Line 183: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/dcfbc6c9_54486156 PS15, Line 184: rhs.push_back(it->as<QString>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/d5c31936_ccdfcfba PS15, Line 184: rhs.push_back(it->as<QString>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/dc063eeb_b462407e PS15, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/d6ab798c_d715ec9b PS15, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f5550870_260f70a6 PS15, Line 185: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0ba1d2dc_03bc246c PS15, Line 185: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/1ec95bac_08af7005 PS15, Line 186: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b77e184f_5eccf27d PS15, Line 186: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/decea6fb_5c62c110 PS15, Line 187: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/5e849eea_f676adf5 PS15, Line 187: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0a56d607_3591cf2b PS15, Line 188: } please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 15 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Comment-Date: Thu, 04 Nov 2021 15:23:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by Sean Rhodes (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Sean Rhodes. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58854 to look at the new patch set (#15). Change subject: [WIP] util: Add coreboot Configurator ...................................................................... [WIP] util: Add coreboot Configurator A simply GUI to change settings in coreboot's CBFS, via the nvramtool utility. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 --- A util/coreboot-configurator/README.md A util/coreboot-configurator/contrib/PKGBUILD A util/coreboot-configurator/contrib/README.md A util/coreboot-configurator/contrib/debian/.debhelper/generated/coreboot-configurator/installed-by-dh_install A util/coreboot-configurator/contrib/debian/.debhelper/generated/coreboot-configurator/installed-by-dh_installdocs A util/coreboot-configurator/contrib/debian/changelog A util/coreboot-configurator/contrib/debian/compat A util/coreboot-configurator/contrib/debian/control A util/coreboot-configurator/contrib/debian/copyright A util/coreboot-configurator/contrib/debian/coreboot-configurator.debhelper.log A util/coreboot-configurator/contrib/debian/coreboot-configurator.substvars A util/coreboot-configurator/contrib/debian/debhelper-build-stamp A util/coreboot-configurator/contrib/debian/files A util/coreboot-configurator/contrib/debian/rules A util/coreboot-configurator/contrib/debian/source/format A util/coreboot-configurator/contrib/flatpak/coreboot-configurator.json A util/coreboot-configurator/contrib/flatpak/org.coreboot.coreboot-configurator.json A util/coreboot-configurator/meson.build A util/coreboot-configurator/meson_options.txt A util/coreboot-configurator/screenshots/coreboot-configurator.gif A util/coreboot-configurator/screenshots/coreboot-configurator.png A util/coreboot-configurator/src/Documentation.txt A util/coreboot-configurator/src/application/aboutwindow.cpp A util/coreboot-configurator/src/application/aboutwindow.h A util/coreboot-configurator/src/application/aboutwindow.ui A util/coreboot-configurator/src/application/categories.yaml A util/coreboot-configurator/src/application/configuration.cpp A util/coreboot-configurator/src/application/configuration.h A util/coreboot-configurator/src/application/coreboot_configurator.cpp A util/coreboot-configurator/src/application/coreboot_configurator.h A util/coreboot-configurator/src/application/coreboot_configurator.ui A util/coreboot-configurator/src/application/images.qrc A util/coreboot-configurator/src/application/main.cpp A util/coreboot-configurator/src/application/meson.build A util/coreboot-configurator/src/application/qtyaml.h A util/coreboot-configurator/src/application/toggle-off.svg A util/coreboot-configurator/src/application/toggle-on.svg A util/coreboot-configurator/src/meson.build A util/coreboot-configurator/src/static/aboutIcon.png A util/coreboot-configurator/src/static/coreboot-configurator.desktop A util/coreboot-configurator/src/static/coreboot_configurator.svg A util/coreboot-configurator/src/static/meson.build A util/coreboot-configurator/src/static/org.coreboot.nvramtool.policy A util/coreboot-configurator/src/static/org.coreboot.reboot.policy 44 files changed, 2,945 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/58854/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 15 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: amdfwtool: Set soc name for Stoneyridge
by Bao Zheng (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Martin Roth, Marshall Dawson, Richard Spiegel, Zheng Bao, Matt Papageorge. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58555 ) Change subject: amdfwtool: Set soc name for Stoneyridge ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: Jenkins got confused. -- To view, visit https://review.coreboot.org/c/coreboot/+/58555 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e82188ce64733420a578446e22a077ef789be92 Gerrit-Change-Number: 58555 Gerrit-PatchSet: 7 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Comment-Date: Thu, 04 Nov 2021 15:22:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Add support for AMD's BIOS A/B recovery feature
by Bao Zheng (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56773 ) Change subject: amdfwtool: Add support for AMD's BIOS A/B recovery feature ...................................................................... Patch Set 28: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56773/comment/04d93984_41e13d5a PS28, Line 12: > Commit need to be added. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56773 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27f5d3476f648fcecafb8d258ccb6cfad4f50036 Gerrit-Change-Number: 56773 Gerrit-PatchSet: 28 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bao Zheng <zheng.bao(a)amd.corp-partner.google.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 04 Nov 2021 15:19:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by build bot (Jenkins) (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Sean Rhodes. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 ) Change subject: [WIP] util: Add coreboot Configurator ...................................................................... Patch Set 14: (364 comments) File util/coreboot-configurator/LICENSE: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/823a0339_602f230a PS14, Line 5: 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1dde9fcb_f8b86874 PS14, Line 253: Software Foundation, write to the Free Software Foundation; we sometimes Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/494fa605_e2952ee4 PS14, Line 307: with this program; if not, write to the Free Software Foundation, Inc., Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/5b6f3f23_fe17c248 PS14, Line 308: 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. File util/coreboot-configurator/contrib/debian/changelog: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/71a86dc1_75c5673b PS14, Line 30: * Added qt5-default dependancy 'dependancy' may be misspelled - perhaps 'dependency'? File util/coreboot-configurator/src/Documentation.txt: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/58032af2_17b3b77c PS14, Line 5: This allows `coreboot-configurator` to display them in a relavant tab, with a nice 'relavant' may be misspelled - perhaps 'relevant'? File util/coreboot-configurator/src/application/aboutwindow.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/dc2316a5_f421e527 PS14, Line 16: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/5e0f417d_31a4dcc3 PS14, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/87292718_0449d91c PS14, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2c17a8ad_751feb85 PS14, Line 21: Ui::aboutWindow *ui; labels should not be indented File util/coreboot-configurator/src/application/categories.yaml: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8a90dd6d_9ed72c78 PS14, Line 84: help: Adjust the amout of time before the keyboard backlight turns off when un-used 'amout' may be misspelled - perhaps 'amount'? File util/coreboot-configurator/src/application/configuration.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/fb7c1a12_f8c85ee2 PS14, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b284f10d_f4d65986 PS14, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/043f11d6_b5860f67 PS14, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/73dc1969_e8a5a633 PS14, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/143178e6_5779a75e PS14, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/0e539ba1_d381bef5 PS14, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/dd6ffa3e_d6153933 PS14, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/7929dbed_71db1a0a PS14, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f1ef8a0f_9abf9b56 PS14, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/9fea4d68_32ed8fb8 PS14, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW) File util/coreboot-configurator/src/application/coreboot_configurator.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/161de2be_544f86c1 PS14, Line 29: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/7008e030_2694198d PS14, Line 30: coreboot_configurator(QWidget *parent = nullptr); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/851af369_e844d050 PS14, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c8a20ead_f4ca9752 PS14, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/7da6694f_70074f2e PS14, Line 48: void displaySettings(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/a1db6b90_fdabed4a PS14, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c55634ea_d30ff1a5 PS14, Line 52: void writeToFile(const QString& out_file); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ccb92cb8_b0647761 PS14, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/899142c4_6f942351 PS14, Line 55: void updateValue(const QString& name); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/7adc107e_443d17f5 PS14, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8a2c9364_fad44dca PS14, Line 59: QString m_fileName; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/56d8b38a_2c980953 PS14, Line 61: QMap<QString, QString> m_values; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8342959f_7805a956 PS14, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/62190311_4269659f PS14, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b8837b43_ed84b59c PS14, Line 64: QMap<QString, QVBoxLayout*> m_tabs; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/3241cb70_68e85bae PS14, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/e2e8e086_573abcf7 PS14, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2e4b70f5_4baeeb60 PS14, Line 67: YAML::Node m_categories; labels should not be indented Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/5ff63c36_a025c7b5 PS14, Line 70: QComboBox *textToDisplay(const QString &in_string); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/875bd8fd_2cea9a5d PS14, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f3b6917d_5e65cf20 PS14, Line 71: QCheckBox *checkToDisplay(const QString &in_string); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/75bd4ce4_4dab995e PS14, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/9a5d86e5_f5f784cd PS14, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b3c38bdd_807f3df4 PS14, Line 73: Ui::coreboot_configurator *ui; labels should not be indented File util/coreboot-configurator/src/application/coreboot_configurator.cpp: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d3051d33_ee3f8672 PS14, Line 24: static auto s_errorWindowTitle = "Error Occured"; 'Occured' may be misspelled - perhaps 'Occurred'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/3efd0884_1e1249f5 PS14, Line 403: QMessageBox::critical(this, "Error Occured", "Can't open file to write"); 'Occured' may be misspelled - perhaps 'Occurred'? File util/coreboot-configurator/src/application/qtyaml.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/46e95f73_50a9e3f7 PS14, Line 30: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/743d9d71_e13c9ead PS14, Line 30: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/70d2369b_fb8e7a50 PS14, Line 31: struct convert<QString> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/569da995_8b650f60 PS14, Line 31: struct convert<QString> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/632c0d06_ee1be7b4 PS14, Line 33: static Node encode(const QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c2cd97bb_b58a3c5d PS14, Line 33: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d6beeb8b_fdc72e0a PS14, Line 33: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/459bc349_55d6feaf PS14, Line 34: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/32d367d6_c32c5da6 PS14, Line 35: return Node(rhs.toStdString()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6371de5c_81fd80af PS14, Line 35: return Node(rhs.toStdString()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/4dae5945_d09ec980 PS14, Line 36: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/31716a6d_5ace225a PS14, Line 38: static bool decode(const Node& node, QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/71994a36_e9c7fbd5 PS14, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d81b00aa_99e43d06 PS14, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/3c76aead_e8c9f0f4 PS14, Line 38: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/fb675d9e_733ec47d PS14, Line 39: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/113265cd_36188b6b PS14, Line 40: if (!node.IsScalar()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/86e2cfda_e3235001 PS14, Line 40: if (!node.IsScalar()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/22f3fedc_550259ec PS14, Line 40: if (!node.IsScalar()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/16221c8d_467d1149 PS14, Line 41: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ab4a637d_868336f4 PS14, Line 41: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/9808b819_498fead4 PS14, Line 42: rhs = QString::fromStdString(node.Scalar()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2f2261ba_c5c4b065 PS14, Line 42: rhs = QString::fromStdString(node.Scalar()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/dbdc50a8_4f69b66c PS14, Line 43: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/95319f78_e103fd85 PS14, Line 43: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/79f7311d_0b8fe08a PS14, Line 44: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/da83dd4a_de8251c9 PS14, Line 48: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/abbd372f_3304855b PS14, Line 48: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ca3e81d1_8cb31b8c PS14, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/dedea6d7_ae7f4cf7 PS14, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/4653171c_1c59c02f PS14, Line 49: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b6d033b6_c9f10d23 PS14, Line 51: static Node encode(const QMap<Key,Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/39dce238_02864cd6 PS14, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/9e212913_50ed517d PS14, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/10ff5eb6_2ddecb74 PS14, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/a67a0fc3_88663825 PS14, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/4de0bb30_0b5f5f9e PS14, Line 51: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/927230f4_0fa2db02 PS14, Line 51: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ccaf29bf_5b3c0a5d PS14, Line 52: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/a3522637_ebce85a5 PS14, Line 53: Node node(NodeType::Map); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/bc69d248_f67c925a PS14, Line 53: Node node(NodeType::Map); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/de198ef9_be96d138 PS14, Line 54: auto it = rhs.constBegin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/39e4b320_ab4adca8 PS14, Line 54: auto it = rhs.constBegin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/51d5d9c3_258c58e2 PS14, Line 55: while (it != rhs.constEnd()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2f5d15b6_971e17fc PS14, Line 55: while (it != rhs.constEnd()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/208ec9a4_b381c771 PS14, Line 55: while (it != rhs.constEnd()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d53102e2_6a1d1aa7 PS14, Line 55: while (it != rhs.constEnd()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ab883f88_d84b3883 PS14, Line 56: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1d3a4c11_a1717656 PS14, Line 56: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c268140c_f6fd187e PS14, Line 57: node.force_insert(it.key(), it.value()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/11328944_86d34059 PS14, Line 57: node.force_insert(it.key(), it.value()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/76d1bc85_d1595dbd PS14, Line 58: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f018b8a8_a38caa85 PS14, Line 58: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/eb33dce8_f9ea0f93 PS14, Line 59: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/cbb514af_94a415c0 PS14, Line 59: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/0ff12056_10f44744 PS14, Line 60: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/7ca3f9e9_fe798fed PS14, Line 60: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8ac319bd_6ac4ac2e PS14, Line 61: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8bf92d01_7d64e2b8 PS14, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/34cdce9c_a6c73515 PS14, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c5841bc2_993dbaa9 PS14, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/845315c3_29cf426a PS14, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f0abfa32_ebdb49e4 PS14, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/65b12d82_9b6889f4 PS14, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/69dacd55_3518adca PS14, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/a12e8e49_88aea92a PS14, Line 64: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c6bea7a7_a32aaf3f PS14, Line 65: if (!node.IsMap()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/a1663e20_a8e2e580 PS14, Line 65: if (!node.IsMap()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/555ec78d_54996980 PS14, Line 65: if (!node.IsMap()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/e003839a_d60f2d3b PS14, Line 66: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/865953e2_0ffacf9b PS14, Line 66: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/5e5b1ef2_a50174c4 PS14, Line 68: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1d3696f7_cafa9645 PS14, Line 68: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/546dbcf4_11034e78 PS14, Line 69: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/a088dc54_babfd8f5 PS14, Line 69: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2c024a53_339659c4 PS14, Line 70: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/70344a02_adbc890c PS14, Line 70: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/4ea7abc4_fadd0ea9 PS14, Line 70: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/44b5104f_62187f6c PS14, Line 70: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/4aa9f485_46ecfb30 PS14, Line 71: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1b892a8f_800f570f PS14, Line 71: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/bff9b3a8_cfe15e95 PS14, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/16625bff_364a1256 PS14, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/4eaf9080_6134042a PS14, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/7b8ba0e0_3d0b51b1 PS14, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/7e516e86_4bd8f21c PS14, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/808da79a_a0fa11f1 PS14, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/94ea0d2e_26270b9c PS14, Line 73: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/7d40f6ac_297b6d23 PS14, Line 73: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c2bea411_514538c6 PS14, Line 74: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/840cf41b_a270dfea PS14, Line 74: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/38f11731_8cc1c975 PS14, Line 75: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/70530452_bdcc749b PS14, Line 75: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/519f455d_e3c75ed6 PS14, Line 76: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/52d5cf45_78fb4737 PS14, Line 80: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6a0dafc6_c8982ef5 PS14, Line 80: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1e683573_01958e65 PS14, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8f8adc64_5b5711f3 PS14, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ca142fa6_c190fdae PS14, Line 81: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/0be03ad8_59dd8954 PS14, Line 83: static Node encode(const QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/dae1a0de_ab0ebd3a PS14, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2056ca72_72670df6 PS14, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/87f6852b_b684b75b PS14, Line 83: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/299790af_fca2309d PS14, Line 83: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/13cdf361_a51ac32c PS14, Line 83: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/37d1bf81_629f0e51 PS14, Line 84: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/761e3f7a_720d6ee0 PS14, Line 85: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/0099c905_bbcadd28 PS14, Line 85: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2238491a_4ff24737 PS14, Line 86: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ae0dad7d_dfedfc16 PS14, Line 86: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f8ff08a7_0fb1e355 PS14, Line 86: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/dccda299_54d5629b PS14, Line 87: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/5aed649a_7c0d6e94 PS14, Line 87: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f81728a6_f7cede06 PS14, Line 88: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b8214330_fcf878bc PS14, Line 88: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6f168572_ca54107a PS14, Line 89: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/23ab5e60_1543bda8 PS14, Line 89: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/516d6360_59af3f3d PS14, Line 90: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ae425ff2_8e126a9f PS14, Line 92: static bool decode(const Node& node, QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/798de0ef_c319444e PS14, Line 92: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/cfb3c4bf_36704093 PS14, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/0bd99270_8c33aa9e PS14, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/bfa5b22d_26d61d93 PS14, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1a70ea82_d731355e PS14, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/af9f144d_1bb9d296 PS14, Line 92: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/fbafd070_af44b35e PS14, Line 93: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/e9ad286a_a9422809 PS14, Line 94: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/9932e5c7_d22357ea PS14, Line 94: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/691164d9_ce01fd82 PS14, Line 94: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1c90dbf2_053a678e PS14, Line 95: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/677dde24_21870e9d PS14, Line 95: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/33b28d7a_188e051c PS14, Line 97: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/076a71e8_3d33d3b9 PS14, Line 97: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/3e104637_9c1f21bb PS14, Line 98: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/388dd700_1019b1a5 PS14, Line 98: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c929afca_190b5777 PS14, Line 99: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b0eb4524_c7b46fa8 PS14, Line 99: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/45182ebd_cf6515c0 PS14, Line 99: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/17802abc_fc206c9f PS14, Line 99: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d7cd46ee_17215dcb PS14, Line 100: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/65580a31_6b035c38 PS14, Line 100: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/bf9ed5b0_29700422 PS14, Line 101: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/821dcb37_90493682 PS14, Line 101: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ef0f254b_04cfbcd0 PS14, Line 101: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/a3b901bb_c1708ad9 PS14, Line 101: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/757435b4_2b069a52 PS14, Line 102: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/7f5f84fd_7a940bea PS14, Line 102: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/469a49fe_ec50ce7d PS14, Line 103: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/39796d58_163ecac7 PS14, Line 103: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f5950c76_678b06c8 PS14, Line 104: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/9587b6e0_f8f420b1 PS14, Line 104: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b94c15f1_11236aa5 PS14, Line 105: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/e030a202_bc52a177 PS14, Line 109: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6bedbbc6_e229a633 PS14, Line 109: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/236af5f3_5d1eaade PS14, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/fcd418cb_72d2dd61 PS14, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c59caa86_dca5c557 PS14, Line 110: struct convert<QList<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f385d16a_348ae98a PS14, Line 112: static Node encode(const QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2bd06e67_44642b19 PS14, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2cbd9bc4_623836cb PS14, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/3a56d167_0a1ba7a8 PS14, Line 112: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/dc308874_78e44017 PS14, Line 112: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/673cec14_69f24bde PS14, Line 112: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/57492a7d_4977c484 PS14, Line 113: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/76bd87cd_e550fb60 PS14, Line 114: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6c40c264_8d420a7e PS14, Line 114: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/061541b7_15192885 PS14, Line 115: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/22a4d85d_6b878510 PS14, Line 115: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d2109024_84101a29 PS14, Line 115: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/032e080a_c13000b3 PS14, Line 116: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f7f140d8_1970fea0 PS14, Line 116: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/15fec8f2_96d4b321 PS14, Line 117: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d824dcf9_262381bb PS14, Line 117: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f5b2e4c7_dc6897aa PS14, Line 118: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/a06f26ff_4244b4a7 PS14, Line 118: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/e9538384_28aa9c12 PS14, Line 119: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/91857909_52e3461b PS14, Line 121: static bool decode(const Node& node, QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/70473e95_ae4d60ae PS14, Line 121: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2b071610_e6bb97af PS14, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/5253d634_d7141cba PS14, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d7bfca03_4f0cee1a PS14, Line 121: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/3c7d3585_f9ec22d4 PS14, Line 121: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/918e1d65_7fcb1d7c PS14, Line 121: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f8c706e5_afdaa563 PS14, Line 122: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b1801f3f_34763e37 PS14, Line 123: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1c3fc22e_fc4280c7 PS14, Line 123: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/5ec96ec7_c1f00148 PS14, Line 123: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f10ee6b0_1d648ad3 PS14, Line 124: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/05c6e200_17950905 PS14, Line 124: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6d1b9130_232ebd60 PS14, Line 126: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/7440f5f8_a3b223cc PS14, Line 126: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/67fc0186_73ca8386 PS14, Line 127: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/332048b8_e680bd6d PS14, Line 127: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/dfb50ffe_0c03aedc PS14, Line 128: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/604d44dd_2e61ea6e PS14, Line 128: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/4231ff19_999ecdb5 PS14, Line 128: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f485c5a4_30b49dea PS14, Line 128: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2d169ad5_3a992656 PS14, Line 129: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/835af2e9_6c477d5f PS14, Line 129: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/db0f8d21_765703d8 PS14, Line 130: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/550fa932_1ca40d05 PS14, Line 130: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/33186e99_6d965493 PS14, Line 130: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2219b411_2272a0a3 PS14, Line 130: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/acf1947e_24c7e13f PS14, Line 131: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/20b7cdb4_690d4b54 PS14, Line 131: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/528b1a3d_c9ee8dee PS14, Line 132: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/798d3fb3_1e76fabd PS14, Line 132: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/019c96ce_49e64e1e PS14, Line 133: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/5dcdefaa_2e65c782 PS14, Line 133: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/28a5c9fe_c43fd458 PS14, Line 134: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6a0851d8_2bad2940 PS14, Line 138: template<typename T, typename U> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/3ea999f1_b6f1c439 PS14, Line 138: template<typename T, typename U> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/e4c20bbc_0dd92bdd PS14, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/fe400f5c_97b7077b PS14, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/fe868618_49162f0e PS14, Line 139: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ba90b91c_af92b6a7 PS14, Line 139: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/aca36ffe_a6e8350e PS14, Line 141: static Node encode(const QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1c280b61_b24ea828 PS14, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/342513fc_920802d8 PS14, Line 141: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/15e7caaf_1270359d PS14, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6bbcdc79_4153de46 PS14, Line 141: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b59c2ec1_ee43125b PS14, Line 141: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2454ab19_9586eea0 PS14, Line 141: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f810c9b3_29cbc111 PS14, Line 142: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d7351648_98445356 PS14, Line 143: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b51a609c_c3d4e6bb PS14, Line 143: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6bbcf7db_3fef961f PS14, Line 144: node.push_back(rhs.first); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/76c0c87a_55341f74 PS14, Line 144: node.push_back(rhs.first); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/780897cf_1170b205 PS14, Line 145: node.push_back(rhs.second); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6d4f0fb6_4e212cbb PS14, Line 145: node.push_back(rhs.second); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/cb1150d5_c2fa8055 PS14, Line 146: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1ae74b3f_26220807 PS14, Line 146: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8c097918_38f90a52 PS14, Line 147: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2c1adbc7_f757bf8c PS14, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b2bb9066_7a731bf4 PS14, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/45cc801d_819cc97f PS14, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/0b151220_15e1ba15 PS14, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2a0c51b5_23e71532 PS14, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/4af1dd28_71a0285a PS14, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/27ceb454_b353f0c3 PS14, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ddc4cc6a_df580260 PS14, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/59418e2d_9b139fe5 PS14, Line 150: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/812e3649_f5fd28cf PS14, Line 151: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/5de6f3e4_2bd15765 PS14, Line 151: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1c4bb431_3ae72a9a PS14, Line 151: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/a5ac5d6b_e0caf53f PS14, Line 152: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1741975b_61ffa32e PS14, Line 152: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d30da64b_5614468d PS14, Line 153: if (node.size() != 2) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/74746ee1_778b11f1 PS14, Line 153: if (node.size() != 2) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6bbd644d_582b49cf PS14, Line 153: if (node.size() != 2) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/fa51509b_5811d4f9 PS14, Line 154: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/181061da_952d3d52 PS14, Line 154: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6e02b8f8_d9874cd8 PS14, Line 156: rhs.first = node[0].as<T>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/20eafcee_3e2fe912 PS14, Line 156: rhs.first = node[0].as<T>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d7af8c77_3a6b2d20 PS14, Line 156: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/de2353b1_61708281 PS14, Line 156: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/566372ac_b918ad5d PS14, Line 157: rhs.second = node[1].as(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2df8ca1c_5bd861b6 PS14, Line 157: rhs.second = node[1].as(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2e269a4b_9696fad9 PS14, Line 157: rhs.second = node[1].as(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c4b76cbe_647b4936 PS14, Line 157: rhs.second = node[1].as(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/49505fed_97441730 PS14, Line 158: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/cf75d0a0_2bebc600 PS14, Line 158: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/27bd3312_a66636da PS14, Line 159: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2210a4f4_ca343d95 PS14, Line 163: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/af048623_381f549b PS14, Line 163: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d86ae31b_0d1f3c89 PS14, Line 164: struct convert<QStringList> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ef3396e8_e877d2a0 PS14, Line 164: struct convert<QStringList> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/cf60aad3_35dfe2a9 PS14, Line 166: static Node encode(const QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2be4b7da_289d23f5 PS14, Line 166: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/e767e6ac_9cafc83f PS14, Line 166: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8ba1301f_963b09e3 PS14, Line 167: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6cab14b3_74d83e00 PS14, Line 168: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ed635923_6993366a PS14, Line 168: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/22e730ab_3772955d PS14, Line 169: for (const auto &value: rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/3d564f8f_9a2e0294 PS14, Line 169: for (const auto &value: rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c4a07297_d9484f51 PS14, Line 169: for (const auto &value: rhs) { suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/5bf85a50_c8bfc8e9 PS14, Line 169: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/085dfada_f9e555fb PS14, Line 169: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f9da089a_c70ceb5e PS14, Line 169: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/4f7d53bc_2bfa8632 PS14, Line 170: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1cebe43b_aef62e9c PS14, Line 170: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1b392aa6_56ec12f0 PS14, Line 171: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/3d9f60f3_5d3725d6 PS14, Line 171: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/e8539580_ac34bfaa PS14, Line 172: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c093669a_bd11b6e3 PS14, Line 172: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/3d5659ff_6d2bdcc3 PS14, Line 173: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/93910a1d_ebb0e06b PS14, Line 175: static bool decode(const Node& node, QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/5e03a72a_20d6cb7f PS14, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8ed4f5aa_70a08a53 PS14, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/51be5b26_a1c3d375 PS14, Line 175: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/74f8ea18_6b38e1c2 PS14, Line 176: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ee22116c_95d09f1f PS14, Line 177: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b633d512_2dde4de8 PS14, Line 177: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/450b9f14_dfb3f39e PS14, Line 177: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d40a7786_491de33e PS14, Line 178: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/13b6752c_9bebc98f PS14, Line 178: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/29262a13_92cbaf5e PS14, Line 180: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/cf2bd553_22703273 PS14, Line 180: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/db6e2564_be9c758c PS14, Line 181: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/a17265fc_66ef24a5 PS14, Line 181: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/69074754_277cff72 PS14, Line 182: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/39be6267_a2f7a73b PS14, Line 182: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d358eb8c_b9afcf3f PS14, Line 182: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/3b3a5e35_31764d6e PS14, Line 182: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8b66df9a_f59448c2 PS14, Line 183: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/be04960a_a23e31b5 PS14, Line 183: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8ce537bf_990f0a60 PS14, Line 184: rhs.push_back(it->as<QString>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/786845a9_7195f291 PS14, Line 184: rhs.push_back(it->as<QString>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/945339af_e0956273 PS14, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8c50b1a3_48d81214 PS14, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f55214ab_6e5e68eb PS14, Line 185: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/494b2aed_a54d8936 PS14, Line 185: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/7ecf7849_df60cec2 PS14, Line 186: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ab325b7a_4fdd1b04 PS14, Line 186: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b3983596_7f5f005d PS14, Line 187: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/4e2bdedb_6ceeabed PS14, Line 187: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8bb6eb38_133d0663 PS14, Line 188: } please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 14 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Comment-Date: Thu, 04 Nov 2021 15:17:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by Sean Rhodes (Code Review) 04 Nov '21

04 Nov '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58854 to look at the new patch set (#13). Change subject: [WIP] util: Add coreboot Configurator ...................................................................... [WIP] util: Add coreboot Configurator A simply GUI to change settings in coreboot's CBFS, via the nvramtool utility. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 --- M 3rdparty/blobs A util/coreboot-configurator/LICENSE A util/coreboot-configurator/README.md A util/coreboot-configurator/contrib/PKGBUILD A util/coreboot-configurator/contrib/README.md A util/coreboot-configurator/contrib/debian/.debhelper/generated/coreboot-configurator/installed-by-dh_install A util/coreboot-configurator/contrib/debian/.debhelper/generated/coreboot-configurator/installed-by-dh_installdocs A util/coreboot-configurator/contrib/debian/changelog A util/coreboot-configurator/contrib/debian/compat A util/coreboot-configurator/contrib/debian/control A util/coreboot-configurator/contrib/debian/copyright A util/coreboot-configurator/contrib/debian/coreboot-configurator.debhelper.log A util/coreboot-configurator/contrib/debian/coreboot-configurator.substvars A util/coreboot-configurator/contrib/debian/coreboot-configurator/DEBIAN/control A util/coreboot-configurator/contrib/debian/coreboot-configurator/DEBIAN/md5sums A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/sbin/coreboot-configurator A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/applications/coreboot-configurator.desktop A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/coreboot-configurator/aboutIcon.png A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/doc/coreboot-configurator/changelog.gz A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/doc/coreboot-configurator/copyright A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/icons/hicolor/128x128/apps/coreboot-configurator.png A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/icons/hicolor/16x16/apps/coreboot-configurator.png A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/icons/hicolor/24x24/apps/coreboot-configurator.png A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/icons/hicolor/256x256/apps/coreboot-configurator.png A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/icons/hicolor/32x32/apps/coreboot-configurator.png A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/icons/hicolor/48x48/apps/coreboot-configurator.png A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/icons/hicolor/512x512/apps/coreboot-configurator.png A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/icons/hicolor/64x64/apps/coreboot-configurator.png A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/icons/hicolor/96x96/apps/coreboot-configurator.png A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/polkit-1/actions/org.coreboot.nvramtool.policy A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/polkit-1/actions/org.coreboot.reboot.policy A util/coreboot-configurator/contrib/debian/debhelper-build-stamp A util/coreboot-configurator/contrib/debian/files A util/coreboot-configurator/contrib/debian/rules A util/coreboot-configurator/contrib/debian/source/format A util/coreboot-configurator/contrib/flatpak/coreboot-configurator.json A util/coreboot-configurator/contrib/flatpak/org.coreboot.coreboot-configurator.json A util/coreboot-configurator/meson.build A util/coreboot-configurator/meson_options.txt A util/coreboot-configurator/screenshots/coreboot-configurator.gif A util/coreboot-configurator/screenshots/coreboot-configurator.png A util/coreboot-configurator/src/Documentation.txt A util/coreboot-configurator/src/application/aboutwindow.cpp A util/coreboot-configurator/src/application/aboutwindow.h A util/coreboot-configurator/src/application/aboutwindow.ui A util/coreboot-configurator/src/application/categories.yaml A util/coreboot-configurator/src/application/configuration.cpp A util/coreboot-configurator/src/application/configuration.h A util/coreboot-configurator/src/application/coreboot_configurator.cpp A util/coreboot-configurator/src/application/coreboot_configurator.h A util/coreboot-configurator/src/application/coreboot_configurator.ui A util/coreboot-configurator/src/application/images.qrc A util/coreboot-configurator/src/application/main.cpp A util/coreboot-configurator/src/application/meson.build A util/coreboot-configurator/src/application/qtyaml.h A util/coreboot-configurator/src/application/toggle-off.svg A util/coreboot-configurator/src/application/toggle-on.svg A util/coreboot-configurator/src/meson.build A util/coreboot-configurator/src/static/aboutIcon.png A util/coreboot-configurator/src/static/coreboot-configurator.desktop A util/coreboot-configurator/src/static/coreboot_configurator.svg A util/coreboot-configurator/src/static/meson.build A util/coreboot-configurator/src/static/org.coreboot.nvramtool.policy A util/coreboot-configurator/src/static/org.coreboot.reboot.policy 64 files changed, 3,367 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/58854/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 13 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: amdfwtool: Add support for AMD's BIOS A/B recovery feature
by Bao Zheng (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56773 ) Change subject: amdfwtool: Add support for AMD's BIOS A/B recovery feature ...................................................................... Patch Set 28: (1 comment) Patchset: PS26: > no. […] Done. checked grunt, trembyle, majolica. -- To view, visit https://review.coreboot.org/c/coreboot/+/56773 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27f5d3476f648fcecafb8d258ccb6cfad4f50036 Gerrit-Change-Number: 56773 Gerrit-PatchSet: 28 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bao Zheng <zheng.bao(a)amd.corp-partner.google.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 04 Nov 2021 15:17:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bao Zheng <fishbaozi(a)gmail.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021