coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: [WIP] util: Add GUI to change CMOS settings
by build bot (Jenkins) (Code Review) 04 Nov '21

04 Nov '21

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 ) Change subject: [WIP] util: Add GUI to change CMOS settings ...................................................................... Patch Set 12: (364 comments) File util/coreboot-configurator/LICENSE: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/fa090907_bb1bcd77 PS12, Line 5: 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/750a0163_f6df5b6a PS12, Line 253: Software Foundation, write to the Free Software Foundation; we sometimes Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/7c124a41_8ab19194 PS12, Line 307: with this program; if not, write to the Free Software Foundation, Inc., Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/bfcbbaed_f7be9bed PS12, Line 308: 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. File util/coreboot-configurator/contrib/debian/changelog: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/af3f8b60_fdd7f3be PS12, Line 30: * Added qt5-default dependancy 'dependancy' may be misspelled - perhaps 'dependency'? File util/coreboot-configurator/src/Documentation.txt: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/59cb0952_c0fb8dff PS12, Line 5: This allows `coreboot-configurator` to display them in a relavant tab, with a nice 'relavant' may be misspelled - perhaps 'relevant'? File util/coreboot-configurator/src/application/aboutwindow.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/0c3c82e9_1c2b72f6 PS12, Line 16: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/d30c0ba6_19e07638 PS12, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/be181efa_70211b3f PS12, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/616d5461_7321f488 PS12, Line 21: Ui::aboutWindow *ui; labels should not be indented File util/coreboot-configurator/src/application/categories.yaml: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/e767ca7e_612608ad PS12, Line 84: help: Adjust the amout of time before the keyboard backlight turns off when un-used 'amout' may be misspelled - perhaps 'amount'? File util/coreboot-configurator/src/application/configuration.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/e7a437d2_8969047f PS12, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/e08b8c61_a7af0ee8 PS12, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/860d4ebc_25fe96ab PS12, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/f3b4481e_f8b5cf83 PS12, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/0a0d6515_6fbdab1b PS12, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/2c03f604_5ff036e2 PS12, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/cd7b6c82_0763939c PS12, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/068b1853_cd7252b2 PS12, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/528bff4d_34c53447 PS12, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/1a4af9ab_9962b08b PS12, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW) File util/coreboot-configurator/src/application/coreboot_configurator.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/a26b742a_65938808 PS12, Line 29: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/74a4c749_2b417baa PS12, Line 30: coreboot_configurator(QWidget *parent = nullptr); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/46d99434_79fe104b PS12, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/66d7bf24_3032ca0e PS12, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/dcb84c8e_e8d593d4 PS12, Line 48: void displaySettings(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/a85dc9e6_5611939f PS12, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/69f55623_43d4dbf1 PS12, Line 52: void writeToFile(const QString& out_file); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/5e976b67_f7c08695 PS12, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/8ebd5c39_37284174 PS12, Line 55: void updateValue(const QString& name); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/132e95fd_5e6f05c5 PS12, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/863a45d8_c28f9116 PS12, Line 59: QString m_fileName; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/efdc27e0_f59c82a7 PS12, Line 61: QMap<QString, QString> m_values; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/cf7145e8_10bb1bf4 PS12, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/154fe0f7_91e09142 PS12, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/9ac49699_7c0bb6b1 PS12, Line 64: QMap<QString, QVBoxLayout*> m_tabs; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/a4f7fedd_4ac898e6 PS12, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/59943b06_affda241 PS12, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/ca07f18b_b96093e6 PS12, Line 67: YAML::Node m_categories; labels should not be indented Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/164c1afa_022db117 PS12, Line 70: QComboBox *textToDisplay(const QString &in_string); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/d1c937d4_9a7342d4 PS12, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/3434972c_eb219bce PS12, Line 71: QCheckBox *checkToDisplay(const QString &in_string); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/c9d931a5_2d03efed PS12, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/7a0f9757_033512c2 PS12, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/ffdfe45e_d0c846be PS12, Line 73: Ui::coreboot_configurator *ui; labels should not be indented File util/coreboot-configurator/src/application/coreboot_configurator.cpp: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/f7f2c5c1_f1ff338b PS12, Line 24: static auto s_errorWindowTitle = "Error Occured"; 'Occured' may be misspelled - perhaps 'Occurred'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/cae95831_6bc7ef1d PS12, Line 403: QMessageBox::critical(this, "Error Occured", "Can't open file to write"); 'Occured' may be misspelled - perhaps 'Occurred'? File util/coreboot-configurator/src/application/qtyaml.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/443473de_b0d06f4c PS12, Line 30: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/49d94c1e_3084b4ae PS12, Line 30: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/9ebbd03b_7bd6d886 PS12, Line 31: struct convert<QString> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/604516e4_3f46526e PS12, Line 31: struct convert<QString> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/f1b6692b_5953e7af PS12, Line 33: static Node encode(const QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/1b7c0deb_2d7b1be2 PS12, Line 33: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/c7f5f931_cb802d1b PS12, Line 33: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/c202248d_734643f4 PS12, Line 34: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/1e1a4eb2_87a986bd PS12, Line 35: return Node(rhs.toStdString()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/3a8ee44e_e2a718a3 PS12, Line 35: return Node(rhs.toStdString()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/7c94ab81_86f35d14 PS12, Line 36: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/90736792_3a08f729 PS12, Line 38: static bool decode(const Node& node, QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/29e081c5_a30682f9 PS12, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/eb85e651_afd340c9 PS12, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/dfdc360b_047595c9 PS12, Line 38: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/3ae3290f_76b8e985 PS12, Line 39: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/9459e4b8_84e34cdf PS12, Line 40: if (!node.IsScalar()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/eb46d935_2c42f0c1 PS12, Line 40: if (!node.IsScalar()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/6a0fd03b_fce68eca PS12, Line 40: if (!node.IsScalar()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/c21f1be6_8bc8ab58 PS12, Line 41: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/aaebde70_37c11a02 PS12, Line 41: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/502ddbbe_24787d3f PS12, Line 42: rhs = QString::fromStdString(node.Scalar()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/765fa2cf_f3be98b0 PS12, Line 42: rhs = QString::fromStdString(node.Scalar()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/a5a3bb00_e93ba3f6 PS12, Line 43: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/4df4df45_4fc3e7ac PS12, Line 43: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/4be8fda8_0bf6ae6a PS12, Line 44: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/baad80f0_f3ba3896 PS12, Line 48: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/14633691_855fa835 PS12, Line 48: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/8a5f5d85_8dab076e PS12, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/633a7e43_e82f7b74 PS12, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/4d0f75fc_1b979c86 PS12, Line 49: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/6275a42e_c1fe1e1e PS12, Line 51: static Node encode(const QMap<Key,Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/8f3af0f8_3ca96511 PS12, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/f7cd8553_bdb37b49 PS12, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/fb80f1a7_1ccac77e PS12, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/093c05a6_47d5a1dd PS12, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/f4b62db5_40c40d51 PS12, Line 51: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/edadf636_21109c7d PS12, Line 51: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/86de2047_d00068ce PS12, Line 52: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/4c18b548_11602aed PS12, Line 53: Node node(NodeType::Map); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/21a76557_462b5ed0 PS12, Line 53: Node node(NodeType::Map); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/fbd2fbb2_8fa88661 PS12, Line 54: auto it = rhs.constBegin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/e91bbece_ecfc9f10 PS12, Line 54: auto it = rhs.constBegin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/5c3867b1_84b1199d PS12, Line 55: while (it != rhs.constEnd()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/8418efb6_4dc78cf1 PS12, Line 55: while (it != rhs.constEnd()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/0ee04e32_c73e6160 PS12, Line 55: while (it != rhs.constEnd()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/80ea7d1d_16281e38 PS12, Line 55: while (it != rhs.constEnd()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/bb01d844_b5882a4f PS12, Line 56: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/94db9a03_53ab470d PS12, Line 56: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/6d1a0d77_a3801949 PS12, Line 57: node.force_insert(it.key(), it.value()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/ccb660fc_6d2bb6e9 PS12, Line 57: node.force_insert(it.key(), it.value()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/1a2a671a_78be0a04 PS12, Line 58: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/880792ea_cd353dab PS12, Line 58: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/7ea1f3aa_f2d1df5f PS12, Line 59: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/a126fb91_b0b6d67a PS12, Line 59: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/60dde0e5_bff38b15 PS12, Line 60: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/2130fe04_9e7d22f3 PS12, Line 60: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/ffb9cd58_94748063 PS12, Line 61: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/f514b87a_1bc5b1e9 PS12, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/dc6b755a_0b652390 PS12, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/7b8e3b71_301387ca PS12, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/9fcd3f34_fe03158b PS12, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/e419aad3_53138d3b PS12, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/176daabd_c4487c2f PS12, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/02e4afee_e4235505 PS12, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/fe945d38_d92f332e PS12, Line 64: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/cb8b55d3_e39be158 PS12, Line 65: if (!node.IsMap()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/bcdc7b60_ad96c309 PS12, Line 65: if (!node.IsMap()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/d7f454f5_2da13349 PS12, Line 65: if (!node.IsMap()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/8070c3d3_d362e3d7 PS12, Line 66: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/b48b66e3_bd7205b1 PS12, Line 66: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/e26bfdd2_973edc55 PS12, Line 68: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/7b150984_cc294e03 PS12, Line 68: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/527877d3_515f4f4f PS12, Line 69: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/44b4280c_d9227397 PS12, Line 69: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/8ad6afbc_a5272c3d PS12, Line 70: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/de416119_28ad713f PS12, Line 70: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/15a0cc1f_bba8989b PS12, Line 70: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/aba3c8b3_ddea238a PS12, Line 70: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/b50365ec_57b93957 PS12, Line 71: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/2b1b6aa0_e27ff871 PS12, Line 71: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/5afdf223_250629e2 PS12, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/1a8e94fc_4d4fab77 PS12, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/be7ad1dc_d8db529b PS12, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/d82a741d_2ab495b1 PS12, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/51184f16_d81ee3a2 PS12, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/98496440_dbfe91ca PS12, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/5283b3f9_8798b6d7 PS12, Line 73: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/54a979cb_babfcb06 PS12, Line 73: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/f67ab82c_3912217f PS12, Line 74: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/4f15b598_5f7104ee PS12, Line 74: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/f06817ec_260e34a0 PS12, Line 75: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/93d047db_b40bd357 PS12, Line 75: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/13e239f8_548b152a PS12, Line 76: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/5d667b64_276940a4 PS12, Line 80: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/058d1e90_4d9887a7 PS12, Line 80: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/b3517773_8e411662 PS12, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/ef7a8fda_ba5d3c23 PS12, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/46ac0da7_d2f61419 PS12, Line 81: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/949ad969_737fecb1 PS12, Line 83: static Node encode(const QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/75a936d9_6c0717e7 PS12, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/061657c4_12db4afc PS12, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/ea944790_cf0eb2fa PS12, Line 83: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/e4c23050_19159682 PS12, Line 83: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/27a90c30_7d9fd618 PS12, Line 83: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/f1dabbf3_2a38750a PS12, Line 84: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/63b4485b_88446254 PS12, Line 85: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/36f3e66e_fe84f6f4 PS12, Line 85: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/0acfe0a7_1c6a6886 PS12, Line 86: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/c27e0c0d_97c4b63f PS12, Line 86: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/675cd8ca_d0439c8d PS12, Line 86: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/2f23f805_d51a162d PS12, Line 87: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/10a30465_b2449cfa PS12, Line 87: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/2ea446ca_9d2f8e25 PS12, Line 88: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/02681060_f1565a3b PS12, Line 88: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/a5edad6c_8cb8790f PS12, Line 89: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/d1fca284_ed7b27b8 PS12, Line 89: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/7bfaf902_f60e7faa PS12, Line 90: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/f75138a7_4ed1d294 PS12, Line 92: static bool decode(const Node& node, QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/b6a5001b_00898cc2 PS12, Line 92: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/3ab0fe2d_bd08c1cf PS12, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/9b1c15f9_5cb470d5 PS12, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/5a7c3bba_eb791d04 PS12, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/9c78f797_32087653 PS12, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/509ec75b_d2b5f6e6 PS12, Line 92: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/25cde10d_6c328c44 PS12, Line 93: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/e7a9aa7f_566f31c8 PS12, Line 94: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/38aa1a64_8d1f8404 PS12, Line 94: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/a73f9834_e951fa38 PS12, Line 94: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/db50c67c_862105be PS12, Line 95: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/91d94f53_54e87527 PS12, Line 95: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/3b6d0a0e_3a9f2083 PS12, Line 97: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/b0cbc422_381747e2 PS12, Line 97: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/54e00234_00bb186a PS12, Line 98: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/95d2bcb9_ebaa6d51 PS12, Line 98: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/9db5f2b4_0cba8e67 PS12, Line 99: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/118a6567_049b5d78 PS12, Line 99: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/974480b6_f8aee46c PS12, Line 99: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/68f13e50_20242451 PS12, Line 99: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/6cbbb727_041ed6cb PS12, Line 100: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/07402ea5_75b24e67 PS12, Line 100: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/b0054ac8_441d2735 PS12, Line 101: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/f752dc66_ba64236b PS12, Line 101: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/b7897c57_c5d0eda2 PS12, Line 101: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/f673402c_d684a669 PS12, Line 101: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/1d57699a_078cda97 PS12, Line 102: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/dbe587c7_a6b09e9e PS12, Line 102: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/1e6e5316_83f84c08 PS12, Line 103: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/d46fa2b0_56b76f18 PS12, Line 103: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/e00b4d93_42155d70 PS12, Line 104: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/96fe15e5_c98ce235 PS12, Line 104: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/3ed2eb2d_c944a774 PS12, Line 105: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/c5749649_dee41ee9 PS12, Line 109: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/98f872fd_5f5771ac PS12, Line 109: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/f50a4543_dac0af89 PS12, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/37c1546d_305a6afa PS12, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/7337202e_9604b796 PS12, Line 110: struct convert<QList<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/ff992f1f_8a732dd6 PS12, Line 112: static Node encode(const QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/0a7a23fe_eb7d9f81 PS12, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/d8aebc2c_cbc91f97 PS12, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/27a52f3d_a15ba5e7 PS12, Line 112: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/23bc93e4_66d4f8fa PS12, Line 112: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/d0a723ae_8c75d050 PS12, Line 112: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/d50a8eee_d8c62abc PS12, Line 113: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/544b109a_5ad979ac PS12, Line 114: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/b110be12_2b0bb929 PS12, Line 114: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/e7c85c34_ea419737 PS12, Line 115: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/882e92fb_ee876c65 PS12, Line 115: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/1d8bbff5_f3246752 PS12, Line 115: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/26d80b00_6a2b4233 PS12, Line 116: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/18c86b02_3a050508 PS12, Line 116: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/750f2c21_13f47c32 PS12, Line 117: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/c85888a5_637fd4c6 PS12, Line 117: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/0a3fe5e7_50fe84c4 PS12, Line 118: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/acd6b897_4dabe746 PS12, Line 118: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/aa710ec8_f6039272 PS12, Line 119: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/bff7c8b6_7b5d635a PS12, Line 121: static bool decode(const Node& node, QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/95aec9fa_a99786bd PS12, Line 121: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/4fd0c566_a0ca1923 PS12, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/bf9e6764_090af204 PS12, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/941ac3b4_92da0c78 PS12, Line 121: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/00be6f63_c53319a2 PS12, Line 121: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/5037997d_b4309587 PS12, Line 121: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/0d602722_74eb14d7 PS12, Line 122: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/42e82cf7_80b7413e PS12, Line 123: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/1c16f397_76952511 PS12, Line 123: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/3690f951_ff6964d6 PS12, Line 123: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/5d6b1200_c647b92c PS12, Line 124: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/1aeb1486_863a69b4 PS12, Line 124: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/bb8e5640_7d8fa694 PS12, Line 126: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/6aa64c92_8e84e176 PS12, Line 126: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/e7744625_c7dcc746 PS12, Line 127: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/d9500fe5_c2e63816 PS12, Line 127: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/2285ea4d_bf259186 PS12, Line 128: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/27c05144_1f057b0b PS12, Line 128: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/c6efd0f4_18367fbe PS12, Line 128: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/449fc3d2_90140ae8 PS12, Line 128: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/5adc12a4_34fc3a0a PS12, Line 129: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/eb272d1b_3b8c3895 PS12, Line 129: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/c8394d19_03ee58b6 PS12, Line 130: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/ae915dca_2e301156 PS12, Line 130: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/6f34b12f_41a3d4c3 PS12, Line 130: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/b27c8a43_f821befb PS12, Line 130: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/4581157d_ced33b02 PS12, Line 131: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/4fed1632_3cc33bd7 PS12, Line 131: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/e6cf14e9_58b06664 PS12, Line 132: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/5a6bcab1_c0cb5782 PS12, Line 132: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/2522cb5a_740d6fea PS12, Line 133: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/9a0c0538_5b3270b3 PS12, Line 133: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/c700f8fd_0710c0c1 PS12, Line 134: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/f0ff0dc0_550e119f PS12, Line 138: template<typename T, typename U> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/603ef89a_b444e215 PS12, Line 138: template<typename T, typename U> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/c967c4df_50137624 PS12, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/5a7e3ab1_d5b30ac2 PS12, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/96f3a118_3bd6210d PS12, Line 139: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/f285c233_9679f3bd PS12, Line 139: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/32521b0f_c40ed97e PS12, Line 141: static Node encode(const QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/42da0926_13104a5b PS12, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/832b77bc_7b3d1006 PS12, Line 141: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/9dd804b6_cc1d33aa PS12, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/bb76884d_8bc850e0 PS12, Line 141: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/1bce17ae_5cfdcadf PS12, Line 141: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/e8a21579_0c7dd3cf PS12, Line 141: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/c1bbbaf5_62fc2b11 PS12, Line 142: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/cf3ba76c_fa00c60b PS12, Line 143: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/bea1bb50_66ad5887 PS12, Line 143: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/acbbdb16_4b49c0bf PS12, Line 144: node.push_back(rhs.first); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/86b9a9c6_bb3ead5d PS12, Line 144: node.push_back(rhs.first); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/f40acb35_85c66d65 PS12, Line 145: node.push_back(rhs.second); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/d04cb82f_e7f4652b PS12, Line 145: node.push_back(rhs.second); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/4974b045_45160368 PS12, Line 146: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/de829c0a_e6f15277 PS12, Line 146: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/5b58b5a9_31d1854e PS12, Line 147: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/d15a75c2_7b1cb57c PS12, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/9df57cd6_dbdb7d84 PS12, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/4e588a0d_508348bf PS12, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/5cbac22b_bb7c6c0b PS12, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/f5cc253d_2532ea51 PS12, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/4d73c010_103c0389 PS12, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/7062b01c_b796195e PS12, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/e2b11378_bd1cd411 PS12, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/451f3598_bd5b38c0 PS12, Line 150: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/2448b4ee_e7ee685d PS12, Line 151: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/fcf9b91b_7600ea19 PS12, Line 151: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/d66283e8_034f2f03 PS12, Line 151: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/d43f6b29_52adfa01 PS12, Line 152: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/255251d0_10279377 PS12, Line 152: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/198ae194_efeb33be PS12, Line 153: if (node.size() != 2) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/68d4b6ed_161d7a28 PS12, Line 153: if (node.size() != 2) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/3433bb81_6527bece PS12, Line 153: if (node.size() != 2) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/f4e96cc8_85152769 PS12, Line 154: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/8a270451_a8c031da PS12, Line 154: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/a487f7b7_3cec8253 PS12, Line 156: rhs.first = node[0].as<T>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/11eaff9e_9c0549be PS12, Line 156: rhs.first = node[0].as<T>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/b30aa610_a29dd1ab PS12, Line 156: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/01cc42d6_52b6254f PS12, Line 156: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/071dae75_d7964579 PS12, Line 157: rhs.second = node[1].as<U>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/e842a396_f443325b PS12, Line 157: rhs.second = node[1].as<U>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/78e1e5ee_1e5ac75e PS12, Line 157: rhs.second = node[1].as<U>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/b80d1f92_0363a973 PS12, Line 157: rhs.second = node[1].as<U>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/2de551b5_1ac0cf4a PS12, Line 158: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/efcb77ba_9363452e PS12, Line 158: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/42c752d0_01674c96 PS12, Line 159: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/9de5b602_a7cd6ed8 PS12, Line 163: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/7b032c09_5b67d071 PS12, Line 163: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/0311e168_d0ef2749 PS12, Line 164: struct convert<QStringList> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/4ee8b607_5b8167f1 PS12, Line 164: struct convert<QStringList> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/2ae5ec0b_0dc934d4 PS12, Line 166: static Node encode(const QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/01299f0e_045ce4bf PS12, Line 166: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/29737500_3dedbdc2 PS12, Line 166: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/70063b29_1be34438 PS12, Line 167: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/01592786_41895f79 PS12, Line 168: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/6aa71a45_0db2df36 PS12, Line 168: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/fda8b3e5_2cd6aa96 PS12, Line 169: for (const auto &value: rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/3f3a89cd_496441b8 PS12, Line 169: for (const auto &value: rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/3789ee8c_912929c3 PS12, Line 169: for (const auto &value: rhs) { suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/02ac1f1a_702e1f07 PS12, Line 169: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/712ebbe3_a77a6dce PS12, Line 169: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/797f9edc_3706a6e0 PS12, Line 169: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/9f55fc1a_9642cba1 PS12, Line 170: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/51e0904e_b2d22f03 PS12, Line 170: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/5cd196e9_18da8f9e PS12, Line 171: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/8c0fc421_825d3d62 PS12, Line 171: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/1359fd3d_e2eb7f60 PS12, Line 172: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/2c3f62f2_3490cffa PS12, Line 172: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/f0271f71_ca2eeac6 PS12, Line 173: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/5b4bdb28_cb75b100 PS12, Line 175: static bool decode(const Node& node, QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/2ce47b22_823aaff6 PS12, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/d19eac86_5364e828 PS12, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/a5d8df79_57167b4b PS12, Line 175: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/bd9be4e5_9c040fa9 PS12, Line 176: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/6d79fed6_c2ec0784 PS12, Line 177: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/d2bd2991_b84fa131 PS12, Line 177: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/cc2ab2dd_194ef088 PS12, Line 177: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/672c489f_688b35d0 PS12, Line 178: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/4da05314_394b230b PS12, Line 178: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/ed570258_4bd0cb03 PS12, Line 180: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/782ed3e5_f2eacfd1 PS12, Line 180: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/e45c3243_e91b9b1c PS12, Line 181: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/a9503605_3d7cbb11 PS12, Line 181: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/0694b8b1_2598d8d4 PS12, Line 182: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/5476725f_a3fcc57e PS12, Line 182: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/d2edb742_a9f5a2ea PS12, Line 182: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/66e7da40_6a255013 PS12, Line 182: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/e3a0ddb4_f7183bbe PS12, Line 183: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/06bc0442_c9d55524 PS12, Line 183: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/d66947c0_858af329 PS12, Line 184: rhs.push_back(it->as<QString>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/8c541470_1e8f6326 PS12, Line 184: rhs.push_back(it->as<QString>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/46de0fb6_61b87a16 PS12, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/06d1f302_c4b2febc PS12, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/1ed6a5a8_badbf282 PS12, Line 185: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/e77bf5b7_88e6eac8 PS12, Line 185: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/90187f3a_019c83ef PS12, Line 186: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/9ff499d8_5ae7f6ee PS12, Line 186: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/69be8e9f_c62a1962 PS12, Line 187: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/c9302f63_c6dee45d PS12, Line 187: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132308): https://review.coreboot.org/c/coreboot/+/58854/comment/5e17e4a2_aeb807ae PS12, Line 188: } please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 12 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Nov 2021 15:17:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] util: Add GUI to change CMOS settings
by Sean Rhodes (Code Review) 04 Nov '21

04 Nov '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58854 to look at the new patch set (#12). Change subject: [WIP] util: Add GUI to change CMOS settings ...................................................................... [WIP] util: Add GUI to change CMOS settings A simply GUI to change settings in coreboot's CBFS, via the nvramtool utility. Not sure if it's even wanted upstream, but if it is, I'll tidy it up and make it work with any CMOS values. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 --- M 3rdparty/blobs A util/coreboot-configurator/LICENSE A util/coreboot-configurator/README.md A util/coreboot-configurator/contrib/PKGBUILD A util/coreboot-configurator/contrib/README.md A util/coreboot-configurator/contrib/debian/.debhelper/generated/coreboot-configurator/installed-by-dh_install A util/coreboot-configurator/contrib/debian/.debhelper/generated/coreboot-configurator/installed-by-dh_installdocs A util/coreboot-configurator/contrib/debian/changelog A util/coreboot-configurator/contrib/debian/compat A util/coreboot-configurator/contrib/debian/control A util/coreboot-configurator/contrib/debian/copyright A util/coreboot-configurator/contrib/debian/coreboot-configurator.debhelper.log A util/coreboot-configurator/contrib/debian/coreboot-configurator.substvars A util/coreboot-configurator/contrib/debian/coreboot-configurator/DEBIAN/control A util/coreboot-configurator/contrib/debian/coreboot-configurator/DEBIAN/md5sums A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/sbin/coreboot-configurator A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/applications/coreboot-configurator.desktop A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/coreboot-configurator/aboutIcon.png A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/doc/coreboot-configurator/changelog.gz A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/doc/coreboot-configurator/copyright A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/icons/hicolor/128x128/apps/coreboot-configurator.png A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/icons/hicolor/16x16/apps/coreboot-configurator.png A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/icons/hicolor/24x24/apps/coreboot-configurator.png A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/icons/hicolor/256x256/apps/coreboot-configurator.png A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/icons/hicolor/32x32/apps/coreboot-configurator.png A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/icons/hicolor/48x48/apps/coreboot-configurator.png A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/icons/hicolor/512x512/apps/coreboot-configurator.png A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/icons/hicolor/64x64/apps/coreboot-configurator.png A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/icons/hicolor/96x96/apps/coreboot-configurator.png A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/polkit-1/actions/org.coreboot.nvramtool.policy A util/coreboot-configurator/contrib/debian/coreboot-configurator/usr/share/polkit-1/actions/org.coreboot.reboot.policy A util/coreboot-configurator/contrib/debian/debhelper-build-stamp A util/coreboot-configurator/contrib/debian/files A util/coreboot-configurator/contrib/debian/rules A util/coreboot-configurator/contrib/debian/source/format A util/coreboot-configurator/contrib/flatpak/coreboot-configurator.json A util/coreboot-configurator/contrib/flatpak/org.coreboot.coreboot-configurator.json A util/coreboot-configurator/meson.build A util/coreboot-configurator/meson_options.txt A util/coreboot-configurator/screenshots/coreboot-configurator.gif A util/coreboot-configurator/screenshots/coreboot-configurator.png A util/coreboot-configurator/src/Documentation.txt A util/coreboot-configurator/src/application/aboutwindow.cpp A util/coreboot-configurator/src/application/aboutwindow.h A util/coreboot-configurator/src/application/aboutwindow.ui A util/coreboot-configurator/src/application/categories.yaml A util/coreboot-configurator/src/application/configuration.cpp A util/coreboot-configurator/src/application/configuration.h A util/coreboot-configurator/src/application/coreboot_configurator.cpp A util/coreboot-configurator/src/application/coreboot_configurator.h A util/coreboot-configurator/src/application/coreboot_configurator.ui A util/coreboot-configurator/src/application/images.qrc A util/coreboot-configurator/src/application/main.cpp A util/coreboot-configurator/src/application/meson.build A util/coreboot-configurator/src/application/qtyaml.h A util/coreboot-configurator/src/application/toggle-off.svg A util/coreboot-configurator/src/application/toggle-on.svg A util/coreboot-configurator/src/meson.build A util/coreboot-configurator/src/static/aboutIcon.png A util/coreboot-configurator/src/static/coreboot-configurator.desktop A util/coreboot-configurator/src/static/coreboot_configurator.svg A util/coreboot-configurator/src/static/meson.build A util/coreboot-configurator/src/static/org.coreboot.nvramtool.policy A util/coreboot-configurator/src/static/org.coreboot.reboot.policy 64 files changed, 3,367 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/58854/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 12 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: tigerlake/apci: Only use SCM for ChromeOS
by Felix Singer (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Sean Rhodes, Tim Wawrzynczak, Patrick Rudolph. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58798 ) Change subject: tigerlake/apci: Only use SCM for ChromeOS ...................................................................... Patch Set 8: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/58798/comment/f2d25389_7f6ae300 PS8, Line 7: tigerlake add `soc/intel/` before that -- To view, visit https://review.coreboot.org/c/coreboot/+/58798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib947c3c9cd843e54d4664509c15336178c0bc99e Gerrit-Change-Number: 58798 Gerrit-PatchSet: 8 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 04 Nov 2021 15:12:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tigerlake/apci: Only use SCM for ChromeOS
by Sean Rhodes (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58798 ) Change subject: tigerlake/apci: Only use SCM for ChromeOS ...................................................................... Patch Set 8: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/58798/comment/621f8efc_050c5282 PS5, Line 9: SCM doesn't work with Linux 5.13 or later and results in TBT : ports timing out. Not advertising this results in FCM being used : and TBT works correctly. > Not sure if everyone knows what SCM/FCM mean, maybe spell them out once? Done Patchset: PS5: > Nice digging Sean! Unfortunately, this has turned out to be Part 1 of 2 as D3cold is refusing to turn off. Fun times 😊 File 3rdparty/blobs: PS1: > I think this was unintentional, try […] Done File src/soc/intel/tigerlake/acpi/tcss.asl: https://review.coreboot.org/c/coreboot/+/58798/comment/67d0f405_a7a17587 PS1, Line 136: #if CONFIG(CHROMEOS) > 23A0D13A-26AB-486C-9C5F-0FFA525A575A […] Done File src/soc/intel/tigerlake/acpi/tcss.asl: https://review.coreboot.org/c/coreboot/+/58798/comment/31d79905_dcd6e89e PS5, Line 157: #if CONFIG(CHROMEOS) > Can you add a comment here (similar to your commit msg) why this is done? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/58798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib947c3c9cd843e54d4664509c15336178c0bc99e Gerrit-Change-Number: 58798 Gerrit-PatchSet: 8 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 04 Nov 2021 15:11:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <admin(a)starlabs.systems> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tigerlake/apci: Only use SCM for ChromeOS
by Sean Rhodes (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Patrick Rudolph. Hello build bot (Jenkins), Tim Wawrzynczak, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58798 to look at the new patch set (#7). Change subject: tigerlake/apci: Only use SCM for ChromeOS ...................................................................... tigerlake/apci: Only use SCM for ChromeOS Software Connection Manager doesn't work with Linux 5.13 or later and results in TBT ports timing out. Not advertising this results in Firmware Connection Manager being used and TBT works correctly. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ib947c3c9cd843e54d4664509c15336178c0bc99e --- M src/soc/intel/tigerlake/acpi/tcss.asl 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/58798/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/58798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib947c3c9cd843e54d4664509c15336178c0bc99e Gerrit-Change-Number: 58798 Gerrit-PatchSet: 7 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: tests: Move x86 I/O functions to include/mock/arch/io.h
by Felix Held (Code Review) 04 Nov '21

04 Nov '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/58881 ) Change subject: tests: Move x86 I/O functions to include/mock/arch/io.h ...................................................................... tests: Move x86 I/O functions to include/mock/arch/io.h Move th x86 I/O functions declarations from tests mocks to the mock architecture io.h. This will make x86 I/O-dependent tests simpler, because the x86_io.h from mocks will not have to be included manually. Change-Id: Ie7f06c992be306d2523f2079bc90adf114b93946 Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/58881 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> --- M payloads/libpayload/include/mock/arch/io.h M payloads/libpayload/tests/drivers/Makefile.inc M payloads/libpayload/tests/drivers/speaker-test.c D payloads/libpayload/tests/include/mocks/x86_io.h 4 files changed, 17 insertions(+), 32 deletions(-) Approvals: build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved diff --git a/payloads/libpayload/include/mock/arch/io.h b/payloads/libpayload/include/mock/arch/io.h index 2bb6255..08c992f 100644 --- a/payloads/libpayload/include/mock/arch/io.h +++ b/payloads/libpayload/include/mock/arch/io.h @@ -26,4 +26,21 @@ void write32(volatile void *addr, uint32_t val); void write64(volatile void *addr, uint64_t val); +/* x86 I/O functions */ +unsigned int inl(int port); +unsigned short inw(int port); +unsigned char inb(int port); + +void outl(unsigned int val, int port); +void outw(unsigned short val, int port); +void outb(unsigned char val, int port); + +void outsl(int port, const void *addr, unsigned long count); +void outsw(int port, const void *addr, unsigned long count); +void outsb(int port, const void *addr, unsigned long count); + +void insl(int port, void *addr, unsigned long count); +void insw(int port, void *addr, unsigned long count); +void insb(int port, void *addr, unsigned long count); + #endif /* _ARCH_IO_H */ diff --git a/payloads/libpayload/tests/drivers/Makefile.inc b/payloads/libpayload/tests/drivers/Makefile.inc index e39921a..7705473 100644 --- a/payloads/libpayload/tests/drivers/Makefile.inc +++ b/payloads/libpayload/tests/drivers/Makefile.inc @@ -6,4 +6,3 @@ speaker-test-mocks += inb speaker-test-mocks += outb speaker-test-mocks += arch_ndelay -speaker-test-cflags += -include $(testsrc)/include/mocks/x86_io.h diff --git a/payloads/libpayload/tests/drivers/speaker-test.c b/payloads/libpayload/tests/drivers/speaker-test.c index 199fa58..a677fa4 100644 --- a/payloads/libpayload/tests/drivers/speaker-test.c +++ b/payloads/libpayload/tests/drivers/speaker-test.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <libpayload.h> -#include <mocks/x86_io.h> /* Include source to gain access to private defines */ #include "../drivers/speaker.c" diff --git a/payloads/libpayload/tests/include/mocks/x86_io.h b/payloads/libpayload/tests/include/mocks/x86_io.h deleted file mode 100644 index c35a572..0000000 --- a/payloads/libpayload/tests/include/mocks/x86_io.h +++ /dev/null @@ -1,30 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#ifndef TESTS_MOCKS_X86_IO_H_ -#define TESTS_MOCKS_X86_IO_H_ - -unsigned int inl(int port); - -unsigned short inw(int port); - -unsigned char inb(int port); - -void outl(unsigned int val, int port); - -void outw(unsigned short val, int port); - -void outb(unsigned char val, int port); - -void outsl(int port, const void *addr, unsigned long count); - -void outsw(int port, const void *addr, unsigned long count); - -void outsb(int port, const void *addr, unsigned long count); - -void insl(int port, void *addr, unsigned long count); - -void insw(int port, void *addr, unsigned long count); - -void insb(int port, void *addr, unsigned long count); - -#endif -- To view, visit https://review.coreboot.org/c/coreboot/+/58881 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie7f06c992be306d2523f2079bc90adf114b93946 Gerrit-Change-Number: 58881 Gerrit-PatchSet: 2 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: tigerlake/apci: Only use SCM for ChromeOS
by Sean Rhodes (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Sean Rhodes, Patrick Rudolph. Hello build bot (Jenkins), Tim Wawrzynczak, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58798 to look at the new patch set (#6). Change subject: tigerlake/apci: Only use SCM for ChromeOS ...................................................................... tigerlake/apci: Only use SCM for ChromeOS Software Connection Manager doesn't work with Linux 5.13 or later and results in TBT ports timing out. Not advertising this results in Firmware Connection Manager being used and TBT works correctly. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ib947c3c9cd843e54d4664509c15336178c0bc99e --- M src/soc/intel/tigerlake/acpi/tcss.asl 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/58798/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/58798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib947c3c9cd843e54d4664509c15336178c0bc99e Gerrit-Change-Number: 58798 Gerrit-PatchSet: 6 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: tigerlake/apci: Only use SCM for ChromeOS
by Tim Wawrzynczak (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Sean Rhodes, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58798 ) Change subject: tigerlake/apci: Only use SCM for ChromeOS ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/58798/comment/18d8604a_a20c27b9 PS5, Line 9: SCM doesn't work with Linux 5.13 or later and results in TBT : ports timing out. Not advertising this results in FCM being used : and TBT works correctly. Not sure if everyone knows what SCM/FCM mean, maybe spell them out once? -- To view, visit https://review.coreboot.org/c/coreboot/+/58798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib947c3c9cd843e54d4664509c15336178c0bc99e Gerrit-Change-Number: 58798 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 04 Nov 2021 15:05:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tigerlake/apci: Only use SCM for ChromeOS
by Tim Wawrzynczak (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Sean Rhodes, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58798 ) Change subject: tigerlake/apci: Only use SCM for ChromeOS ...................................................................... Patch Set 5: Code-Review+1 (2 comments) Patchset: PS5: Nice digging Sean! File src/soc/intel/tigerlake/acpi/tcss.asl: https://review.coreboot.org/c/coreboot/+/58798/comment/d77e6f9f_bf12bd7c PS5, Line 157: #if CONFIG(CHROMEOS) Can you add a comment here (similar to your commit msg) why this is done? -- To view, visit https://review.coreboot.org/c/coreboot/+/58798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib947c3c9cd843e54d4664509c15336178c0bc99e Gerrit-Change-Number: 58798 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 04 Nov 2021 15:05:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: google/guybrush: Move SPI speed override
by Felix Held (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Raul Rangel, Kyösti Mälkki, Karthik Ramasubramanian. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58945 ) Change subject: google/guybrush: Move SPI speed override ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: moving the spi speed override out of chromeos.c sounds good to me. i'd do the removal of the $(CONFIG_CHROMEOS) guard in a separate patch, since that's not directly related to moving out the spi speed override. if you want to keep it as one patch, please mention the additional change in the commit message though. Maybe Raul and Karthik have an opinion on this -- To view, visit https://review.coreboot.org/c/coreboot/+/58945 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie3db89f252af1f44e9539497c05bdf965565a191 Gerrit-Change-Number: 58945 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 04 Nov 2021 15:02:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021