coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: mb/google/brya/variants/primus: enable ALC5682I-VS
by Malik Hsu (Code Review) 11 Nov '21

11 Nov '21

Attention is currently required from: Tim Wawrzynczak. Hello Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59173 to look at the new patch set (#2). Change subject: mb/google/brya/variants/primus: enable ALC5682I-VS ...................................................................... mb/google/brya/variants/primus: enable ALC5682I-VS In next phase build, the audio codec will chang to ALC5682I-VS BUG=b:205883511 TEST=emerge-brya coreboot chromeos-bootimage and check audio function Signed-off-by: Malik_Hsu <malik_hsu(a)wistron.corp-partner.google.com> Change-Id: I5906ef9bb88da7fe450a986bf7dd1ee701227f95 --- M src/mainboard/google/brya/variants/primus/variant.c 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/59173/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59173 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5906ef9bb88da7fe450a986bf7dd1ee701227f95 Gerrit-Change-Number: 59173 Gerrit-PatchSet: 2 Gerrit-Owner: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/variants/primus: enable ALC5682I-VS
by build bot (Jenkins) (Code Review) 11 Nov '21

11 Nov '21

Attention is currently required from: Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59173 ) Change subject: mb/google/brya/variants/primus: enable ALC5682I-VS ...................................................................... Patch Set 1: (2 comments) File src/mainboard/google/brya/variants/primus/variant.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132938): https://review.coreboot.org/c/coreboot/+/59173/comment/420eade6_f40c71fb PS1, Line 48: alc_dev=child; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132938): https://review.coreboot.org/c/coreboot/+/59173/comment/a5f5cf70_7a5c24a4 PS1, Line 52: alc_dev->enabled=1; spaces required around that '=' (ctx:VxV) -- To view, visit https://review.coreboot.org/c/coreboot/+/59173 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5906ef9bb88da7fe450a986bf7dd1ee701227f95 Gerrit-Change-Number: 59173 Gerrit-PatchSet: 1 Gerrit-Owner: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Thu, 11 Nov 2021 04:01:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/variants/primus: enable ALC5682I-VS
by Malik Hsu (Code Review) 11 Nov '21

11 Nov '21

Malik Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59173 ) Change subject: mb/google/brya/variants/primus: enable ALC5682I-VS ...................................................................... mb/google/brya/variants/primus: enable ALC5682I-VS In next phase build, the audio codec will chang to ALC5682I-VS BUB=b:205883511 TEST=emerge-brya coreboot chromeos-bootimage and check audio function Signed-off-by: Malik_Hsu <malik_hsu(a)wistron.corp-partner.google.com> Change-Id: I5906ef9bb88da7fe450a986bf7dd1ee701227f95 --- M src/mainboard/google/brya/variants/primus/variant.c 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/59173/1 diff --git a/src/mainboard/google/brya/variants/primus/variant.c b/src/mainboard/google/brya/variants/primus/variant.c index 82521b0..bebe001 100644 --- a/src/mainboard/google/brya/variants/primus/variant.c +++ b/src/mainboard/google/brya/variants/primus/variant.c @@ -5,8 +5,11 @@ #include <boardid.h> #include <soc/pci_devs.h> #include <device/device.h> +#include <string.h> +#include <drivers/i2c/hid/chip.h> extern struct chip_operations soc_intel_common_block_pcie_rtd3_ops; +extern struct chip_operations drivers_i2c_generic_ops; static void devtree_update_emmc_rtd3(uint32_t board_ver) { @@ -27,8 +30,31 @@ rtd3_dev->enabled = 0; } +static void devtree_update_audio_codec(void) +{ + struct device *alc_dev = NULL, *child = NULL; + struct device *i2c0_dev = pcidev_path_on_root(PCH_DEVFN_I2C0); + + while ((child = dev_bus_each_child(i2c0_dev->link_list, child)) != NULL) { + if (child->path.type != DEVICE_PATH_I2C) + continue; + if (child->path.i2c.device != 0x1a) + continue; + if (child->chip_ops == &drivers_i2c_generic_ops) { + struct drivers_i2c_generic_config *config = child->chip_info; + if (!strcmp(config->hid, "10EC5682")) { + config->hid = "RTL5682"; + config->name = "RT58"; + alc_dev=child; + } + } + } + alc_dev->enabled=1; +} + void variant_devtree_update(void) { uint32_t board_ver = board_id(); devtree_update_emmc_rtd3(board_ver); + devtree_update_audio_codec(board_ver); } -- To view, visit https://review.coreboot.org/c/coreboot/+/59173 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5906ef9bb88da7fe450a986bf7dd1ee701227f95 Gerrit-Change-Number: 59173 Gerrit-PatchSet: 1 Gerrit-Owner: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/brya/variants/gimble: Update PL1 min value
by Sumeet R Pawnikar (Code Review) 11 Nov '21

11 Nov '21

Attention is currently required from: Furquan Shaikh, Nick Vaccaro, Scott Chao, Karthik Ramasubramanian. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58650 ) Change subject: mb/google/brya/variants/gimble: Update PL1 min value ...................................................................... Patch Set 1: -Code-Review (1 comment) Patchset: PS1: As per latest comment#19 on bug, we need this CL reviewed by Wistron team as well. -- To view, visit https://review.coreboot.org/c/coreboot/+/58650 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id66cfb6f6dc0217bd4d83eae1d66ad867a1bdb46 Gerrit-Change-Number: 58650 Gerrit-PatchSet: 1 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Baieswara Reddy Sagili <baieswara.reddy.sagili(a)intel.com> Gerrit-CC: Kedar J. Karanje <kedar.j.karanje(a)intel.com> Gerrit-CC: Vinay Kumar <vinay.kumar(a)intel.com> Gerrit-CC: neha1.kumari(a)intel.com Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 11 Nov 2021 04:00:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/net/r8168: Add support for Realtek RT8125
by Alan Huang (Code Review) 11 Nov '21

11 Nov '21

Attention is currently required from: David Wu, Tim Wawrzynczak, Alan Huang. Hello build bot (Jenkins), David Wu, Tim Wawrzynczak, Zhuohao Lee, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59086 to look at the new patch set (#5). Change subject: drivers/net/r8168: Add support for Realtek RT8125 ...................................................................... drivers/net/r8168: Add support for Realtek RT8125 The Realtek RT8168 and RT8125 have a similar programming interface, therefore add the PCI device ID for the RT8125 into driver for support. BUG=b:193750191 TEST=emerge-brask coreboot chromeos-bootimage Signed-off-by: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Change-Id: Iaa4c41f94fd6e5fd6393abbb30bfc22a149f5d71 --- M src/drivers/net/r8168.c M src/include/device/pci_ids.h 2 files changed, 11 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/59086/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/59086 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa4c41f94fd6e5fd6393abbb30bfc22a149f5d71 Gerrit-Change-Number: 59086 Gerrit-PatchSet: 5 Gerrit-Owner: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/mediatek/mt8195: Add APU device apc driver
by Yu-Ping Wu (Code Review) 11 Nov '21

11 Nov '21

Attention is currently required from: Hung-Te Lin, Paul Menzel, flora.fu(a)mediatek.com. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58969 ) Change subject: soc/mediatek/mt8195: Add APU device apc driver ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58969 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If92d3b02ac4966332315b85d68e0f48c6a9fce85 Gerrit-Change-Number: 58969 Gerrit-PatchSet: 9 Gerrit-Owner: flora.fu(a)mediatek.com <flora.fu(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: flora.fu(a)mediatek.com <flora.fu(a)mediatek.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: flora.fu(a)mediatek.com <flora.fu(a)mediatek.com> Gerrit-Comment-Date: Thu, 11 Nov 2021 03:45:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: utils: Add initial version of "remove_unused_code" script
by Martin Roth (Code Review) 11 Nov '21

11 Nov '21

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59169 ) Change subject: utils: Add initial version of "remove_unused_code" script ...................................................................... utils: Add initial version of "remove_unused_code" script This script creates a patch to remove all of the coreboot code that a platform doesn't use. This is useful for auditing the codebase for an individual platform or releasing a platform's code. Unlike the script that Sage used that did something similar, this keeps the entire Kconfig tree (Though in a single file), all makefiles that are required to build, and the standard build tools can still be used. This will allow for much easier re-integration back into the coreboot codebase if code is released after running this. This is just the initial version and more features needed to be added to make it fully functional. - It should be able to build multiple configurations to retain the code for all of those configurations. - Flag to remove submodules files as well - Additional variable flags to replace hardcoded values. - The list of makefiles that need to be kept is pretty long, and could be updated so that they aren't needed by the top level makefiles. - Add flag to show changed files - Show number of files before and after script is run Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Iec69db2ad1358846d649db627b6d60ac8c2204e4 --- M util/scripts/description.md A util/scripts/rm_unused_code 2 files changed, 295 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/59169/1 diff --git a/util/scripts/description.md b/util/scripts/description.md index a08771d..d028323 100644 --- a/util/scripts/description.md +++ b/util/scripts/description.md @@ -23,5 +23,7 @@ headers `Shell` * _parse-maintainers.pl_ - Script to alphabetize MAINTAINERS file `Perl` + * _rm_unused_code_ - Remove all code not used for a platform from the local + git repository for auditing or release `Bash` * _ucode_h_to_bin.sh_ - Microcode conversion tool `Bash` * _update_submodules_ - Check all submodules for updates `Bash` diff --git a/util/scripts/rm_unused_code b/util/scripts/rm_unused_code new file mode 100755 index 0000000..7c06959 --- /dev/null +++ b/util/scripts/rm_unused_code @@ -0,0 +1,293 @@ +#!/bin/bash +set -e + +VERSION="1.00" + +PROGRAM=$0 +PROGNAME="$(basename "${PROGRAM}")" + +MODIFIED_FILES= +CLEAN_DIR_LIST="configs Documentation payloads spd src util" +KEEP_FILES='util/kconfig/' +REQUIRED_MAKEFILES="util/testing\|util/crossgcc\|payloads/coreinfo\|payloads/nvramcui\|payloads/libpayload\|payloads/external/tint\|util/amdfwtool\|util/ectool\|util/futility\|util/intelmetool\|util/inteltool\|util/intelvbttool\|til/post\|util/superiotool" +VERBOSE= +# Text STYLE variables +BOLD="\033[1m" +RED='\033[38;5;9m' +GREEN='\033[38;5;2m' +ORANGERED="\033[38;5;202m" +NO_COLOR='\033[0m' + +################################################################################ + +usage() { + echo "Usage: ${PROGNAME} [options]" + echo + echo "Options:" + echo ' -b | --blddir <dir> Set /tmp/<dir> as the build directory' + echo " -h | --help Print usage and exit" + echo " -D | --debug Print debug information. Use -DD to show all commands" + echo " -V | --version Print the version and exit" + echo " --nocolor Don't print color codes" + echo +} + +show_version() { + echo + _echo_color "${BOLD}${GREEN}" "${PROGNAME} version ${VERSION}" 1 + echo +} + +_echo_color() { + if [ "${3}" = "0" ]; then + printf "${1}%s${NO_COLOR}" "${2}" + else + printf "${1}%s${NO_COLOR}\n" "${2}" + fi +} + +_echo_debug() { + test -n "${VERBOSE}" && + printf "${ORANGERED}%s${NO_COLOR}\n" "${2}" >&2 +} + +_echo_error() { + (_echo_color >&2 "${RED}" "$*" 1) +} + +get_args() { + args=$(getopt -l version,help,debug,nocolor,blddir: -o b:DhV -- "$@") + getopt_ret=$? + eval set -- "${args}" + + if [ ${getopt_ret} != 0 ]; then + usage + exit 1 + fi + + while true; do + case "$1" in + -b | --blddir) + shift + BLD_DIR="/tmp/$1" + ;; + -D | --debug) + shift + # -d prints extra debug info + # -dd prints all script steps + if [ -n "${VERBOSE}" ]; then + set -x + else + VERBOSE="V=1" + fi + ;; + -h | --help) + shift + usage + exit 0 + ;; + --nocolor) + shift + BOLD="" + RED="" + GREEN="" + ORANGERED="" + NO_COLOR="" + ;; + -V | --version) exit 0 ;; + --) + shift + break + ;; + *) break ;; + esac + done + + BLD_DIR="${BLD_DIR:-$(mktemp -d)}" +} + +recursively_rm_dir_onlyfile() { + local dir=$1 + local beforecount + local aftercount + + while true; do + if [[ ! -d ${dir} ]]; then + break + fi + beforecount="$(find "${dir}" | wc -l)" + # shellcheck disable=SC2016 + find "${dir}" -depth -type d -exec /bin/bash -c \ + 'if echo "$1" | grep -q "$2"; then exit; fi && + if [[ "$(cd "$1" && find . -maxdepth 1 | grep -v "./Makefile")" = "." ]]; then + rm -rf "$1"; fi' shell {} \ + ${REQUIRED_MAKEFILES} \; + if [[ ! -d ${dir} ]]; then + break + fi + find "${dir}" -type d -empty -delete + if [[ ! -d ${dir} ]]; then + break + fi + aftercount="$(find "${dir}" | wc -l)" + if [[ ${aftercount} -eq ${beforecount} ]]; then + break + fi + done +} + +verify_atime_enabled() { + local testfile + # Make sure the build directory is mounted correctly + if [ ! -d "${BLD_DIR}" ]; then + mkdir "${BLD_DIR}" + fi + if ! grep -q "${BLD_DIR}" /proc/mounts; then + echo "Mounting the ${BLD_DIR} directory with atime enabled" + sudo mount -t tmpfs -o rw,relatime tmpfs "${BLD_DIR}" + elif ! grep "${BLD_DIR}" /proc/mounts | grep -q relatime; then + echo "Remounting the ${BLD_DIR} directory with relatime enabled" + sudo mount -o remount,relatime "${BLD_DIR}" + fi + + testfile="$(mktemp -p "${BLD_DIR}")" + touch -a --date="2020-01-01 00:00:00" "${testfile}" + if ! stat "${testfile}" | grep -q "Access: 2020-01-01"; then + _echo_error "Error: could not set access time." + sudo umount "${BLD_DIR}" + rm -rf "${BLD_DIR}" + exit 1 + fi + rm -f "${testfile}" +} + +update_codebase() { + local tempconfig + tempconfig="$(mktemp)" + if [ ! -f "${BLD_DIR}/COPYING" ]; then + echo "Downloading coreboot tree" + git clone https://review.coreboot.org/coreboot.git "${BLD_DIR}" + make -C "${BLD_DIR}" build/xcompile + fi + + # Start from a completely clean tree or we'll miss anything that + # doesn't need to be rebuilt. Save the config if it exists. + if [[ -f .config ]]; then + mv .config "${tempconfig}" + fi + _echo_color "${GREEN}" "Cleaning coreboot tree" + make -s -C "${BLD_DIR}" distclean + if [[ -f ${tempconfig} ]]; then + mv "${tempconfig}" .config + fi + + # force a refresh of all submodules + _echo_color "${GREEN}" "Refreshing all submodules..." + git submodule update --recursive --remote --init --checkout +} + +save_kconfig() { + (cd "${BLD_DIR}" && util/lint/kconfig_lint -w -p -o kconfig.tmp) +} + +update_times() { + _echo_color "${GREEN}" "Updating access time of all files" + git ls-files | xargs touch -a -m -t 202001010000 + # find "${BLD_DIR}" -type f -exec touch -a --date="2020-01-01 00:00:00" {} \; + if ! stat "${BLD_DIR}/COPYING" | grep -q "Access: 2020-01-01"; then + _echo_error "Error: could not set access time." + _echo_error " One of the following processes may be accessing it." + fuser -uvm "${BLD_DIR}/COPYING" + exit 1 + fi +} +mark_files_to_keep() { + for file in ${KEEP_FILES}; do + find "${BLD_DIR}/${file}" -depth -exec touch {} \; + done +} + +build_platform() { + local extra_text=$1 + _echo_color "${GREEN}" "Building platform ${extra_text}" + if [[ ! -f "${BLD_DIR}/.config" ]]; then + if [[ -n ${CONFIG_FILE} ]]; then + cp "${CONFIG_FILE}" "${BLD_DIR}/.config" || exit 1 + fi + echo "CONFIG_PAYLOAD_NONE=y" >>"${BLD_DIR}/.config" + fi + + make -C "${BLD_DIR}" -s clean UPDATED_SUBMODULES=1 BUILD_TIMELESS=1 + make -C "${BLD_DIR}" -s olddefconfig || exit 1 + make -C "${BLD_DIR}" -s UPDATED_SUBMODULES=1 BUILD_TIMELESS=1 ${VERBOSE} + HASH="$(sha256sum build/coreboot.rom)" + make -C "${BLD_DIR}" -s clean UPDATED_SUBMODULES=1 BUILD_TIMELESS=1 +} + +show_modified() { + MODIFIED_FILES=$(find "${BLD_DIR}" -atime -1 -type f | grep -v '.git') + echo "Files changed: $(echo "${MODIFIED_FILES}" | wc -l)" +} + +remove_kconfigs() { + # Dump all Kconfigs into a single file so that directories + # can be removed, while maintaining the entire Kconfig + # structure. + find "${BLD_DIR}/src" -name 'Kconfig*' -exec rm {} \; + mv "${BLD_DIR}/kconfig.tmp" "${BLD_DIR}/src/Kconfig" +} + +remove_unused() { + local dir + # Most files can be removed simply by looking at the time, but + # all Kconfig and Makefile.inc files in the entire tree are accessed + # whether they're used or not. + remove_kconfigs + + echo + _echo_color "${GREEN}" "Checking access time and removing unused files in:" + for dir in ${CLEAN_DIR_LIST}; do + printf "%s\n" "${BLD_DIR}/${dir}" + # find and remove all files without updated times. + find "${BLD_DIR}/${dir}" -atime +5 -type f -exec rm {} \; + + recursively_rm_dir_onlyfile "${BLD_DIR}/${dir}" + done + printf "\n\n" +} + +create_patch() { + _echo_color "${GREEN}" "Creating patch" + ( + cd "${BLD_DIR}" || exit 1 + git add -A + git commit -m "remove unused files" --no-verify && + git format-patch HEAD^ + ) +} + +main() { + show_version + get_args "$@" + + verify_atime_enabled + update_codebase + save_kconfig + update_times + mark_files_to_keep + build_platform "to mark used files" + OLDHASH=${HASH} + HASH="" + #show_modified + remove_unused + create_patch + build_platform "to verify the build still works" + NEWHASH=${HASH} + + echo + _echo_color "${GREEN}" "Checksums:" + echo "Old: ${OLDHASH}" + echo "New: ${NEWHASH}" +} + +main "$@" -- To view, visit https://review.coreboot.org/c/coreboot/+/59169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iec69db2ad1358846d649db627b6d60ac8c2204e4 Gerrit-Change-Number: 59169 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/net/r8168: Add support for Realtek RT8125
by Zhuohao Lee (Code Review) 11 Nov '21

11 Nov '21

Attention is currently required from: David Wu, Tim Wawrzynczak, Alan Huang. Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59086 ) Change subject: drivers/net/r8168: Add support for Realtek RT8125 ...................................................................... Patch Set 4: (1 comment) File src/drivers/net/r8168.c: https://review.coreboot.org/c/coreboot/+/59086/comment/4d35773c_71010b3c PS4, Line 255: /* : * Refer to RTL8111H datasheet 7.2 Customizable LED Configuration : * Starting from offset 0x18 : * Bit[15:12] LED Feature Control(FC) : * Bit[11:08] LED Select for PINLED2 : * Bit[07:04] LED Select for PINLED1 : * Bit[03:00] LED Select for PINLED0 : * : * Speed Link10M Link100M Link1000M ACT/Full : * LED0 Bit0 Bit1 Bit2 Bit3 : * LED1 Bit4 Bit5 Bit6 Bit7 : * LED2 Bit8 Bit9 Bit10 Bit11 : * FC Bit12 Bit13 Bit14 Bit15 : */ : : /* Set customized LED registers */ : outw(config->customized_leds, io_base + CMD_LED0_LED1); This is incorrect for the 8125. Could you please modify this according to the different pci_device_ids? -- To view, visit https://review.coreboot.org/c/coreboot/+/59086 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa4c41f94fd6e5fd6393abbb30bfc22a149f5d71 Gerrit-Change-Number: 59086 Gerrit-PatchSet: 4 Gerrit-Owner: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 11 Nov 2021 03:19:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/brask: disabled autonomous GPIO power management
by David Wu (Code Review) 11 Nov '21

11 Nov '21

David Wu has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/58793 ) Change subject: mb/google/brya/var/brask: disabled autonomous GPIO power management ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/58793 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id9fab5f7d3be74f855e8116ec8f0f24ecc05e0b0 Gerrit-Change-Number: 58793 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: ChiJen Chen <chi-jen.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: mb/google/brya/variants/primus: enable RTD3 for PCIe-eMMC bridge
by Zhuohao Lee (Code Review) 11 Nov '21

11 Nov '21

Attention is currently required from: Malik Hsu, Tim Wawrzynczak. Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59135 ) Change subject: mb/google/brya/variants/primus: enable RTD3 for PCIe-eMMC bridge ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/brya/variants/primus/variant.c: https://review.coreboot.org/c/coreboot/+/59135/comment/ab093da1_410e4004 PS3, Line 33: uint32_t board_ver = board_id(); > There is another function that also uses board_ver, so it will keep, thanks。 Sorry, I can't catch the meaning. Which is function you mean here? I only see only function, ie: devtree_update_emmc_rtd3 -- To view, visit https://review.coreboot.org/c/coreboot/+/59135 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5836d65cedfe3907af2c4c33de7a396c4bb8b727 Gerrit-Change-Number: 59135 Gerrit-PatchSet: 4 Gerrit-Owner: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Attention: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Thu, 11 Nov 2021 03:15:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Comment-In-Reply-To: Zhuohao Lee <zhuohao(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021