coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: mb/google/corsola: add configuration for kingler and krabby
by Yu-Ping Wu (Code Review) 12 Nov '21

12 Nov '21

Attention is currently required from: Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59249 ) Change subject: mb/google/corsola: add configuration for kingler and krabby ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59249 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf9c6af1a395030937a9a5c00e95d7246ddcb6eb Gerrit-Change-Number: 59249 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Fri, 12 Nov 2021 08:37:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8186: Enable mmu operation for L2C SRAM and DMA
by Yu-Ping Wu (Code Review) 12 Nov '21

12 Nov '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59247 ) Change subject: soc/mediatek/mt8186: Enable mmu operation for L2C SRAM and DMA ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59247 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If56d29cdd7d9dfaed05e129754aa1f887a581482 Gerrit-Change-Number: 59247 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Fri, 12 Nov 2021 08:36:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek: move functions of mmu operation to common folder
by Yu-Ping Wu (Code Review) 12 Nov '21

12 Nov '21

Attention is currently required from: Hung-Te Lin, Xi Chen, Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59246 ) Change subject: soc/mediatek: move functions of mmu operation to common folder ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f49214b932a8d28ed2ca0d764dc745fa8ad330d Gerrit-Change-Number: 59246 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Fri, 12 Nov 2021 08:35:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8186: Add support for PMIC MT6366
by Yu-Ping Wu (Code Review) 12 Nov '21

12 Nov '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59245 ) Change subject: soc/mediatek/mt8186: Add support for PMIC MT6366 ...................................................................... Patch Set 1: (3 comments) File src/soc/mediatek/mt8186/mt6366.c: https://review.coreboot.org/c/coreboot/+/59245/comment/6beaf1ff_61d22643 PS1, Line 174: };; > Statements terminations use 1 semicolon Please fix. https://review.coreboot.org/c/coreboot/+/59245/comment/b7d3dd1b_7c25970e PS1, Line 606: printk(BIOS_WARNING, "%s: ID = %#x \n", __func__, > unnecessary whitespace before a quoted newline Please fix. File src/soc/mediatek/mt8186/pmic_wrap.c: https://review.coreboot.org/c/coreboot/+/59245/comment/6bea412f_6466f7c5 PS1, Line 63: write32(&mt8186_infracfg_ao->module_sw_cg_0_set, 0x0000000f); > please, no space before tabs Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/59245 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22e30421560a32f4a9e15899e8150376b1414494 Gerrit-Change-Number: 59245 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Fri, 12 Nov 2021 08:34:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek: change help text of FLASH_DUAL_READ
by Yu-Ping Wu (Code Review) 12 Nov '21

12 Nov '21

Attention is currently required from: Hung-Te Lin, Xi Chen, Rex-BC Chen, Felix Held. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59244 ) Change subject: soc/mediatek: change help text of FLASH_DUAL_READ ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59244 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54b81cdeba3b693451f66e003fb470c9f8c19ad9 Gerrit-Change-Number: 59244 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 12 Nov 2021 08:32:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Disable VT-d for early silicons
by Felix Singer (Code Review) 12 Nov '21

12 Nov '21

Attention is currently required from: Abhijeet Rao, Maulik V Vaghela, Tim Wawrzynczak, Meera Ravindranath, Patrick Rudolph. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59191 ) Change subject: soc/intel/alderlake: Disable VT-d for early silicons ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/soc/intel/alderlake/romstage/fsp_params.c: https://review.coreboot.org/c/coreboot/+/59191/comment/ddb8766c_2a73cff5 PS5, Line 263: const uint32_t cpuid = cpu_get_cpuid(); I would add a comment here that Vt-D is broken on these models and that it results in a CPU hang if enabled. -- To view, visit https://review.coreboot.org/c/coreboot/+/59191 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0b9b76b6527d8b80777cb7588ce6b12282af7882 Gerrit-Change-Number: 59191 Gerrit-PatchSet: 5 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Abhijeet Rao <abhijeet.rao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Abhijeet Rao <abhijeet.rao(a)intel.corp-partner.google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 12 Nov 2021 08:28:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload/tests: Add libcbfs/cbfs_core-test test case
by Yu-Ping Wu (Code Review) 12 Nov '21

12 Nov '21

Attention is currently required from: Jakub Czapiga, Paul Fagerburg, Julius Werner, Jan Dabros. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58327 ) Change subject: libpayload/tests: Add libcbfs/cbfs_core-test test case ...................................................................... Patch Set 2: (6 comments) Patchset: PS2: Partial review for get_cbfs_header(). File payloads/libpayload/tests/libcbfs/cbfs_core-test.c: https://review.coreboot.org/c/coreboot/+/58327/comment/fdd1bb60_850e6f39 PS2, Line 208: htobe32 We're using ntohl() in the code, so htonl() would be more consistent here (although they are the same thing 😊). https://review.coreboot.org/c/coreboot/+/58327/comment/43005107_d5dd419e PS2, Line 209: 0xFFFFFFFF Use UINT32_MAX? https://review.coreboot.org/c/coreboot/+/58327/comment/dcfafda7_79298cd3 PS2, Line 332: It took me a while to understand how cbfs_get_handle_test_state is initialized. How about adding a short comment explaining that? /* Convert cbfs_get_handle_test_prestate to cbfs_get_handle_test_state. */ https://review.coreboot.org/c/coreboot/+/58327/comment/2e168e69_5b1bd0e3 PS2, Line 367: LP_ARCH_X86 Should we return error instead of silently ignoring use_aligned_bootblocksize for non-x86 platforms? https://review.coreboot.org/c/coreboot/+/58327/comment/8d24d833_bb7e1163 PS2, Line 966: NULL This is the same as CBFS_DEFAULT_MEDIA, so the line test_media = &local_media will never run. -- To view, visit https://review.coreboot.org/c/coreboot/+/58327 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib246a891242f5a514f2f142699800eeb407de4f9 Gerrit-Change-Number: 58327 Gerrit-PatchSet: 2 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-Comment-Date: Fri, 12 Nov 2021 08:25:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/tigerlake: Add config option for S3 ACPI
by Sean Rhodes (Code Review) 12 Nov '21

12 Nov '21

Attention is currently required from: Tim Crawford, Tim Wawrzynczak, Patrick Rudolph. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59024 ) Change subject: soc/intel/tigerlake: Add config option for S3 ACPI ...................................................................... Patch Set 18: (1 comment) File src/soc/intel/tigerlake/acpi/tcss_pcierp.asl: https://review.coreboot.org/c/coreboot/+/59024/comment/9d8eab84_3e8097ac PS17, Line 282: } Else { > one more tab here Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb1cc3d6a03cb452ff38ae393a993e881d9b5ff4 Gerrit-Change-Number: 59024 Gerrit-PatchSet: 18 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 12 Nov 2021 08:04:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8186: Add support for PMIC MT6366
by build bot (Jenkins) (Code Review) 12 Nov '21

12 Nov '21

Attention is currently required from: Hung-Te Lin. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59245 ) Change subject: soc/mediatek/mt8186: Add support for PMIC MT6366 ...................................................................... Patch Set 1: (7 comments) File src/soc/mediatek/mt8186/mt6366.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133099): https://review.coreboot.org/c/coreboot/+/59245/comment/84aeba0d_3c6fa010 PS1, Line 174: };; Statements terminations use 1 semicolon Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133099): https://review.coreboot.org/c/coreboot/+/59245/comment/728a3665_5b1dce6f PS1, Line 606: printk(BIOS_WARNING, "%s: ID = %#x \n", __func__, unnecessary whitespace before a quoted newline Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133099): https://review.coreboot.org/c/coreboot/+/59245/comment/7b0225c6_d56be240 PS1, Line 647: BUG(); Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133099): https://review.coreboot.org/c/coreboot/+/59245/comment/1b5c5df8_68f06713 PS1, Line 707: while (!stopwatch_expired(&voltage_settled)) suspect code indent for conditional statements (8, 49) File src/soc/mediatek/mt8186/pmic_wrap.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133099): https://review.coreboot.org/c/coreboot/+/59245/comment/b03713cf_fe3d0d1f PS1, Line 63: write32(&mt8186_infracfg_ao->module_sw_cg_0_set, 0x0000000f); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133099): https://review.coreboot.org/c/coreboot/+/59245/comment/45b5958f_24d7c1c7 PS1, Line 63: write32(&mt8186_infracfg_ao->module_sw_cg_0_set, 0x0000000f); please, no space before tabs Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133099): https://review.coreboot.org/c/coreboot/+/59245/comment/d953790c_9b2b17d9 PS1, Line 63: write32(&mt8186_infracfg_ao->module_sw_cg_0_set, 0x0000000f); please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/59245 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22e30421560a32f4a9e15899e8150376b1414494 Gerrit-Change-Number: 59245 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Comment-Date: Fri, 12 Nov 2021 07:59:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/corsola: Add VMCH and VMC for regulator interface
by Rex-BC Chen (Code Review) 12 Nov '21

12 Nov '21

Attention is currently required from: Hung-Te Lin. Rex-BC Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59255 ) Change subject: mb/google/corsola: Add VMCH and VMC for regulator interface ...................................................................... mb/google/corsola: Add VMCH and VMC for regulator interface Add VMCH and VMC for providing power of SDCard. TEST=build pass BUG=b:202871018 Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Change-Id: I50fc87415086eb22ff35d157dba38cfd7594cc40 --- M src/mainboard/google/corsola/regulator.c M src/soc/mediatek/common/include/soc/regulator.h 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/59255/1 diff --git a/src/mainboard/google/corsola/regulator.c b/src/mainboard/google/corsola/regulator.c index 1ddc52c..b1310af 100644 --- a/src/mainboard/google/corsola/regulator.c +++ b/src/mainboard/google/corsola/regulator.c @@ -16,6 +16,8 @@ [MTK_REGULATOR_VCC] = REGULATOR_NOT_SUPPORT, [MTK_REGULATOR_VCCQ] = REGULATOR_NOT_SUPPORT, [MTK_REGULATOR_VDRAM1] = MT6366_VDRAM1, + [MTK_REGULATOR_VMCH] = MT6366_VMCH, + [MTK_REGULATOR_VMC] = MT6366_VMC, }; _Static_assert(ARRAY_SIZE(regulator_id) == MTK_REGULATOR_NUM, "regulator_id size error"); diff --git a/src/soc/mediatek/common/include/soc/regulator.h b/src/soc/mediatek/common/include/soc/regulator.h index 08ce47f..a53d01c 100644 --- a/src/soc/mediatek/common/include/soc/regulator.h +++ b/src/soc/mediatek/common/include/soc/regulator.h @@ -14,6 +14,8 @@ MTK_REGULATOR_VCC, MTK_REGULATOR_VCCQ, MTK_REGULATOR_VDRAM1, + MTK_REGULATOR_VMCH, + MTK_REGULATOR_VMC, MTK_REGULATOR_NUM, }; -- To view, visit https://review.coreboot.org/c/coreboot/+/59255 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I50fc87415086eb22ff35d157dba38cfd7594cc40 Gerrit-Change-Number: 59255 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021