coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: libpayload/tests: Fix mocks __real_<func> symbol creation
by Julius Werner (Code Review) 19 Nov '21

19 Nov '21

Attention is currently required from: Jakub Czapiga. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59496 ) Change subject: libpayload/tests: Fix mocks __real_<func> symbol creation ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Weird how that crept in, wasn't this just copy&pasted from coreboot? -- To view, visit https://review.coreboot.org/c/coreboot/+/59496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I751109735b6c56824df9a560ae989bf062a0e9a6 Gerrit-Change-Number: 59496 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Comment-Date: Fri, 19 Nov 2021 21:40:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Add mock assert support for unit testing purposes
by Julius Werner (Code Review) 19 Nov '21

19 Nov '21

Attention is currently required from: Jakub Czapiga. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59495 ) Change subject: libpayload: Add mock assert support for unit testing purposes ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/59495/comment/e9260622_3374ab8a PS1, Line 10: passwd typo -- To view, visit https://review.coreboot.org/c/coreboot/+/59495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e4620400f27dbebc57c71bbf2bf9144ca65807f Gerrit-Change-Number: 59495 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Comment-Date: Fri, 19 Nov 2021 21:37:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Add mock assert support for unit testing purposes
by Julius Werner (Code Review) 19 Nov '21

19 Nov '21

Attention is currently required from: Jakub Czapiga. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59495 ) Change subject: libpayload: Add mock assert support for unit testing purposes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e4620400f27dbebc57c71bbf2bf9144ca65807f Gerrit-Change-Number: 59495 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Comment-Date: Fri, 19 Nov 2021 21:36:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/tpm: Add firmware-power-managed DSD property
by Rob Barnes (Code Review) 19 Nov '21

19 Nov '21

Attention is currently required from: Andrey Pronin, Paul Menzel, Christian Walter, Karthik Ramasubramanian. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59479 ) Change subject: drivers/tpm: Add firmware-power-managed DSD property ...................................................................... Patch Set 7: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/59479/comment/6b5f74d3_871e52c2 PS6, Line 19: Shutdown is triggered > Shutdown of what? TPM. Commit message updated. -- To view, visit https://review.coreboot.org/c/coreboot/+/59479 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia48ead856fc0c6e637a2e07a5ecc58423f599c5b Gerrit-Change-Number: 59479 Gerrit-PatchSet: 7 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Andrey Pronin <apronin(a)google.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andrey Pronin <apronin(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 19 Nov 2021 21:35:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload/libc/fmap: Use libpayload_boot_device_read for media access
by Julius Werner (Code Review) 19 Nov '21

19 Nov '21

Attention is currently required from: Jakub Czapiga. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59494 ) Change subject: libpayload/libc/fmap: Use libpayload_boot_device_read for media access ...................................................................... Patch Set 1: (2 comments) File payloads/libpayload/libc/fmap.c: https://review.coreboot.org/c/coreboot/+/59494/comment/6840659c_e20a26da PS1, Line 36: int fmap_region_by_name(const uint32_t fmap_offset, const char * const name, I don't think we want to keep this API, it's also kinda crufty. There's no point in having to pass fmap_offset in here manually, we already know that's in lib_sysinfo.fmap_offset, libpayload should just use that directly. Let's just treat this the same as libcbfs where we implement a wholly new API on the side and eventually just get rid of the old one. (Maybe call it fmap_locate_area() for consistency with coreboot?) File payloads/libpayload/tests/libc/fmap_region_by_name-test.c: https://review.coreboot.org/c/coreboot/+/59494/comment/88c1457e_c57a02c9 PS1, Line 44: SETUP_LIBPAYLOAD_BOOT_DEVICE_READ_MOCK(&test_fmap, fmap_offset, sizeof(test_fmap)); I feel like this test is a bit too white-boxy (i.e. it specifies behavior of the unit under test too narrowly... like that you get exactly two calls here). Maybe doing this with a mock that allows multiple reads and writes for any offset within the specified range would be cleaner? -- To view, visit https://review.coreboot.org/c/coreboot/+/59494 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idbf9016ce73aa58e17f3ee19920ab83dc6c25abb Gerrit-Change-Number: 59494 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Comment-Date: Fri, 19 Nov 2021 21:35:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/tpm: Add firmware-power-managed DSD property
by Rob Barnes (Code Review) 19 Nov '21

19 Nov '21

Attention is currently required from: Andrey Pronin, Christian Walter, Rob Barnes, Karthik Ramasubramanian. Hello build bot (Jenkins), Andrey Pronin, Raul Rangel, Christian Walter, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59479 to look at the new patch set (#7). Change subject: drivers/tpm: Add firmware-power-managed DSD property ...................................................................... drivers/tpm: Add firmware-power-managed DSD property Introduce firmware-power-managed DSD ACPI property for TPM devices. This property can be checked by the kernel TPM driver to override how the TPM power states are managed. This is a tri-state flag, true, false, or unset. So an enum used to keep the flag is unset by default. When firmware-power-managed is true, the kernel driver will not send a shutdown during s2idle/s0i3 suspend. BUG=b:200578885 BRANCH=None TEST=TPM shutdown is triggered on s0ix suspend on guybrush with patched kernel Change-Id: Ia48ead856fc0c6e637a2e07a5ecc58423f599c5b Signed-off-by: Rob Barnes <robbarnes(a)google.com> --- M src/drivers/i2c/tpm/chip.c M src/drivers/i2c/tpm/chip.h 2 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/59479/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/59479 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia48ead856fc0c6e637a2e07a5ecc58423f599c5b Gerrit-Change-Number: 59479 Gerrit-PatchSet: 7 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Andrey Pronin <apronin(a)google.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andrey Pronin <apronin(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: libpayload/tests: remove tests/include/mocks include path
by Julius Werner (Code Review) 19 Nov '21

19 Nov '21

Attention is currently required from: Jakub Czapiga. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59493 ) Change subject: libpayload/tests: remove tests/include/mocks include path ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59493 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4baa07472f0379d56423cf7152b1ecc9a4824539 Gerrit-Change-Number: 59493 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Comment-Date: Fri, 19 Nov 2021 21:20:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Add libpayload_boot_device_read function
by Julius Werner (Code Review) 19 Nov '21

19 Nov '21

Attention is currently required from: Jakub Czapiga. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59492 ) Change subject: libpayload: Add libpayload_boot_device_read function ...................................................................... Patch Set 1: (3 comments) File payloads/libpayload/include/boot_device.h: https://review.coreboot.org/c/coreboot/+/59492/comment/0fde871f_7ced4613 PS1, Line 10: It has to be implemented by payloads using : * FlashMap and libCBFS. nit: There's a bit of ambiguity in this sentence, I'd reword to "by payloads that want to use FMAP or libcbfs" to clear that up. File payloads/libpayload/include/libpayload.h: https://review.coreboot.org/c/coreboot/+/59492/comment/5a38daa1_77d06263 PS1, Line 67: #include <boot_device.h> nit: not sure this needs to be in here (it's not going to be called by payload code itself, usually) File payloads/libpayload/libc/boot_device.c: https://review.coreboot.org/c/coreboot/+/59492/comment/b3d9e8a0_ce2ac238 PS1, Line 8: __attribute__((weak)) ssize_t libpayload_boot_device_read(void *buf, size_t offset, size_t size) Do we really want this? I think if a payload is using the new CBFS API, it can also be expected to provide this call. I think I'd just have the old API keep using media and the new API only use this call, and then after some transition time we can just throw the whole API including the media stuff away completely. I think we still should have a default weak implementation for x86 for this, but it would probably be better to rewrite that than to rely on the existing stuff in rom_media.c. We want to get rid of that old master header parsing and CONFIG_LP_ROM_SIZE for the new API... it should just take the size from lib_sysinfo.boot_media_size and leave it at that. -- To view, visit https://review.coreboot.org/c/coreboot/+/59492 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1babd2a8414ed9de3ca49903fcb4f036997b5ff3 Gerrit-Change-Number: 59492 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Comment-Date: Fri, 19 Nov 2021 21:19:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Allow variants to choose CAR setup configuration
by Tim Wawrzynczak (Code Review) 19 Nov '21

19 Nov '21

Attention is currently required from: Maulik V Vaghela, Subrata Banik, Nick Vaccaro, EricR Lai. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59272 ) Change subject: mb/google/brya: Allow variants to choose CAR setup configuration ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/59272/comment/1b1e4f4b_69800947 PS3, Line 134: BOARD_GOOGLE_BRYA0 I am getting an ETA on decommission date for these older rev boards 👍 -- To view, visit https://review.coreboot.org/c/coreboot/+/59272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe94e6b82739ec65829859271622d904d75e978d Gerrit-Change-Number: 59272 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Fri, 19 Nov 2021 21:08:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Add CBMEM_IMD_ENTRY support to coreboot tables parser
by Julius Werner (Code Review) 19 Nov '21

19 Nov '21

Attention is currently required from: Jakub Czapiga. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59491 ) Change subject: libpayload: Add CBMEM_IMD_ENTRY support to coreboot tables parser ...................................................................... Patch Set 1: (2 comments) File payloads/libpayload/include/cbmem_id.h: PS1: Rather than duplicate this, do we just want to move commonlib/cbmem_id.h to commonlib/bsd/ (and change the license, since it doesn't really contain more than you copied here anyway)? File payloads/libpayload/libc/coreboot.c: https://review.coreboot.org/c/coreboot/+/59491/comment/f101e75e_2c416618 PS1, Line 275: switch (cbmem_entry->id) { Could you take this opportunity to convert all the others that currently use lb_cbmem_ref (and call get_cbmem_addr() here) to use these entries as well? Then we could eventually get rid of some of that pointless duplication in the tables. -- To view, visit https://review.coreboot.org/c/coreboot/+/59491 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5bd02a98ba2631f34014bc0f8e7ebd5a5ddd2321 Gerrit-Change-Number: 59491 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Comment-Date: Fri, 19 Nov 2021 21:05:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021