coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: payloads/U-Boot: Enable the frame buffer
by Simon Glass (Code Review) 23 Nov '21

23 Nov '21

Attention is currently required from: Martin Roth, Stefan Reinauer, Simon Glass. Hello build bot (Jenkins), Martin Roth, Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59605 to look at the new patch set (#2). Change subject: payloads/U-Boot: Enable the frame buffer ...................................................................... payloads/U-Boot: Enable the frame buffer U-Boot normally runs with a display if available. Enable this option so that the display shows if U-Boot supports it. Use 'select' rather than 'imply' since the CI complains. Signed-off-by: Simon Glass <sjg(a)chromium.org> Change-Id: Ie5684c6ead30076689f43034675ff9f3531970fe --- M payloads/external/U-Boot/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/59605/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59605 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5684c6ead30076689f43034675ff9f3531970fe Gerrit-Change-Number: 59605 Gerrit-PatchSet: 2 Gerrit-Owner: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Simon Glass <sjg(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common/thermal: Refactor thermal block to improve reusability
by Subrata Banik (Code Review) 23 Nov '21

23 Nov '21

Attention is currently required from: Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59509 ) Change subject: soc/intel/common/thermal: Refactor thermal block to improve reusability ...................................................................... Patch Set 6: (1 comment) File src/soc/intel/common/block/thermal/Kconfig: https://review.coreboot.org/c/coreboot/+/59509/comment/42e100fa_9b44a04d PS4, Line 7: config SOC_INTEL_COMMON_BLOCK_THERMAL_PCI_DEV : bool : default n : select SOC_INTEL_COMMON_BLOCK_THERMAL : help : This option allows to configure PCH thermal registers using Thermal PCI device : for chipsets till Ice Lake PCH. : : config SOC_INTEL_COMMON_BLOCK_THERMAL_BEHIND_PMC : bool : default n : select SOC_INTEL_COMMON_BLOCK_THERMAL : help : This option allows to configure PCH thermal registers using PMC PWRMBASE : for chipsets since Tiger Lake PCH. > HI Eric and Angel, […] Any feedback Angel/Eric? -- To view, visit https://review.coreboot.org/c/coreboot/+/59509 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14df5145629ef03f358b98e824bca6a5b8ebdfc6 Gerrit-Change-Number: 59509 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Tue, 23 Nov 2021 17:51:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subi.banik(a)gmail.com> Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/U-Boot: Move to v2021.10
by Simon Glass (Code Review) 23 Nov '21

23 Nov '21

Attention is currently required from: Martin Roth, Stefan Reinauer. Simon Glass has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59606 ) Change subject: payloads/U-Boot: Move to v2021.10 ...................................................................... payloads/U-Boot: Move to v2021.10 Move to building the latest U-Boot. Signed-off-by: Simon Glass <sjg(a)chromium.org> Change-Id: I33fcfc3135e55d16b0dcd8135217bd5adcef2099 --- M payloads/external/U-Boot/Makefile 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/59606/1 diff --git a/payloads/external/U-Boot/Makefile b/payloads/external/U-Boot/Makefile index 90777a5..daadb3e 100644 --- a/payloads/external/U-Boot/Makefile +++ b/payloads/external/U-Boot/Makefile @@ -1,7 +1,6 @@ ## SPDX-License-Identifier: GPL-2.0-only -# 2019-4 tag -STABLE_COMMIT_ID=3c99166441bf3ea325af2da83cfe65430b49c066 +STABLE_COMMIT_ID=v2021.07 TAG-$(CONFIG_UBOOT_MASTER)=origin/master TAG-$(CONFIG_UBOOT_STABLE)=$(STABLE_COMMIT_ID) -- To view, visit https://review.coreboot.org/c/coreboot/+/59606 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I33fcfc3135e55d16b0dcd8135217bd5adcef2099 Gerrit-Change-Number: 59606 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: payloads/U-Boot: Enable the frame buffer
by Simon Glass (Code Review) 23 Nov '21

23 Nov '21

Attention is currently required from: Martin Roth, Stefan Reinauer. Simon Glass has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59605 ) Change subject: payloads/U-Boot: Enable the frame buffer ...................................................................... payloads/U-Boot: Enable the frame buffer U-Boot normally runs with a display if available. Enable this option so that the display shows if U-Boot supports it. Signed-off-by: Simon Glass <sjg(a)chromium.org> Change-Id: Ie5684c6ead30076689f43034675ff9f3531970fe --- M payloads/external/U-Boot/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/59605/1 diff --git a/payloads/external/U-Boot/Kconfig b/payloads/external/U-Boot/Kconfig index deeef75..794e282 100644 --- a/payloads/external/U-Boot/Kconfig +++ b/payloads/external/U-Boot/Kconfig @@ -3,6 +3,7 @@ config PAYLOAD_SPECIFIC_OPTIONS def_bool y select PAYLOAD_IS_FLAT_BINARY + imply WANT_LINEAR_FRAMEBUFFER choice prompt "U-Boot version" -- To view, visit https://review.coreboot.org/c/coreboot/+/59605 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5684c6ead30076689f43034675ff9f3531970fe Gerrit-Change-Number: 59605 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: emulation/qemu-i440fx: Use a 1MB ROM by default with U-Boot
by Simon Glass (Code Review) 23 Nov '21

23 Nov '21

Simon Glass has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59604 ) Change subject: emulation/qemu-i440fx: Use a 1MB ROM by default with U-Boot ...................................................................... emulation/qemu-i440fx: Use a 1MB ROM by default with U-Boot At present the default ROM for for QEMU is too small for U-Boot to fit. Add a condition to catch this and expand it to a 1MB ROM. This allows booting U-Boot under emulation. Signed-off-by: Simon Glass <sjg(a)chromium.org> Change-Id: Ia1a8c1109e3ece5fec56255173a2d19d4a130bcb --- M src/mainboard/emulation/qemu-i440fx/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/59604/1 diff --git a/src/mainboard/emulation/qemu-i440fx/Kconfig b/src/mainboard/emulation/qemu-i440fx/Kconfig index 436bb20..518e51f 100644 --- a/src/mainboard/emulation/qemu-i440fx/Kconfig +++ b/src/mainboard/emulation/qemu-i440fx/Kconfig @@ -9,7 +9,8 @@ select HAVE_CMOS_DEFAULT select HAVE_PIRQ_TABLE select HAVE_ACPI_TABLES - select BOARD_ROMSIZE_KB_256 if !VBOOT + select BOARD_ROMSIZE_KB_256 if !VBOOT && !PAYLOAD_UBOOT + select BOARD_ROMSIZE_KB_1024 if PAYLOAD_UBOOT select BOARD_ROMSIZE_KB_16384 if VBOOT select MAINBOARD_HAS_NATIVE_VGA_INIT select MAINBOARD_FORCE_NATIVE_VGA_INIT -- To view, visit https://review.coreboot.org/c/coreboot/+/59604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia1a8c1109e3ece5fec56255173a2d19d4a130bcb Gerrit-Change-Number: 59604 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Glass <sjg(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: payloads/U-Boot: Correct start address
by Simon Glass (Code Review) 23 Nov '21

23 Nov '21

Attention is currently required from: Martin Roth, Stefan Reinauer. Simon Glass has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59603 ) Change subject: payloads/U-Boot: Correct start address ...................................................................... payloads/U-Boot: Correct start address At present U-Boot crashes on entry as the start address is wrong. Fix it. Signed-off-by: Simon Glass <sjg(a)chromium.org> Change-Id: I65e32fbb4ffea04b99abe4dc5afccfacd06c986e --- M payloads/external/U-Boot/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/59603/1 diff --git a/payloads/external/U-Boot/Kconfig b/payloads/external/U-Boot/Kconfig index 2ee14fd..deeef75 100644 --- a/payloads/external/U-Boot/Kconfig +++ b/payloads/external/U-Boot/Kconfig @@ -35,6 +35,6 @@ default "payloads/external/U-Boot/build/u-boot.bin" config PAYLOAD_OPTIONS - default "-l 0x1110000 -e 0x1110015" + default "-l 0x1110000 -e 0x1110000" endif -- To view, visit https://review.coreboot.org/c/coreboot/+/59603 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65e32fbb4ffea04b99abe4dc5afccfacd06c986e Gerrit-Change-Number: 59603 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: payloads/U-Boot: Do a shallow clone
by Simon Glass (Code Review) 23 Nov '21

23 Nov '21

Attention is currently required from: Martin Roth, Stefan Reinauer. Simon Glass has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59602 ) Change subject: payloads/U-Boot: Do a shallow clone ...................................................................... payloads/U-Boot: Do a shallow clone We don't need all the git history. Speed up the build by doing a shallow clone. Signed-off-by: Simon Glass <sjg(a)chromium.org> Change-Id: If31c9dd158aa23f242e4fd145449ef7502fb1ab1 --- M payloads/external/U-Boot/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/59602/1 diff --git a/payloads/external/U-Boot/Makefile b/payloads/external/U-Boot/Makefile index 1d1d332..90777a5 100644 --- a/payloads/external/U-Boot/Makefile +++ b/payloads/external/U-Boot/Makefile @@ -26,7 +26,7 @@ $(project_dir): echo " Cloning $(project_name) from Git" - git clone $(project_git_repo) $(project_dir) + git clone --depth 1 $(project_git_repo) $(project_dir) fetch: $(project_dir) ifeq ($(CONFIG_UBOOT_MASTER),y) -- To view, visit https://review.coreboot.org/c/coreboot/+/59602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If31c9dd158aa23f242e4fd145449ef7502fb1ab1 Gerrit-Change-Number: 59602 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: payloads/U-Boot: Use the correct output binary
by Simon Glass (Code Review) 23 Nov '21

23 Nov '21

Attention is currently required from: Martin Roth, Stefan Reinauer. Simon Glass has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59601 ) Change subject: payloads/U-Boot: Use the correct output binary ...................................................................... payloads/U-Boot: Use the correct output binary The u-boot.bin file should be used, rather than u-boot-dtb.bin While they are often the same, the -dtb version is really just for legacy use now. Signed-off-by: Simon Glass <sjg(a)chromium.org> Change-Id: I5558ed94c7dd6cc57ceb835fe367bfa050ad2150 --- M payloads/external/Makefile.inc M payloads/external/U-Boot/Kconfig 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/59601/1 diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc index 151a27c..a185a77 100644 --- a/payloads/external/Makefile.inc +++ b/payloads/external/Makefile.inc @@ -197,7 +197,7 @@ # U-Boot -payloads/external/U-Boot/build/u-boot/u-boot-dtb.bin u-boot: $(DOTCONFIG) +payloads/external/U-Boot/build/u-boot/u-boot.bin u-boot: $(DOTCONFIG) $(MAKE) -C payloads/external/U-Boot \ CONFIG_UBOOT_MASTER=$(CONFIG_UBOOT_MASTER) \ CONFIG_UBOOT_STABLE=$(CONFIG_UBOOT_STABLE) diff --git a/payloads/external/U-Boot/Kconfig b/payloads/external/U-Boot/Kconfig index b635bbb..2ee14fd 100644 --- a/payloads/external/U-Boot/Kconfig +++ b/payloads/external/U-Boot/Kconfig @@ -32,7 +32,7 @@ from the U-Boot config directory config PAYLOAD_FILE - default "payloads/external/U-Boot/build/u-boot/u-boot-dtb.bin" + default "payloads/external/U-Boot/build/u-boot.bin" config PAYLOAD_OPTIONS default "-l 0x1110000 -e 0x1110015" -- To view, visit https://review.coreboot.org/c/coreboot/+/59601 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5558ed94c7dd6cc57ceb835fe367bfa050ad2150 Gerrit-Change-Number: 59601 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: payloads/U-Boot: Tidy up the U-Boot build
by Simon Glass (Code Review) 23 Nov '21

23 Nov '21

Simon Glass has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59600 ) Change subject: payloads/U-Boot: Tidy up the U-Boot build ...................................................................... payloads/U-Boot: Tidy up the U-Boot build This doesn't work at present, merely printing an error when U-Boot is selected as a payload. This is because it adds a file into the U-Boot tree which makes U-Boot's build system think that the tree is unclean. Update the rules to put the tag file outside the source tree. Use an out-of-tree build for U-Boot to avoid changing the source tree. Signed-off-by: Simon Glass <sjg(a)chromium.org> Change-Id: I24d6545b54f97afeefaca3ffed79eec2e7afacb4 --- M payloads/external/Makefile.inc M payloads/external/U-Boot/Kconfig M payloads/external/U-Boot/Makefile 3 files changed, 13 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/59600/1 diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc index 6db1720..151a27c 100644 --- a/payloads/external/Makefile.inc +++ b/payloads/external/Makefile.inc @@ -197,7 +197,7 @@ # U-Boot -payloads/external/U-Boot/u-boot/u-boot-dtb.bin u-boot: $(DOTCONFIG) +payloads/external/U-Boot/build/u-boot/u-boot-dtb.bin u-boot: $(DOTCONFIG) $(MAKE) -C payloads/external/U-Boot \ CONFIG_UBOOT_MASTER=$(CONFIG_UBOOT_MASTER) \ CONFIG_UBOOT_STABLE=$(CONFIG_UBOOT_STABLE) diff --git a/payloads/external/U-Boot/Kconfig b/payloads/external/U-Boot/Kconfig index 9e51ae1..b635bbb 100644 --- a/payloads/external/U-Boot/Kconfig +++ b/payloads/external/U-Boot/Kconfig @@ -32,7 +32,7 @@ from the U-Boot config directory config PAYLOAD_FILE - default "payloads/external/U-Boot/u-boot/u-boot-dtb.bin" + default "payloads/external/U-Boot/build/u-boot/u-boot-dtb.bin" config PAYLOAD_OPTIONS default "-l 0x1110000 -e 0x1110015" diff --git a/payloads/external/U-Boot/Makefile b/payloads/external/U-Boot/Makefile index 38dfe99..1d1d332 100644 --- a/payloads/external/U-Boot/Makefile +++ b/payloads/external/U-Boot/Makefile @@ -9,7 +9,10 @@ project_name=U-Boot project_dir=u-boot project_git_repo=http://git.denx.de/u-boot.git -project_config_file=$(project_dir)/.config +project_build_dir=build +project_config_file=$(project_build_dir)/.config + +make_args=-C $(project_dir) O=../build unexport KCONFIG_AUTOHEADER unexport KCONFIG_AUTOCONFIG @@ -31,11 +34,11 @@ git fetch #master doesn't get a file, so it's continuously updated - rm -f $(project_dir)/$(STABLE_COMMIT_ID) + rm -f $(STABLE_COMMIT_ID) else cd $(project_dir); git show $(TAG-y) >/dev/null 2>&1 ; if [ $$? -ne 0 ]; \ then echo " Fetching new commits from the $(project_name) git repo"; git fetch; fi - touch $(project_dir)/$(STABLE_COMMIT_ID) + touch $(STABLE_COMMIT_ID) endif checkout: fetch @@ -43,26 +46,26 @@ cd $(project_dir); git checkout master; git branch -D coreboot 2>/dev/null; git checkout -b coreboot $(TAG-y) config: checkout + mkdir -p $(project_build_dir) rm -f $(project_config_file) ifneq ($(CONFIG_PAYLOAD_CONFIGFILE),) ifneq ("$(wildcard $(CONFIG_PAYLOAD_CONFIGFILE))","") cat $(CONFIG_PAYLOAD_CONFIGFILE)" > tag-$(project_config_file) + $(MAKE) $(make_args) olddefconfig else echo "Error: File $(CONFIG_PAYLOAD_CONFIGFILE) does not exist" false endif else - cat $(project_dir)/configs/coreboot_defconfig >> $(project_config_file) + $(MAKE) $(make_args) coreboot_defconfig endif - $(MAKE) -C $(project_dir) olddefconfig - build: config echo " MAKE $(project_name) $(TAG-y)" - $(MAKE) -C $(project_dir) + $(MAKE) $(make_args) clean: - test -d $(project_dir) && $(MAKE) -C $(project_dir) clean || exit 0 + test -d $(project_dir) && $(MAKE) $(make_args) clean || exit 0 distclean: rm -rf $(project_dir) -- To view, visit https://review.coreboot.org/c/coreboot/+/59600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I24d6545b54f97afeefaca3ffed79eec2e7afacb4 Gerrit-Change-Number: 59600 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Glass <sjg(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/graphics/Kconfig: Guard options
by Felix Held (Code Review) 23 Nov '21

23 Nov '21

Attention is currently required from: Arthur Heymans, Patrick Rudolph. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59471 ) Change subject: soc/intel/graphics/Kconfig: Guard options ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/common/block/graphics/Kconfig: https://review.coreboot.org/c/coreboot/+/59471/comment/8286597e_ae55db66 PS1, Line 13: config SOC_INTEL_DISABLE_IGD > This one is actually implemented per soc. Doesn't seem to matter, but […] this patch has a +2, but this comment makes me wonder if i'm supposed to submit the patch in its current state or not -- To view, visit https://review.coreboot.org/c/coreboot/+/59471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c252e31867e4560fb5aaf12273288f4ff18ae3d Gerrit-Change-Number: 59471 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 23 Nov 2021 17:09:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021