Attention is currently required from: Caveh Jalali.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47501 )
Change subject: mb/google/volteer/v/volteer2: Add config for passive USB-C DB on C1
......................................................................
Patch Set 15:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/47501/comment/47498138_8a2f7d48
PS15, Line 7: v/
Please let’s use `var/` until it’s agreed upon to change the scheme.
--
To view, visit https://review.coreboot.org/c/coreboot/+/47501
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9939450213bac4c0d661759bef2f38f3fd3af76
Gerrit-Change-Number: 47501
Gerrit-PatchSet: 15
Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Comment-Date: Wed, 13 Oct 2021 15:15:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello build bot (Jenkins), Jeremy Soller,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57652
to look at the new patch set (#4).
Change subject: mb/system76/oryp8: Add System76 Oryx Pro 8
......................................................................
mb/system76/oryp8: Add System76 Oryx Pro 8
https://tech-docs.system76.com/models/oryp8/README.html
Tested with TianoCore (UeifPayloadPkg).
Working:
- PS/2 keyboard, touchpad
- Both DIMM slots
- Both M.2 SSD slots
- All USB ports
- Webcam
- Ethernet
- WiFi/Bluetooth
- Integrated graphics using Intel GOP driver
- Internal microphone
- Internal speakers
- Combined 3.5mm headphone & microphone jack
- Combined 3.5mm microphone & S/PDIF jack*
- S3 suspend/resume
- Booting to Pop!_OS Linux 21.10 and Windows 10 20H2
- Flashing with flashrom
Not working:
- Discrete/Hybrid graphics
Not tested:
- Thunderbolt functionality
- S/PDIF output
Change-Id: Iabc8e273f997d7f5852ddec63e0c1bf0c9434acb
Signed-off-by: Jeremy Soller <jeremy(a)system76.com>
Signed-off-by: Tim Crawford <tcrawford(a)system76.com>
---
M Documentation/mainboard/index.md
A Documentation/mainboard/system76/oryp8.md
A src/mainboard/system76/oryp8/Kconfig
A src/mainboard/system76/oryp8/Kconfig.name
A src/mainboard/system76/oryp8/Makefile.inc
A src/mainboard/system76/oryp8/acpi/mainboard.asl
A src/mainboard/system76/oryp8/acpi/sleep.asl
A src/mainboard/system76/oryp8/board_info.txt
A src/mainboard/system76/oryp8/bootblock.c
A src/mainboard/system76/oryp8/cmos.default
A src/mainboard/system76/oryp8/cmos.layout
A src/mainboard/system76/oryp8/data.vbt
A src/mainboard/system76/oryp8/devicetree.cb
A src/mainboard/system76/oryp8/dsdt.asl
A src/mainboard/system76/oryp8/gpio.c
A src/mainboard/system76/oryp8/gpio_early.c
A src/mainboard/system76/oryp8/hda_verb.c
A src/mainboard/system76/oryp8/include/mainboard/gpio.h
A src/mainboard/system76/oryp8/ramstage.c
A src/mainboard/system76/oryp8/romstage.c
A src/mainboard/system76/oryp8/tas5825m.c
21 files changed, 2,702 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/57652/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/57652
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iabc8e273f997d7f5852ddec63e0c1bf0c9434acb
Gerrit-Change-Number: 57652
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jeremy Soller <jeremy(a)system76.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jeremy Soller.
Hello build bot (Jenkins), Jeremy Soller,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56956
to look at the new patch set (#14).
Change subject: mb/system76/gaze16: Add System76 Gazelle 16
......................................................................
mb/system76/gaze16: Add System76 Gazelle 16
https://tech-docs.system76.com/models/gaze16/README.html
Tested on the 3050 variant.
Tested with TianoCore (UefiPayloadPkg).
Working:
- PS/2 keyboard, touchpad
- Both DIMM slots
- M.2 NVMe SSD
- M.2 SATA SSD
- 2.5" SSD
- All USB ports
- SD card reader
- Webcam
- Ethernet
- WiFi/Bluetooth
- Integrated graphics using Intel GOP driver
- HDMI output
- Internal microphone
- Internal speakers
- Combined headphone + mic 3.5mm audio*
- 3.5mm microphone input*
- S3 suspend/resume
- Booting to Pop!_OS Linux 21.04 and Windows 10 20H2
- Flashing with flashrom
Not working:
- Discrete/Hybrid graphics
- Mini DisplayPort output (requires NVIDIA GPU)
- 3.5mm audio input/output detection on Windows
Change-Id: Ifb90f9b73a10abf53a21738e2c466d539df9a37c
Signed-off-by: Jeremy Soller <jeremy(a)system76.com>
Signed-off-by: Tim Crawford <tcrawford(a)system76.com>
---
M Documentation/mainboard/index.md
A Documentation/mainboard/system76/gaze16.md
A src/mainboard/system76/gaze16/Kconfig
A src/mainboard/system76/gaze16/Kconfig.name
A src/mainboard/system76/gaze16/Makefile.inc
A src/mainboard/system76/gaze16/acpi/mainboard.asl
A src/mainboard/system76/gaze16/acpi/sleep.asl
A src/mainboard/system76/gaze16/board_info.txt
A src/mainboard/system76/gaze16/bootblock.c
A src/mainboard/system76/gaze16/cmos.default
A src/mainboard/system76/gaze16/cmos.layout
A src/mainboard/system76/gaze16/devicetree.cb
A src/mainboard/system76/gaze16/dsdt.asl
A src/mainboard/system76/gaze16/ramstage.c
A src/mainboard/system76/gaze16/romstage.c
A src/mainboard/system76/gaze16/variant.h
A src/mainboard/system76/gaze16/variants/3050/data.vbt
A src/mainboard/system76/gaze16/variants/3050/hda_verb.c
A src/mainboard/system76/gaze16/variants/3050/include/variant/gpio.h
A src/mainboard/system76/gaze16/variants/3050/overridetree.cb
A src/mainboard/system76/gaze16/variants/3050/ramstage.c
A src/mainboard/system76/gaze16/variants/3050/romstage.c
A src/mainboard/system76/gaze16/variants/3060/data.vbt
A src/mainboard/system76/gaze16/variants/3060/hda_verb.c
A src/mainboard/system76/gaze16/variants/3060/include/variant/gpio.h
A src/mainboard/system76/gaze16/variants/3060/overridetree.cb
A src/mainboard/system76/gaze16/variants/3060/ramstage.c
A src/mainboard/system76/gaze16/variants/3060/romstage.c
28 files changed, 1,356 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/56956/14
--
To view, visit https://review.coreboot.org/c/coreboot/+/56956
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb90f9b73a10abf53a21738e2c466d539df9a37c
Gerrit-Change-Number: 56956
Gerrit-PatchSet: 14
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber, Jakub Czapiga, Julius Werner, Yu-Ping Wu.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58242 )
Change subject: libpayload: Add unit-tests framework and first test case
......................................................................
Patch Set 5:
(1 comment)
File payloads/libpayload/tests/Makefile.inc:
PS4:
> Yes, it does not differ much. […]
Is this wise? Changes you make in tests/Makefile.inc (to fix bugs, to add features) must now be synced up with this Makefile. Libpayload is in the same git repository as coreboot, so let's see if we can find a way to avoid duplicating code.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58242
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa94ee4dcdc3f74af830113813df0e8fb0b31e4f
Gerrit-Change-Number: 58242
Gerrit-PatchSet: 5
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Wed, 13 Oct 2021 14:09:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: comment
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/58155 )
Change subject: drivers/pc80/tpm: Fix wrong debug message
......................................................................
drivers/pc80/tpm: Fix wrong debug message
There is the wrong register offset printed in the debug log when the
data register is written:
'lpc_tpm: Write reg 0x18 with 0xnn' should be
'lpc_tpm: Write reg 0x24 with 0xnn' for data FIFO access.
This can be confusing when searching for issues with the help of the
TPM debug messages since the code itself is correct. Fix this error.
Change-Id: Ic28ee5a07146e804574b887ea05c62e7e88e9078
Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58155
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
---
M src/drivers/pc80/tpm/tis.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Kyösti Mälkki: Looks good to me, approved
Paul Menzel: Looks good to me, but someone else must approve
Angel Pons: Looks good to me, approved
diff --git a/src/drivers/pc80/tpm/tis.c b/src/drivers/pc80/tpm/tis.c
index 526b574..2b29acf 100644
--- a/src/drivers/pc80/tpm/tis.c
+++ b/src/drivers/pc80/tpm/tis.c
@@ -172,7 +172,7 @@
static inline void tpm_write_data(u8 data, int locality)
{
- TPM_DEBUG_IO_WRITE(TIS_REG_STS, data);
+ TPM_DEBUG_IO_WRITE(TIS_REG_DATA_FIFO, data);
write8(TIS_REG(locality, TIS_REG_DATA_FIFO), data);
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/58155
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic28ee5a07146e804574b887ea05c62e7e88e9078
Gerrit-Change-Number: 58155
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged