Attention is currently required from: Reka Norman.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57871 )
Change subject: MAINTAINERS: Add Reka for SPD utilities
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Yikes, we have spdtool and spd_tools? What went wrong there?
--
To view, visit https://review.coreboot.org/c/coreboot/+/57871
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd4837e11a0ac22e1c8855553a0c51b0f25ab96c
Gerrit-Change-Number: 57871
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Comment-Date: Thu, 14 Oct 2021 17:11:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Hello build bot (Jenkins), Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/58213
to look at the new patch set (#4).
Change subject: mb/google/brya: Set same size for CSE_RW, ME_RW_A and ME_RW_B
......................................................................
mb/google/brya: Set same size for CSE_RW, ME_RW_A and ME_RW_B
CSE RW firmware from ME_RW_A/ME_RW_B is copied over to CSE_RW region
in case of firmware update. Ensure that the size of the regions match
so that we do not have situations where ME_RW_A/B firmware grows
bigger than what CSE_RW can hold.
BUG=b:189177538
Change-Id: I374db5d490292eeb98f67dc684c2106d42779dac
Signed-off-by: Furquan Shaikh <furquan(a)google.com>
---
M src/mainboard/google/brya/chromeos.fmd
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/58213/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/58213
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I374db5d490292eeb98f67dc684c2106d42779dac
Gerrit-Change-Number: 58213
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Sridhar Siricilla, Bernardo Perez Priego, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58158 )
Change subject: soc/intel/common/cse: Split CSE metadata into two CBFS files
......................................................................
Patch Set 12:
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/58158/comment/44281044_c37247a5
PS12, Line 595: CSE_UPDATE_METADATA_ERROR
> CSE_LITE_SKU_RW_METADATA_NOT_FOUND instead of CSE_UPDATE_METADATA_ERROR like you did for RW hash fil […]
This function is returning `enum cse_update_status` and the caller `cse_fw_update` returns `CSE_LITE_SKU_RW_METADATA_NOT_FOUND` on line 745.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58158
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c9bb165e6a64415affcd0b3331628092195fa0d
Gerrit-Change-Number: 58158
Gerrit-PatchSet: 12
Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 14 Oct 2021 17:09:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Martin Roth, Angel Pons, Julius Werner, Michael Niewöhner.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56410 )
Change subject: [RFC] kconfig_lint: Drop overly restrictive rules about choice configs
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56410/comment/70f6d811_2ad6cbaa
PS4, Line 19: On top, the linter treats every occurence of a `config` entry as a
: symbol declaration, even when it's just setting a default or adding
: selects.
> > > Thanks for the hint - I missed that discussion. I'll have a look later.
> > >
> > > > they had to debug something for weeks because they had a bad binary in their build environment, AIUI
> > >
> > > Not sure how that shall work as argument against Python. What am I missing?
> >
> > The assumption was that we use the Python binaries that people have
> > already installed. Same as for any other host tool we just assume to
> > be present, we'd have to maintain on our end, i.e. keep compatibility
> > to everything people might have installed. We already do that for the
> > host toolchain, for instance, and the effort is not negligible,
>
> Uhm, if we don't use that fancy python stuff, we won't have any problem. Ofc there must be some minimum version, same as with perl or whatever.
Only if you assume 100% backwards compatibility including warnings,
command-line options etc. Which I've never seen for any compiler
or interpreter of that size.
>
> >
> > I guess things would look differently if we would add Python to buildgcc.
> > But I have really no idea if that is feasible. And again, we'd have to
> > maintain something on our end.
> >
> > > > It seems, one major issue was the transition from Python 2 to 3.
> > >
> > > Python2 vs. Python3 never was a real problem - the problem actually was:
> > > - that religious `print is not a function but a statement` bs discussion.
> > > - Python3 is soooo different. No, it's not. Python2.7 and Python3 are mostly compatible.
> > > Anyway, Py2 is dead and we shouldn't use it.
> >
> > It's not about what changed but that things change. If we'd work with
> > the random versions everybody has installed, we'd have to keep our code
> > compatible with all these versions at once. Same for any other tool that
> > we don't provide ourselves. (kconfiglib is said to achieve that rather
> > well, btw.)
>
> Python versions are backwards compatible. Sure, here and there we will have to adapt but that won't be a huge problem.
We agree on everything but the scale :) Not "a huge problem" can
still be a problem.
>
> >
> > >
> > > However, from my (very naive) point of view, we should just evaluate it and see if it works for us. Theoretical discussions often lead to false assumptions, at least in my experience.
> >
> > Well, _you_ can evaluate what you like. But you shouldn't push other people
> > (you said "we should") to evaluate something that you want. The project is
> > simply too big for that. You can't expect everybody to take a break just to
> > evaluate something.
>
> No it's different: When I say we should, then it's a proposal. When you don't care, you don't have to. I don't expect anything. I proposed it, if noone cares I don't give a f***. Sorry.
Sorry, I messed up the quotation. This was nothing you said, Michael,
so I wasn't addressing you. I assumed when Felix wrote "we should"
that "we" means the coreboot community. Anyway, this is really some-
thing for the ML thread, let's not go on about it here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56410
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I48a17f6403470251be6b6d44bb82a8bdcbefe9f6
Gerrit-Change-Number: 56410
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Comment-Date: Thu, 14 Oct 2021 17:00:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Martin Roth <martinroth(a)google.com>
Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Paul Menzel, Angel Pons, Arthur Heymans, Patrick Rudolph, Felix Held.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58322 )
Change subject: Doc/mainboard_io_trap_handler_sample.c: Drop file
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/58322
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4a238fbf354926cb6568e1709bfb79cc546dfd73
Gerrit-Change-Number: 58322
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 14 Oct 2021 16:26:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Ariel Fang, Malik Hsu, Casper Chang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58319 )
Change subject: mb/google/brya/variants/primus: To fine tune WWAN power sequencing
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58319/comment/b7ab33ca_95135c3d
PS1, Line 9: fix the correct timing of WWAN power sequencing.
suggestion:
`correct the WWAN poweron and powerdown sequences`
--
To view, visit https://review.coreboot.org/c/coreboot/+/58319
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I232d283a9d6093f5da64fcdce44e5cb640e3df0e
Gerrit-Change-Number: 58319
Gerrit-PatchSet: 1
Gerrit-Owner: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com>
Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com>
Gerrit-Attention: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com>
Gerrit-Attention: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 14 Oct 2021 16:20:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment