Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37807 )
Change subject: util/lint: Provide some exemption to common parts of a vendor's MB
......................................................................
util/lint: Provide some exemption to common parts of a vendor's MB
Adding common definitions for a vendor's mainboard(eg. CB:37705) requires
creating dummy board_info.txt and Kconfig.name files due to lint checks.
Update the lint scripts to provide exemption to common definitions for a
vendor's mainboard.
BUG=None
TEST=Ensure that no lint errors are observed when common definitions are
added for a vendor's mainboard.
Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com>
Change-Id: I55c3474c17eacd008fee5f4089da33d4f7d6002a
---
M util/lint/lint-stable-005-board-status
M util/lint/lint-stable-006-board-name
2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/37807/1
diff --git a/util/lint/lint-stable-005-board-status b/util/lint/lint-stable-005-board-status
index 952a9b5..e8313f2 100755
--- a/util/lint/lint-stable-005-board-status
+++ b/util/lint/lint-stable-005-board-status
@@ -17,6 +17,10 @@
LC_ALL=C export LC_ALL
for mobodir in $(git ls-files src/mainboard | sed -n 's,^\(src/mainboard/[^/]*/[^/]*\)/.*$,\1,p'|sort|uniq); do
+ if [[ ${mobodir} =~ ^src\/mainboard\/.*\/common$ ]]; then
+ continue
+ fi
+
board_info="$mobodir/board_info.txt"
if ! [ -f "$board_info" ]; then
echo "No $board_info found"
diff --git a/util/lint/lint-stable-006-board-name b/util/lint/lint-stable-006-board-name
index b2418a1..cf3b0e2 100755
--- a/util/lint/lint-stable-006-board-name
+++ b/util/lint/lint-stable-006-board-name
@@ -29,6 +29,9 @@
done
for i in src/mainboard/*/*/; do
+ if [[ ${i} =~ ^src\/mainboard\/.*\/common\/$ ]]; then
+ continue
+ fi
if [ -r $i/Kconfig ]; then
if [ ! -r $i/Kconfig.name ]; then
BOARD="$(grep -A2 MAINBOARD_PART_NUMBER $i/Kconfig | tail -1 | cut -f2 -d\")"
--
To view, visit https://review.coreboot.org/c/coreboot/+/37807
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55c3474c17eacd008fee5f4089da33d4f7d6002a
Gerrit-Change-Number: 37807
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newchange
Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44637 )
Change subject: mb/asus/a88xm-e: Disable SeaBIOS options unsupported by hardware
......................................................................
mb/asus/a88xm-e: Disable SeaBIOS options unsupported by hardware
A88XM-E doesn't have any SAS or NVMe controllers and couldn't have a TPM
so it makes sense to disable the related SeaBIOS options for this board.
This reduces the size of compiled SeaBIOS by 129344-110048=19296 bytes.
Signed-off-by: Mike Banon <mikebdp2(a)gmail.com>
Change-Id: Ie9760449734499628637e015cacc0541ec0002a2
---
M src/mainboard/asus/a88xm-e/Kconfig
A src/mainboard/asus/a88xm-e/config_seabios
2 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/44637/1
diff --git a/src/mainboard/asus/a88xm-e/Kconfig b/src/mainboard/asus/a88xm-e/Kconfig
index 6874e9e..139f989 100644
--- a/src/mainboard/asus/a88xm-e/Kconfig
+++ b/src/mainboard/asus/a88xm-e/Kconfig
@@ -56,4 +56,8 @@
bool
default n
+config PAYLOAD_CONFIGFILE
+ string
+ default "$(top)/src/mainboard/$(MAINBOARDDIR)/config_seabios" if PAYLOAD_SEABIOS
+
endif # BOARD_ASUS_A88XM_E
diff --git a/src/mainboard/asus/a88xm-e/config_seabios b/src/mainboard/asus/a88xm-e/config_seabios
new file mode 100644
index 0000000..03bf0e8
--- /dev/null
+++ b/src/mainboard/asus/a88xm-e/config_seabios
@@ -0,0 +1,7 @@
+###
+### SeaBIOS custom configuration for ASUS A88XM-E
+###
+# CONFIG_MEGASAS is not set
+# CONFIG_NVME is not set
+# CONFIG_TCGBIOS is not set
+#
--
To view, visit https://review.coreboot.org/c/coreboot/+/44637
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9760449734499628637e015cacc0541ec0002a2
Gerrit-Change-Number: 44637
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-MessageType: newchange
Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44636 )
Change subject: mb/asus/am1i-a: Disable SeaBIOS options unsupported by hardware
......................................................................
mb/asus/am1i-a: Disable SeaBIOS options unsupported by hardware
AM1I-A does not have any SAS or NVMe controllers, so it makes sense
to disable the related SeaBIOS options for this board. This
reduces the size of compiled SeaBIOS by 129344-124096 = 5248 bytes.
Signed-off-by: Mike Banon <mikebdp2(a)gmail.com>
Change-Id: Ideec5d8cf3cf4cc7fba0787e56ab38b5172a5314
---
M src/mainboard/asus/am1i-a/Kconfig
A src/mainboard/asus/am1i-a/config_seabios
2 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/44636/1
diff --git a/src/mainboard/asus/am1i-a/Kconfig b/src/mainboard/asus/am1i-a/Kconfig
index 172d808..ff12d74 100644
--- a/src/mainboard/asus/am1i-a/Kconfig
+++ b/src/mainboard/asus/am1i-a/Kconfig
@@ -51,4 +51,8 @@
bool
default n
+config PAYLOAD_CONFIGFILE
+ string
+ default "$(top)/src/mainboard/$(MAINBOARDDIR)/config_seabios" if PAYLOAD_SEABIOS
+
endif # BOARD_ASUS_AM1I_A
diff --git a/src/mainboard/asus/am1i-a/config_seabios b/src/mainboard/asus/am1i-a/config_seabios
new file mode 100644
index 0000000..0ee9cea
--- /dev/null
+++ b/src/mainboard/asus/am1i-a/config_seabios
@@ -0,0 +1,6 @@
+###
+### SeaBIOS custom configuration for ASUS AM1I-A
+###
+# CONFIG_MEGASAS is not set
+# CONFIG_NVME is not set
+#
--
To view, visit https://review.coreboot.org/c/coreboot/+/44636
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ideec5d8cf3cf4cc7fba0787e56ab38b5172a5314
Gerrit-Change-Number: 44636
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-MessageType: newchange
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32882
Change subject: src/Kconfig: Move DRAM section to 'Devices' menu
......................................................................
src/Kconfig: Move DRAM section to 'Devices' menu
This moves DRAM to 'Devices' menu and allow to change default
DIMM_MAX value if needed.
Change-Id: I7aa5436c6ff5fef53fde2081e902d793f3581c1e
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/Kconfig
M src/device/Kconfig
2 files changed, 24 insertions(+), 25 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/32882/1
diff --git a/src/Kconfig b/src/Kconfig
index 2c9dc4a..d30aa99 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -1158,31 +1158,6 @@
implies configurability usually found on SoCs, particularly the
ability to control internal pull resistors.
-config GENERIC_SPD_BIN
- bool
- help
- If enabled, add support for adding spd.hex files in cbfs as spd.bin
- and locating it runtime to load SPD. Additionally provide provision to
- fetch SPD over SMBus.
-
-config DIMM_MAX
- int
- default 4
- help
- Total number of memory DIMM slots available on motherboard.
- It is multiplication of number of channel to number of DIMMs per
- channel
-
-config DIMM_SPD_SIZE
- int
- default 256
- help
- Total SPD size that will be used for DIMM.
- Ex: DDR3 256, DDR4 512.
-
-config SPD_READ_BY_WORD
- bool
-
config BOOTBLOCK_CUSTOM
# To be selected by arch, SoC or mainboard if it does not want use the normal
# src/lib/bootblock.c#main() C entry point.
diff --git a/src/device/Kconfig b/src/device/Kconfig
index 0539062..d4cacec 100644
--- a/src/device/Kconfig
+++ b/src/device/Kconfig
@@ -681,5 +681,29 @@
be useful for debugging or on platforms where a driver for the real
I2C controller is not (yet) available. The platform code needs to
provide bindings to manually toggle I2C lines.
+config GENERIC_SPD_BIN
+ bool
+ help
+ If enabled, add support for adding spd.hex files in cbfs as spd.bin
+ and locating it runtime to load SPD. Additionally provide provision to
+ fetch SPD over SMBus.
+
+config DIMM_MAX
+ int "Total number of memory DIMM slots"
+ default 4
+ help
+ Total number of memory DIMM slots available on motherboard.
+ It is multiplication of number of channel to number of DIMMs per
+ channel
+
+config DIMM_SPD_SIZE
+ int
+ default 256
+ help
+ Total SPD size that will be used for DIMM.
+ Ex: DDR3 256, DDR4 512.
+
+config SPD_READ_BY_WORD
+ bool
endmenu
--
To view, visit https://review.coreboot.org/c/coreboot/+/32882
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7aa5436c6ff5fef53fde2081e902d793f3581c1e
Gerrit-Change-Number: 32882
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-MessageType: newchange