Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45523 )
Change subject: mb/google/hatch/Kconfig: Make cse override depend on lite sku
......................................................................
mb/google/hatch/Kconfig: Make cse override depend on lite sku
Lets have the Kconfig depend more directly on CSE_LITE_SKU
than indirectly on the PUFF baseboard.
BUG=none
BRANCH=puff
TEST=builds
Change-Id: I8784b506629ceedc2770dc86d8caabbef5eb8a1d
Signed-off-by: Edward O'Callaghan <quasisec(a)google.com>
---
M src/mainboard/google/hatch/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/45523/1
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig
index e4e343b..ca310ed 100644
--- a/src/mainboard/google/hatch/Kconfig
+++ b/src/mainboard/google/hatch/Kconfig
@@ -55,7 +55,7 @@
select HAS_RECOVERY_MRC_CACHE
select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN
select VBOOT_LID_SWITCH
- select CHROMEOS_CSE_BOARD_RESET_OVERRIDE if BOARD_GOOGLE_BASEBOARD_PUFF
+ select CHROMEOS_CSE_BOARD_RESET_OVERRIDE if SOC_INTEL_CSE_LITE_SKU
config CHROMEOS_WIFI_SAR
bool "Enable SAR options for Chrome OS build"
--
To view, visit https://review.coreboot.org/c/coreboot/+/45523
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8784b506629ceedc2770dc86d8caabbef5eb8a1d
Gerrit-Change-Number: 45523
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: newchange
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45549 )
Change subject: soc/intel/cnl: drop lpit.asl in favor of common version
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/45549
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iefbd18db7f4c560dce16c4119fde4f4cfbeafb84
Gerrit-Change-Number: 45549
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 21 Sep 2020 15:06:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39995
to look at the new patch set (#17).
Change subject: mb/siemens/chili: Add Chili variant
......................................................................
mb/siemens/chili: Add Chili variant
This Chili mainboard is used in an all-in-one PC.
For more information see
https://www.secunet.com/fileadmin/user_upload/_temp_/importexport/Print/Fac…
Change-Id: Ic7a5dccbb0d5b7bceb154fb050cf991254475f7b
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
Signed-off-by: Felix Singer <felix.singer(a)secunet.com>
---
M src/mainboard/siemens/chili/Kconfig
M src/mainboard/siemens/chili/Kconfig.name
M src/mainboard/siemens/chili/mainboard.c
M src/mainboard/siemens/chili/romstage.c
M src/mainboard/siemens/chili/variant.h
A src/mainboard/siemens/chili/variants/chili/Makefile.inc
A src/mainboard/siemens/chili/variants/chili/board_info.txt
A src/mainboard/siemens/chili/variants/chili/data.vbt
A src/mainboard/siemens/chili/variants/chili/devicetree.cb
A src/mainboard/siemens/chili/variants/chili/gma-mainboard.ads
A src/mainboard/siemens/chili/variants/chili/gpio.c
A src/mainboard/siemens/chili/variants/chili/hda_verb.c
A src/mainboard/siemens/chili/variants/chili/romstage.c
13 files changed, 481 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/39995/17
--
To view, visit https://review.coreboot.org/c/coreboot/+/39995
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic7a5dccbb0d5b7bceb154fb050cf991254475f7b
Gerrit-Change-Number: 39995
Gerrit-PatchSet: 17
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44137 )
Change subject: soc/intel/skylake: acpi: drop HWP's dependency on EIST
......................................................................
soc/intel/skylake: acpi: drop HWP's dependency on EIST
Enhanced Intel SpeedStep Technology (EIST) and Intel Speed Shift
Technology (ISST) - also know as HWP - are two independent mechanisms
for controlling voltage and frequency based on performance hints.
When HWP is enabled, it overrides the software-based EIST. It does not
depend on EIST, though, but can be enabled on its own.
Break up that currently existing dependency in ACPI generation code.
It was tested that HWP can be enabled and gets used by the Linux pstate
cpufreq driver. With HWP disabled, the frequency does not decrease, even
not in powersave mode. After enabling HWP the frequency changed in
relation to the current workload. (Test device: Acer ES1-572)
Change-Id: I93d888ddce7b54e91b54e5b4fdd4d9cf16630eda
Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44137
Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz>
Reviewed-by: Subrata Banik <subrata.banik(a)intel.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/soc/intel/skylake/acpi.c
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
build bot (Jenkins): Verified
Arthur Heymans: Looks good to me, but someone else must approve
Subrata Banik: Looks good to me, approved
diff --git a/src/soc/intel/skylake/acpi.c b/src/soc/intel/skylake/acpi.c
index 0ec6e47..eb5b5b0 100644
--- a/src/soc/intel/skylake/acpi.c
+++ b/src/soc/intel/skylake/acpi.c
@@ -379,7 +379,7 @@
printk(BIOS_DEBUG, "Found %d CPU(s) with %d core(s) each.\n",
numcpus, cores_per_package);
- if (config->eist_enable && config->speed_shift_enable) {
+ if (config->speed_shift_enable) {
struct cppc_config cppc_config;
cpu_init_cppc_config(&cppc_config, 2 /* version 2 */);
acpigen_write_CPPC_package(&cppc_config);
@@ -403,9 +403,11 @@
/* Generate P-state tables */
generate_p_state_entries(core_id,
cores_per_package);
- if (config->speed_shift_enable)
- acpigen_write_CPPC_method();
}
+
+ if (config->speed_shift_enable)
+ acpigen_write_CPPC_method();
+
acpigen_pop_len();
}
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/44137
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93d888ddce7b54e91b54e5b4fdd4d9cf16630eda
Gerrit-Change-Number: 44137
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Matt Delco <delco(a)chromium.org>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45533 )
Change subject: mb/system76/lemp9: Enable battery charging thresholds
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/45533
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5131cf350d5b8c2a45f8d8245c0df26742c0d732
Gerrit-Change-Number: 45533
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 21 Sep 2020 14:45:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45532 )
Change subject: ec/system76/ec: Add battery charging thresholds
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/45532
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d656291c096f320d469274677e9fe6c74819d25
Gerrit-Change-Number: 45532
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 21 Sep 2020 14:45:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39995
to look at the new patch set (#16).
Change subject: mb/siemens/chili: Add Chili variant
......................................................................
mb/siemens/chili: Add Chili variant
This Chili mainboard is used in an all-in-one PC.
For more information see
https://www.secunet.com/fileadmin/user_upload/_temp_/importexport/Print/Fac…
Change-Id: Ic7a5dccbb0d5b7bceb154fb050cf991254475f7b
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
Signed-off-by: Felix Singer <felix.singer(a)secunet.com>
---
M src/mainboard/siemens/chili/Kconfig
M src/mainboard/siemens/chili/Kconfig.name
M src/mainboard/siemens/chili/mainboard.c
M src/mainboard/siemens/chili/romstage.c
M src/mainboard/siemens/chili/variant.h
A src/mainboard/siemens/chili/variants/chili/Makefile.inc
A src/mainboard/siemens/chili/variants/chili/board_info.txt
A src/mainboard/siemens/chili/variants/chili/boxer26_eeprom.h
A src/mainboard/siemens/chili/variants/chili/data.vbt
A src/mainboard/siemens/chili/variants/chili/devicetree.cb
A src/mainboard/siemens/chili/variants/chili/gma-mainboard.ads
A src/mainboard/siemens/chili/variants/chili/gpio.c
A src/mainboard/siemens/chili/variants/chili/hda_verb.c
A src/mainboard/siemens/chili/variants/chili/romstage.c
A src/mainboard/siemens/chili/variants/chili/smbios.c
15 files changed, 678 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/39995/16
--
To view, visit https://review.coreboot.org/c/coreboot/+/39995
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic7a5dccbb0d5b7bceb154fb050cf991254475f7b
Gerrit-Change-Number: 39995
Gerrit-PatchSet: 16
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset